Re: [PR] Buffer for more Speed [ant]
jaikiran merged PR #207: URL: https://github.com/apache/ant/pull/207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Buffer for more Speed [ant]
tg-freigmbh commented on PR #207: URL: https://github.com/apache/ant/pull/207#issuecomment-1892275667 Ah I already made an Contribution under a different account, I am Gösen ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Buffer for more Speed [ant]
jaikiran commented on PR #207: URL: https://github.com/apache/ant/pull/207#issuecomment-1892272296 Thank you for the update, looks good to me. Since you are a first time contributor to Ant, we add your name to the contributors list we maintain in the repo. Is there a specific first name, last name you want us to add you as? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Buffer for more Speed [ant]
tg-freigmbh commented on code in PR #207: URL: https://github.com/apache/ant/pull/207#discussion_r1452440245 ## src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/LauncherSupport.java: ## @@ -45,14 +45,7 @@ import org.junit.platform.launcher.listeners.SummaryGeneratingListener; import org.junit.platform.launcher.listeners.TestExecutionSummary; -import java.io.File; -import java.io.IOException; -import java.io.InputStream; -import java.io.OutputStream; -import java.io.PipedInputStream; -import java.io.PipedOutputStream; -import java.io.PrintStream; -import java.io.UncheckedIOException; +import java.io.*; Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Buffer for more Speed [ant]
tg-freigmbh commented on PR #207: URL: https://github.com/apache/ant/pull/207#issuecomment-1892265688 I tried, but my ide realy doesnt like that :D maybe I can do it manually on github -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Buffer for more Speed [ant]
jaikiran commented on code in PR #207: URL: https://github.com/apache/ant/pull/207#discussion_r1452430883 ## src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/LauncherSupport.java: ## @@ -45,14 +45,7 @@ import org.junit.platform.launcher.listeners.SummaryGeneratingListener; import org.junit.platform.launcher.listeners.TestExecutionSummary; -import java.io.File; -import java.io.IOException; -import java.io.InputStream; -import java.io.OutputStream; -import java.io.PipedInputStream; -import java.io.PipedOutputStream; -import java.io.PrintStream; -import java.io.UncheckedIOException; +import java.io.*; Review Comment: Can you undo the `*` import and use the previous existing imports plus one new for the BufferedOutputStream? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Buffer for more Speed [ant]
jaikiran commented on PR #207: URL: https://github.com/apache/ant/pull/207#issuecomment-1892256118 Hello @tg-freigmbh, very good catch. This indeed is an issue. I've added a trivial comment inline, other than that this looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[PR] Buffer for more Speed [ant]
tg-freigmbh opened a new pull request, #207: URL: https://github.com/apache/ant/pull/207 I realized that running tests using ant was much slower than running them from the IDE. The culprit was the legacy-xml reporter.  Using an unbuffered Output is very slow, even if you are using an .m2 disk.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
