[GitHub] [apr] notroj commented on a diff in pull request #46: WIP: lmdb support

2023-09-28 Thread via GitHub
notroj commented on code in PR #46: URL: https://github.com/apache/apr/pull/46#discussion_r1339682434 ## build.conf: ## @@ -22,6 +22,7 @@ paths = crypto/crypt_blowfish.c dbm/apr_dbm_sdbm.c dbm/apr_dbm.c + dbm/apr_dbm_lmdb.c Review Comment: This should be removed,

[GitHub] [apr] notroj commented on pull request #46: WIP: lmdb support

2023-09-28 Thread via GitHub
notroj commented on PR #46: URL: https://github.com/apache/apr/pull/46#issuecomment-1738652639 With the line marked in my review above removed, and e147886e92b2858895fe9fff30fccf9dba678cad reverted, I can build with: ```sh "./configure" \ "--with-lmdb" \ "--with-berkeley-db"

[GitHub] [apr] uhliarik commented on pull request #46: WIP: lmdb support

2023-09-28 Thread via GitHub
uhliarik commented on PR #46: URL: https://github.com/apache/apr/pull/46#issuecomment-1738905002 Thanks Joe for reviewing my changes. Previously, I was configurating the lmdb driver with: ``` ./configure --with-lmdb --with-dbm=lmdb ``` And I was having troubles with

[GitHub] [apr] notroj commented on pull request #46: WIP: lmdb support

2023-09-28 Thread via GitHub
notroj commented on PR #46: URL: https://github.com/apache/apr/pull/46#issuecomment-1738859328 I've tested this with mod_dav and it seems to work well. As well as the changes described above I changed the `_usednames` implementation to pass back the "-lock" file as well: