notroj commented on code in PR #49:
URL: https://github.com/apache/apr/pull/49#discussion_r1369834921
##
dbm/apr_dbm_lmdb.c:
##
@@ -237,9 +256,14 @@ static apr_status_t vt_lmdb_del(apr_dbm_t *dbm,
apr_datum_t key)
if ((rv = mdb_del(f->txn, f->dbi, , NULL)) == 0) {
notroj commented on PR #49:
URL: https://github.com/apache/apr/pull/49#issuecomment-1776804513
Also just a comment on code style - use `if (blah) {` rather than `if
(blah){` without a space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
uhliarik commented on code in PR #49:
URL: https://github.com/apache/apr/pull/49#discussion_r1370095013
##
dbm/apr_dbm_lmdb.c:
##
@@ -216,9 +230,14 @@ static apr_status_t vt_lmdb_store(apr_dbm_t *dbm,
apr_datum_t key,
if ((rv = mdb_put(f->txn, f->dbi, , , 0)) == 0) {
asfgit closed pull request #49: apr_dbm_lmdb.c: better error handling and better
URL: https://github.com/apache/apr/pull/49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
notroj commented on code in PR #49:
URL: https://github.com/apache/apr/pull/49#discussion_r1370260493
##
dbm/apr_dbm_lmdb.c:
##
@@ -216,9 +230,14 @@ static apr_status_t vt_lmdb_store(apr_dbm_t *dbm,
apr_datum_t key,
if ((rv = mdb_put(f->txn, f->dbi, , , 0)) == 0) {
ylavic commented on code in PR #49:
URL: https://github.com/apache/apr/pull/49#discussion_r1370436413
##
dbm/apr_dbm_lmdb.c:
##
@@ -156,14 +168,16 @@ static void vt_lmdb_close(apr_dbm_t *dbm)
{
real_file_t *f = dbm->file;
-if (f->cursor) {
-
