[GitHub] [apr] notroj commented on pull request #46: WIP: lmdb support
notroj commented on PR #46: URL: https://github.com/apache/apr/pull/46#issuecomment-1740939720 Thanks a lot for the contribution, @uhliarik -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@apr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apr] notroj commented on pull request #46: WIP: lmdb support
notroj commented on PR #46: URL: https://github.com/apache/apr/pull/46#issuecomment-1738859328 I've tested this with mod_dav and it seems to work well. As well as the changes described above I changed the `_usednames` implementation to pass back the "-lock" file as well: https://github.com/notroj/apr/commit/26afe6b5b134ef3652bb629e6c68af38317f7f62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@apr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apr] notroj commented on pull request #46: WIP: lmdb support
notroj commented on PR #46: URL: https://github.com/apache/apr/pull/46#issuecomment-1738652639 With the line marked in my review above removed, and e147886e92b2858895fe9fff30fccf9dba678cad reverted, I can build with: ```sh "./configure" \ "--with-lmdb" \ "--with-berkeley-db" \ "--with-dbm=db5" \ "--disable-modular-dso" ``` and this passes the tests. Thanks @uhliarik! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@apr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org