Re: [VOTE] Release apr-1.7.4-rc1 as apr-1.7.4
vote passes with following binding +1 and no other votes: steffenal, ylavic, kotkov, covener, jailletc36 On Wed, Apr 12, 2023 at 10:25 PM Eric Covener wrote: > > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/apr/ > > I would like to call a VOTE over the next few days to release > this candidate tarball apr-1.7.4-rc1 as 1.7.4: > [ ] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. > > The computed digests of the tarball up for vote are: > > > The SVN candidate source is found at tags/1.7.4-rc1-candidate. > > -- > Eric Covener > cove...@gmail.com -- Eric Covener cove...@gmail.com
Re: [VOTE] Release apr-1.7.4-rc1 as apr-1.7.4
Le 13/04/2023 à 04:25, Eric Covener a écrit : Hi all, Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/apr/ I would like to call a VOTE over the next few days to release this candidate tarball apr-1.7.4-rc1 as 1.7.4: [X] +1: It's not just good, it's good enough! [ ] +0: Let's have a talk. [ ] -1: There's trouble in paradise. Here's what's wrong. The computed digests of the tarball up for vote are: The SVN candidate source is found at tags/1.7.4-rc1-candidate. +1 Tested on: Linux pop-os 6.2.0-76060200-generic gcc (Ubuntu 12.1.0-2ubuntu1~22.04) 12.1.0 CJ
Re: [VOTE] Release apr-1.7.4-rc1 as apr-1.7.4
+1 All looks fine on Windows. Steffen On Thursday 13/04/2023 at 04:25, Eric Covener wrote: Hi all, Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/apr/ I would like to call a VOTE over the next few days to release this candidate tarball apr-1.7.4-rc1 as 1.7.4: [ ] +1: It's not just good, it's good enough! [ ] +0: Let's have a talk. [ ] -1: There's trouble in paradise. Here's what's wrong. The computed digests of the tarball up for vote are: The SVN candidate source is found at tags/1.7.4-rc1-candidate. -- Eric Covener cove...@gmail.com
Re: [VOTE] Release apr-1.7.4-rc1 as apr-1.7.4
On Wed, Apr 12, 2023 at 10:25 PM Eric Covener wrote: > > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/apr/ > > I would like to call a VOTE over the next few days to release > this candidate tarball apr-1.7.4-rc1 as 1.7.4: > [x] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. my +1 aix/xlc/ppc64 usual suspects only Failed TestsTotal FailFailed % === testprocmutex 6 2 33.33% testsock 17 1 5.88%
Re: [VOTE] Release apr-1.7.4-rc1 as apr-1.7.4
Eric Covener writes: > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/apr/ > > I would like to call a VOTE over the next few days to release > this candidate tarball apr-1.7.4-rc1 as 1.7.4: [X] +1: It's not just good, it's good enough! Checks performed: — Verify SHA256 for apr-1.7.4-rc1-candidate.tar.bz2 — Verify SHA256 for apr-1.7.4-rc1-candidate.tar.gz — Verify SHA256 for apr-1.7.4-rc1-candidate-win32-src.zip — Verify diff between apr-1.7.4-rc1-candidate-win32-src.zip and published apr-1.7.3-win32-src.zip — Build using apr-1.7.4-rc1-candidate-win32-src.zip on Windows x64/CMake — Run APR tests on Windows x64 — Run Subversion 1.14.x tests with this APR version on Windows x64 Thanks, Evgeny Kotkov
Re: [VOTE] Release apr-1.7.4-rc1 as apr-1.7.4
On Thu, Apr 13, 2023 at 1:08 PM Evgeny Kotkov wrote: > > Eric Covener writes: > > > Hi all, > > > > Please find below the proposed release tarball and signatures: > > > > https://dist.apache.org/repos/dist/dev/apr/ > > First time voting for an APR release, but isn't apr-1.7.4-rc1-win32-src.zip > missing from the set of artifacts? yes, omission in porting the httpd automation. I manually added now.
Re: [VOTE] Release apr-1.7.4-rc1 as apr-1.7.4
Eric Covener writes: > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/apr/ First time voting for an APR release, but isn't apr-1.7.4-rc1-win32-src.zip missing from the set of artifacts? I think that it was present during the vote for APR 1.7.3: [[[ > svn log https://dist.apache.org/repos/dist/dev/apr -c60838 -v Changed paths: M /dev/apr/Announcement1.x.html M /dev/apr/Announcement1.x.txt A /dev/apr/apr-1.7.3-rc1-win32-src.zip A /dev/apr/apr-1.7.3-rc1-win32-src.zip.asc A /dev/apr/apr-1.7.3-rc1-win32-src.zip.sha256 A /dev/apr/apr-1.7.3-rc1.tar.bz2 A /dev/apr/apr-1.7.3-rc1.tar.bz2.asc A /dev/apr/apr-1.7.3-rc1.tar.bz2.sha256 A /dev/apr/apr-1.7.3-rc1.tar.gz A /dev/apr/apr-1.7.3-rc1.tar.gz.asc A /dev/apr/apr-1.7.3-rc1.tar.gz.sha256 1.7.3. rc1 ]]] Thanks, Evgeny Kotkov
Re: [VOTE] Release apr-1.7.4-rc1 as apr-1.7.4
On Thu, Apr 13, 2023 at 1:08 PM Yann Ylavic wrote: > > On Thu, Apr 13, 2023 at 1:02 PM Eric Covener wrote: > > > > New for this release we are only toggling it on the release tag (sic), > > similar to httpd release process. > > Maybe a bump (to 1.7.5 here) is missing in 1.7.x after tagging now? > Currently apr_version.h is still at 1.7.4-dev it seems. Nevermind, this probably happens when the release is accepted..
Re: [VOTE] Release apr-1.7.4-rc1 as apr-1.7.4
On Thu, Apr 13, 2023 at 4:25 AM Eric Covener wrote: > > I would like to call a VOTE over the next few days to release > this candidate tarball apr-1.7.4-rc1 as 1.7.4: [X] +1: It's not just good, it's good enough! All tests pass on Debian 11 and 12, sums/sigs/version/dirname OK. Thanks Eric for RMing!
Re: [VOTE] Release apr-1.7.4-rc1 as apr-1.7.4
On Thu, Apr 13, 2023 at 1:02 PM Eric Covener wrote: > > New for this release we are only toggling it on the release tag (sic), > similar to httpd release process. Maybe a bump (to 1.7.5 here) is missing in 1.7.x after tagging now? Currently apr_version.h is still at 1.7.4-dev it seems.
Re: [VOTE] Release apr-1.7.4-rc1 as apr-1.7.4
New for this release we are only toggling it on the release tag (sic), similar to httpd release process. On Thu, Apr 13, 2023, 6:42 AM Yann Ylavic wrote: > On Thu, Apr 13, 2023 at 12:16 PM SteffenAL wrote: > > > > it's me. I build from svn, and there is : > > > > #define APR_IS_DEV_VERSION > > Yeah, this is restored immediately after tagging to not let a branch > in a "release" state. > You could checkout tags/apr-1.7.4-rc1 rather than branches/1.7.x for > testing, the vote is about the tarballs but I suppose testing the tag > is fine too if it helps (maybe related with Windows' CRLF vs tarball's > LF in the source files in your case..). > > > Regards; > Yann. >
Re: [VOTE] Release apr-1.7.4-rc1 as apr-1.7.4
On Thu, Apr 13, 2023 at 12:16 PM SteffenAL wrote: > > it's me. I build from svn, and there is : > > #define APR_IS_DEV_VERSION Yeah, this is restored immediately after tagging to not let a branch in a "release" state. You could checkout tags/apr-1.7.4-rc1 rather than branches/1.7.x for testing, the vote is about the tarballs but I suppose testing the tag is fine too if it helps (maybe related with Windows' CRLF vs tarball's LF in the source files in your case..). Regards; Yann.
Re: [VOTE] Release apr-1.7.4-rc1 as apr-1.7.4
Re: [VOTE] Release apr-1.7.4-rc1 as apr-1.7.4
On Thu, Apr 13, 2023 at 9:38 AM SteffenAL wrote: > > It is identified as 1.7.4-dev > > In apr_version.h dev version is defined. I don't see this in the release candidate tarballs (.gz or .bz2), apr_version.h contains: /* #undef APR_IS_DEV_VERSION */ so it should not include the "-dev" suffix in APR_VERSION_STRING. Likewise here: https://github.com/apache/apr/blob/1.7.4-rc1-candidate/include/apr_version.h#L72 Could it be from a local /D of yours or something? Regards; Yann.
Re: [VOTE] Release apr-1.7.4-rc1 as apr-1.7.4
It is identified as 1.7.4-dev In apr_version.h dev version is defined. Steffen --- Original message --- Subject: [VOTE] Release apr-1.7.4-rc1 as apr-1.7.4 From: Eric Covener To: dev@apr.apache.org Date: Thursday, 13/04/2023 04:25 Hi all, Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/apr/ I would like to call a VOTE over the next few days to release this candidate tarball apr-1.7.4-rc1 as 1.7.4: [ ] +1: It's not just good, it's good enough! [ ] +0: Let's have a talk. [ ] -1: There's trouble in paradise. Here's what's wrong. The computed digests of the tarball up for vote are: The SVN candidate source is found at tags/1.7.4-rc1-candidate. -- Eric Covener cove...@gmail.com
