Re: [DBCP]

2017-03-29 Thread Matt Sicker
Using a MethodHandle lookup ahead of time to create a fast invocation proxy and using that where available would make sense. I don't like the idea of catching errors like that. On 29 March 2017 at 01:53, Gary Gregory wrote: > Hi All: > > The method: > >

Re: [DBCP]

2017-03-29 Thread Gary Gregory
On Wed, Mar 29, 2017 at 8:28 AM, Matt Sicker wrote: > Using a MethodHandle lookup ahead of time to create a fast invocation proxy > and using that where available would make sense. I don't like the idea of > catching errors like that. > Hi Matt, Thank you for the tip. Do you

Re: [DBCP]

2017-03-29 Thread Matt Sicker
MethodHandles.Lookup lookup = MethodHandles.lookup(); MethodType mt = MethodType.methodType(boolean.class, int.class); MethodHandle handle = lookup.findVirtual(Connection.class, "isValid", mt); // ... boolean isValid = (boolean) handle.invokeExact(connection, timeout); The findVirtual() call

Re: [DBCP] isValid replacement

2017-03-29 Thread Bernd Eckenfels
You can run a verification SQL instead. So I guess doing nothing would be fine as well, as the verification SQL (on borrow) could be configured instead. Other methods which do a round trip to the database can be used as well (for example setAutocommit() on some drivers). Gruss Bernd --

[DBCP]

2017-03-29 Thread Gary Gregory
Hi All: The method: org.apache.commons.dbcp2.DelegatingConnection.isValid(int) delegates to a JDBC method that is marked "@since 1.6" in the JDBC Javadoc. I am dealing with an old JDBC driver that throws an AbstractMethodError when this method is called. How can I workaround this? Should we

[GitHub] commons-compress pull request #17: CPIO crc overflow resolved for large file...

2017-03-29 Thread dcollin
GitHub user dcollin opened a pull request: https://github.com/apache/commons-compress/pull/17 CPIO crc overflow resolved for large files When unpacking a CPIO file containing a large file the crc check will overflow and throw an IOException("CRC Error..."). Did not find

[GitHub] commons-compress issue #17: CPIO crc overflow resolved for large files

2017-03-29 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-compress/pull/17 [![Coverage Status](https://coveralls.io/builds/10826707/badge)](https://coveralls.io/builds/10826707) Coverage increased (+0.001%) to 84.176% when pulling

[GitHub] commons-compress issue #17: CPIO crc overflow resolved for large files

2017-03-29 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/commons-compress/pull/17 Great, many thanks, I've just found https://people.freebsd.org/~kientzle/libarchive/man/cpio.5.txt states > The CRC format is identical to the new ASCII format described in

[GitHub] commons-compress pull request #17: CPIO crc overflow resolved for large file...

2017-03-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-compress/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the