[GitHub] commons-fileupload issue #8: FILEUPLOAD-283: add tests for the portlet packa...

Github user kinow commented on the issue: https://github.com/apache/commons-fileupload/pull/8 No objections so far, will merge it tomorrow after reviewing the code once more :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] commons-text pull request #54: TEXT-93: RandomStringGenerator accepts a list...

Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-text/pull/54#discussion_r123874569 --- Diff: src/main/java/org/apache/commons/text/RandomStringGenerator.java --- @@ -76,23 +78,29 @@ private final TextRandomProvider random;

[GitHub] commons-text pull request #54: TEXT-93: RandomStringGenerator accepts a list...

Github user ameyjadiye commented on a diff in the pull request: https://github.com/apache/commons-text/pull/54#discussion_r123877950 --- Diff: src/main/java/org/apache/commons/text/RandomStringGenerator.java --- @@ -76,23 +78,29 @@ private final TextRandomProvider random;

[GitHub] commons-text issue #54: TEXT-93: RandomStringGenerator accepts a list of val...

Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/54 [](https://:/builds/12116448) Coverage decreased (-0.02%) to 97.305% when pulling **9db77088ecc557c2f209dd36972746d6de8dfc4a

Re: [FUNCTOR] Why do we have an API module?

Hi Matt, what is your opinion in this topic (targeting Java 8) Benedikt Matt Benson schrieb am Sa. 24. Juni 2017 um 19:18: > If we want to repurpose functor for Java 8 then I imagine we'd just > use their interfaces, for the most part. So the API module would > indeed

Re: [FUNCTOR] Why do we have an API module?

Hi, > Am 16.06.2017 um 13:03 schrieb Matt Benson : > > Yes, the point of the API module was to define the functional interfaces > separately from the utility code around them; particularly pre-Java 8, > these could be used apart from the utility code from the core. Since we

Re: [configuration] checkstyle fails build

Should changes related to the setup and handling of checkstyle then be done for Commons as a whole? Oliver (No P.S.) Am 23.06.2017 um 21:19 schrieb Gary Gregory: > I > > P.S. > > Agree > > P.P.S. > > With > > P.P.P.S. > > you! > > Gary > > On Jun 23, 2017 10:28, "Simon Spero"

[GitHub] commons-fileupload pull request #8: FILEUPLOAD-283: add tests for the portle...

Github user asfgit closed the pull request at: https://github.com/apache/commons-fileupload/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Some ideas for improving Travis build performance improvements:

Hi Simon et al I'm not sure what we are using Travis CI for in the first place. Maybe we can minimize build time by reducing the build to the utter minimum required to achieve that - whatever that is? Honestly I don't see anything we couldn't do with our Jenkins installation as well. Maybe