[GitHub] commons-text pull request #60: additional-tests

2017-08-01 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-text/pull/60#discussion_r130549181 --- Diff: src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java --- @@ -592,4 +593,43 @@ public void testUnscapeXSI() {

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

2017-08-01 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-cli/pull/16 [![Coverage Status](https://coveralls.io/builds/12646111/badge)](https://coveralls.io/builds/12646111) Coverage remained the same at 96.287% when pulling

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

2017-08-01 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-cli/pull/16 [![Coverage Status](https://coveralls.io/builds/12646111/badge)](https://coveralls.io/builds/12646111) Coverage remained the same at 96.287% when pulling

[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.

2017-08-01 Thread ameyjadiye
GitHub user ameyjadiye opened a pull request: https://github.com/apache/commons-text/pull/61 Added flexible Travis-ci build script. This enables ua to use any jdk against our code and not keeps us dependency on Travis to provide jdk You can merge this pull request into a Git

[GitHub] commons-text issue #60: additional-tests

2017-08-01 Thread TheRealHaui
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/60 You're welcome! Thought it would be preferred by comments. However, I will try to keep in mind. And be cautious what you wish. ;-) --- If your project is set up for it, you can

[GitHub] commons-text issue #61: Added flexible Travis-ci build script.

2017-08-01 Thread chtompki
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/61 I'll get to this soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] commons-text issue #61: Added flexible Travis-ci build script.

2017-08-01 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/61 In my opinion this is overkill. I don't think commons-text needs to be tested against the eclipse java compiler and early access version of java 8 and 9. The script looks difficult to

[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...

2017-08-01 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/57 [![Coverage Status](https://coveralls.io/builds/12640859/badge)](https://coveralls.io/builds/12640859) Coverage decreased (-0.2%) to 98.021% when pulling

[GitHub] commons-text pull request #60: additional-tests

2017-08-01 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-text/pull/60#discussion_r130633380 --- Diff: src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java --- @@ -592,4 +593,43 @@ public void testUnscapeXSI() {

[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...

2017-08-01 Thread arunvinudss
Github user arunvinudss commented on the issue: https://github.com/apache/commons-text/pull/57 @chtompki Please review and merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] commons-imaging issue #30: add-tests

2017-08-01 Thread TheRealHaui
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/30 Checks failed due to Travis JDK crashing not due to problems in code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[RESULT] Release Commons Email 1.5 Based on RC1

2017-08-01 Thread Stefan Bodewig
Hi all with the binding +1s by Oliver Heger, Gary Gregory and myself (cast implicitly) as well as the +1 by Amey Jadiye this vote has passed. I'll publish the artifacts and give the mirrors a little time to catch up before announcing the release. Many thanks to those who reviewed the release

[GitHub] commons-text pull request #60: additional-tests

2017-08-01 Thread TheRealHaui
Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-text/pull/60#discussion_r130609309 --- Diff: src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java --- @@ -592,4 +593,43 @@ public void testUnscapeXSI() {

[GitHub] commons-text issue #60: additional-tests

2017-08-01 Thread TheRealHaui
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/60 Rechecked for blank lines and removed them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] commons-text issue #60: additional-tests

2017-08-01 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/60 [![Coverage Status](https://coveralls.io/builds/12639540/badge)](https://coveralls.io/builds/12639540) Coverage increased (+0.3%) to 98.489% when pulling

[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...

2017-08-01 Thread chtompki
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/57 Will get to this today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] commons-text pull request #60: additional-tests

2017-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-text/pull/60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] commons-text pull request #57: TEXT-98: Remove isDelimiter and use HashSets ...

2017-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-text/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] commons-text issue #60: additional-tests

2017-08-01 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/60 Thanks! :+1: By the way: Feel free to raise a jira issue for anything you think that maybe be a bug (e.g. NullPointerExceptions). --- If your project is set up for it, you

Re: Fwd: [2/2] commons-cli git commit: add default mvn default (clean, test, clirr, rat and javadoc) and run it on travis

2017-08-01 Thread Pascal Schumacher
Imho yes, but to make this possible existing violations have to be analyzed and then either fixed or ignored. Am 01.08.2017 um 19:37 schrieb Amey Jadiye: It would be nice to add checkstyle and findbug as well ? Regards, Amey -- Forwarded message -- From:

Fwd: [2/2] commons-cli git commit: add default mvn default (clean, test, clirr, rat and javadoc) and run it on travis

2017-08-01 Thread Amey Jadiye
It would be nice to add checkstyle and findbug as well ? Regards, Amey -- Forwarded message -- From: Date: Tue, Aug 1, 2017 at 10:57 PM Subject: [2/2] commons-cli git commit: add default mvn default (clean, test, clirr, rat and javadoc) and run it on

[ANN] Apache Commons Email 1.5 Released

2017-08-01 Thread Stefan Bodewig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The Apache Commons Team is pleased to announce the release of Apache Commons Email 1.5. This is a major and security bugfix release which adds some new features and fixes several bugs present in the 1.4 release. All current users are encouraged to

CVE-2017-9801: Apache Commons Email SMTP header injection vulnerabilty

2017-08-01 Thread Stefan Bodewig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 CVE-2017-9801: Apache Commons Email SMTP header injection vulnerabilty Severity: low Vendor: The Apache Software Foundation Versions Affected: Apache Commons Email 1.0 to 1.4. Description: When a call-site passes a subject for an email that

[GitHub] commons-cli pull request #16: added findbug and checkstyle support while bui...

2017-08-01 Thread ameyjadiye
GitHub user ameyjadiye opened a pull request: https://github.com/apache/commons-cli/pull/16 added findbug and checkstyle support while building You can merge this pull request into a Git repository by running: $ git pull https://github.com/ameyjadiye/commons-cli master

Re: Fwd: [2/2] commons-cli git commit: add default mvn default (clean, test, clirr, rat and javadoc) and run it on travis

2017-08-01 Thread Amey Jadiye
Just checked commons-cli pom.xml and found checkstyle and findbug support is already present in reporting section, just copied same setting in build section and we are good. https://github.com/apache/commons-cli/pull/16 You are welcome :-) Regards, Amey On Tue, Aug 1, 2017 at 11:26 PM, Pascal