Re: [ALL] Automated requirements (e.g. CheckStyle)? (Was: [MATH] Enforce run [...])

2017-08-08 Thread Karl-Philipp Richter
Hi, Am 07.08.2017 um 15:09 schrieb Gilles: > Less work for the maintainers is good. :-) > > By "taking time" I meant that validating should not be enforced when > calling "mvn compile" or "mvn test". I wouldn't worry about the time consumption of the validation even if it's run by every dev

Re: [ALL] Automated requirements (e.g. CheckStyle)?

2017-08-08 Thread Gilles
Hello. On Wed, 9 Aug 2017 00:20:00 +0200, Karl-Philipp Richter wrote: Hi, Am 07.08.2017 um 15:09 schrieb Gilles: Less work for the maintainers is good. :-) By "taking time" I meant that validating should not be enforced when calling "mvn compile" or "mvn test". I wouldn't worry about the

Re: [ALL] Automated requirements (e.g. CheckStyle)?

2017-08-08 Thread Chas Honton
Since most of us work in an IDE, the "wasted" time of checkstyle for every build is negligible. At my day job, all code is automatically reformatted as part of the build. It's just another step along with PMD, CPD, findbugs, sonar, jacoco, junit, and a few other static analyses. The more we

Re: [ALL] Automated requirements (e.g. CheckStyle)?

2017-08-08 Thread Gilles
On Tue, 8 Aug 2017 18:49:44 -0700, Chas Honton wrote: Since most of us work in an IDE, the "wasted" time of checkstyle for every build is negligible. It's not just the wasted time of running the tool (which might well be negligible), it's the forcing of e.g. documenting a code that might turn

Re: Ready for JDK 9 ?

2017-08-08 Thread Gilles
Hi. On Tue, 8 Aug 2017 11:09:01 +0100, Rory O'Donnell wrote: Hi Benedikt, Thank you very much for all your testing of JDK 9 during its development! Such contributions have significantly helped shape and improve JDK 9. Now that we have reached the JDK 9 Final Release Candidate phase [1] , I

[GitHub] commons-fileupload pull request #9: Msamery commons fileupload 1.3.2 patch 1

2017-08-08 Thread MSAmery
GitHub user MSAmery opened a pull request: https://github.com/apache/commons-fileupload/pull/9 Msamery commons fileupload 1.3.2 patch 1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSAmery/commons-fileupload

Ready for JDK 9 ?

2017-08-08 Thread Rory O'Donnell
Hi Benedikt, Thank you very much for all your testing of JDK 9 during its development! Such contributions have significantly helped shape and improve JDK 9. Now that we have reached the JDK 9 Final Release Candidate phase [1] , I would like to ask if your project can be considered to be

Re: Ready for JDK 9 ?

2017-08-08 Thread Amey Jadiye
Hmm, isn't that easy with just Travis ? We just have to add java9 option(not sure it have RC) and trigger build it will automatically check build and tests. IIRC for few components we are having java9 Travis env already set. Regards, Amey On Tue, Aug 8, 2017, 8:38 PM Jörg Schaible

Re: Ready for JDK 9 ?

2017-08-08 Thread Pascal Schumacher
Hello everybody, commons-lang and commons-text are build and tested with JDK 9 on traivs-ci, e.g.: https://travis-ci.org/apache/commons-text/jobs/259838032 https://travis-ci.org/apache/commons-lang/jobs/258653445 so I guess these components are ready for JDK 9. Cheers, Pascal Am 08.08.2017

Re: Ready for JDK 9 ?

2017-08-08 Thread Pascal Schumacher
The same goes for commons-compress (as already mentioned by Simon Spero): https://travis-ci.org/apache/commons-compress/jobs/258642081 Am 08.08.2017 um 22:48 schrieb Pascal Schumacher: Hello everybody, commons-lang and commons-text are build and tested with JDK 9 on traivs-ci, e.g.:

Re: Ready for JDK 9 ?

2017-08-08 Thread Jörg Schaible
Hi, Gilles wrote: > Hi. > > On Tue, 8 Aug 2017 11:09:01 +0100, Rory O'Donnell wrote: >> Hi Benedikt, >> >> Thank you very much for all your testing of JDK 9 during its >> development! Such contributions have significantly helped shape and >> improve JDK 9. >> >> Now that we have reached the JDK

Re: Ready for JDK 9 ?

2017-08-08 Thread Bernd Eckenfels
Hello, I am willing to do that for a few components. Maybe we can collect the Java9 state for commons on a Wiki Page, like: Component | Compiles with 9 since | Module aware? | Latest bin Release runs in 9. | Comments (Not sure how easy the modules check will be and what we define as

Re: Ready for JDK 9 ?

2017-08-08 Thread Simon Spero
Compress HEAD is tested against the equivalent of RC. The main issues were with tests; some types of mocking (especially of concrete classes) don't work. This might have been fixed by now. I believe that the latest jacoco is 9 compatible. [The biggest problem was caused by a bug in the zip code