Re: [math] javadoc unbalanced code

2012-03-09 Thread Benedikt Ritter
Thanks for the patch Dennis! Feel free create a JIRA ticket [1] for this issue, where you can attach your patch (and maybe more ;). One little suggestion for improvement: According to [2] {@code } should be used in instead of code and tt. Regards, Benedikt [1] https://issues.apache.org/jira [2]

Re: [csv] Performance comparison

2012-03-11 Thread Benedikt Ritter
Am 11. März 2012 15:05 schrieb Emmanuel Bourg ebo...@apache.org: Hi, I compared the performance of Commons CSV with the other CSV parsers available. I took the world cities file from Maxmind as a test file [1], it's a big file of 130M with 2.8 million records. Here are the results obtained

Re: [csv] Performance comparison

2012-03-11 Thread Benedikt Ritter
Am 11. März 2012 21:21 schrieb Emmanuel Bourg ebo...@apache.org: Le 11/03/2012 16:53, Benedikt Ritter a écrit : I have some spare time to help you with this. I'll check out the latest source tonight. Any suggestion where to start? Hi Benedikt, thank you for helping. You can start looking

[csv] Serializable on CSVFormat

2012-03-11 Thread Benedikt Ritter
Hi, I just saw that CSVFormat implements Serializable, but neither does it provide a no-arg constructor nor any of the special serialization methods (and it has no custom serialUID). Is this the way it is supposed to be? Benedikt

Re: [jira] [Created] (CSV-55) Replace while(true)-loop in CSVParser.getRecord() with do-while-loop

2012-03-12 Thread Benedikt Ritter
On Mar 12, 2012, at 9:59, Benedikt Ritter (Created) (JIRA) j...@apache.org wrote: Replace while(true)-loop in CSVParser.getRecord() with do-while-loop                 Key: CSV-55                 URL: https://issues.apache.org

Re: [jira] [Created] (CSV-55) Replace while(true)-loop in CSVParser.getRecord() with do-while-loop

2012-03-12 Thread Benedikt Ritter
Am 12. März 2012 15:39 schrieb Gary Gregory garydgreg...@gmail.com: On Mon, Mar 12, 2012 at 10:17 AM, Benedikt Ritter benerit...@googlemail.com wrote: Hey Gary, thanks for the hint. Should I just send patches for minor changes like that to the ML (plain text, not as attachment of course

Re: [csv] Performance comparison

2012-03-12 Thread Benedikt Ritter
Am 12. März 2012 11:31 schrieb Emmanuel Bourg ebo...@apache.org: I have identified the performance killer, it's the ExtendedBufferedReader. It implements a complex logic to fetch one character ahead, but this extra character is rarely used. I have implemented a simpler look ahead using

Re: [csv] Performance comparison

2012-03-12 Thread Benedikt Ritter
Am 12. März 2012 17:22 schrieb Emmanuel Bourg ebo...@apache.org: Le 12/03/2012 17:03, Benedikt Ritter a écrit : The hole logic behind CSVLexer.nextToken() is very hard to read (IMHO). Maybe a some refactoring would help to make it easier to identify bottle necks? Yes I started

[cvs] CSVLexer.isEndOfLine(int c) makes assumptions on the line separator of a CSVFormat

2012-03-12 Thread Benedikt Ritter
Hi, while looking for potential performance optimization I came across CSVLexer.isEndOfLine(int c). Here is the source: private boolean isEndOfLine(int c) throws IOException { // check if we have \r\n... if (c == '\r' in.lookAhead() == '\n') { // note: does not

Re: [cvs] CSVLexer.isEndOfLine(int c) makes assumptions on the line separator of a CSVFormat

2012-03-12 Thread Benedikt Ritter
Am 12. März 2012 18:24 schrieb Emmanuel Bourg ebo...@apache.org: Le 12/03/2012 18:17, Benedikt Ritter a écrit : this method assumes, that a line separator will always be \r or \r\n. This is true for the pre-configured CSVFormats EXCEL, TDF and MYSQL. I'm not a pro when it comes to file

Re: [cvs] CSVLexer.isEndOfLine(int c) makes assumptions on the line separator of a CSVFormat

2012-03-12 Thread Benedikt Ritter
Am 12. März 2012 18:38 schrieb Emmanuel Bourg ebo...@apache.org: Le 12/03/2012 18:31, Benedikt Ritter a écrit : I'm not sure if I got you right. You have to pass a CSVFormat if you want to construct a CSVLexer(), so we could use the lexer's internal CSVformat. Yes that's what I understood

Re: [lang] Longest common substring / Suffix Tree

2012-03-12 Thread Benedikt Ritter
Am 12. März 2012 21:20 schrieb Thomas Neidhart thomas.neidh...@gmail.com: Hi, on the weekend, I started to work on issue LANG-680 (https://issues.apache.org/jira/browse/LANG-680), which is about adding support for finding the longest common substring of a set of Strings. Suffix Trees are a

Re: [csv] Headers

2012-03-13 Thread Benedikt Ritter
I think transforming the result of the parse process into instances of some class is a different concern. That should not be part of as CSVParser. In Hibernate they use ResultTransformers for this purpose [1]. I think we should separate this concerns as well. [1]

Re: [ALL] Commons Parent reports

2012-03-13 Thread Benedikt Ritter
Am 13. März 2012 14:15 schrieb Gary Gregory garydgreg...@gmail.com: On Tue, Mar 13, 2012 at 8:39 AM, Torsten Curdt tcu...@vafer.org wrote: I find checkstyle to be not very useful. It's more hassle than it's worth. It's like pointing fingers instead of helping. If you want to foster a certain

Re: svn commit: r1300661 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java

2012-03-14 Thread Benedikt Ritter
Am 14. März 2012 18:43 schrieb s...@apache.org: Author: sebb Date: Wed Mar 14 17:43:35 2012 New Revision: 1300661 URL: http://svn.apache.org/viewvc?rev=1300661view=rev Log: CSV-60 CSVParser.iterator().remove() should throw throw new UnsupportedOperationException() is it reasonable to

Re: svn commit: r1300661 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java

2012-03-14 Thread Benedikt Ritter
Am 14. März 2012 20:33 schrieb Benedikt Ritter benerit...@googlemail.com: Am 14. März 2012 18:43 schrieb  s...@apache.org: Author: sebb Date: Wed Mar 14 17:43:35 2012 New Revision: 1300661 URL: http://svn.apache.org/viewvc?rev=1300661view=rev Log: CSV-60 CSVParser.iterator().remove

Re: svn commit: r1300699 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java

2012-03-14 Thread Benedikt Ritter
Am 14. März 2012 20:48 schrieb s...@apache.org: Author: sebb Date: Wed Mar 14 19:48:12 2012 New Revision: 1300699 URL: http://svn.apache.org/viewvc?rev=1300699view=rev Log: Javadoc Modified:     commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java Modified:

[csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-14 Thread Benedikt Ritter
Hey, the subject of this mail is pretty self-explanatory. Why do we need a package private validate() method, given the fact, that users can not create custom instances (constructor is package private)? You could even argue, that no validation is needed at all, since we are in control of what

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-14 Thread Benedikt Ritter
Am 14. März 2012 22:02 schrieb Emmanuel Bourg ebo...@apache.org: Le 14/03/2012 21:52, Benedikt Ritter a écrit : the subject of this mail is pretty self-explanatory. Why do we need a package private validate() method, given the fact, that users can not create custom instances (constructor

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-14 Thread Benedikt Ritter
Am 14. März 2012 22:16 schrieb sebb seb...@gmail.com: On 14 March 2012 21:02, Emmanuel Bourg ebo...@apache.org wrote: Le 14/03/2012 21:52, Benedikt Ritter a écrit : the subject of this mail is pretty self-explanatory. Why do we need a package private validate() method, given the fact

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-14 Thread Benedikt Ritter
Am 14. März 2012 22:33 schrieb Emmanuel Bourg ebo...@apache.org: Le 14/03/2012 22:25, Benedikt Ritter a écrit : I agree with you on this. However, I think it would be better to tie validation to the object creation. Maybe the Builder Pattern like shown in Effective Java p. 14-15

Re: [csv] Headers

2012-03-15 Thread Benedikt Ritter
Am 15. März 2012 01:58 schrieb Emmanuel Bourg ebo...@apache.org: There is another alternative, we might replace the records returned as a String[] by a CSVRecord class able to access the fields by id or by name. This would be similar to a JDBC resultset (except for the looping logic) sounds

Re: svn commit: r1300925 - /commons/sandbox/beanutils2/trunk/src/main/java/org/apache/commons/beanutils2/AccessibleObjectsRegistry.java

2012-03-15 Thread Benedikt Ritter
Am 15. März 2012 12:59 schrieb sebb seb...@gmail.com: On 15 March 2012 11:26,  simonetrip...@apache.org wrote: Author: simonetripodi Date: Thu Mar 15 11:26:25 2012 New Revision: 1300925 URL: http://svn.apache.org/viewvc?rev=1300925view=rev Log: just incrementally built the hashcode in the

Re: [CSV] Performance

2012-03-15 Thread Benedikt Ritter
Am 15. März 2012 13:50 schrieb Gary Gregory garydgreg...@gmail.com: Can you put your perf test code and resources in SVN so I do not have to write on please? Hi Gary, have a look at http://markmail.org/message/x73i3hl63rjqdyfa (I agree with you, that having a clean performance test in SVN

Re: svn commit: r1300977 - in /commons/proper/csv/trunk: ./ src/test/java/org/apache/commons/csv/

2012-03-15 Thread Benedikt Ritter
Am 15. März 2012 14:44 schrieb ggreg...@apache.org: Author: ggregory Date: Thu Mar 15 13:44:44 2012 New Revision: 1300977 URL: http://svn.apache.org/viewvc?rev=1300977view=rev Log: Update to JUnit 4.10 from 3.8.1. nice work! how about a static import of org.junit.Assert.* ? Modified:  

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-15 Thread Benedikt Ritter
Am 14. März 2012 22:47 schrieb sebb seb...@gmail.com: On 14 March 2012 21:40, Benedikt Ritter benerit...@googlemail.com wrote: Am 14. März 2012 22:33 schrieb Emmanuel Bourg ebo...@apache.org: Le 14/03/2012 22:25, Benedikt Ritter a écrit : I agree with you on this. However, I think it would

[csv] Improving readability in CSVLexer

2012-03-16 Thread Benedikt Ritter
Hey, I'm thinking of ways to improve the readability of CSVLexer. I think that it might be easier to improve performance if the code is easier to understand. Here is, what I think can be improved: 1. eliminate Token input parameter on nextToken() To me it looks like the token input parameter on

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-17 Thread Benedikt Ritter
Am 16. März 2012 23:36 schrieb Emmanuel Bourg ebo...@apache.org: Choice is good I agree. Commons CSV will also support annotated POJO, that will give two ways to use the API. Are we still talking about how to create CSVFormat instances? Benedikt Emmanuel Bourg Le 16/03/2012 22:26, Simone

Re: svn commit: r1301852 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/

2012-03-17 Thread Benedikt Ritter
Am 17. März 2012 13:12 schrieb sebb seb...@gmail.com: On 17 March 2012 01:39,  ebo...@apache.org wrote: Author: ebourg Date: Sat Mar 17 01:39:04 2012 New Revision: 1301852 URL: http://svn.apache.org/viewvc?rev=1301852view=rev Log: Header support (CSV-65) Added:    

Re: svn commit: r1303488 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java

2012-03-21 Thread Benedikt Ritter
What about the Builder pattern we discussed lately? Several people have expressed their feels for that solution. Am 21. März 2012 19:20 schrieb s...@apache.org: Author: sebb Date: Wed Mar 21 18:20:05 2012 New Revision: 1303488 URL: http://svn.apache.org/viewvc?rev=1303488view=rev Log:

Re: [csv] Improving readability in CSVLexer

2012-03-21 Thread Benedikt Ritter
Hey, I've tried to remove the Token input parameter in CSVLexer.nextToken(). First by creating ne new Token on every invocation of nextToken(). That slowed execution of that method by about 100ms. So I added a private Token field to CSVLexer, that only get's initiated once. But that solution was

Re: [csv] Improving readability in CSVLexer

2012-03-22 Thread Benedikt Ritter
Am 22. März 2012 00:19 schrieb sebb seb...@gmail.com: On 21 March 2012 19:16, Benedikt Ritter benerit...@googlemail.com wrote: Hey, I've tried to remove the Token input parameter in CSVLexer.nextToken(). First by creating ne new Token on every invocation of nextToken(). That slowed execution

Re: svn commit: r1303878 - /commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/PerformanceTest.java

2012-03-23 Thread Benedikt Ritter
Am 22. März 2012 17:28 schrieb s...@apache.org: Author: sebb Date: Thu Mar 22 16:28:47 2012 New Revision: 1303878 URL: http://svn.apache.org/viewvc?rev=1303878view=rev Log: Allow testing of dynamically loaded CSVLexers I'm not sure if I understand where you are going with this. Don't you

[csv] Rename methods on XXXLexer methods on CSVLexer

2012-03-29 Thread Benedikt Ritter
Hey, how about renaming CSVLexer.simpleTokenLexer() and CSVLexer.encapsulatedTokenLexer(), so that the method names express what the methods do? For example simpleTokenLexer() could be renamed to parseSimpleToken or parseSimpleTokenContent. Likewise encapsulatedTokenLexer() could be renamed to

Re: [csv] Rename methods on XXXLexer methods on CSVLexer

2012-03-29 Thread Benedikt Ritter
Am 29. März 2012 22:07 schrieb sebb seb...@gmail.com: On 29 March 2012 20:45, Benedikt Ritter benerit...@googlemail.com wrote: Hey, how about renaming CSVLexer.simpleTokenLexer() and CSVLexer.encapsulatedTokenLexer(), so that the method names express what the methods do? For example

Re: [ALL]Can you share the codeformater.xml and codetemplates.xml in eclipse

2012-06-01 Thread Benedikt Ritter
Since configurations may change over time it would be better to put them in SVN. Benedikt 2012/5/31 sebb seb...@gmail.com: On 31 May 2012 22:13, Gary Gregory garydgreg...@gmail.com wrote: We need to put this or some commons wide convention in SVN... where? How about commons-parent?

Re: [Math] How to use a class from the test source tree?

2012-06-13 Thread Benedikt Ritter
Hi, 2012/6/13 Gilles Sadowski gil...@harfang.homelinux.org: Hi. Is there a way for an application to depend on the classes defined in the test subtree of the code repository? If the component releases the test jar, then it should be possible. It seems that it's not released as a JAR

Re: [Math] How to use a class from the test source tree?

2012-06-13 Thread Benedikt Ritter
Hi again, 2012/6/13 Gilles Sadowski gil...@harfang.homelinux.org: On Wed, Jun 13, 2012 at 12:34:51PM +0200, Benedikt Ritter wrote: Hi, 2012/6/13 Gilles Sadowski gil...@harfang.homelinux.org: Hi. Is there a way for an application to depend on the classes defined in the test

[BeanUtils2] Thoughts about the API

2012-06-14 Thread Benedikt Ritter
Hi, while working on BU2, I was thinking about the API and what may be improved. Exceptions: Right now a lot of API methods just populate the checked reflection exceptions like InvocationTargetException from the native java reflection API. This dooms Java 6 users to write code like: try {

Re: [BeanUtils2] Thoughts about the API

2012-06-15 Thread Benedikt Ritter
Hi, I agree with what you said. - Annotation processing: let's keep that in mind, and come back to it later. Simo, can you create the wiki page for us? - Renaming methods: I hope that I get the time to create a patch this weekend - Wrapper Exceptions: I thing we should discuss, how a exception

Re: [BeanUtils2] Thoughts about the API

2012-06-15 Thread Benedikt Ritter
2012/6/15 James Carman ja...@carmanconsulting.com: On Fri, Jun 15, 2012 at 9:39 AM, Benedikt Ritter benerit...@googlemail.com wrote: - Wrapper Exceptions: I thing we should discuss, how a exception hierarchy could look like. I'll make a suggestion ASAP. I don't want to duplicate

[BeanUtils2] Some proposals for an exception name

2012-06-17 Thread Benedikt Ritter
Hi, following up on the thread where we discussed about the current state of the API [1], I want to discuss how to name the generic RuntimeException we talked about. Here are some proposals: 1. BeanUtilsException 2. BeanUtilsReflectionException 3. ReflectionException 4. ReflectiveAcessException

Re: [BeanUtils2] Thoughts about the API

2012-06-18 Thread Benedikt Ritter
BeanUtilsReflectionException, I don't think you'll run into problems. On Fri, Jun 15, 2012 at 10:26 AM, Benedikt Ritter benerit...@googlemail.com wrote: 2012/6/15 James Carman ja...@carmanconsulting.com: On Fri, Jun 15, 2012 at 9:39 AM, Benedikt Ritter benerit...@googlemail.com wrote: - Wrapper Exceptions

[BeanUtils2] Do we still need the internal and the transformers package?

2012-06-18 Thread Benedikt Ritter
Hi, I remember, that we added the internal package, because we had the need to split up the code base. Looking at the code base now, I don't see any reason for the internal package. Can we move Assertions back to the main package and remove the internal package? And what do we need the

Re: [BeanUtils2] Some proposals for an exception name

2012-06-18 Thread Benedikt Ritter
Hi, I've started to implement BeanReflectionException and I want to take the approach Simone suggested with the ErrorMessage from Digester. Now I have a problem: If I want to pass the throwable cause as well, that parameter has to be before the varargs argument. This would result in the following

Re: [BeanUtils2] Do we still need the internal and the transformers package?

2012-06-20 Thread Benedikt Ritter
2012/6/19 Simone Tripodi simonetrip...@apache.org: Hello, I remember, that we added the internal package, because we had the need to split up the code base. Looking at the code base now, I don't see any reason for the internal package. Can we move Assertions back to the main package and

Re: [BeanUtils2] Thoughts about the API

2012-06-20 Thread Benedikt Ritter
2012/6/18 Simone Tripodi simonetrip...@apache.org: +1 to 'of' short to type and intuitive! Thanks Matt for the valuable feedbacks! I'll implement that after I'm finished with replacing the exceptions. Benedikt best, -Simo http://people.apache.org/~simonetripodi/

Re: [BeanUtils2] Some proposals for an exception name

2012-06-20 Thread Benedikt Ritter
2012/6/19 Simone Tripodi simonetrip...@apache.org: The point is with Property %s not found in %s type you're embedding the relevant data in the message text and a client would have to parse the text if a special handling is required. I would never force poor users parsing the exception

[BeanUtils2] In what cases can we expect to see an IllegalAccessException?

2012-06-20 Thread Benedikt Ritter
Hi, I'm still working on https://issues.apache.org/jira/browse/SANDBOX-423 and I wanted to test if all the new exception get thrown correctly. For that reason I implemented a new class - ExceptionThrowingTestBean that properties and methods that throw exceptions when they get called. That way I

Re: [BeanUtils2] In what cases can we expect to see an IllegalAccessException?

2012-06-21 Thread Benedikt Ritter
, Benedikt Ritter benerit...@googlemail.com wrote: Hi, I'm still working on https://issues.apache.org/jira/browse/SANDBOX-423 and I wanted to test if all the new exception get thrown correctly. For that reason I implemented a new class - ExceptionThrowingTestBean that properties and methods

Re: [collections] Cleanup of trunk

2012-06-24 Thread Benedikt Ritter
Are we going through that Java 5 vs Java 6 discussion again? ;) Thomas: I always wanted to work on collections but there hasn't been much activity since I joined the ML. I'd be happy to contribute some patches. Benedikt Von meinem iPhone gesendet Am 24.06.2012 um 14:10 schrieb Gary Gregory

Re: [BeanUtils2] In what cases can we expect to see an IllegalAccessException?

2012-06-26 Thread Benedikt Ritter
Hey Simo, thanks for the feedback. I hope that you could make your deadline ;-) I'll implement that ASAP. Just one comment: 2012/6/25 Simone Tripodi simonetrip...@apache.org: Hi Bene, [SNIP] that is fine, but just throw the expected exception, no needs to throw an IllegalAccessException

Re: svn commit: r1356439 - /commons/proper/commons-site/trunk/src/site/xdoc/sandbox/index.xml

2012-07-03 Thread Benedikt Ritter
I'm happy to see this commit ;-) I hope this will get us some more contributers. 2012/7/2 simonetrip...@apache.org: Author: simonetripodi Date: Mon Jul 2 19:53:03 2012 New Revision: 1356439 URL: http://svn.apache.org/viewvc?rev=1356439view=rev Log: added beanutils2 in the sandbox list

Re: [all] Does this break binary compatibility?

2012-07-09 Thread Benedikt Ritter
Hi Sebastien, have a look at: http://wiki.eclipse.org/Evolving_Java-based_APIs http://wiki.eclipse.org/Evolving_Java-based_APIs_2 http://wiki.eclipse.org/Evolving_Java-based_APIs_3 In section Evolving API classes - API methods and constructors it says: Change result type (including void) -

Re: [VOTE] Release Apache Commons-DbUtils 1.5 based on RC1

2012-07-16 Thread Benedikt Ritter
Hi Simo, 2012/7/16 Simone Tripodi simonetrip...@apache.org: Impressive feedbacks Gary, thanks a lot! -1 with mvn clear site for https://repository.apache.org/content/repositories/orgapachecommons-054/commons-dbutils/commons-dbutils/1.5/commons-dbutils-1.5-src.zip : [ERROR] Failed to

Re: [VOTE] Release Apache Commons-DbUtils 1.5 based on RC1

2012-07-17 Thread Benedikt Ritter
Have a look at https://issues.apache.org/jira/browse/DBUTILS-94 ;) Bene 2012/7/17 Simone Tripodi simonetrip...@apache.org: If the patch doesn't make it into dbutil 1.5 we'll have the coverage for 1.6 ;-) release early and often is a mantra that we should apply more... often :) -Simo

[functor] Downloads page broken?

2012-07-20 Thread Benedikt Ritter
Hi, does anybody else experience problems with the download page of functor? http://commons.apache.org/functor/download_functor.cgi gives me 403 Forbidden. Regards, Benedikt - To unsubscribe, e-mail:

Re: [functor] Downloads page broken?

2012-07-20 Thread Benedikt Ritter
Skype: liviutudor I'm nobody, nobody's perfect -- therefore I'm perfect! On 20/07/2012 02:30, Benedikt Ritter benerit...@gmail.com wrote: Hi, does anybody else experience problems with the download page of functor? http://commons.apache.org/functor/download_functor.cgi gives me 403

Re: [chain2] serialVersionUID

2012-07-24 Thread Benedikt Ritter
Hi Elijah, if you need a introduction to serialization, I recommend to read the corresponding chapters in Effective Java by Josh Blooch [1]. Regards, Benedikt [1]

[dbcp] Encoding problems on dbcp site?

2012-07-25 Thread Benedikt Ritter
Hi, I'm having problems with the dbcp website. It displays diamonds with question marks inside for example between Commons and DBCP in the sidebar. Usually that is sign of an encoding problem. Can anyone verify that? thanks, Benedikt

Re: [dbcp] Encoding problems on dbcp site?

2012-07-25 Thread Benedikt Ritter
2012/7/25 Jörg Schaible joerg.schai...@scalaris.com: Benedikt Ritter wrote: Hi, I'm having problems with the dbcp website. It displays diamonds with question marks inside for example between Commons and DBCP in the sidebar. Usually that is sign of an encoding problem. Can anyone verify

Re: [chain2] serialVersionUID

2012-07-26 Thread Benedikt Ritter
2012/7/26 sebb seb...@gmail.com: On 26 July 2012 18:29, Brent Worden brent.wor...@gmail.com wrote: On Thu, Jul 26, 2012 at 3:48 AM, sebb seb...@gmail.com wrote: On 25 July 2012 07:54, Jörg Schaible joerg.schai...@scalaris.com wrote: sebb wrote: On 24 July 2012 09:11, Jörg Schaible

Re: svn commit: r1365262 - in /commons/proper/chain/trunk: apps/example2/src/main/java/org/apache/commons/chain2/apps/example/ core/src/main/java/org/apache/commons/chain2/ core/src/main/java/org/apac

2012-07-26 Thread Benedikt Ritter
2012/7/26 sebb seb...@gmail.com: On 24 July 2012 20:56, eli...@apache.org wrote: Author: elijah Date: Tue Jul 24 19:56:21 2012 New Revision: 1365262 URL: http://svn.apache.org/viewvc?rev=1365262view=rev Log: CHAIN-75 Updated serialVersionUID field in chain classes to a format based on

Re: [chain2] serialVersionUID

2012-07-26 Thread Benedikt Ritter
2012/7/26 Bruno P. Kinoshita brunodepau...@yahoo.com.br: From: Benedikt Ritter benerit...@gmail.com To: Commons Developers List dev@commons.apache.org Sent: Thursday, 26 July 2012 3:28 PM Subject: Re: [chain2] serialVersionUID 2012/7/26 sebb seb...@gmail.com

Re: Proposal Commons-JNDI

2012-08-08 Thread Benedikt Ritter
2012/8/8 Gary Gregory garydgreg...@gmail.com: On Wed, Aug 8, 2012 at 10:14 AM, Jochen Wiedmann jochen.wiedm...@gmail.comwrote: On Wed, Aug 8, 2012 at 10:29 AM, Jörg Schaible joerg.schai...@scalaris.com wrote: Jochen Wiedmann wrote: Hi, I'd like to propose a new component Commons

[BeanUtils2] WeakHashMap is not a cache (?)

2012-08-13 Thread Benedikt Ritter
Hi, I just came across this post: http://www.codeinstructions.com/2008/09/weakhashmap-is-not-cache-understanding.html Now i'm wondering what you think about it, since we are using the WeakHashMap for BU2. Maybe we should be looking for an alternative caching mechanism? Any suggestions? Best

[BeanUtils2] Working on mapped properties

2012-08-13 Thread Benedikt Ritter
Hi all, I've started work on mapped properties and just want to be sure, that I'm going in the right direction. I've had a look at BU1 and found the MappedPropertyDescirptor class. Now my plan is to adapt that class to BU2 and use it to build up the functionality needed to handle mapped

Re: [BeanUtils2] WeakHashMap is not a cache (?)

2012-08-13 Thread Benedikt Ritter
://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Mon, Aug 13, 2012 at 1:11 PM, Benedikt Ritter benerit...@gmail.com wrote: Hi, I just came across this post: http://www.codeinstructions.com/2008/09

Re: [site] yet another proposal on how to restyle the commons site

2012-08-30 Thread Benedikt Ritter
2012/8/30 Gary Gregory garydgreg...@gmail.com: On Thu, Aug 30, 2012 at 10:50 AM, Benedikt Ritter benerit...@gmail.comwrote: Hi Simo, great work, I really like the fluido skin and would like to see it go live for commons. One minor issue: does the releases section need to have a drop down

Re: [site] yet another proposal on how to restyle the commons site

2012-08-30 Thread Benedikt Ritter
2012/8/30 Simone Tripodi simonetrip...@apache.org: Hi all! - I find the slider gadget thingy disconcerting. I do not know that it will slide, I thought it was a bug and that the other components were missing (see above). Then, poof!, it does slide. I would not use it so prominently if at

Re: [site] yet another proposal on how to restyle the commons site

2012-08-31 Thread Benedikt Ritter
Hi again, on my mobile, the top navi does not fit into the horizontal space causing a line break. That will display Components and Sandbox above the header of the side bar. I'll upload a screenshot as soon as I'm at home. Great work, Simo! Benedikt PS: I liked the side scrolling widget from

Re: [all] FindBugs' Switch statement found in class.method where default case is missing

2012-09-04 Thread Benedikt Ritter
Hi Gary, IMHO FindBugs is supposed to point you at code fragments that potentially could cause subtle bugs. If say that the code in codec is carefully constructed and everything is backed up by junit tests, I'd say a default clause is nosy and doesn't add anything. OTOH if you can not see that no

Re: [configuration] Plan for 2.0

2012-09-09 Thread Benedikt Ritter
Hi Oliver, there are a lot of @author tags. As far as I know, the use of author tags is deprecated in commons, so the mentioned developers and contributors should be moved to pom.xml and changes.xml. Benedikt 2012/9/7 Oliver Heger oliver.he...@oliver-heger.de: Hi all, the pom was updated to

Re: [math] Is this good practice?

2012-09-10 Thread Benedikt Ritter
Hi, 2012/9/10 Luc Maisonobe luc.maison...@free.fr: Le 10/09/2012 21:08, Sébastien Brisard a écrit : Hi, Hi Sébastien, I thought it was not good practice to rely on exception in unexceptional circumstances. In ArrayFieldVector, there are numerous occurences of the following pattern

Re: svn commit: r1391258 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/Conversion.java

2012-09-28 Thread Benedikt Ritter
2012/9/28 Jörg Schaible joerg.schai...@scalaris.com: Hi Sebb, sebb wrote: On 27 September 2012 23:53, joe...@apache.org wrote: Author: joehni Date: Thu Sep 27 22:53:46 2012 New Revision: 1391258 URL: http://svn.apache.org/viewvc?rev=1391258view=rev Log: Use conversion tables for

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread Benedikt Ritter
Hi 2012/10/12 ggreg...@apache.org: Author: ggregory Date: Fri Oct 12 12:12:44 2012 New Revision: 1397534 URL: http://svn.apache.org/viewvc?rev=1397534view=rev Log: Refactor magic strings into constants. Modified:

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread Benedikt Ritter
...@gmail.com wrote: On Fri, Oct 12, 2012 at 8:22 AM, Benedikt Ritter benerit...@gmail.com wrote: Hi 2012/10/12 ggreg...@apache.org: Author: ggregory Date: Fri Oct 12 12:12:44 2012 New Revision: 1397534 URL: http://svn.apache.org/viewvc?rev=1397534view=rev

Re: [csv] CSVFormat API names

2012-10-16 Thread Benedikt Ritter
2012/10/16 Stephen Colebourne scolebou...@joda.org: On 16 October 2012 17:44, Matt Benson gudnabr...@gmail.com wrote: On Tue, Oct 16, 2012 at 11:42 AM, James Carman ja...@carmanconsulting.com wrote: On Tue, Oct 16, 2012 at 12:38 PM, Matt Benson gudnabr...@gmail.com wrote: Are these specific

Re: [csv] CSVFormat API names

2012-10-16 Thread Benedikt Ritter
2012/10/16 Gary Gregory garydgreg...@gmail.com: On Tue, Oct 16, 2012 at 1:00 PM, Stephen Colebourne scolebou...@joda.orgwrote: On 16 October 2012 17:44, Matt Benson gudnabr...@gmail.com wrote: On Tue, Oct 16, 2012 at 11:42 AM, James Carman ja...@carmanconsulting.com wrote: On Tue, Oct

Re: [csv] CSVFormat API names

2012-10-17 Thread Benedikt Ritter
2012/10/17 sebb seb...@gmail.com: On 16 October 2012 21:56, Benedikt Ritter benerit...@gmail.com wrote: 2012/10/16 Gary Gregory garydgreg...@gmail.com: On Tue, Oct 16, 2012 at 1:00 PM, Stephen Colebourne scolebou...@joda.orgwrote: On 16 October 2012 17:44, Matt Benson gudnabr...@gmail.com

[BeanUtils2] Caching in BU2

2012-10-26 Thread Benedikt Ritter
Hi, implementing benchmarks for BU2 has shown, that the WeakHashMap with WeakReferences to the values is not sufficient for caching [1]. The solution I suggested for that issue is not to use WeakReferences as values. This will prevent NPEs if the GC kicks in. But it only resolves part of the

Re: [OGNL] A new release

2012-10-28 Thread Benedikt Ritter
Use the mvn site goal. Benedikt Von meinem iPhone gesendet Am 28.10.2012 um 11:24 schrieb Lukasz Lenart lukaszlen...@apache.org: How to generate reports locally ? Thanks in advance -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/

Re: [v2] org.apache.logging.log4j.core.Logger.log(Marker, String, Level, Message, Throwable)

2012-11-04 Thread Benedikt Ritter
Hey Gary, wrong ML? ;-) Regards, Benedikt Von meinem iPhone gesendet Am 04.11.2012 um 15:06 schrieb Gary Gregory garydgreg...@gmail.com: I wonder if in: org.apache.logging.log4j.core.Logger.log(Marker, String, Level, Message, Throwable) @Override public void log(Marker marker,

Re: svn commit: r1405889 - in /commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration: Configuration.java ImmutableConfiguration.java

2012-11-05 Thread Benedikt Ritter
Hi Oliver, 2012/11/5 ohe...@apache.org Author: oheger Date: Mon Nov 5 17:29:01 2012 New Revision: 1405889 URL: http://svn.apache.org/viewvc?rev=1405889view=rev Log: Initial version of an immutable configuration interface. Added:

Re: svn commit: r1405889 - in /commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration: Configuration.java ImmutableConfiguration.java

2012-11-05 Thread Benedikt Ritter
2012/11/5 Benedikt Ritter benerit...@gmail.com Hi Oliver, 2012/11/5 ohe...@apache.org Author: oheger Date: Mon Nov 5 17:29:01 2012 New Revision: 1405889 URL: http://svn.apache.org/viewvc?rev=1405889view=rev Log: Initial version of an immutable configuration interface. Added

Re: svn commit: r1405889 - in /commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration: Configuration.java ImmutableConfiguration.java

2012-11-06 Thread Benedikt Ritter
...@gmx.de Benedikt Ritter wrote: 2012/11/5 Benedikt Ritter benerit...@gmail.com Hi Oliver, 2012/11/5 ohe...@apache.org Author: oheger Date: Mon Nov 5 17:29:01 2012 New Revision: 1405889 URL: http://svn.apache.org/viewvc?rev=1405889view=rev Log: Initial version

Re: svn commit: r1405889 - in /commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration: Configuration.java ImmutableConfiguration.java

2012-11-06 Thread Benedikt Ritter
Oliver Heger oliver.he...@oliver-heger.de Hi Benedikt, Am 05.11.2012 21:04, schrieb Benedikt Ritter: 2012/11/5 Benedikt Ritter benerit...@gmail.com Hi Oliver, 2012/11/5 ohe...@apache.org Author: oheger Date: Mon Nov 5 17:29:01 2012 New Revision: 1405889 URL: http

Re: svn commit: r1405889 - in /commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration: Configuration.java ImmutableConfiguration.java

2012-11-06 Thread Benedikt Ritter
2012/11/6 Oliver Heger oliver.he...@oliver-heger.de Am 06.11.2012 09:57, schrieb Benedikt Ritter: Hi Oliver, thanks for the clarification. I see where you are going with the design. What do you think of my proposal to implement the configuration interfaces like the java collections

Re: [LANG] FastDateParserTest is failing

2012-11-09 Thread Benedikt Ritter
Hi Lam, thanks for your info. Can you file an issue in jira [1] and attach a patch for that? Reagrds, Benedikt [1] https://issues.apache.org/jira/ 2012/11/9 Lam nguyen phuc ruado1...@gmail.com Hi, I cloned the commons-lang repository from github and encountered a failed test in

Re: svn commit: r1410759 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVFormat.java test/java/org/apache/commons/csv/CSVFormatBuilderTest.java test/java/org/apache/commons/csv

2012-11-19 Thread Benedikt Ritter
2012/11/17 ggreg...@apache.org Author: ggregory Date: Sat Nov 17 18:00:38 2012 New Revision: 1410759 URL: http://svn.apache.org/viewvc?rev=1410759view=rev Log: [CSV-68] Use the Builder pattern for CSVFormat. Modified:

[CSV] Discussion about the new CSVFormatBuilder

2012-11-20 Thread Benedikt Ritter
Hi, Gary and I did some work on CSV-68 Use the Builder Pattern to create CSVFormats [1]. We have implemented a builder for CSVFormats in trunk. It is capable of... ...creating a CSVFormat from scratch by only passing in a delimiter: CSVFormat format = CSVFormat.newBuilder(',').build();

Re: [CSV] Discussion about the new CSVFormatBuilder

2012-11-20 Thread Benedikt Ritter
Hey Ted, no I was referring to the comments of CSV-68, where it was stated that no other CSV library provides validation of the used CSV formats (and hence it can be removed from commons csv entirely). Benedikt 2012/11/20 Ted Dunning ted.dunn...@gmail.com Surely you meant to say no other

Re: svn commit: r1411919 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java

2012-11-20 Thread Benedikt Ritter
2012/11/21 Gary Gregory garydgreg...@gmail.com On Tue, Nov 20, 2012 at 6:22 PM, s...@apache.org wrote: Author: sebb Date: Tue Nov 20 23:22:21 2012 New Revision: 1411919 URL: http://svn.apache.org/viewvc?rev=1411919view=rev Log: Make some methods package-protected to avoid the need

Re: [CSV] Discussion about the new CSVFormatBuilder

2012-11-22 Thread Benedikt Ritter
some validation. Gary On Nov 20, 2012, at 16:59, Emmanuel Bourg ebo...@apache.org wrote: Le 20/11/2012 20:01, Benedikt Ritter a écrit : Please share your thoughts about the builder. Sorry Benedikt but I have to say I really don't like this design. I prefer a simpler API

Re: [beanutils] Property access on a fluent API

2012-12-05 Thread Benedikt Ritter
Hi Oliver, AFAIK beanutils is not restricted to pure JavaBeans. The project website just says that the component provides simple wrappers around the java refelct and introspect API. So I would say, that the functionality you propsed would fit nicely into BU (maybe the scope has changed and now

Re: [beanutils] Property access on a fluent API

2012-12-07 Thread Benedikt Ritter
2012/12/6 Oliver Heger oliver.he...@oliver-heger.de Am 05.12.2012 23:13, schrieb Benedikt Ritter: Hi Oliver, AFAIK beanutils is not restricted to pure JavaBeans. The project website just says that the component provides simple wrappers around the java refelct and introspect API. So I

Re: [Math] Request for future releases: kill Cobertura

2012-12-19 Thread Benedikt Ritter
What about a sonar instance for commons? Benedikt

Re: [Math] Request for future releases: kill Cobertura

2012-12-20 Thread Benedikt Ritter
2012/12/20 luc l...@spaceroots.org Le 2012-12-20 15:01, Phil Steitz a écrit : On 12/19/12 6:19 PM, Gilles Sadowski wrote: Hello. Hi all, The situation with Cobertura is fairly annoying, perhaps particularly so for Commons Math because of the size of the code base (and thus the

Re: autosuggest

2013-01-02 Thread Benedikt Ritter
Hi Karnakar, if you want to contribute to one of the commons sub projects, the best way is to create an issue in JIRA [1] and attach a SVN patch file to it. People will generally not download files send to the ML. thanks! Benedikt [1] https://issues.apache.org/jira 2013/1/1 karnakar

Re: [logging] Cleanup of trunk

2013-01-15 Thread Benedikt Ritter
2013/1/15 Thomas Neidhart thomas.neidh...@gmail.com On 01/15/2013 07:17 PM, Dennis Lundberg wrote: On 2013-01-12 15:03, Thomas Neidhart wrote: Hi, Hi Thomas A while back I made changes to the Maven build so that it produces the same output as the Ant build. The should mean that we

  1   2   3   4   5   6   7   8   9   10   >