Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/61#discussion_r130978503
--- Diff: pom.xml ---
@@ -171,6 +171,7 @@
src/site/resources/download_lang.cgi
src/test/resources
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-cli/pull/16
@PascalSchumacher , can you take a look at this ? seems only issue with
findbug on java6 build, rest seems Ok.
---
If your project is set up for it, you can reply to this email and have
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-cli/pull/16
@PascalSchumacher , can you take a look at this ? seems only issue with
findbug on java6 build, rest seems Ok.
---
If your project is set up for it, you can reply to this email and have
GitHub user ameyjadiye opened a pull request:
https://github.com/apache/commons-text/pull/61
Added flexible Travis-ci build script.
This enables ua to use any jdk against our code and not keeps us dependency
on Travis to provide jdk
You can merge this pull request into a Git
Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/61#discussion_r131239555
--- Diff: pom.xml ---
@@ -171,6 +171,7 @@
src/site/resources/download_lang.cgi
src/test/resources
Github user ameyjadiye closed the pull request at:
https://github.com/apache/commons-text/pull/61
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/61
Because of low interest of community adapting this change i'm closing this
pull request.
http://markmail.org/message/mn2or73hqsz6oxo2
---
If your project is set up for it, you can
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/49
@arunvinudss , can you please rename PR saying character processing
switched with codepoints and change commit comment as well, that you can do
with ```rebase``` or ```git commit --amend
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/49
probably just because utf-32 it could be confusing, @ecki can explain more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/49
For detailed explanation.
https://www.joelonsoftware.com/2003/10/08/the-absolute-minimum-every-software-developer-absolutely-positively-must-know-about-unicode-and-character-sets
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/49
@chtompki , this PR looks good, shall we merge it ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/48
```isDelimiter``` is simply the method to identify if codePoint or char is
present in given second parameter which is array. ofcource if array is empty it
means first param is not present
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/55
Yeah, will see if we can simplify API in 2.x .
I need opinion on the method I have given in this PR, According to me it's
good addition to existing API but go through JIRA discussion once
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/49
@arunvinudss , amend commit comment as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/49
@chtompki , @PascalSchumacher this seems good to me for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/56
@PascalSchumacher I just enabled in my local, seems very cumbersome task to
me at this point.
```
[INFO] There are 2551 checkstyle errors.
.
.
.
[INFO
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/57
@chtompki , I think whichever items are piled up for 2.x are not too
critical, we should wait for 2.x release.
If we are releasing some major improvement or fix we can release all queued
Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/57#discussion_r129102692
--- Diff: src/main/java/org/apache/commons/text/WordUtils.java ---
@@ -747,45 +750,29 @@ public static boolean containsAllWords(final
CharSequence
Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/57#discussion_r129102634
--- Diff: src/main/java/org/apache/commons/text/WordUtils.java ---
@@ -747,45 +750,29 @@ public static boolean containsAllWords(final
CharSequence
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/57
@arunvinudss , just addition to @PascalSchumacher comment , at this point
we don't know other than Commons text who else having dependancy on
`isDelimiter` so better we can make
GitHub user ameyjadiye opened a pull request:
https://github.com/apache/commons-text/pull/55
TEXT-97: RandomStringGenerator able to pass multiple ranges to
.withinRange()
*.withinRange()* now able to accept multiple ranges.
Ex.
```
final char [][] pairs = {{'a','z
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/48
I think we are good to merge this as per discussion here
[TEXT-88](https://issues.apache.org/jira/browse/TEXT-88)
---
If your project is set up for it, you can reply to this email and have
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/55
@chtompki , @PascalSchumacher , can you please express your opinion on this
, please check JIRA for detail discussion.
---
If your project is set up for it, you can reply to this email
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/59
@chtompki , I'm testing same on my Commons Text fork , that shell file need
a bit modification for Commons , will raise PR.
---
If your project is set up for it, you can reply
GitHub user ameyjadiye opened a pull request:
https://github.com/apache/commons-cli/pull/16
added findbug and checkstyle support while building
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ameyjadiye/commons-cli master
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/44
Hi @britter, there is no issue even in checkstyle with my changes, above
Travis build failed because there was some trailing space issue in master and
which you have already fixed. merging
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/45
Hi @garydgregory , I think removing ``` test ``` is not good idea, better
we can have ```verify``` along with ```test```
---
If your project is set up for it, you can reply to this email
Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/45#discussion_r121062216
--- Diff: .travis.yml ---
@@ -21,8 +21,15 @@ jdk:
- oraclejdk7
- oraclejdk8
+services:
+ - docker
GitHub user ameyjadiye opened a pull request:
https://github.com/apache/commons-text/pull/48
TEXT-88: Fixed issue with empty delimiters array with capitalizeFully
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ameyjadiye
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/52
Cool, seems clean now :+1: thanks Pascal. Trick will be certainly
beneficial in future to me ð
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/52
@PascalSchumacher This seems nice trick , but somehow didn't worked for me
and ended up just pushing latest commit, can you try this once ? I have given
you write access for exact
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/52
Fixed all the code as suggested, Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user ameyjadiye opened a pull request:
https://github.com/apache/commons-text/pull/54
TEXT-93: RandomStringGenerator accepts a list of valid characters
Added selectFrom feature :
```
selectFromList(char[] chars)
selectFromList(List charList)
```
You can
Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/54#discussion_r123877950
--- Diff: src/main/java/org/apache/commons/text/RandomStringGenerator.java
---
@@ -76,23 +78,29 @@
private final TextRandomProvider random
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/54
As per discussion
here[TEXT-93](https://issues.apache.org/jira/browse/TEXT-93) we are good to
merge this PR.
---
If your project is set up for it, you can reply to this email and have
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/44
@britter , please review and accept this PR. Travis build on this is
because previous commit in master , by merging this won't make any issue in
master. Tested on local before creating PR
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/44
Hi @garydgregory , Its already discussed here
[LANG-564](https://issues.apache.org/jira/browse/LANG-564) and
[TEXT-80](https://issues.apache.org/jira/browse/TEXT-80) and all seems agree
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/44
Hi @chtompki , since commons-text is relatively new there are very [low
usage](https://mvnrepository.com/artifact/org.apache.commons/commons-text),
```clirr:check``` is also passed whoever
GitHub user ameyjadiye opened a pull request:
https://github.com/apache/commons-text/pull/45
Added IBM Jdk8 build support to travis-ci configuration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ameyjadiye/commons-text travis
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/45
Hi @PascalSchumacher , where did you see build is failing ? I see all
builds passed given in your link
https://travis-ci.org/apache/commons-text/jobs/243003865,
Yes ibmjdk8
GitHub user ameyjadiye opened a pull request:
https://github.com/apache/commons-text/pull/52
Test: Improved testcase coverage for StrBuilder
added some missing flows to testcases plus some nice formatting for easy
understanding.
You can merge this pull request into a Git
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/45
@chtompki, I think we are good to merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/42
Hi @chtompki, do we expect anything more to be done here ? as per
@garydgregory it looks good to be merged.
---
If your project is set up for it, you can reply to this email and have your
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/44
Lets park this for 2.X release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/45#discussion_r121184938
--- Diff: .travis.yml ---
@@ -21,8 +21,15 @@ jdk:
- oraclejdk7
- oraclejdk8
+services:
+ - docker
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/45
Created one image containing maven with ibmjava8, same can be pushed to
apache dockerhub repo
https://hub.docker.com/r/ameyjadiye/ibmjava8/
---
If your project is set up
Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/45#discussion_r121188654
--- Diff: .travis.yml ---
@@ -21,8 +21,15 @@ jdk:
- oraclejdk7
- oraclejdk8
+services:
+ - docker
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/62
@chtompki , can you take a look if this looks good ?
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-cli/pull/16
@chtompki , is this not accepted ?
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-cli/pull/16
@chtompki , is this not accepted ?
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-cli/pull/16
Thanks @PascalSchumacher
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-cli/pull/16
Thanks @PascalSchumacher
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/55
@chtompki , If possible can you review and accept this ? I need this for
TEXT-101.
---
-
To unsubscribe, e-mail: dev
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/55
@chtompki , I'm sorry for such short note, 2.x was for making .builder()
static, PR seems ok for accepting in 1.2 release, you might want to go though
jira as well
GitHub user ameyjadiye opened a pull request:
https://github.com/apache/commons-text/pull/62
TEXT-101: Moved RandomStringUtils to Commons-text
Moved **RandomStringUtils** from lang to text along with changed core logic
which is using **RandomStringGenerator** internally, Test
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/62
@chtompki , can you please take look at this PR ?
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/62
Hi @chtompki , do you see more places to improvement or its good now ?
---
-
To unsubscribe, e-mail: dev-unsubscr
GitHub user ameyjadiye opened a pull request:
https://github.com/apache/commons-text/pull/66
Adding validation for pair
adding validation of pairs where each pair must contain only 2 char min and
max.
You can merge this pull request into a Git repository by running:
$ git
Github user ameyjadiye closed the pull request at:
https://github.com/apache/commons-text/pull/62
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/62
As per discussion on Dev ML we are undoing deprecation of RandomStringUtils
in Lang and discarding this solution
Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/62#discussion_r140843601
--- Diff: src/main/java/org/apache/commons/text/RandomStringGenerator.java
---
@@ -324,6 +324,40 @@ public Builder withinRange(final int
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/62
@chtompki , I think all were thinking to deprecate it from lang and so we
did. and due to more requests for ```RandomStringUtils``` we came up with the
plan to move it also I think since
62 matches
Mail list logo
