commons-text git commit: SANDBOX-483 Incorporate String algorithms from Commons Lang

2014-11-19 Thread kinow
Repository: commons-text Updated Branches: refs/heads/master 71b59af90 - c0e8c0210 SANDBOX-483 Incorporate String algorithms from Commons Lang Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/c0e8c021 Tree:

commons-text git commit: Fix parenthesis logic in math operation

2014-11-26 Thread kinow
Repository: commons-text Updated Branches: refs/heads/master c0e8c0210 - 7cbefa010 Fix parenthesis logic in math operation Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/7cbefa01 Tree:

[GitHub] commons-compress pull request #20: COMPRESS-382

2017-04-22 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-compress/pull/20#discussion_r112810239 --- Diff: src/test/java/org/apache/commons/compress/compressors/DetectCompressorTestCase.java --- @@ -167,6 +171,26 @@ private String detect(String

[GitHub] commons-fileupload issue #9: Msamery commons fileupload 1.3.2 patch 1

2017-08-10 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-fileupload/pull/9 Looks like your pull request was rebased, or something else happened. It is not possible to verify what were your changes, review, and merge. Could you review it? Ideally, we should have one

[GitHub] commons-compress pull request #20: COMPRESS-382

2017-04-25 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-compress/pull/20#discussion_r113141080 --- Diff: src/main/java/org/apache/commons/compress/compressors/lzma/LZMACompressorInputStream.java --- @@ -56,7 +56,7 @@ public

[GitHub] commons-compress pull request #20: COMPRESS-382

2017-04-25 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-compress/pull/20#discussion_r113178004 --- Diff: src/main/java/org/apache/commons/compress/compressors/lzma/LZMACompressorInputStream.java --- @@ -56,7 +56,7 @@ public

[GitHub] commons-fileupload pull request #:

2017-08-04 Thread kinow
Github user kinow commented on the pull request: https://github.com/apache/commons-fileupload/commit/86a79bceac4a267819de986ca814f11b48d81da3#commitcomment-23490295 In src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java: In src/test/java/org/apache/commons

[GitHub] commons-imaging pull request #30: add-tests

2017-08-06 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r131538871 --- Diff: src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpParserTest.java --- @@ -1,3 +1,19 @@ +/* --- End diff

[GitHub] commons-imaging pull request #30: add-tests

2017-08-06 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r131538915 --- Diff: src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoByteOrShortTest.java --- @@ -0,0 +1,55 @@ +/* + * Licensed

[GitHub] commons-imaging pull request #30: add-tests

2017-08-06 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r131538887 --- Diff: src/test/java/org/apache/commons/imaging/formats/pnm/PgmFileInfoTest.java --- @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache

[GitHub] commons-imaging pull request #30: add-tests

2017-08-06 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r131538792 --- Diff: pom.xml --- @@ -209,6 +209,12 @@ 2.5 test + --- End diff -- -0 Looks like it reduces

[GitHub] commons-imaging pull request #30: add-tests

2017-08-06 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r131538892 --- Diff: src/test/java/org/apache/commons/imaging/formats/pnm/PgmFileInfoTest.java --- @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache

[GitHub] commons-imaging pull request #18: IMAGING-168 installing package with Swedis...

2017-08-06 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/18#discussion_r131540224 --- Diff: src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcParser.java --- @@ -248,6 +258,35 @@ public PhotoshopApp13Data

[GitHub] commons-imaging pull request #18: IMAGING-168 installing package with Swedis...

2017-08-06 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/18#discussion_r131540245 --- Diff: src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcRecord.java --- @@ -50,6 +50,10 @@ public IptcRecord(final IptcType iptcType

[GitHub] commons-imaging pull request #30: add-tests

2017-08-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r132310660 --- Diff: pom.xml --- @@ -209,6 +209,12 @@ 2.5 test + --- End diff -- Indeed, and I may even use

[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

2017-06-21 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-text/pull/52 Looking good! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] commons-fileupload issue #8: FILEUPLOAD-283: add tests for the portlet packa...

2017-06-24 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-fileupload/pull/8 No objections so far, will merge it tomorrow after reviewing the code once more :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] commons-text pull request #54: TEXT-93: RandomStringGenerator accepts a list...

2017-06-24 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-text/pull/54#discussion_r123874569 --- Diff: src/main/java/org/apache/commons/text/RandomStringGenerator.java --- @@ -76,23 +78,29 @@ private final TextRandomProvider random

[GitHub] commons-text pull request #50: TEXT-90: Add CharacterPredicates for ASCII le...

2017-06-14 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-text/pull/50#discussion_r122105816 --- Diff: src/test/java/org/apache/commons/text/CharacterPredicatesTest.java --- @@ -44,4 +44,77 @@ public void testDigits() { assertFalse

[GitHub] commons-fileupload pull request #7: FILEUPLOAD-238: add tests for the portle...

2017-06-16 Thread kinow
Github user kinow closed the pull request at: https://github.com/apache/commons-fileupload/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] commons-fileupload pull request #8: FILEUPLOAD-283: add tests for the portle...

2017-06-16 Thread kinow
GitHub user kinow opened a pull request: https://github.com/apache/commons-fileupload/pull/8 FILEUPLOAD-283: add tests for the portlet package Initial tests for the portlet package. I believe there have been updates to the portlet specification(s) that have not been applied

[GitHub] commons-fileupload pull request #7: FILEUPLOAD-238: add tests for the portle...

2017-06-16 Thread kinow
GitHub user kinow opened a pull request: https://github.com/apache/commons-fileupload/pull/7 FILEUPLOAD-238: add tests for the portlet package Initial tests for the portlet package. I believe there have been updates to the portlet specification(s) that have not been applied

[GitHub] commons-fileupload issue #1: Commons fileupload headerfix

2017-06-10 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-fileupload/pull/1 Hmmm, this pull request seems to be a bit messed up due to either changes in the branch, or to the way the commit was created. There are also IDE files committed. @developerSid if you could

[GitHub] commons-fileupload pull request #:

2017-06-15 Thread kinow
Github user kinow commented on the pull request: https://github.com/apache/commons-fileupload/commit/94e5e1a77e4319c98dea22c051e19c1e57c58c00#commitcomment-22573680 :clap: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] commons-fileupload issue #7: FILEUPLOAD-238: add tests for the portlet packa...

2017-06-18 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-fileupload/pull/7 I use pull requests when I want someone else to review my code. In this case, I modified the tests design a wee bit too (not just added portlet tests), so would like that someone confirmed

[GitHub] commons-cli issue #13: CLI-277: Add generics to TypeHandler

2017-06-14 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-cli/pull/13 +1 code in pull request looks good, tests too. But when I checked out the code to read it on Eclipse, I thought the class Javadoc a bit confusing. ``` * This is a temporary

[GitHub] commons-cli issue #13: CLI-277: Add generics to TypeHandler

2017-06-14 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-cli/pull/13 +1 code in pull request looks good, tests too. But when I checked out the code to read it on Eclipse, I thought the class Javadoc a bit confusing. ``` * This is a temporary

[GitHub] commons-text pull request #63: small-code-quality-improvements

2017-09-21 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-text/pull/63#discussion_r140401739 --- Diff: src/main/java/org/apache/commons/text/WordUtils.java --- @@ -614,13 +615,11 @@ public static String swapCase(final String str

[GitHub] commons-text pull request #63: small-code-quality-improvements

2017-09-21 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-text/pull/63#discussion_r140401636 --- Diff: src/main/java/org/apache/commons/text/WordUtils.java --- @@ -614,13 +615,11 @@ public static String swapCase(final String str

[GitHub] commons-text pull request #63: small-code-quality-improvements

2017-09-21 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-text/pull/63#discussion_r140401548 --- Diff: src/main/java/org/apache/commons/text/FormattableUtils.java --- @@ -46,6 +46,7 @@ * This constructor is public to permit tools

[GitHub] commons-rng pull request #5: Feature rng 37

2017-10-10 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-rng/pull/5#discussion_r143859435 --- Diff: commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/ZigguratGaussianSampler.java --- @@ -0,0 +1,159

[GitHub] commons-rng pull request #5: Feature rng 37

2017-10-10 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-rng/pull/5#discussion_r143869091 --- Diff: commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/ZigguratGaussianSampler.java --- @@ -0,0 +1,161

[GitHub] commons-collections pull request #28: COLLECTIONS-661: fix for concurrency i...

2017-10-11 Thread kinow
GitHub user kinow opened a pull request: https://github.com/apache/commons-collections/pull/28 COLLECTIONS-661: fix for concurrency issue in HashSetValuedHashMapTest The `getMap()` method, when testing a `HashSetValuedHashMap`, would return an object of this type. Which

[GitHub] commons-collections issue #25: COLLECTIONS-575: Add synchronized queue wrapp...

2017-09-11 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-collections/pull/25 Hi @Xaerxess, had a few minutes to look at the pull request tonight. The code looks neat and simple to understand. Well indented, with tests, and comments. The Javadocs look well written

[GitHub] commons-collections pull request #26: COLLECTIONS-656 Update commons-parent ...

2017-09-12 Thread kinow
Github user kinow closed the pull request at: https://github.com/apache/commons-collections/pull/26 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h

[GitHub] commons-collections issue #26: COLLECTIONS-656 Update commons-parent version...

2017-09-12 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-collections/pull/26 Fixed in 1081b725bea339fcda33d70c71b9eb1859d60d8f and 6a10051a7b5b3c615180413fe116c61780754969. Thanks to @garydgregory

[GitHub] commons-collections pull request #26: COLLECTIONS-656 Update commons-parent ...

2017-09-12 Thread kinow
Github user kinow closed the pull request at: https://github.com/apache/commons-collections/pull/26 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h

[GitHub] commons-collections pull request #26: COLLECTIONS-656 Update commons-parent ...

2017-09-12 Thread kinow
GitHub user kinow opened a pull request: https://github.com/apache/commons-collections/pull/26 COLLECTIONS-656 Update commons-parent version, and use inherited FindBugs plugin version Copied settings from [text] component after Javadocs issues were fixed but then the `mvn site

[GitHub] commons-rng pull request #5: Feature rng 37

2017-10-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-rng/pull/5#discussion_r143630188 --- Diff: commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/ZigguratGaussianSampler.java --- @@ -0,0 +1,152

[GitHub] commons-rng pull request #5: Feature rng 37

2017-10-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-rng/pull/5#discussion_r143630285 --- Diff: commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/ZigguratGaussianSampler.java --- @@ -0,0 +1,152

[GitHub] commons-rng pull request #5: Feature rng 37

2017-10-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-rng/pull/5#discussion_r143630148 --- Diff: commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/ZigguratGaussianSampler.java --- @@ -0,0 +1,152

[GitHub] commons-rng pull request #5: Feature rng 37

2017-10-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-rng/pull/5#discussion_r143630250 --- Diff: commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/ZigguratGaussianSampler.java --- @@ -0,0 +1,152

[GitHub] commons-rng issue #5: Feature rng 37

2017-10-09 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-rng/pull/5 Builds successfully in Apache Maven 3.3.9 Maven home: /usr/share/maven Java version: 1.8.0_131, vendor: Oracle Corporation Java home: /opt/jdk1.8.0_131/jre Default locale

[GitHub] commons-rng issue #5: Feature rng 37

2017-10-09 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-rng/pull/5 Thank you @cur4so for the pull request. Travis CI failed to build this pull request, but I suspect it may be related to some thing else. ``` Results : Failed tests

[GitHub] commons-collections issue #28: COLLECTIONS-661: fix for concurrency issue in...

2017-10-12 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-collections/pull/28 Merged inhttps://github.com/apache/commons-collections/commit/eed8a7adb3de7441751e846f4a75d110dd205f23. Closing

[GitHub] commons-collections pull request #28: COLLECTIONS-661: fix for concurrency i...

2017-10-12 Thread kinow
Github user kinow closed the pull request at: https://github.com/apache/commons-collections/pull/28 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h

[GitHub] commons-collections pull request #28: COLLECTIONS-661: fix for concurrency i...

2017-10-12 Thread kinow
Github user kinow closed the pull request at: https://github.com/apache/commons-collections/pull/28 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h

[GitHub] commons-text issue #73: TEXT-106: Exception thrown in ExtendedMessageFormat ...

2017-11-04 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-text/pull/73 Already done @ben12! Hope first pull request of many :-) --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

[GitHub] commons-collections issue #33: [COLLECTIONS-664] Add a class that extend a l...

2017-11-06 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-collections/pull/33 Thanks for the clear response Minglei! And thanks for your contribution. Let's see what others think :+1

[GitHub] commons-collections issue #33: [COLLECTIONS-664] Add a class that extend a l...

2017-11-06 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-collections/pull/33 Hi @zhangminglei ! Sure. Few questions from reviewing the JIRA ticket and the pull request. * Why Commons Collections? The SortedProperties uses Java collection classes

[GitHub] commons-imaging issue #31: add-missing-license-headers

2017-12-07 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/31 Change looks good. Before merging, built the site and got the following in the RAT report: ``` * Summary

[GitHub] commons-imaging issue #31: add-missing-license-headers

2017-12-07 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/31 Thank you for your contribution @TheRealHaui ! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

[GitHub] commons-imaging issue #31: add-missing-license-headers

2017-12-07 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/31 FTR, done in b4374368a133614347ca4583cc3f34c84cf538aa --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

[GitHub] commons-pool pull request #3: Fix checkstyle errors

2017-10-29 Thread kinow
GitHub user kinow opened a pull request: https://github.com/apache/commons-pool/pull/3 Fix checkstyle errors The RAT report was enabled and configured for build, but not for reporting. The licence header was being verified by both, but inconsistently. Checkstyle complained about

[GitHub] commons-text issue #71: Apply (relaxed) checkstyle rules to test and fix exi...

2017-10-26 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-text/pull/71 But thanks for working on this :-) :clap: --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional

[GitHub] commons-text issue #70: partial automated migration to assertj

2017-10-20 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-text/pull/70 I thought we were using Java 8, but [text] is actually using Java 7. I thought there was some discussion around the minimum requirement for the latest version of assertj being Java 8? So I assume

[GitHub] commons-text issue #70: partial automated migration to assertj

2017-10-20 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-text/pull/70 Looks good to me. Given [text] is already on Java 8, I believe it's a good candidate to start using assertj. >The script use only the most basic assertj assertions, so the full po

[GitHub] commons-text issue #72: fix for TEXT-100

2017-10-20 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-text/pull/72 Merged, and ticket updated. Thanks for the pull request @drajakumar ! --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] commons-pool issue #3: Fix checkstyle errors

2017-10-31 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-pool/pull/3 Done! Thanks @garydgregory ! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail

[GitHub] commons-pool pull request #3: Fix checkstyle errors

2017-10-31 Thread kinow
Github user kinow closed the pull request at: https://github.com/apache/commons-pool/pull/3 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli issue #25: CLI-284: Fix inconsistent behaviour for short and lon...

2018-06-09 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-cli/pull/25 Hi @sfuhrm thanks for the pull request. I had a look at the CLI-284 issue in JIRA, and also checked out the pull request locally to take a look in Eclipse. I believe we have some tests

[GitHub] commons-cli issue #25: CLI-284: Fix inconsistent behaviour for short and lon...

2018-06-09 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-cli/pull/25 Hi @sfuhrm thanks for the pull request. I had a look at the CLI-284 issue in JIRA, and also checked out the pull request locally to take a look in Eclipse. I believe we have some tests

[GitHub] commons-text pull request #73: Exception thrown in ExtendedMessageFormat usi...

2017-10-28 Thread kinow
GitHub user kinow opened a pull request: https://github.com/apache/commons-text/pull/73 Exception thrown in ExtendedMessageFormat using quotes with custom registry Created this pull request from the patch provided by Benoît Moreau in [TEXT-106](https://issues.apache.org/jira

[GitHub] commons-imaging pull request #15: Imaging-136

2017-12-31 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/15#discussion_r159147410 --- Diff: src/test/data/specificTests/info.txt --- @@ -0,0 +1 @@ +Licensed to the Apache Software Foundation (ASF) under one or more contributor

[GitHub] commons-imaging pull request #15: Imaging-136

2017-12-31 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/15#discussion_r159147413 --- Diff: src/test/java/org/apache/commons/imaging/formats/jpeg/specific/JpegImageParserTest.java --- @@ -0,0 +1,48 @@ +/* + * Copyright 2015

[GitHub] commons-imaging pull request #15: Imaging-136

2017-12-31 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/15#discussion_r159147395 --- Diff: src/main/java/org/apache/commons/imaging/formats/jpeg/JpegConstants.java --- @@ -125,7 +136,9 @@ SOF5_MARKER

[GitHub] commons-imaging pull request #15: Imaging-136

2017-12-31 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/15#discussion_r159147397 --- Diff: src/main/java/org/apache/commons/imaging/formats/jpeg/decoder/JpegDecoder.java --- @@ -38,7 +41,7 @@ import static

[GitHub] commons-imaging pull request #15: Imaging-136

2017-12-31 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/15#discussion_r159147391 --- Diff: src/main/java/org/apache/commons/imaging/common/BinaryFunctions.java --- @@ -317,4 +317,23 @@ public static void copyStreamToStream(final

[GitHub] commons-imaging issue #33: Imaging-209 PnmImageParser throws ImageWriteExcep...

2017-12-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/33 Thank you **a lot** for including tests, and making the change so simple to be reviewed. No extra formatting, or any other change :-) Had a look at the code in Eclipse and also

[GitHub] commons-imaging issue #32: add test for DataReaderStripsTest::applyPredictor

2017-12-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/32 Added an extra commit to include the license header. Thanks for your contribution @testingsavvy . Pull request merged

[GitHub] commons-imaging issue #5: Proposal for a patch for Imaging-159 using a POJO

2017-12-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/5 Looks like the code from the pull request and the code in the master branch have moved into too different directions, and it can't be updated any longer. @mgmechanics let me know if you

[GitHub] commons-imaging issue #30: add-tests

2017-12-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/30 Looking good. I'm still just reluctant to add the new test dependency. So leaving it here for now until others have time to chime in. I'm updating merge requests now, merging what can

[GitHub] commons-imaging issue #4: IPTCParser now takes the raw bytes of an IPTCRecor...

2017-12-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/4 I think from your description you have a valid use case for handling the encoding yourself, instead of letting the library use ISO-8859-1 only. I started to rebase the branch locally

[GitHub] commons-imaging issue #6: Imaging-167

2017-12-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/6 Code looking good. Wonder if it would be feasible to add a test? What do you think @mgmechanics ? Not sure if worth/useful/possible to test that `Integer.MAX_VALUE`... Thanks

[GitHub] commons-imaging issue #35: IMAGING-154 Removed Debug class

2018-02-05 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/35 `changes.xml` updated. Last commit contains the word-trick to close the pull request. Once merged, everything should be correct, just need to update JIRA

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

2018-02-05 Thread kinow
GitHub user kinow opened a pull request: https://github.com/apache/commons-imaging/pull/35 IMAGING-154 Removed Debug class Removed the `Debug` and `ImageDump` classes. Also removed methods with the `verbose` parameter, as well as any `System.out.println`'s. Tried to keep

[GitHub] commons-collections issue #45: [COLLECTIONS-691] Use boolean operator for bo...

2018-07-25 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-collections/pull/45 Merged. Thanks again @grimreaper ! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

2018-08-16 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210524716 --- Diff: src/main/java/org/apache/commons/imaging/icc/IccTag.java --- @@ -73,11 +76,12 @@ private IccTagDataType getIccTagDataType(final int quad

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

2018-08-16 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210523866 --- Diff: src/main/java/org/apache/commons/imaging/formats/psd/PsdHeaderInfo.java --- @@ -45,9 +50,14 @@ public PsdHeaderInfo(final int version, final

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

2018-08-16 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210519489 --- Diff: src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkText.java --- @@ -42,9 +47,9 @@ public PngChunkText(final int length

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

2018-08-16 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210521304 --- Diff: src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java --- @@ -327,7 +331,7 @@ private BmpImageContents readImageContents

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

2018-08-16 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210546814 --- Diff: src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java --- @@ -327,7 +331,7 @@ private BmpImageContents readImageContents

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

2018-08-16 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210549560 --- Diff: src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java --- @@ -327,7 +331,7 @@ private BmpImageContents readImageContents

[GitHub] commons-imaging issue #35: IMAGING-154 Removed Debug class

2018-08-17 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/35 Agreed on not using INFO level @sebbASF & @garydgregory . Moved what was in FINE to FINEST level. And moved what was in INFO to FINE. My plan for the web site informa

[GitHub] commons-imaging issue #35: IMAGING-154 Removed Debug class

2018-08-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/35 Thanks @garydgregory ! No objection for a 1.0-alpha1, then wait a couple of months or a bit more perhaps for user feedback. I assume this 1.0-alpha1 would make all the way to maven central

[GitHub] commons-imaging issue #35: IMAGING-154 Removed Debug class

2018-08-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/35 Thanks @andreasrosdal ! I still have some more development bandwidth this month, so hopefully it will be merged this weekend, and I will find a way to squeeze in a few more hours to finish

[GitHub] commons-pool issue #8: Format DefaultPooledObject getIdleTimeMillis method w...

2018-07-21 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-pool/pull/8 Merged. Thanks!!! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h

[GitHub] commons-collections issue #42: Fix for 5 CheckStyle 3.0.0 plugin warnings.

2018-07-21 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-collections/pull/42 Hi @sfuhrm , thanks for your contribution. I had a look running `mvn clean site` against master, and checkstyle report is empty. How did you get the warnings? Note

[GitHub] commons-text pull request #85: Add optimization to limited levenshtein dista...

2018-07-21 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-text/pull/85#discussion_r204208775 --- Diff: src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java --- @@ -270,12 +270,6 @@ private static int limitedCompare

[GitHub] commons-collections issue #42: Fix for 5 CheckStyle 3.0.0 plugin warnings.

2018-07-21 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-collections/pull/42 I was confused too. Maybe it was fixed recently, or it was run with the IDE or with some other setting. Thanks for updating the issue so quickly. And feel free to submit other

[GitHub] commons-collections issue #35: COLLECTION-599: Fix for out-of-memory errors ...

2018-07-21 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-collections/pull/35 @saleem-akbar, thanks for taking your time to prepare a pull request. Looks like, actually, there are two pull requests from you, for the same issue. #34 and #35. This one has

[GitHub] commons-imaging pull request #36: Avoid jpeg parse fail due to jfxx and exif

2018-07-21 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/36#discussion_r204226858 --- Diff: src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java --- @@ -312,7 +312,12 @@ private void dumpSegments(final List v

[GitHub] commons-imaging pull request #34: IMAGING-188

2018-07-21 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/34#discussion_r204226800 --- Diff: pom.xml --- @@ -209,6 +209,12 @@ 2.6 test + + + com.github.jai-imageio

[GitHub] commons-imaging issue #37: ICNS: missing element types; some safety checks

2018-07-21 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/37 >As much as I love tests I'm not sure how to proceed. So what do you think? Maybe it we could get at least one or two tests, maybe using that `groovy-1.7.5/bin/groovy.icns` f

[GitHub] commons-collections issue #45: [COLLECTIONS-691] Use boolean operator for bo...

2018-07-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-collections/pull/45 After seeing the patch and pull request, I had to check the project to see and try to understand why we had it that way in the first place. I couldn't find an explanation. All tests pass

[GitHub] commons-collections issue #47: IdentityMap: correct JavaDoc

2018-07-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-collections/pull/47 Merged. Thanks a lot for your contribution! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

2018-04-08 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-text/pull/79 Tested the master branch first, and everything obviously worked. Then switched to this branch, and got an error message, then Eclipse opened the run configuration. Followed

[GitHub] commons-text issue #79: Upgrade to JUnit 5.1

2018-04-08 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-text/pull/79 ![screenshot_2018-04-08_22-34-52](https://user-images.githubusercontent.com/304786/38466438-1d71ec6e-3b7d-11e8-82e2-d21cfa9e79bd.png) Screenshot with Eclipse version, and sample output