[GitHub] commons-compress issue #17: CPIO crc overflow resolved for large files

2017-03-29 Thread bodewig
Github user bodewig commented on the issue:

https://github.com/apache/commons-compress/pull/17
  
Great, many thanks,

I've just found 
https://people.freebsd.org/~kientzle/libarchive/man/cpio.5.txt states

> The CRC format is identical to the new ASCII format described in the 
previous section except that the magic field is set to ``070702'' and the check 
field is set to the sum of all bytes in the file data.  This sum is computed 
treating all bytes as unsigned values and using unsigned arithmetic.  Only the 
least-significant 32 bits of the sum are stored.

so your patch is certainly correct.

I'm afraid we've got the same bug when writing CPIO archives. I'll take 
care of it.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-compress issue #17: CPIO crc overflow resolved for large files

2017-03-29 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/17
  

[![Coverage 
Status](https://coveralls.io/builds/10826707/badge)](https://coveralls.io/builds/10826707)

Coverage increased (+0.001%) to 84.176% when pulling 
**dd1ec97f687c462f4225b5efb5f9a363d7281918 on dcollin:crc_fix** into 
**785233a6fe47009e8b92db72e778f7932db978cd on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org