Re: (commons-parent) branch master updated: Facilitate JMH benchmarking from the Maven CLI
I don't what would go in this new component though. The tests in the
components I looked at don't have anything to share AFAICT.
Gary
On Sat, Apr 20, 2024, 12:13 PM Gilles Sadowski wrote:
> Hi.
>
> Le sam. 20 avr. 2024 à 17:50, Gary Gregory a
> écrit :
> >
> > Hello,
> >
> > I looked at Commons Lang, Commons IO, Commons CSV, Commons BCEL, Commons
> > Crypto, and Commons Text. All of the above do the same duplicate work.
>
> For sure, it's an improvement to make duplicate configurations obsolete.
> However, shouldn't we go a step further in harmonizing the repositories'
> structure in terms of functionality?
> For example, we could have a component ("internal" to Commons" dedicated
> to benchmarking boiler-plate code (similar to, or within, the "Testing"
> project
> which you had proposed some time ago).
> As noted, IMHO a Maven module dedicated to benchmarking is preferable to
> "mixing" with unit tests (e.g. only that module would then depend on the
> benchmarking utilities).
>
> Regards,
> Gilles
>
> >
> > Gary
> >
> > On Sat, Apr 20, 2024, 11:01 AM Gilles Sadowski
> wrote:
> >
> > > Hi.
> > >
> > > This commit caught my attention but I've not looked in detail (sorry!).
> > > I'm wondering whether this addition deserves a discussion here on "dev"
> > > to reach consensus on how to handle benchmarking code in a uniform
> > > way across all components.
> > > For a long time, some components (namely and mainly "Commons
> > > RNG") have been providing[1] extensive JMH codes (in dedicated
> > > maven modules) in order to generate benchmark reports.
> > > This addition seems (?) to duplicate the functionality, under different
> > > assumptions on how to trigger it.
> > > Did you look at how the benchmarking functionality is laid out in
> [RNG]?
> > > Can't it be generalized to other components, with or without formal
> > > support in the "main" POM file? [At first sight, it would seem tidier,
> > > more
> > > flexible and more maintainable, to *not* bundle benchmark codes within
> > > "src/test" (where true unit tests reside)...]
> > >
> > > Gilles
> > >
> > > [1] Thanks to Alex.
> > >
> > > Le sam. 20 avr. 2024 à 16:30, a écrit :
> > > >
> > > > [...]
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>
Re: (commons-parent) branch master updated: Facilitate JMH benchmarking from the Maven CLI
Hi.
Le sam. 20 avr. 2024 à 17:50, Gary Gregory a écrit :
>
> Hello,
>
> I looked at Commons Lang, Commons IO, Commons CSV, Commons BCEL, Commons
> Crypto, and Commons Text. All of the above do the same duplicate work.
For sure, it's an improvement to make duplicate configurations obsolete.
However, shouldn't we go a step further in harmonizing the repositories'
structure in terms of functionality?
For example, we could have a component ("internal" to Commons" dedicated
to benchmarking boiler-plate code (similar to, or within, the "Testing" project
which you had proposed some time ago).
As noted, IMHO a Maven module dedicated to benchmarking is preferable to
"mixing" with unit tests (e.g. only that module would then depend on the
benchmarking utilities).
Regards,
Gilles
>
> Gary
>
> On Sat, Apr 20, 2024, 11:01 AM Gilles Sadowski wrote:
>
> > Hi.
> >
> > This commit caught my attention but I've not looked in detail (sorry!).
> > I'm wondering whether this addition deserves a discussion here on "dev"
> > to reach consensus on how to handle benchmarking code in a uniform
> > way across all components.
> > For a long time, some components (namely and mainly "Commons
> > RNG") have been providing[1] extensive JMH codes (in dedicated
> > maven modules) in order to generate benchmark reports.
> > This addition seems (?) to duplicate the functionality, under different
> > assumptions on how to trigger it.
> > Did you look at how the benchmarking functionality is laid out in [RNG]?
> > Can't it be generalized to other components, with or without formal
> > support in the "main" POM file? [At first sight, it would seem tidier,
> > more
> > flexible and more maintainable, to *not* bundle benchmark codes within
> > "src/test" (where true unit tests reside)...]
> >
> > Gilles
> >
> > [1] Thanks to Alex.
> >
> > Le sam. 20 avr. 2024 à 16:30, a écrit :
> > >
> > > [...]
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Re: (commons-parent) branch master updated: Facilitate JMH benchmarking from the Maven CLI
Hello,
I looked at Commons Lang, Commons IO, Commons CSV, Commons BCEL, Commons
Crypto, and Commons Text. All of the above do the same duplicate work.
Gary
On Sat, Apr 20, 2024, 11:01 AM Gilles Sadowski wrote:
> Hi.
>
> This commit caught my attention but I've not looked in detail (sorry!).
> I'm wondering whether this addition deserves a discussion here on "dev"
> to reach consensus on how to handle benchmarking code in a uniform
> way across all components.
> For a long time, some components (namely and mainly "Commons
> RNG") have been providing[1] extensive JMH codes (in dedicated
> maven modules) in order to generate benchmark reports.
> This addition seems (?) to duplicate the functionality, under different
> assumptions on how to trigger it.
> Did you look at how the benchmarking functionality is laid out in [RNG]?
> Can't it be generalized to other components, with or without formal
> support in the "main" POM file? [At first sight, it would seem tidier,
> more
> flexible and more maintainable, to *not* bundle benchmark codes within
> "src/test" (where true unit tests reside)...]
>
> Gilles
>
> [1] Thanks to Alex.
>
> Le sam. 20 avr. 2024 à 16:30, a écrit :
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > ggregory pushed a commit to branch master
> > in repository https://gitbox.apache.org/repos/asf/commons-parent.git
> >
> >
> > The following commit(s) were added to refs/heads/master by this push:
> > new 9637b97 Facilitate JMH benchmarking from the Maven CLI
> > 9637b97 is described below
> >
> > commit 9637b97c371906c90d958b2b7869a47818ad2e0b
> > Author: Gary Gregory
> > AuthorDate: Sat Apr 20 10:28:56 2024 -0400
> >
> > Facilitate JMH benchmarking from the Maven CLI
> >
> > - Add profile benchmark for JMH benchmarks
> > - Add JMH to dependency management section
> > ---
> > pom.xml | 46
> +-
> > src/changes/changes.xml | 3 +++
> > 2 files changed, 44 insertions(+), 5 deletions(-)
> >
> > diff --git a/pom.xml b/pom.xml
> > index abfe20e..dbb3698 100644
> > --- a/pom.xml
> > +++ b/pom.xml
> > @@ -167,7 +167,7 @@
> >
> > 6.4.1 .aQute.bndlib.version>
> > 5.10.2
> > -
> > +1.37
> >
> >java-11-up
> > @@ -1856,7 +1855,6 @@
> > 10.15.0
> >
> >
> > -
> >
> >
> >java-17-up
> > @@ -1870,7 +1868,45 @@
> > -->
> >
> >
> > -
> > +
> > +
> > + benchmark
> > +
> > +true
> > +org.apache
> > +
> > +
> > +
> > +
> > +org.codehaus.mojo
> > +exec-maven-plugin
> > +3.2.0
> > +
> > +
> > +benchmark
> > +test
> > +
> > + exec
> > +
> > +
> > + test
> > + java
> > +
> > +-classpath
> > +
> > +org.openjdk.jmh.Main
> > +-rf
> > +json
> > +-rff
> > +
> target/jmh-result.${benchmark}.json
> > +${benchmark}
> > +
> > +
> > +
> > +
> > +
> > +
> > +
> > +
> >
> > -
> >
> > diff --git a/src/changes/changes.xml b/src/changes/changes.xml
> > index a62cb49..0937e3b 100644
> > --- a/src/changes/changes.xml
> > +++ b/src/changes/changes.xml
> > @@ -58,6 +58,9 @@ The type attribute can be
> add,update,fix,remove.
> > -->
> >
> >
> > +
> > + Add
> profile benchmark for JMH benchmarks.
> > + Add
> JMH to dependency management section.
> >
> > Set
> Javadoc link to latest Java API LTS version.
> >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>
Re: (commons-parent) branch master updated: Facilitate JMH benchmarking from the Maven CLI
Hi.
This commit caught my attention but I've not looked in detail (sorry!).
I'm wondering whether this addition deserves a discussion here on "dev"
to reach consensus on how to handle benchmarking code in a uniform
way across all components.
For a long time, some components (namely and mainly "Commons
RNG") have been providing[1] extensive JMH codes (in dedicated
maven modules) in order to generate benchmark reports.
This addition seems (?) to duplicate the functionality, under different
assumptions on how to trigger it.
Did you look at how the benchmarking functionality is laid out in [RNG]?
Can't it be generalized to other components, with or without formal
support in the "main" POM file? [At first sight, it would seem tidier, more
flexible and more maintainable, to *not* bundle benchmark codes within
"src/test" (where true unit tests reside)...]
Gilles
[1] Thanks to Alex.
Le sam. 20 avr. 2024 à 16:30, a écrit :
>
> This is an automated email from the ASF dual-hosted git repository.
>
> ggregory pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/commons-parent.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new 9637b97 Facilitate JMH benchmarking from the Maven CLI
> 9637b97 is described below
>
> commit 9637b97c371906c90d958b2b7869a47818ad2e0b
> Author: Gary Gregory
> AuthorDate: Sat Apr 20 10:28:56 2024 -0400
>
> Facilitate JMH benchmarking from the Maven CLI
>
> - Add profile benchmark for JMH benchmarks
> - Add JMH to dependency management section
> ---
> pom.xml | 46 +-
> src/changes/changes.xml | 3 +++
> 2 files changed, 44 insertions(+), 5 deletions(-)
>
> diff --git a/pom.xml b/pom.xml
> index abfe20e..dbb3698 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -167,7 +167,7 @@
>
>
> 6.4.1
> 5.10.2
> -
> +1.37
>
>java-11-up
> @@ -1856,7 +1855,6 @@
> 10.15.0
>
>
> -
>
>
>java-17-up
> @@ -1870,7 +1868,45 @@
> -->
>
>
> -
> +
> +
> + benchmark
> +
> +true
> +org.apache
> +
> +
> +
> +
> +org.codehaus.mojo
> +exec-maven-plugin
> +3.2.0
> +
> +
> +benchmark
> +test
> +
> + exec
> +
> +
> + test
> + java
> +
> +-classpath
> +
> +org.openjdk.jmh.Main
> +-rf
> +json
> +-rff
> +target/jmh-result.${benchmark}.json
> +${benchmark}
> +
> +
> +
> +
> +
> +
> +
> +
>
> -
>
> diff --git a/src/changes/changes.xml b/src/changes/changes.xml
> index a62cb49..0937e3b 100644
> --- a/src/changes/changes.xml
> +++ b/src/changes/changes.xml
> @@ -58,6 +58,9 @@ The type attribute can be add,update,fix,remove.
> -->
>
>
> +
> + Add
> profile benchmark for JMH benchmarks.
> + Add JMH
> to dependency management section.
>
> Set
> Javadoc link to latest Java API LTS version.
>
>
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
