Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

> Implementation thoughts: > (1) Switch implementation “isNumber” -> “isParsable” > (2) Deprecate “isNumber” and have it call “isParsable" > (3) Rename “createNumber” to “parseNumber” (with Deprecation) > (4) Fix subtle differences between “parseNumber” and newly implemented > “isParsable" > (5)

Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

I spent considerable time over the weekend here playing around with different ideas on how to accomplish the reconciliation of the methods at hand here in NumberUtils. The more I fiddle around with the issue, the more I really want to rename “isNumber,” “isParsable” and take “isNumber” (what

Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

> On Aug 18, 2016, at 3:10 AM, Jochen Wiedmann > wrote: > > On Tue, Aug 16, 2016 at 9:10 PM, Benedikt Ritter wrote: > On Jul 31, 2016, at 3:03 PM, Rob Tompkins wrote: >

Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

On Tue, Aug 16, 2016 at 9:10 PM, Benedikt Ritter wrote: >> > On Jul 31, 2016, at 3:03 PM, Rob Tompkins wrote: >> > System.out.println(NumberUtils.isParsable("+2")); > false >> > System.out.println(NumberUtils.createNumber("+2")); ---> 2 >> If I had

Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

Hello Rob, I'm back from vacation and I will have a look at this issue again later this week. Benedikt Rob Tompkins schrieb am Do., 11. Aug. 2016 um 16:48 Uhr: > > > On Jul 31, 2016, at 3:03 PM, Rob Tompkins wrote: > > > > I figured that I would run an

Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

> On Jul 31, 2016, at 3:03 PM, Rob Tompkins wrote: > > I figured that I would run an analogous test to the original with isParsable > and createNumber, and I ran into the following: > > System.out.println(NumberUtils.isParsable("+2")); > false >

Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

I figured that I would run an analogous test to the original with isParsable and createNumber, and I ran into the following: System.out.println(NumberUtils.isParsable("+2")); > false System.out.println(NumberUtils.createNumber("+2")); ---> 2 I’m not sure if we should tackle that in this Jira

Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

> On Jul 31, 2016, at 6:23 AM, Benedikt Ritter wrote: > > How about deprecating and renaming? > > isNumber -> isJavaNumberLiteral > createNumber -> parseNumber > > this way there would be a clearer connection between isParsebale and the > method that parses the number.

Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

How about deprecating and renaming? isNumber -> isJavaNumberLiteral createNumber -> parseNumber this way there would be a clearer connection between isParsebale and the method that parses the number. Furthermore it is clearer what isNumber really does. Benedikt Rob Tompkins

Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

> On Jul 30, 2016, at 12:41 PM, Gary Gregory wrote: > > Can this all be solved with better Javadocs? > I don’t think so. So, I would think that we would do one of two things: (1) Clarify Javadocs, and set up unit tests to reflect the intent (that being that

Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

Can this all be solved with better Javadocs? Gary On Jul 29, 2016 7:59 AM, "Rob Tompkins" wrote: > Hi Benedikt, > > Thanks for the insights here. > > > On Jul 29, 2016, at 3:53 AM, Benedikt Ritter wrote: > > > > Hello Rob, > > > > Rob Tompkins

Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

Hi Benedikt, Thanks for the insights here. > On Jul 29, 2016, at 3:53 AM, Benedikt Ritter wrote: > > Hello Rob, > > Rob Tompkins > schrieb am Do., > 28. Juli 2016 um > 14:23 Uhr: > >> In short, I’m trying to generalize

Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

Hello Rob, Rob Tompkins schrieb am Do., 28. Juli 2016 um 14:23 Uhr: > In short, I’m trying to generalize LANG-1060, LANG-1040, LANG-1038, and > LANG-992 with a single issue that actually hits all the bases here with > NumberUtils.isNumber. > > Bug (1): > >