GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/141
SUREFIRE-1331: Bump version number for 3.0.0 release line
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/britter/maven-surefire
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/142
SUREFIRE-1330: Import provider code donated by JUnit team
This PR adds the code donated in
[SUREFIRE-1330](https://issues.apache.org/jira/browse/SUREFIRE-1330) by
@marcphilipp. Here
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/142
Thank you! I will continue then with the detection code in
ABstractSurefireMojo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/142
Resolved comments by @marcphilipp
WDYT @Tibor17? Looks good for merge? behavior of surefire is currently not
changed since we don't have automatic look up code. Would like
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/142
awesome!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/142
@Tibor17 this PR is for 3.0-rc1 branch not for master. Can't we integrate
it into 3.0-rc1 branch right away?
---
If your project is set up for it, you can reply to this email and have your
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/118
Add basic integration test for JUnit 5
This is WIP. My take on adding a first basic integration test for JUnit 5.
If this is going in the right direction we can add more tests.
You can
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@tibor this PR is only about introducing ITs. The M2 release of the
provider is pulled in via maven as dependency, see the test pom.xml. I agree
that surefire should not ship with a have
Github user britter commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/118#discussion_r77860110
--- Diff:
surefire-integration-tests/src/test/resources/junit5/src/test/java/junit5/JUnit4Test.java
---
@@ -0,0 +1,67 @@
+package junit5
Github user britter commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/118#discussion_r77858530
--- Diff:
surefire-integration-tests/src/test/resources/junit5/src/test/java/junit5/JUnit4Test.java
---
@@ -0,0 +1,67 @@
+package junit5
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@Tibor17 yes I need #120 to finish this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user britter commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/120#discussion_r78336717
--- Diff:
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/HelperAssertions.java
---
@@ -159,4 +164,10 @@ public
Github user britter commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/120#discussion_r78354537
--- Diff:
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/HelperAssertions.java
---
@@ -159,4 +164,10 @@ public
Github user britter commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/120#discussion_r78776416
--- Diff:
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/HelperAssertions.java
---
@@ -159,4 +164,10 @@ public
Github user britter commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/120#discussion_r78775898
--- Diff:
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/HelperAssertions.java
---
@@ -159,4 +164,10 @@ public
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/119
@Tibor17 can we merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/120
Add convinient method to check for the currently used Java Version
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/britter/maven
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/119
Make JUnit4VersionsIT acutally use the versions set by the test code
As discussed on the ML.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user britter closed the pull request at:
https://github.com/apache/maven-surefire/pull/118
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@Tibor17 Thank you! I'll continue with the next more complex examples.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user britter commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/125#discussion_r81810117
--- Diff:
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/JUnit47ConcurrencyIT.java
---
@@ -32,14 +32,14
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/124
@Tibor17 easy fix, how about merging it? ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user britter commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/125#discussion_r82520806
--- Diff:
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/JUnit47ConcurrencyIT.java
---
@@ -32,14 +32,14
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/126
Make Junit4VersionsIT parameterized
In preparation for introducing more JUnit 5 ITs, make the Junit4VersionsIT
parameterized.
You can merge this pull request into a Git repository
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/119
@Tibor17 I don't have commit access to the maven repositories. You will
have to merge it for me :-)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/120
@Tibor17 you have to follow the workflow described
[here](http://wiki.apache.org/commons/UsingGIT#Applying_Pull_Requests_.28for_git_based_components.29).
It's not possible to merge using
Github user britter closed the pull request at:
https://github.com/apache/maven-surefire/pull/120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/120
@Tibor17 thank you for integrating this. Did you know, that it is possible
to mark PRs as merged in GitHub? I've documented the workflow in the [Apache
Commons
Wiki](http://wiki.apache.org
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@Tibor17 I've assed the assume statement using the API introduced in #120.
I propose that you create a new branch for JUnit 5, where we can merge this PR
and all follow up PRs for JUnit 5
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@Tibor17 any chance this can land on it's own feature branch, so that I can
start with the next tests? I don't want to bloat this PR.
---
If your project is set up for it, you can reply
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/120
Hello @Tibor17
I've addressed you're comment about comparing Strings. There already is an
API for comparing JavaVersions in SystemUtils. Hope you like this.
---
If your project
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@Tibor17 worked through all your comments. Can this be merged as a first
starter for JUnit 5 ITs?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@Tibor17 thank you for the input. I'd like to take have small PRs, so my
proposal is to introduce this first PR and merge it to the code base after your
comments have been resolved
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/123
Add test for setting environment variables from surefire configuratioâ¦
â¦n for JUnit 5
You can merge this pull request into a Git repository by running:
$ git pull https
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/123
@Tibor17 finally found some time to work on more ITs :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/125
Consistently rename JUnit 4.x integration tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/britter/maven-surefire naming
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/124
Fix formatting, convert tabs to spaces
Just some minor cosmetic changes...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/britter/maven
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/126
We need to rebase the junit5 branch after this has been merged in order to
pick up this changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/127
[SUREFIRE 1293] Simplify
org.apache.maven.plugin.surefire.report.TestSetRunListener by using the null
object pattern
Added null object implementations for fields used by TestSetRunListener
Github user britter commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/127#discussion_r82631691
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java
---
@@ -76,7 +76,7 @@ public
Github user britter commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/127#discussion_r82631034
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/NullStatisticsReporter.java
---
@@ -35,7 +36,7
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/132
@Tibor17 find the build log for running the tests with JUnit 4.7 below. I
have not investigated whether it is a regression in JUnit 4.7 or in whether it
is a defect in mavne-sureifre
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/135
@Tibor17: answering your comment from #133:
> In reality the user would use only one dependency and not the profiles.
WDYT ?
Yes, this is just for testing purposes,
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/134
[SUREFIRE-1308] Move Surefire1179IT to jiras package
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/britter/maven-surefire SUREFIRE
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/132
SUREFIRE-1306: JUnit4RerunFailingTestsIT does not execute with the JUnit
version configured in the test
Drop the junitVersion property from pom.xml and let the test execute
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/133
SUREFIRE-1307: Provide a convenient way to run tests against multiple JUnit
versions
First proposal to run tests against multiple JUnit versions.
I implemented an Enum representing
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/135
SUREFIRE-1307: Provide a convenient way to run tests against multiple JUnit
versions
First proposal to run tests against multiple JUnit versions.
I implemented an Enum representing
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/133
@Tibor17 see #135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user britter closed the pull request at:
https://github.com/apache/maven-surefire/pull/133
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/133
Yes sorry, I opened the PR for the wrong branch. Will recreate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user britter closed the pull request at:
https://github.com/apache/maven-surefire/pull/126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/126
Okay, this is reintegrated. I will fix it in another PR. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/127
Hello @Tibor17, I'll fix the checkstyle violations and squash everything
into one single commit!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/125
@Tibor17 rebased with master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user britter closed the pull request at:
https://github.com/apache/maven-surefire/pull/127
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/129
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/128
@Tibor17 I think I'll wait until this is reintegrated, before I make a PR
for merging master to junit5.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/129
Merge master to junit5 branch
As discussed on the ML.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/britter/maven-surefire merge
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/127
@Tibor17 I don't understand. `mvn clean compile` works. Why does this fail
on Jenkins?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/127
> I fixed this issue where I removed [1]
Thank you!
> Because of one method in commons-lang3 we should not pass such a big
library.
ACK
> Instead
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/128
Unpack Suffix for parameterized JUnit4VersionsIT
As discussed in #126 : Pass suffix parameter to unpack method in order to
generate separate test workspaces.
You can merge this pull
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/126
@Tibor17 Wouldn't it be better to rebase junit5 branch onto master? I don't
have push access to maven-surefire, so you would have to do the trick.
---
If your project is set up for it, you
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/127
@Tibor17 fixed checkstyle issues, moved creation of null objects to
DefaultRepoterFactory and squasched everything into one commit. Hope you like
it! :-)
---
If your project is set up
Github user britter closed the pull request at:
https://github.com/apache/maven-surefire/pull/124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user britter closed the pull request at:
https://github.com/apache/maven-surefire/pull/123
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/123
We don't need this anymore, since we'll go with the parameterized test
approach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user britter closed the pull request at:
https://github.com/apache/maven-surefire/pull/134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/135
@Tibor17 okay, let's discuss the details of the engine look up once we have
some integrations tests in place. Do you want anything to be changed in this PR
or can we merge
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/154
@Tibor17 comments would be appreciated. We need this and #155 to continue
work in this direction.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/154
@Tibor17 awesome. Thank you for the feedback. Waiting for the merge to
continue work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/155
@Tibor17 I'll have a look at the state of the junit5 branch next week.
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/155
@Tibor17 I'd say this order:
- #155: revert stuff from rc1 branch
- #154: Add the stuff to junit5 branch
#153 I have to rework, since we have to target it at junit5
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/162
SUREFIRE-1384: ProviderInfo for JUnit Plattform (WIP)
Followup for #153
This is Work in Progress! First take on a JUnitPlattform ProviderInfo, to
enable automatic provider lookup
Github user britter closed the pull request at:
https://github.com/apache/maven-surefire/pull/153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/153
Opening a new PR against junit5 branch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/162
@Tibor17 when I run `mvn compile` I get:
```
Restricted to JDK 1.5 yet
org.apache.maven.surefire:surefire-api:jar:2.19.2-SNAPSHOT:compile contains
org/apache/maven/plugin
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/153
See #162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/153
@marcphilipp this may be of interest for you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/153
@Tibor17 I'm having problems executing the integration test. When I run
`mvn -Dit.test=JUnitPlattformIT verify` with Java 8, I get an error on running
the Integration Test project
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/153
SUREFIRE-1384: ProviderInfo for JUnit Plattform (WIP)
This is Work in Progress!
First take on a JUnitPlattform ProviderInfo, to enable automatic provider
lookup.
You can merge
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/141
@Tibor17 what about this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/146
@Tibor17 the provider is already part of the 3.0-rc1 branch. Please see
#142. This just fixes an incorrect module name.
> It's not legal to introduce incomplete feat
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/146
@Tibor17 I'm currently working on a `JUnitPlattformProviderInfo`. I have
some issues with the ITs, which I will bring up on the ML.
In the mean time, I need you to merge this PR
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/141
@Tibor17 this and #146 a targeted at the 3.0-rc1 branch. So they won't
interfere with the release of 2.20.1.
Regarding junit5 support: it is currently pretty messy and I'm to blame
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/154
@tibor17 got some time to review and merge this an #155?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/154
Move junit5 provider code
Move the junit5/junit-plattform provider code to the junit5 branch. I used
`git cherry-pick 73e09a8b^..70c8843e` to do this.
You can merge this pull request
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/155
Revert junit-plattform provider code from 3.0-rc1 branch.
This code will be moved to the junit5 branch. This commit reverts:
- Commit 70c8843e935882b0a78916894cb9f042964f2717
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/153
@Tibor17 thank you for your review. Have you seen my question? I'm having
problems running the IT. Is this related to the 3.0-rc1 branch?
---
If your project is set up for it, you can reply
Github user britter commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/153#discussion_r121315282
--- Diff:
surefire-integration-tests/src/test/resources/junit-plattform/src/test/java/junitplattform/BasicTest.java
---
@@ -0,0 +1,65
Github user britter commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/153#discussion_r121315310
--- Diff:
surefire-integration-tests/src/test/resources/junit-plattform/pom.xml ---
@@ -0,0 +1,58 @@
+
+
+
+http://maven.apache.org
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/146
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/141
@Tibor17 so we can merge this to 3.0-rc1 branch? Than the branch will have
the correct SNAPSHOT version.
---
If your project is set up for it, you can reply to this email and have your
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/141
@Tibor17 I'm not working on the 3.0 branch any more. It's up to you. I
think the 3.0 branch should have version 3.0
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/165
Merge master to junit5
Bring the junit5 branch up to date with master, so we can continue work.
I'm still getting build failures when running mvn clean verify
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/162
@Tibor17 for the JUnit Plattform Provider we even need JDK 8! Can you merge
Master to junit5 Branch so we have the enforcer fixes? Than I can rebase this
PR.
Thank you
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/162
@Tibor17 any news on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
96 matches
Mail list logo
