[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 Thank you. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail:

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 @Fuud This branch was rebased and pushed to master. Please close it. Thx for contributing. --- - To unsubscribe,

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 https://issues.apache.org/jira/browse/SUREFIRE-1409 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 Any questions? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 ParallelComputerBuilder.PC sets scheduller to runner (see org.apache.maven.surefire.junitcore.pc.ParallelComputerBuilder.PC#setSchedulers(org.junit.runners.ParentRunner,

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 IIYC you mean test-methods by "children". The classes and suites are under our control mean ParallelComputer only? Is it under Spock control as well? On Wed, May 10, 2017 at

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 >Is that true that at least some runners still have some children since the beginning when parallel computer (PC) has recognized them? In general case I can not garantee that.

Re: [GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

IIUC some runners or Runnable children are added as leafs by your framework as at the runtime. I cannot guarantee that these addons would run in parallel. Is that true that at least some runners still have some children since the beginning when parallel computer (PC) has recognized them? On Sat,

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 I am not sure that I understand your question. But I can try to answer :) 1) JUnit has @RunWith annotaion that consumes Class 2) This Runner should implement method getDescription.

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 hm, I am not sure creating runners is possible and even if it is how this could work with us because we create JUnitCore instance and put PC in to if and intercept JUnit builder and

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 Because Spock can't (do not want) generate runners at test object creation time. Parametrized runners are generated at runtime and therefore not known at init time. --- If your project is set

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 @Fuud Makes sense. Why, what is the purpose in your f/w to schedule empty runner? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 NoTestsRemainException will be thrown in this case --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 There is one occasion when you set Filter to ParentRunner all children could be filtered out. On Fri, May 5, 2017 at 9:52 AM, Fedor Bobin wrote:

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 With pure JUnit it is not possible. You can only place @Test annotation on method => there will be at least one test in TestClass. --- If your project is set up for it, you can reply to

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 Question. Could it happen that a runner has no children, as e.g. JUnit's runner builder creates runners? It does not make sense to allocate a thread for empty runner because this is

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 @Jezorko https://github.com/spockframework/spock/pull/558 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 The release would not be that fast. Maybe next month. There is quite a lot to do. I need to find spare time to see if the changes in ParallelComputerBuilder.java

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Jezorko commented on the issue: https://github.com/apache/maven-surefire/pull/114 @Tibor17 I see [the current GIT version is 2.21-SNAPSHOT](https://github.com/apache/maven-surefire/blob/b54e33e68e9c3e13f8fca4b66dbb5c89a0a30715/pom.xml#L32), when a release is expected?

Re: [GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml> > -- View this message in context: http://maven.40175.n5.nabble.com/Re-GitHub-maven-surefire-issue-114-Parallel-runner-should-not-drop-away-runners-that-tp5904931.html Sent from the Maven Developers mailing list archive at Nabble.com.

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 any updates? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Re: [GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

cribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml> > -- View this message in context: http://maven.40175.n5.nabble.com/Re-GitHub-maven-surefire-issue-114-Parallel-runner-should-not-drop-away-runners-that-tp5898774.html Sent from the Maven Developers mailing list archive at Nabble.com.

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user huzaus commented on the issue: https://github.com/apache/maven-surefire/pull/114 Any updates? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 @Fuud We had an internal collision and I tried to recover from this and reverted 11 commits and now trying to fix them and add the last jira fix and then cut the release version. Please

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 Any updates? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 I have this PR in my mind, do not worry. The problem is that we may cleanup our codeline and I do not want to loose your path in master after we revert. Pls wait few days. On

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user szpak commented on the issue: https://github.com/apache/maven-surefire/pull/114 @Tibor17 Is there something else that prevent that PR from being merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 "Master Origin" integration tests suite does not pass on my Windows box. ``` Results : Failed tests:

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 @Fuud You mean this PR does not pass on Win or the master origin? Please see our Jenkins on Windows. It passed https://builds.apache.org/job/maven-surefire-windows --- If your

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 Just FYI: integration tests suite does not pass on Windows. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 Tests run: 701, Failures: 0, Errors: 0, Skipped: 133 [INFO] [INFO] --- maven-checkstyle-plugin:2.13:check (checkstyle-check) @ surefire-integration-tests --- [INFO] [INFO]

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 @szpak @Fuud Pls post the test result `mvn install -P run-its`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user szpak commented on the issue: https://github.com/apache/maven-surefire/pull/114 Is there a plan to make it merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: [GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

I am sure the code had a reason but currently sorry I have not answered since I have being preparing fixes for bugs and feature which are really big. I keep in mind that I should come back soon. On 8/29/16, Fuud wrote: > Github user Fuud commented on the issue: > >

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 any updates? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or