[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Fuud]

Github user Fuud commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
Thank you.


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
@Fuud 
This branch was rebased and pushed to master. Please close it.
Thx for contributing.


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
https://issues.apache.org/jira/browse/SUREFIRE-1409


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Fuud]

Github user Fuud commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
Any questions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Fuud]

Github user Fuud commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
ParallelComputerBuilder.PC sets scheduller to runner (see 
org.apache.maven.surefire.junitcore.pc.ParallelComputerBuilder.PC#setSchedulers(org.junit.runners.ParentRunner,
 org.junit.runners.ParentRunner)

Spock just schedule test methods to provided Scheduller.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
IIYC you mean test-methods by "children".
The classes and suites are under our control mean ParallelComputer only? Is
it under Spock control as well?

On Wed, May 10, 2017 at 6:40 AM, Fedor Bobin 
wrote:

> Is that true that at least some runners still have some children since the
> beginning when parallel computer (PC) has recognized them?
>
> In general case I can not garantee that.
>
> I cannot guarantee that these addons would run in parallel.
>
> JUnit's ParallelComputer sets scheduler to ParentRunner. Spock uses this
> scheduler to run children. Everything should just work.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



-- 
Cheers
Tibor



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Fuud]

Github user Fuud commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
>Is that true that at least some runners still have some children since the
beginning when parallel computer (PC) has recognized them?

In general case I can not garantee that.

>>I cannot guarantee that these addons would run in parallel.

JUnit's ParallelComputer sets scheduler to ParentRunner. Spock uses this 
scheduler to run children. Everything should just work.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Tibor Digana]

IIUC some runners or Runnable children are added as leafs by your framework
as at the runtime.
I cannot guarantee that these addons would run in parallel.
Is that true that at least some runners still have some children since the
beginning when parallel computer (PC) has recognized them?

On Sat, May 6, 2017 at 4:39 PM, Fuud  wrote:

> Github user Fuud commented on the issue:
>
> https://github.com/apache/maven-surefire/pull/114
>
> I am not sure that I understand your question. But I can try to answer
> :)
>
> 1) JUnit has @RunWith annotaion that consumes Class
> 2) This Runner should implement method getDescription. But it is not
> prohibited to report via getDescription less children than will be ran.
> 3) There is only one releable method to get all children: run Runner
> and listen to RunNotifier.
> 4) JUnit's default JUnitCore does not skip runners that reports no
> children. Surefire does.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


-- 
Cheers
Tibor

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Fuud]

Github user Fuud commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
I am not sure that I understand your question. But I can try to answer :)

1) JUnit has @RunWith annotaion that consumes Class
2) This Runner should implement method getDescription. But it is not 
prohibited to report via getDescription less children than will be ran.
3) There is only one releable method to get all children: run Runner and 
listen to RunNotifier.
4) JUnit's default JUnitCore does not skip runners that reports no 
children. Surefire does. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
hm, I am not sure creating runners is possible and even if it is how this
could work with us because we create JUnitCore instance and put PC in to if
and intercept JUnit builder and handle all runners before runtime.
If you say you create runners at runtime means that Junit must know it and
PC would not.

On Fri, May 5, 2017 at 12:54 PM, Fedor Bobin 
wrote:

> Because Spock can't (do not want) generate runners at test object creation
> time. Parametrized runners are generated at runtime and therefore not 
known
> at init time.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



-- 
Cheers
Tibor



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Fuud]

Github user Fuud commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
Because Spock can't (do not want) generate runners at test object creation 
time. Parametrized runners are generated at runtime and therefore not known at 
init time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
@Fuud 
Makes sense.
Why, what is the purpose in your f/w to schedule empty runner?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Fuud]

Github user Fuud commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
NoTestsRemainException will be thrown in this case


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
There is one occasion when you set Filter to ParentRunner all children
could be filtered out.

On Fri, May 5, 2017 at 9:52 AM, Fedor Bobin 
wrote:

> With pure JUnit it is not possible.
> You can only place @Test  annotation on method
> => there will be at least one test in TestClass.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



-- 
Cheers
Tibor



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Fuud]

Github user Fuud commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
With pure JUnit it is not possible.
You can only place @Test annotation on method => there will be at least one 
test in TestClass.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
Question.
Could it happen that a runner has no children, as e.g. JUnit's runner 
builder creates runners?
It does not make sense to allocate a thread for empty runner because this 
is the waste of Threads and such Thread is allocated permanently for no reason.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Fuud]

Github user Fuud commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
@Jezorko 
https://github.com/spockframework/spock/pull/558


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
The release would not be that fast. Maybe next month. There is quite a lot
to do.
I need to find spare time to see if the changes in
ParallelComputerBuilder.java


make logical sense and do not affect testing. If it is ok I will create a
Jira issue for this change from Fuud to have it documented in release notes.
So far we spent a lot of time on massive number of files changes and code
review. The code review is what we are stepping to right now.
I am facing two big tickets and some little which will improve stability of
the plugins.


On Thu, May 4, 2017 at 2:59 AM, Jezorko  wrote:

> @Tibor17  I see the current GIT version is
> 2.21-SNAPSHOT
> 
,
> when a release is expected?
>
> Also a little off-topic, @Fuud  is the code for
> your concurrent spock fork available anywhere? I cannot seem to find it.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



-- 
Cheers
Tibor



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Jezorko]

Github user Jezorko commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
@Tibor17 I see [the current GIT version is 
2.21-SNAPSHOT](https://github.com/apache/maven-surefire/blob/b54e33e68e9c3e13f8fca4b66dbb5c89a0a30715/pom.xml#L32),
 when a release is expected?

Also a little off-topic, @Fuud is the code for your concurrent spock fork 
available anywhere? I cannot seem to find it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Tibor Digana]

Sorry, I realized this was pending issue after release Vote started. Do not
worry, we will trigger a new version 2.20.1 in two weeks. Something is
already in good progress like this, so no reason to wait too long for
2.20.1.

On Fri, Apr 7, 2017 at 8:52 AM, flungo [via Maven] <
ml-node+s40175n5904930...@n5.nabble.com> wrote:

> Github user Fuud commented on the issue:
>
> https://github.com/apache/maven-surefire/pull/114
>
> any updates?
>
>
> ---
> If your project is set up for it, you can reply to this email and have
> your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working,
> please
> contact infrastructure at [hidden email]
> <http:///user/SendEmail.jtp?type=node=5904930=0> or file a JIRA
> ticket
> with INFRA.
> ---
>
> -
> To unsubscribe, e-mail: [hidden email]
> <http:///user/SendEmail.jtp?type=node=5904930=1>
> For additional commands, e-mail: [hidden email]
> <http:///user/SendEmail.jtp?type=node=5904930=2>
>
>
>
> --
> If you reply to this email, your message will be added to the discussion
> below:
> http://maven.40175.n5.nabble.com/GitHub-maven-surefire-
> pull-request-114-Parallel-runner-should-not-drop-away-
> runne-tp5875060p5904930.html
> To start a new topic under Maven Developers, email
> ml-node+s40175n142166...@n5.nabble.com
> To unsubscribe from Maven Developers, click here
> <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code=142166=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ8LTI4OTQ5MjEwMg==>
> .
> NAML
> <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer=instant_html%21nabble%3Aemail.naml=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>




--
View this message in context: 
http://maven.40175.n5.nabble.com/Re-GitHub-maven-surefire-issue-114-Parallel-runner-should-not-drop-away-runners-that-tp5904931.html
Sent from the Maven Developers mailing list archive at Nabble.com.

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Fuud]

Github user Fuud commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
any updates?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Tibor Digana]

I will check your PR, but it is not about pushing to master. The more
important is what we do. We cannot make release yet, but if we could I
would release your PR.
Currently we try to release Maven 3.5.0 and Surefire has 1200 tests and a
lot of them fail with new Maven. So our team cooperates with me and we are
fixing Surefire and Maven running on platform FreeBSD and we make hacks and
talk on IRC.
Pls be patient. We are working every day to release both maven and
surefire. For instance we started at 6pm and finished at 11:45 pm.

On Wed, Feb 15, 2017 at 3:29 PM, Tibor17-2 [via Maven] <
ml-node+s40175n5898753...@n5.nabble.com> wrote:

> Github user huzaus commented on the issue:
>
> https://github.com/apache/maven-surefire/pull/114
>
> Any updates?
>
>
> ---
> If your project is set up for it, you can reply to this email and have
> your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working,
> please
> contact infrastructure at [hidden email]
> <http:///user/SendEmail.jtp?type=node=5898753=0> or file a JIRA
> ticket
> with INFRA.
> ---
>
> -
> To unsubscribe, e-mail: [hidden email]
> <http:///user/SendEmail.jtp?type=node=5898753=1>
> For additional commands, e-mail: [hidden email]
> <http:///user/SendEmail.jtp?type=node=5898753=2>
>
>
>
> --
> If you reply to this email, your message will be added to the discussion
> below:
> http://maven.40175.n5.nabble.com/GitHub-maven-surefire-
> pull-request-114-Parallel-runner-should-not-drop-away-
> runne-tp5875060p5898753.html
> To start a new topic under Maven Developers, email
> ml-node+s40175n142166...@n5.nabble.com
> To unsubscribe from Maven Developers, click here
> <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code=142166=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ8LTI4OTQ5MjEwMg==>
> .
> NAML
> <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer=instant_html%21nabble%3Aemail.naml=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>




--
View this message in context: 
http://maven.40175.n5.nabble.com/Re-GitHub-maven-surefire-issue-114-Parallel-runner-should-not-drop-away-runners-that-tp5898774.html
Sent from the Maven Developers mailing list archive at Nabble.com.

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[huzaus]

Github user huzaus commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
Any updates?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
@Fuud
We had an internal collision and I tried to recover from this and reverted 
11 commits and now trying to fix them and add the last jira fix and then cut 
the release version. Please try to be patient. We want to continue on this 
project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Fuud]

Github user Fuud commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
Any updates?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
I have this PR in my mind, do not worry. The problem is that we may cleanup
our codeline and I do not want to loose your path in master after we
revert. Pls wait few days.

On Sun, Jan 8, 2017 at 12:33 AM, Marcin Zajączkowski <
notificati...@github.com> wrote:

> @Tibor17  Is there something else that
> prevent that PR from being merged?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



-- 
Cheers
Tibor



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[szpak]

Github user szpak commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
@Tibor17 Is there something else that prevent that PR from being merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Fuud]

Github user Fuud commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
"Master Origin" integration tests suite does not pass on my Windows box.
 
```
Results :

Failed tests:   
properNewlinesAndEncodingWithDifferentEncoding(org.apache.maven.surefire.its.ConsoleOutputIT):
 Did not find expected message in log
  
properNewlinesAndEncodingWithDefaultEncodings(org.apache.maven.surefire.its.ConsoleOutputIT):
 Did not find expected message in log
  
properNewlinesAndEncodingWithoutFork(org.apache.maven.surefire.its.ConsoleOutputIT):
 Did not find expected message in log

Tests in error:
  testUmlautIsolatedClassLoader(org.apache.maven.surefire.its.UmlautDirIT): 
Exit code was non-zero: 1; command line and log = (..)
  testUmlaut(org.apache.maven.surefire.its.UmlautDirIT): Exit code was 
non-zero: 1; command line and log = (..)
```

But this PR does nothing with encodings, I think we can ignore this errors 
now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
@Fuud 
You mean this PR does not pass on Win or the master origin?
Please see our Jenkins on Windows. It passed 
https://builds.apache.org/job/maven-surefire-windows


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Fuud]

Github user Fuud commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
Just FYI: integration tests suite does not pass on Windows.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Fuud]

Github user Fuud commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
Tests run: 701, Failures: 0, Errors: 0, Skipped: 133

[INFO]
[INFO] --- maven-checkstyle-plugin:2.13:check (checkstyle-check) @ 
surefire-integration-tests ---
[INFO]
[INFO]
[INFO] --- maven-failsafe-plugin:2.12.4:verify (default) @ 
surefire-integration-tests ---
[INFO] Failsafe report directory: 
/tmp/maven-surefire/surefire-integration-tests/target/failsafe-reports
[INFO]
[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
surefire-integration-tests ---
[INFO] Skipping artifact installation
[INFO] 

[INFO] Reactor Summary:
[INFO]
[INFO] Apache Maven Surefire . SUCCESS [  2.059 
s]
[INFO] ShadeFire JUnit3 Provider . SUCCESS [  0.831 
s]
[INFO] SureFire API .. SUCCESS [  4.160 
s]
[INFO] SureFire Booter ... SUCCESS [  1.175 
s]
[INFO] Maven Surefire Test-Grouping Support .. SUCCESS [  2.420 
s]
[INFO] SureFire Providers  SUCCESS [  0.339 
s]
[INFO] Shared JUnit3 Provider Code ... SUCCESS [  0.522 
s]
[INFO] Shared Java 5 Provider Base ... SUCCESS [  0.674 
s]
[INFO] Shared JUnit4 Provider Code ... SUCCESS [  0.739 
s]
[INFO] Shared JUnit48 Provider Code .. SUCCESS [  1.103 
s]
[INFO] SureFire JUnit Runner . SUCCESS [  0.542 
s]
[INFO] SureFire JUnit4 Runner  SUCCESS [  0.982 
s]
[INFO] Maven Surefire Common . SUCCESS [  4.611 
s]
[INFO] SureFire JUnitCore Runner . SUCCESS [ 51.137 
s]
[INFO] SureFire TestNG Utils . SUCCESS [  0.650 
s]
[INFO] SureFire TestNG Runner  SUCCESS [  0.818 
s]
[INFO] Surefire Report Parser  SUCCESS [  1.268 
s]
[INFO] Maven Surefire Plugin . SUCCESS [  4.376 
s]
[INFO] Maven Failsafe Plugin . SUCCESS [ 22.047 
s]
[INFO] Maven Surefire Report Plugin .. SUCCESS [  5.319 
s]
[INFO] Maven Surefire Integration Test Setup . SUCCESS [ 15.186 
s]
[INFO] Maven Surefire Integration Tests .. SUCCESS [26:14 
min]
[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 28:16 min
[INFO] Finished at: 2016-12-08T10:43:01+01:00
[INFO] Final Memory: 72M/656M



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
@szpak @Fuud 
Pls post the test result `mvn install -P run-its`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[szpak]

Github user szpak commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
Is there a plan to make it merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Tibor Digana]

I am sure the code had a reason but currently sorry I have not
answered since I have being preparing fixes for bugs and feature which
are really big.
I keep in mind that I should come back soon.

On 8/29/16, Fuud  wrote:
> Github user Fuud commented on the issue:
>
> https://github.com/apache/maven-surefire/pull/114
>
> any updates?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


-- 
Cheers
Tibor

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

[Fuud]

Github user Fuud commented on the issue:

https://github.com/apache/maven-surefire/pull/114
  
any updates?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org