Github user mryan43 commented on the issue:
https://github.com/apache/maven/pull/114
Great thanks @rfscholte !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user agudian commented on the issue:
https://github.com/apache/maven/pull/114
@rfscholte: looks good! ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rfscholte commented on the issue:
https://github.com/apache/maven/pull/114
Here's my proposal:
https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=fd57754218e749305be1dd745fda9407960cf985
---
If your project is set up for it, you can reply to this email and
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/114
I don't might to pick this up, but it won't happen before Sep for personal
priorities.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user mryan43 commented on the issue:
https://github.com/apache/maven/pull/114
I feel stuck until someone with more experience of the maven code base
update the version of maven-shared-utils to 3.2.1-SNAPSHOT on the default
branch, anyone up to the task ?
---
If your project
Github user mryan43 commented on the issue:
https://github.com/apache/maven/pull/114
I applied solution B.
I have added an auto-detection method in MessageUtils in my fork of
maven-shared-utils (https://github.com/mryan43/maven-shared) based on the
corresponding code in
Github user mryan43 commented on the issue:
https://github.com/apache/maven/pull/114
Unfortunately, the system property is read only once in a static init block
in the JansiConsole class before the cli main method is invoked, so my change
doesn't work.
We have a kind of
Github user mryan43 commented on the issue:
https://github.com/apache/maven/pull/114
I will test with less and jenkins and comment again with results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/114
I think yes, grep doesn't do different. Please try the patch thoroughly!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mryan43 commented on the issue:
https://github.com/apache/maven/pull/114
Good idea to align the name of choices with grep, I just changed it.
About "isatty", do you think we should set the jansi.force system property
when --color is set to "always" ?
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/114
Two issues:
1. Unfortunately, Commons CLI does not offer valid values. If it would, it
would fail if the option value is wrong. I would do so too.
2. You blindly `return` from `always`,
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/114
They are several issues. People are used to
[GNU](https://www.gnu.org/software/grep/manual/grep.html#General-Output-Control)
and [BSD](https://www.freebsd.org/cgi/man.cgi?query=grep=opensearch)
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/114
I will comment shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
13 matches
Mail list logo
