[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...
Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/125 No, sorry, I can't "assign" this to anyone, you just have to wait for somebody to review and merge this pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...
Github user dbmeneses commented on the issue: https://github.com/apache/maven/pull/125 @ifedorenko Ok, thanks for the help preparing the p/r. Is there anyone you could assign the review to? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...
Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/125 The change looks reasonable but I don't use built-in multithreaded build support myself and do not feel comfortable merging this change without proper testing. I will have to defer to somebody more familiar with this part of Maven codebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...
Github user dbmeneses commented on the issue: https://github.com/apache/maven/pull/125 Ok my bad, I've managed to make them pass on my box as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...
Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/125 No, having IT failures are not normal, and [jenkins seems to be happy](https://builds.apache.org/view/M-R/view/Maven%20Core%20ITs/job/core-integration-testing-maven-3-embedded/). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...
Github user dbmeneses commented on the issue: https://github.com/apache/maven/pull/125 @ifedorenko I've updated my previous comment. I added a simple reproducer and I submitted a P/R to maven-integration-testing with an IT. BTW is it normal to have 100+ ITs failing with mvn 3.5.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...
Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/125 Can you provide a regression test that demonstrates the problem and the fix? Semi-related, I recently fixed similar problem in [Takari Smart Builder](https://github.com/takari/takari-smart-builder) where aggregate tasks ran multiple times. Multithreading is hard :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org