Re: Review request

[Michael Osipov]

Am 2017-03-27 um 19:58 schrieb Stephen Connolly:

My mng-6195 branch is passing all ITs

https://builds.apache.org/view/Maven/job/maven-3.x-jenkinsfile/job/mng-6195/

Can somebody test it on FreeBSD (check that .mvn folder is resolved
correctly when using -f to specify a path outside the current directory)


Passes all ITs on
FreeBSD bsd10.local 10.3-RELEASE-p11 FreeBSD 10.3-RELEASE-p11 #0: Mon 
Oct 24 18:49:24 UTC 2016 
r...@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64


with
openjdk version "1.8.0_121"
OpenJDK Runtime Environment (build 1.8.0_121-b13)
OpenJDK 64-Bit Server VM (build 25.121-b13, mixed mode)


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Review request

[Stephen Connolly]

Thanks. My analysis was correct on the Windows mvn.cmd then ;-)

On Tue 28 Mar 2017 at 19:09, Robert Scholte  wrote:

> Just to confirm: on Windows in all three cases the tests are skipped when
> following the steps to reproduce MNG-6198
>
> Robert
>
> On Mon, 27 Mar 2017 22:08:06 +0200, Stephen Connolly
>  wrote:
>
> > Found another issue with the shell script: MNG-6198 (would be good if
> > somebody with windows could confirm that `mvn.cmd` is not affected by the
> > bug I have identified in `mvn`)
> >
> > On 27 March 2017 at 18:58, Stephen Connolly
> >  >> wrote:
> >
> >> My mng-6195 branch is passing all ITs
> >>
> >> https://builds.apache.org/view/Maven/job/maven-3.x-
> >> jenkinsfile/job/mng-6195/
> >>
> >> Can somebody test it on FreeBSD (check that .mvn folder is resolved
> >> correctly when using -f to specify a path outside the current directory)
> >>
> >> Can somebody test on Solaris 10 (same test)
> >>
> >> I'll double check on macOS (same test)
> >>
> >> Other test data points welcome
> >> --
> >> Sent from my phone
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
> --
Sent from my phone

Re: Review request

[Robert Scholte]

Just to confirm: on Windows in all three cases the tests are skipped when  
following the steps to reproduce MNG-6198


Robert

On Mon, 27 Mar 2017 22:08:06 +0200, Stephen Connolly  
 wrote:



Found another issue with the shell script: MNG-6198 (would be good if
somebody with windows could confirm that `mvn.cmd` is not affected by the
bug I have identified in `mvn`)

On 27 March 2017 at 18:58, Stephen Connolly  

Re: Review request

[Stephen Connolly]

Found another issue with the shell script: MNG-6198 (would be good if
somebody with windows could confirm that `mvn.cmd` is not affected by the
bug I have identified in `mvn`)

On 27 March 2017 at 18:58, Stephen Connolly  wrote:

> My mng-6195 branch is passing all ITs
>
> https://builds.apache.org/view/Maven/job/maven-3.x-
> jenkinsfile/job/mng-6195/
>
> Can somebody test it on FreeBSD (check that .mvn folder is resolved
> correctly when using -f to specify a path outside the current directory)
>
> Can somebody test on Solaris 10 (same test)
>
> I'll double check on macOS (same test)
>
> Other test data points welcome
> --
> Sent from my phone
>

Review request

[Stephen Connolly]

My mng-6195 branch is passing all ITs

https://builds.apache.org/view/Maven/job/maven-3.x-jenkinsfile/job/mng-6195/

Can somebody test it on FreeBSD (check that .mvn folder is resolved
correctly when using -f to specify a path outside the current directory)

Can somebody test on Solaris 10 (same test)

I'll double check on macOS (same test)

Other test data points welcome
-- 
Sent from my phone

Review Request: Download Dependencies in parallel (MRESOLVER-7)

[Harald Wellmann]

There's a pull request waiting for review by resolver experts:

https://github.com/apache/maven-resolver/pull/2
https://issues.apache.org/jira/browse/MRESOLVER-7

This is a recap of a PR I originally submitted last year, which has been 
pending while Aether move from Eclipse to ASF was in progress.


I adapted it to the current version in November. In the meantime, some 
more conflicting changes have occurred on master.


It would be great if someone who knows Resolver inside out could comment 
on the PR in this stage, before starting another rework.


Thanks,
Harald

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Review Request: Apache Maven Recipe for module-info and older projects

[Robert Scholte]

Hi,

I've written a page[1] about the problem related to projects which need to  
be compatible with pre Java9 versions, but also want to provide a  
module-info file in case it is used in a Java 9 project. This is mainly an  
issue for library builders, end-application builders can simply push  
everything to Java 9.


Let me also explain why I didn't go for any other options:
- 1 execution-block to rule them all (maven-compiler-plugin magic): this  
would mean you need to introduce several parameters for the compilation of  
the module-info file. And we must assume they cannot always use the same  
JDK. To keep enough strength for the end-user you must provide duplicates  
of source/target/release, jdkToolchain, includes, excludes and maybe more.
  The next issue is about result handling: the result of both javac calls  
need to be merged, in all combinations of success and failure. In case of  
failure you must provide the exact information. Whoever tries to implement  
this just like I did must admit it results in ugly and hard controllable  
code.
-  2 separate source folders could be a pattern, but probably not a  
developer-friendly option. This also depends on what IDEs are going to do.
- Multimodule JAR: feels quite expensive to have a Maven MultiModule for  
only one file. Also in this case we might need to wait and see what kind  
of solutions IDEs have.
- auto-ignore module-info in case source/target/release < 9: I've decided  
not to do this. Uninformed developers might think that the module-info is  
automatically compiled. However, in the end the jar won't have the  
module-info file. Better break the build and point them to the module-info  
page[1]


I've written an integration test[2] matching this concept.

As said: this is mainly an issue for library builders. I expect that they  
don't have a real issue with this small amount of extra configuration in  
their pom. And this way they are still in full control.


Any comment is appreciated,
Robert

ps. .apt-files will be transformed to html with the maven-site-plugin as  
part of every release.


[1]  
http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-compiler-plugin/src/site/apt/examples/module-info.apt.vm
[2]  
http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-compiler-plugin/src/it/MCOMPILER-275_separate-moduleinfo/


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Patch review request for https://jira.codehaus.org/browse/MSHADE-112

[Trask Stalnaker]

Hi,

Could someone review the patch attached to this issue and commit or let me
know what I can do to make the patch more acceptable?

I have found this patch useful for deploying a fully shaded sources
artifact which helps a lot when stepping through the shaded artifact in the
eclipse debugger.

https://jira.codehaus.org/browse/MSHADE-112


Thanks,
Trask

Re: Patch review request for https://jira.codehaus.org/browse/MSHADE-112

[Olivier Lamy]

Hi,
I have just added a comment.

2012/5/7 Trask Stalnaker trask.stalna...@gmail.com:
 Hi,

 Could someone review the patch attached to this issue and commit or let me
 know what I can do to make the patch more acceptable?

 I have found this patch useful for deploying a fully shaded sources
 artifact which helps a lot when stepping through the shaded artifact in the
 eclipse debugger.

 https://jira.codehaus.org/browse/MSHADE-112


 Thanks,
 Trask



-- 
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[REVIEW REQUEST] Animal Sniffer

[Stephen Connolly]

Hey all,

I've been working on the animal-sniffer documentation.

It would be greatly appreciated if some more eyes could take a look at
what I've done so far:

Main site: http://mojo.codehaus.org/animal-sniffer/
Java Boot classpath detector:
http://mojo.codehaus.org/animal-sniffer/java-boot-classpath-detector/index.html
Annotations for Java 1.5+:
http://mojo.codehaus.org/animal-sniffer/animal-sniffer-annotations/index.html
API/CLI: http://mojo.codehaus.org/animal-sniffer/animal-sniffer/index.html
Maven Enforcer Rule:
http://mojo.codehaus.org/animal-sniffer/animal-sniffer-enforcer-rule/index.html
ANT Tasks: 
http://mojo.codehaus.org/animal-sniffer/animal-sniffer-ant-tasks/index.html
Maven Plugin: http://mojo.codehaus.org/animal-sniffer-maven-plugin/index.html

Please respond with comments on this thread, or please update SVN with
your fixes

I'd like to have the site fixed and ready for a Vote by Saturday...
Then I just have to sort out the Java Signatures (which I cannot roll
a release of until we have animal-sniffer-maven-plugin released

Thanks,

-Stephen

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [REVIEW REQUEST] Animal Sniffer

[Stephen Connolly]

Damn, ment to go for d...@codehaus

2009/11/5 Stephen Connolly stephen.alan.conno...@gmail.com:
 Hey all,

 I've been working on the animal-sniffer documentation.

 It would be greatly appreciated if some more eyes could take a look at
 what I've done so far:

 Main site: http://mojo.codehaus.org/animal-sniffer/
 Java Boot classpath detector:
 http://mojo.codehaus.org/animal-sniffer/java-boot-classpath-detector/index.html
 Annotations for Java 1.5+:
 http://mojo.codehaus.org/animal-sniffer/animal-sniffer-annotations/index.html
 API/CLI: http://mojo.codehaus.org/animal-sniffer/animal-sniffer/index.html
 Maven Enforcer Rule:
 http://mojo.codehaus.org/animal-sniffer/animal-sniffer-enforcer-rule/index.html
 ANT Tasks: 
 http://mojo.codehaus.org/animal-sniffer/animal-sniffer-ant-tasks/index.html
 Maven Plugin: http://mojo.codehaus.org/animal-sniffer-maven-plugin/index.html

 Please respond with comments on this thread, or please update SVN with
 your fixes

 I'd like to have the site fixed and ready for a Vote by Saturday...
 Then I just have to sort out the Java Signatures (which I cannot roll
 a release of until we have animal-sniffer-maven-plugin released

 Thanks,

 -Stephen


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[repost: review request] Re: MJAR-28 Advice from dev: Mainfest.mf/Class-Path entries by MavenArchiver, Assembly and Jar

[Barrie Treloar]

Reposting to request someone with MavenArchiver, Assembly and Jar dev
experience to provide some guidance on which is the correct direction
so I can file a patch.

Cheers
Bae

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]