[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

2018-02-21 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372427#comment-16372427 ] Goldstein Lyor commented on SSHD-730: - I'm fine with it if it passes compilation and full unit tests - I

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

2018-02-21 Thread Guillaume Nodet (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371881#comment-16371881 ] Guillaume Nodet commented on SSHD-730: -- Actually, I wonder why this method exists at all. It's used in

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

2018-02-21 Thread Guillaume Nodet (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371909#comment-16371909 ] Guillaume Nodet commented on SSHD-730: -- So what about the following patch then: {code} diff --git

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

2018-02-21 Thread Lukas Waldmann (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371417#comment-16371417 ] Lukas Waldmann commented on SSHD-730: - Why removedDots is int and not boolean? It is used only to check

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

2018-02-20 Thread Lukas Waldmann (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369969#comment-16369969 ] Lukas Waldmann commented on SSHD-730: - I agree, the underlying FileSystem should now best how to

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

2018-02-20 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369880#comment-16369880 ] Goldstein Lyor commented on SSHD-730: - Bottom line from the long :) comment - we should revise the

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

2018-02-19 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369756#comment-16369756 ] Goldstein Lyor commented on SSHD-730: - I think I did no explain my thoughts on this issue clearly thus

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

2018-02-19 Thread Guillaume Nodet (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369444#comment-16369444 ] Guillaume Nodet commented on SSHD-730: -- [~lgoldstein] The link should be resolved relative to the its 

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

2018-02-19 Thread Lukas Waldmann (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369409#comment-16369409 ] Lukas Waldmann commented on SSHD-730: - Lyor, I really can't agree if you have directories defined as

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

2018-02-19 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369386#comment-16369386 ] Goldstein Lyor commented on SSHD-730: - {quote} We are talking about traversing well defined directory

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

2018-02-19 Thread Lukas Waldmann (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369278#comment-16369278 ] Lukas Waldmann commented on SSHD-730: - Sure, I can give it a try > Relative symbolic links with .. is

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

2018-02-19 Thread Guillaume Nodet (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369233#comment-16369233 ] Guillaume Nodet commented on SSHD-730: -- [~luky] could you write a unit test in

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

2018-02-19 Thread Lukas Waldmann (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369167#comment-16369167 ] Lukas Waldmann commented on SSHD-730: - I beg to differ. We are not talking about "current directory" in

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

2018-02-19 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369145#comment-16369145 ] Goldstein Lyor commented on SSHD-730: - There is an issue regarding what \{quote}current

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

2017-03-03 Thread Lukas Waldmann (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894150#comment-15894150 ] Lukas Waldmann commented on SSHD-730: - Imagine dir tree like this: /dir1/dir2/file /dir1/dir3/link if

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

2017-03-02 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893717#comment-15893717 ] Goldstein Lyor commented on SSHD-730: - Please clarify the problem some more - specifically what is meant