[jira] [Commented] (SSHD-732) ClientIdentitiesWatcher should load keys one at a time

2017-03-29 Thread Goldstein Lyor (JIRA)

[ 
https://issues.apache.org/jira/browse/SSHD-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15947454#comment-15947454
 ] 

Goldstein Lyor commented on SSHD-732:
-

Great - thanks :-)

> ClientIdentitiesWatcher should load keys one at a time
> --
>
> Key: SSHD-732
> URL: https://issues.apache.org/jira/browse/SSHD-732
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Critical
> Fix For: 1.5.0
>
> Attachments: 
> org.apache.sshd.common.auth.AuthenticationTest-output.txt, 
> org.apache.sshd.common.auth.AuthenticationTest.txt
>
>
> The keys are loaded into a List instead of using an 
> Iterable which could allow lazy loading the keys.
> The problem is that loading keys can require passwords, thus asking the user 
> for passwords which may not be used.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (SSHD-732) ClientIdentitiesWatcher should load keys one at a time

2017-03-28 Thread Goldstein Lyor (JIRA)

[ 
https://issues.apache.org/jira/browse/SSHD-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945635#comment-15945635
 ] 

Goldstein Lyor commented on SSHD-732:
-

Still failing for me - Windows 10, Oracle JDK 1.8.0_121 - attached reports, 
will try on Linux

> ClientIdentitiesWatcher should load keys one at a time
> --
>
> Key: SSHD-732
> URL: https://issues.apache.org/jira/browse/SSHD-732
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Critical
> Fix For: 1.5.0
>
>
> The keys are loaded into a List instead of using an 
> Iterable which could allow lazy loading the keys.
> The problem is that loading keys can require passwords, thus asking the user 
> for passwords which may not be used.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (SSHD-732) ClientIdentitiesWatcher should load keys one at a time

2017-03-21 Thread Goldstein Lyor (JIRA)

[ 
https://issues.apache.org/jira/browse/SSHD-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935748#comment-15935748
 ] 

Goldstein Lyor commented on SSHD-732:
-

I believe the problem is related to some kind of bug in the implementation of 
spliteraror for the keys iterable. I was able to zoom into some issue with the 
UserAuthPublicKeysIterator

> ClientIdentitiesWatcher should load keys one at a time
> --
>
> Key: SSHD-732
> URL: https://issues.apache.org/jira/browse/SSHD-732
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Critical
>
> The keys are loaded into a List instead of using an 
> Iterable which could allow lazy loading the keys.
> The problem is that loading keys can require passwords, thus asking the user 
> for passwords which may not be used.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)