[
https://issues.apache.org/jira/browse/SLING-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antonio Sanso reassigned SLING-3713:
Assignee: Antonio Sanso
VanityPathTest testRedirectOnPathWithExtension fails: Expecting
Thanks for redoing, Robert.
+1
Carsten
2014-07-01 2:01 GMT+02:00 Justin Edelson jus...@justinedelson.com:
+1
On Mon, Jun 30, 2014 at 12:14 PM, Robert Munteanu rob...@lmn.ro wrote:
I think I've gotten the right Maven/Tycho incantations set up and
deployed the 1.0.0 artifacts to
Antonio Sanso created SLING-3719:
Summary: MapEntries-updateTargetPaths holds incorrect
information in case of exception while creating a MapEntry
Key: SLING-3719
URL:
[
https://issues.apache.org/jira/browse/SLING-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antonio Sanso resolved SLING-3719.
--
Resolution: Fixed
Fix Version/s: Resource Resolver 1.1.2
added unit test and fix in
Hi
There currently are two issues floating around dealing with the question of
returning more information than just null from the Adaptable.adaptTo(Class)
method: https://issues.apache.org/jira/browse/SLING-3714 and
https://issues.apache.org/jira/browse/SLING-3709. I think these requests
Hi,
On Tue, Jul 1, 2014 at 9:07 AM, Felix Meschberger fmesc...@adobe.com wrote:
..there are options available...
Just a wild idea, how about this:
Foo f = someObject.adaptTo(RequireAdapter.for(Foo.class));
which could be handled by the AdapterManagerImpl, by wrapping whatever
adapter it
On Tue, Jul 1, 2014 at 9:41 AM, Bertrand Delacretaz
bdelacre...@apache.org wrote:
...how about this:
Foo f = someObject.adaptTo(RequireAdapter.for(Foo.class));
Actually, rereading SLING-3714, this can be made simpler with generics
Foo f = someObject.adaptTo(RequireAdapterFoo.class));
Regarding 1) Having such a Result class would mean that all consumer would need
to unwrap the exception first. So instead of being forced of implementing a
null-check (as with the old solution) one would need to implement another
check. I want to prevent such a burden to the consumers.
See
https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.replication.it/1161/
--
[INFO]
[INFO]
See https://builds.apache.org/job/sling-contrib-1.6/1161/changes
Changes:
[olli] SLING-3027 use latest release (Sling Service User Mapper)
--
[...truncated 2924 lines...]
[INFO] Copying jackrabbit-jcr-commons-2.7.2.jar to
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.models.integration-tests/2240/
See https://builds.apache.org/job/sling-trunk-1.6/changes
[
https://issues.apache.org/jira/browse/SLING-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Artyom Stetsenko updated SLING-3720:
Description: Crankstart launcher should determine the path to its JAR and
add it as a
[
https://issues.apache.org/jira/browse/SLING-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Artyom Stetsenko updated SLING-3720:
Attachment: crankstart.jar.path.patch
Attached patch that adds {{crankstart.jar.path}}
Artyom Stetsenko created SLING-3720:
---
Summary: Make Crankstart launcher add path to its JAR as a system
property
Key: SLING-3720
URL: https://issues.apache.org/jira/browse/SLING-3720
Project: Sling
Adding a new interface would require us to implement it all over the place
and as Felix points out, client code would always need to check whether the
new interface is implemented or not Having to methods, like hasAdapter and
adaptOrThrow does not work very well as between the two calls things
[
https://issues.apache.org/jira/browse/SLING-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz resolved SLING-3720.
Resolution: Fixed
Assignee: Bertrand Delacretaz
Patch applied in revision
adaptTo() is currently commonly used as a test, similar to instanceof.
Throwing and catching to return null is a very poor implementation
(performance-wise) for this use.
Adding a hasAdapter() or canAdaptTo() might decrease the number of
implementations that think throwing is OK, but only if the
It is not (only) about throwing exceptions in case no suitable adapter is
available. It rather is about the fact, that today the adaptTo is a barrier for
all kinds of exceptions. In some cases the adaptation fails for a specific
reason (one example is Sling Models where injection fails, another
See
https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/614/
adaption and validation are different concerns
Carsten
2014-07-01 10:55 GMT+02:00 Jeff Young j...@adobe.com:
We could solve that by defining a specific exception for
adaptation-not-possible and then catch only that.
Of course that would leak tons of exceptions from code written before that
[
https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reopened SLING-3505:
-
Reopening due to reported NPE
Improve handling of updates to mapping (alias, vanity path)
Hi Carsten,
Can you say more? (I'm not sure I understand what you're getting at)
Thanks,
Jeff.
On 01/07/2014 09:56, Carsten Ziegeler cziege...@apache.org wrote:
adaption and validation are different concerns
Carsten
2014-07-01 10:55 GMT+02:00 Jeff Young j...@adobe.com:
We could
[
https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14048668#comment-14048668
]
Antonio Sanso commented on SLING-3505:
--
[~cziegeler] which NPE ? I fyou mean
[
https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14048668#comment-14048668
]
Antonio Sanso edited comment on SLING-3505 at 7/1/14 9:13 AM:
--
Sure :) For the adapter pattern, the client does not care why the adaption
failed, the client is just interested in the result (success or not)
Validation is a different beast, if validation fails you want to know
specific reasons why it failed - and this can be multiple.
I tried to explain in my
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2241/
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.event/2241/
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.testing.samples.integrationtests/2241/
See https://builds.apache.org/job/sling-trunk-1.6/changes
[
https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-3505.
-
Resolution: Fixed
Ah, SLING-3706 wasn't mentioned in the comment above. So everything is
Hi Tommaso,
could you please open an issue for this?
Thanks
Carsten
2014-06-17 9:30 GMT+02:00 Stefan Egli stefane...@apache.org:
Hi Tommaso,
That sounds indeed odd. From a code point of view both should be
equivalent, as findJobs checks for ( templates != null templates.length
0 ) - so
[
https://issues.apache.org/jira/browse/SLING-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated SLING-3716:
--
Attachment: 140701_SLING-3716_slingmodes_constructorinjection.patch
attached is a patch for
See
https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.replication.it/1162/
[
https://issues.apache.org/jira/browse/SLING-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated SLING-3716:
--
Attachment: 140701_SLING-3716_slingmodes_constructorinjection.patch
updated the patch, it
[
https://issues.apache.org/jira/browse/SLING-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated SLING-3716:
--
Attachment: (was:
140701_SLING-3716_slingmodes_constructorinjection.patch)
Sling Models:
See
https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/615/
See https://builds.apache.org/job/sling-trunk-1.7/changes
+1
(verified md5 sha1 using the check_staged_release.sh)
Cheers,
Stefan
On 7/1/14 8:34 AM, Carsten Ziegeler cziege...@apache.org wrote:
Thanks for redoing, Robert.
+1
Carsten
2014-07-01 2:01 GMT+02:00 Justin Edelson jus...@justinedelson.com:
+1
On Mon, Jun 30, 2014 at 12:14 PM, Robert
I like that approach. It is backwards-compatible and allows the developers to
decide whether they want to check for null or to rely on exceptions.
The AdapterManagerImpl indeed would need to deal with such a parametrisation
and in addition the javadocs would need to be adjusted to make it clear
Foo f = someObject.adaptTo(RequireAdapterFoo.class));
this would still require an unwrapping of the object out of the
RequireAdapterFoo instance.
Foo f = someObject.adaptTo(RequireAdapter.for(Foo.class));
this looks interesting, and does not need unwrapping if the return value is the
input
Hi Carsten,
Sure, but Konrad has a point in that I think sometimes the client *does*
care why the adaption failed. For instance, if it had to do with
something entirely different from whether or not adaption would normally
work.
Let's say that I have a resource that should adapt to XYZ, but
On 01 Jul 2014, at 12:05, Stefan Seifert sseif...@pro-vision.de wrote:
Foo f = someObject.adaptTo(RequireAdapterFoo.class));
this would still require an unwrapping of the object out of the
RequireAdapterFoo instance.
In my regard there is an instanceof RequireAdapter check within the
So if your adapter is buggy and you get an exception, what do you do with
it?
Carsten
2014-07-01 12:08 GMT+02:00 Jeff Young j...@adobe.com:
Hi Carsten,
Sure, but Konrad has a point in that I think sometimes the client *does*
care why the adaption failed. For instance, if it had to do with
example: usecase like here
https://issues.apache.org/jira/browse/SLING-3714?focusedCommentId=14048040#comment-14048040
the caller code expects that the adaption is always successful if everything
works correct - if not it is an application error which should be propagated
through error handling
Yes, but right now you would get an NPE accessing the object - so you
already have a runtime exception and don't need to check for null (I'm not
arguing that this is a good way, I'm just trying to avoid heavy changes).
And we could change the adapter manager/factory implemntation to log the
I just fix it in the code ;-). Those exceptions should only happen during
runtime (due to some false assumptions).
For the same reasons methods do throw IllegalArgumentExceptions in case a given
parameter is null
the NPE would swallow all maybe usefull excpetion information, that might be
contained in the root cause of the exception throws by a method like
adaptToOrThrow method. always logging the exception internally by the adapter
manager has the drawback that the application might not be interested
I like the idea too, but I guess it's merely a question of taste as to
which of the following two options is nicer:
* Foo f = someObject.adaptTo(RequireAdapterFoo.class));
* Foo f = someObject.adaptToUnchecked(Foo.class);
Cheers,
Stefan
On 7/1/14 11:57 AM, Konrad Windszus konra...@gmx.de
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.testing.samples.integrationtests/2242/
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.event/2242/
On Tue, Jul 1, 2014 at 12:38 PM, Stefan Egli stefane...@apache.org wrote:
I like the idea too, but I guess it's merely a question of taste as to
which of the following two options is nicer:
* Foo f = someObject.adaptTo(RequireAdapterFoo.class));
* Foo f =
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2242/
See https://builds.apache.org/job/sling-trunk-1.6/changes
Ok, this would solve the throw if adaption is not possible case, what about
the validation use case?
Carsten
2014-07-01 12:50 GMT+02:00 Bertrand Delacretaz bdelacre...@apache.org:
On Tue, Jul 1, 2014 at 12:38 PM, Stefan Egli stefane...@apache.org
wrote:
I like the idea too, but I guess
[
https://issues.apache.org/jira/browse/SLING-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14048770#comment-14048770
]
Stefan Egli commented on SLING-3618:
bq. no matching child node definition found for
That would be solved by just stating that RuntimeExceptions are allowed as
alternative to returning null for all AdapterFactories (i.e. no API change
necessary) and making sure that those exceptions are either being caught within
the AdapterManagerImpl or just propagated to the caller.
On 01
Well, for one thing, display it in the Developer Mode console (or whatever
other debugging UIs my app happens to have).
Jeff.
On 01/07/2014 11:14, Carsten Ziegeler cziege...@apache.org wrote:
So if your adapter is buggy and you get an exception, what do you do with
it?
Carsten
2014-07-01
[
https://issues.apache.org/jira/browse/SLING-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14048780#comment-14048780
]
Konrad Windszus commented on SLING-3714:
Idea from [~bdelacretaz]: Don't change
[
https://issues.apache.org/jira/browse/SLING-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14048780#comment-14048780
]
Konrad Windszus edited comment on SLING-3714 at 7/1/14 11:51 AM:
See
https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.replication.it/1163/
--
[INFO]
[INFO]
See https://builds.apache.org/job/sling-contrib-1.6/1163/changes
Changes:
[bdelacretaz] Fix registration of multiple resources via the Sling installer
--
[...truncated 2945 lines...]
[INFO] Copying jackrabbit-jcr-commons-2.7.2.jar to
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.event/2243/
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.testing.samples.integrationtests/2243/
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2243/
See https://builds.apache.org/job/sling-trunk-1.6/changes
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.models.integration-tests/2243/
+1
On Tue, Jul 1, 2014 at 5:55 AM, Stefan Egli stefane...@apache.org wrote:
+1
(verified md5 sha1 using the check_staged_release.sh)
Cheers,
Stefan
On 7/1/14 8:34 AM, Carsten Ziegeler cziege...@apache.org wrote:
Thanks for redoing, Robert.
+1
Carsten
2014-07-01 2:01
See
https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/616/
See https://builds.apache.org/job/sling-trunk-1.7/changes
Hi,
The vote has passed with the following result :
+1 (binding): Robert Munteanu, Justin Edelson, Carsten Ziegler, Stefan
Egli, Daniel Klco
I will copy this release to the Sling dist directory and promote the
artifacts to the central Maven repository.
Robert
Need one more binding vote
On Friday, June 27, 2014, Stefan Seifert sseif...@pro-vision.de wrote:
+1 (non-binding)
p.s. integration tests are running fine on my machine
-Original Message-
From: justinedel...@gmail.com javascript:; [mailto:
justinedel...@gmail.com
[
https://issues.apache.org/jira/browse/SLING-3718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated SLING-3718:
--
Attachment:
140701_SLING-3716_slingmodes_constructorinjection_SLING-3718_selfinjector.patch
[
https://issues.apache.org/jira/browse/SLING-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14048841#comment-14048841
]
Stefan Seifert commented on SLING-3716:
---
please note: SLING-3718 contains an updated
[
https://issues.apache.org/jira/browse/SLING-3718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14048840#comment-14048840
]
Stefan Seifert edited comment on SLING-3718 at 7/1/14 1:15 PM:
Anyone?
On Sun, Jun 22, 2014 at 10:19 PM, Robert Munteanu romb...@apache.org wrote:
Hi,
In SLING-3667 [1] Tomek Rękawek was kind enough to submit the
SlingQuery library to the Sling project.
I am not certain whether this contribution needs to go through the
extra process described at [2]
On Tue, Jul 1, 2014 at 3:14 PM, Robert Munteanu romb...@apache.org wrote:
...Does anyone know how to debug this?...
You'd have to install the CMS locally AFAIK...someone should really
create a Vagrant box for that but ENOTIME.
In the meantime I think I fixed it in http://svn.apache.org/r1607079
On Tue, Jul 1, 2014 at 4:56 PM, Bertrand Delacretaz
bdelacre...@apache.org wrote:
On Tue, Jul 1, 2014 at 3:14 PM, Robert Munteanu romb...@apache.org wrote:
...Does anyone know how to debug this?...
You'd have to install the CMS locally AFAIK...someone should really
create a Vagrant box for
[
https://issues.apache.org/jira/browse/SLING-3685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040663#comment-14040663
]
Robert Munteanu edited comment on SLING-3685 at 7/1/14 2:42 PM:
[
https://issues.apache.org/jira/browse/SLING-3685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040663#comment-14040663
]
Robert Munteanu edited comment on SLING-3685 at 7/1/14 2:44 PM:
I quickly tried to implement a POC, but due to type erasure the interface is
not as simple as just putting RequireAdapterFoo.class
I found the following reference:
http://gafter.blogspot.de/2006/12/super-type-tokens.html and tried to implement
something like that but could not get it to work in
Hi
Am 01.07.2014 um 09:44 schrieb Bertrand Delacretaz bdelacre...@apache.org:
On Tue, Jul 1, 2014 at 9:41 AM, Bertrand Delacretaz
bdelacre...@apache.org wrote:
...how about this:
Foo f = someObject.adaptTo(RequireAdapter.for(Foo.class));
Actually, rereading SLING-3714, this can be made
Artyom Stetsenko created SLING-3721:
---
Summary: Crankstart does not stop the framework gracefully on exit
Key: SLING-3721
URL: https://issues.apache.org/jira/browse/SLING-3721
Project: Sling
[
https://issues.apache.org/jira/browse/SLING-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Artyom Stetsenko updated SLING-3721:
Attachment: frameworkShutdown.patch
Attached patch which adds a shutdown hook to the JVM,
Carsten Ziegeler created SLING-3722:
---
Summary: Add metatype information for source and target vm version
Key: SLING-3722
URL: https://issues.apache.org/jira/browse/SLING-3722
Project: Sling
[
https://issues.apache.org/jira/browse/SLING-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-3722.
-
Resolution: Fixed
Added in rev 1607118
The default value is empty (for compatibility)
Antonio Sanso created SLING-3723:
Summary: MapEntries-resolveMapsMap holds incorrect information in
case of vanityPath removal
Key: SLING-3723
URL: https://issues.apache.org/jira/browse/SLING-3723
[
https://issues.apache.org/jira/browse/SLING-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antonio Sanso resolved SLING-3723.
--
Resolution: Fixed
Fix Version/s: Resource Resolver 1.1.2
added test case and fix in
See
https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/617/
See https://builds.apache.org/job/sling-trunk-1.7/changes
Carsten Ziegeler created SLING-3724:
---
Summary: Provide option to always use current vm version for
source and target
Key: SLING-3724
URL: https://issues.apache.org/jira/browse/SLING-3724
Project:
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.models.integration-tests/2244/
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2244/
See https://builds.apache.org/job/sling-trunk-1.6/changes
[
https://issues.apache.org/jira/browse/SLING-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-3724.
-
Resolution: Fixed
If the value auto is specified as the version, the current vm version
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.testing.samples.integrationtests/2244/
[
https://issues.apache.org/jira/browse/SLING-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-3724:
Fix Version/s: Scripting Java 2.0.8
Provide option to always use current vm version for
It seems we're still missing a vote on this pretty old vote thread...
Carsten
2014-06-04 9:30 GMT+02:00 Carsten Ziegeler cziege...@apache.org:
+1
Carsten
2014-06-04 8:13 GMT+02:00 Ian Boston i...@tfd.co.uk:
+1
Signatures checked.
Ian
On 4 June 2014 07:06, Carsten Ziegeler
+1
On Tue, Jul 1, 2014 at 12:05 PM, Carsten Ziegeler cziege...@apache.org wrote:
It seems we're still missing a vote on this pretty old vote thread...
Carsten
2014-06-04 9:30 GMT+02:00 Carsten Ziegeler cziege...@apache.org:
+1
Carsten
2014-06-04 8:13 GMT+02:00 Ian Boston
[
https://issues.apache.org/jira/browse/SLING-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049008#comment-14049008
]
Carsten Ziegeler commented on SLING-3724:
-
Also implemented for scripting java
1 - 100 of 110 matches
Mail list logo
