[
https://issues.apache.org/jira/browse/SLING-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978638#comment-15978638
]
Jason E Bailey commented on SLING-3270:
---
The solution in stackoverflow was also the one that came up
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christophe Jelger updated SLING-6785:
-
Description:
Similar to the scopes of JEE beans
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christophe Jelger updated SLING-6785:
-
Description:
Similar to the scopes of JEE beans
Christophe Jelger created SLING-6785:
Summary: Add support for scoped lifecycle of sling models
Key: SLING-6785
URL: https://issues.apache.org/jira/browse/SLING-6785
Project: Sling
Issue
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978793#comment-15978793
]
Justin Edelson commented on SLING-6785:
---
Leaving aside the {{session}} and {{application}} scopes, I
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978813#comment-15978813
]
Jason E Bailey commented on SLING-6785:
---
I have concerns with the utility of this. It would be
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978814#comment-15978814
]
Christophe Jelger edited comment on SLING-6785 at 4/21/17 2:26 PM:
---
Just
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1597#comment-1597
]
Justin Edelson commented on SLING-6785:
---
[~jelger]
bq. Just to make sure, you also agree that we
I'm seeing a build warning when building the api bundle that
org.apache.sling.api.wrappers was changed from 2.6.0 to 2.6.1, but this
change was not necessary.
It looks like this was done in
http://svn.apache.org/viewvc?view=revision=1775427
Is there a reason for this that I'm missing?
Thanks,
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978814#comment-15978814
]
Christophe Jelger commented on SLING-6785:
--
Just to make sure this is clear, I do not mean that
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978821#comment-15978821
]
Justin Edelson commented on SLING-6785:
---
bq. Regarding your proposal, do you foresee that the scope
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978854#comment-15978854
]
Christophe Jelger commented on SLING-6785:
--
[~justinedelson] Actually {{scope="adaptable"}} seems
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978858#comment-15978858
]
Justin Edelson commented on SLING-6785:
---
[~jelger] the problem for me with {{scope="request"}} is
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978921#comment-15978921
]
Jason E Bailey commented on SLING-6785:
---
[~justinedelson] Wouldn't placing this in the
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978818#comment-15978818
]
Justin Edelson commented on SLING-6785:
---
[~jebailey] I see your concern, but wouldn't the model
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978872#comment-15978872
]
Christophe Jelger commented on SLING-6785:
--
[~justinedelson] Just to make sure, you also agree
the reason is in the log message:
"also increase third digit of package version because the contract of the
ValueMap impl changed (from wrong to correct behavior)"
if we think this does not justify or need a package version increment we can
just set it back to 2.6.0
stefan
>-Original
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-6785:
--
Attachment: SLING-6785.diff
Here's a diff of how this would look implemented in the
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978927#comment-15978927
]
Justin Edelson commented on SLING-6785:
---
[~jebailey] the cache is a WeakHashMap where the keys are
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978942#comment-15978942
]
Stefan Seifert edited comment on SLING-6785 at 4/21/17 3:43 PM:
please
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978973#comment-15978973
]
Justin Edelson commented on SLING-6785:
---
bq. but this does not seem to apply to current
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978942#comment-15978942
]
Stefan Seifert commented on SLING-6785:
---
please note that if the adaptable extends SlingAdaptable
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978980#comment-15978980
]
Stefan Seifert commented on SLING-6785:
---
{quote}
if we add a scoping/caching support via @Model
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978982#comment-15978982
]
Justin Edelson commented on SLING-6785:
---
bq. if the user does not set 'scope="adaptable"' and the
Sorry, I missed that part of the log message. This seems ok to me.
On Fri, Apr 21, 2017 at 10:58 AM Stefan Seifert
wrote:
> the reason is in the log message:
> "also increase third digit of package version because the contract of the
> ValueMap impl changed (from wrong to
25 matches
Mail list logo