[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-11-24 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265249#comment-16265249 ] Carsten Ziegeler commented on SLING-7043: - [~chetanm] Sure, although I have the feeling that we

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-11-24 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265185#comment-16265185 ] Chetan Mehrotra commented on SLING-7043: [~cziegeler] Would it be fine to move this to next

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-08-15 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128281#comment-16128281 ] Chetan Mehrotra commented on SLING-7043: I still do not think that current status is having a

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-08-14 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125544#comment-16125544 ] Carsten Ziegeler commented on SLING-7043: - I think we have two options: a) we add missing

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-08-14 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125420#comment-16125420 ] Bertrand Delacretaz commented on SLING-7043: I think this discussion should move to our dev

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-08-14 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125315#comment-16125315 ] Chetan Mehrotra commented on SLING-7043: Technically there is NOOP Metrics support also. So we

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-08-14 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125312#comment-16125312 ] Carsten Ziegeler commented on SLING-7043: - The Resource API provides an abstraction over multiple

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-08-14 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125306#comment-16125306 ] Chetan Mehrotra commented on SLING-7043: bq. but again it is totally flawed as we expose a way to

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-08-14 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125302#comment-16125302 ] Carsten Ziegeler commented on SLING-7043: - I understand the "intend" of our own abstraction - but

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-08-14 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125296#comment-16125296 ] Chetan Mehrotra commented on SLING-7043: Again trying to highlight what was discussed earlier

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-08-14 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125291#comment-16125291 ] Carsten Ziegeler commented on SLING-7043: - Let me ask this differently: when or why should code

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-08-13 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125268#comment-16125268 ] Chetan Mehrotra commented on SLING-7043: bq. it's now depending on two APIs (Slings metrics and

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-08-13 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125266#comment-16125266 ] Carsten Ziegeler commented on SLING-7043: - Let's look at a client of the metrics library: commons

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-08-13 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125258#comment-16125258 ] Chetan Mehrotra commented on SLING-7043: bq. Gauge does not seem to be implemented at all. Guage

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-08-13 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125257#comment-16125257 ] Carsten Ziegeler commented on SLING-7043: - I think the idea of a stable interface is now totally

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-08-13 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125238#comment-16125238 ] Chetan Mehrotra commented on SLING-7043: As mentioned in [1] the Metrics support has 2 users #

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-08-11 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123346#comment-16123346 ] Carsten Ziegeler commented on SLING-7043: - Why do we have the then sling commons metrics at all?

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

2017-08-11 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123220#comment-16123220 ] Chetan Mehrotra commented on SLING-7043: Export of MetricRegistry is required for other reporters