Re: svn commit: r585313 - /tomcat/tc6.0.x/trunk/STATUS

2007-10-17 Thread Rémy Maucherat
On Wed, 2007-10-17 at 05:47 +0200, Peter Rossbach wrote: Hi Remy, I think the patch is incomplete this line seem not correct: +else + JRE_HOME=/usr +fi better +else + JRE_HOME=/usr/bin/java +fi The path to the Java executable is $JRE_HOME/bin/java, so

Re: svn commit: r585313 - /tomcat/tc6.0.x/trunk/STATUS

2007-10-17 Thread Rémy Maucherat
On Wed, 2007-10-17 at 07:28 -0400, Tim Funk wrote: There was a request in bugzilla to pass in a new env variable called JAVA_EXE (or similar). Could that be an acceptable alternative? Then it would make the bug submitter happy since he can symlink my_program_that_i_can_see_in_ps to java.

Re: Mavenization (M10N) of Tomcat Build Process - Should Tomcat Be Migrated to Maven 2?

2007-10-17 Thread Rémy Maucherat
On Wed, 2007-10-17 at 16:21 -0400, Paul Shemansky wrote: It is not my intention to start a flame war between Ant and Maven users, but merely to propose Maven 2 to this group, and respectfully use this thread to discuss the advantages and disadvantages of switching Tomcat's build process within

New tag

2007-10-18 Thread Rémy Maucherat
Hi, As I stated a couple weeks ago, I think a new tag is needed. As a result, I propose creating a 6.0.15 tag at the end of this week (late Friday). Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands,

Re: [Fwd: [Security] - **Updated** Important vulnerability disclosed in Apache Tomcat webdav servlet]

2007-10-21 Thread Rémy Maucherat
On Sat, 2007-10-20 at 23:04 -0400, Mark Thomas wrote: The mitigations available are: - - Disable write access until a fixed version is released - - Limit write access to trusted users - - Apply the following patch which will be included in the next releases of 6.0.x, 5.5.x and 4.1.x Since

Re: svn commit: r588000 - /tomcat/tc6.0.x/trunk/STATUS

2007-10-24 Thread Rémy Maucherat
On Wed, 2007-10-24 at 20:39 -0300, Lucas Galfaso wrote: Hi all, I do not know what each of you actually thinks about this bug, but I would hardly consider this a must have, nor a show stopper (thing that I thought was the case for the next tomcat 6.0.x tag.) I feel a bit like you. I was

New tag

2007-10-29 Thread Rémy Maucherat
Hi, As the issue list seems relatively empty, I would like to tag 6.0.15 soon, probably late tomorrow. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Time to organise svn - Take 3

2007-11-01 Thread Rémy Maucherat
On Thu, 2007-11-01 at 10:03 +, Mark Thomas wrote: jean-frederic clere wrote: Why Friday? Shouldn't we wait until 6.0.15 (or 6.0.15 + n) is voted stable? We can do if that is the preference. My motivation is that I am keen to get back to a CTR codebase asap as I find only having RTC a

[VOTE] Release build 6.0.15

2007-11-05 Thread Rémy Maucherat
The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.15/ According to the release process, the 6.0.15 tag is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable Rémy - To unsubscribe, e-mail: [EMAIL

Re: Time to organise svn - Take 4

2007-11-06 Thread Rémy Maucherat
On Sun, 2007-11-04 at 16:10 +, Mark Thomas wrote: Do the (unless there is a pressing need - eg a major security issue) final stable release of 6.0.x. Freeze development of the 6.0.x branch. -1. Branches should continue to be open as long as committers want to propose patches and make

Re: Rough plan for Tomcat 8

2013-11-15 Thread Rémy Maucherat
2013/11/15 Mark Thomas ma...@apache.org The major refactorings planned for 8.0.x are complete. There are a few minor refactorings that can either done before the first stable release or (if they turn out to be a little bigger) left until 9.0.x. Cool. Since there was never a 7.1, I suppose

Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-13 Thread Rémy Maucherat
2013/12/13 Violeta Georgieva miles...@gmail.com I'm receiving NPE when testing an application with jsp that specifies tld location with relative path: java.lang.NullPointerException org.apache.jasper.compiler.TldCache.getTaglibXml(TldCache.java:97)

Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-13 Thread Rémy Maucherat
2013/12/13 Violeta Georgieva miles...@gmail.com I found another issue: If a tag file is placed in a jar file in WEB-INF/lib and then is used, the The change in the code is introduced with r1541960 Besides that the message is wrong because we check only for WEB-INF/tags [1], what should be

Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-13 Thread Rémy Maucherat
2013/12/13 Violeta Georgieva miles...@gmail.com Unfortunately with that fix I'm receiving FNF: java.io.FileNotFoundException: /META-INF/tags/my.tag org.apache.jasper.servlet.JspServletWrapper.loadTagFile(JspServletWrapper.java:235)

Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-13 Thread Rémy Maucherat
2013/12/13 Violeta Georgieva miles...@gmail.com Here [1] is the test [1] https://www.dropbox.com/s/3zd106lpqfb3ytv/test.zip Fixed. I didn't add the test yet since I suppose adding a binary should be avoided. Rémy

Re: [VOTE] Release Apache Tomcat 8.0.0-RC9

2013-12-18 Thread Rémy Maucherat
2013/12/18 Mark Thomas ma...@apache.org The proposed Apache Tomcat 8.0.0 release candidate 9 is now available for voting. Given this is a release candidate I am working on the basis that it is equivalent to an alpha. The main changes since RC5 are: - Better handling of generic types in the

Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-20 Thread Rémy Maucherat
2013/12/19 Mark Thomas ma...@apache.org The proposed 8.0.0-RC10 release is: [ ] Broken - do not release [X] Alpha - go ahead and release as 8.0.0-RC10 alpha Rémy

Re: svn commit: r1556071 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java

2014-01-08 Thread Rémy Maucherat
2014/1/8 Mark Thomas ma...@apache.org Tomcat only does this if the WriteListener is set via the CoyoteOutputStream. It does not do it if HTTP upgrade is used (which uses a lighter-weight ServletOutputStream). That looks like a bug that needs fixing. Yes, I saw after my commit there was code

Context switch integration

2014-01-14 Thread Rémy Maucherat
Hi, In Tomcat, entering a context is done simply by setting the context classloader and sometimes firing some random events (like the ones from the ServletRequestListener). This isn't so good for integration and could use improvements, in addition to at least one place where this is not done at

Re: Context switch integration

2014-01-15 Thread Rémy Maucherat
2014/1/15 Mark Thomas ma...@apache.org If folks integrating with Tomcat need to extend / replace what is currently in StandardContext.bindThread() and StandardContext.unbindThread() having a listener for this rather than having to extend StandardContext makes sense to me. Ok. I'm not

Re: svn commit: r1558930 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/authenticator/ java/org/apache/catalina/core/ java/org/apache/catalina/security/ java/org/apache/catalin

2014-01-17 Thread Rémy Maucherat
2014/1/17 Mark Thomas ma...@apache.org +protected static final ThreadBindingListener DEFAULT_NAMING_LISTENER = (new ThreadBindingListener() { +public void bind() {} +public void unbind() {} +}); +protected ThreadBindingListener threadBindingListener =

Re: Git

2014-01-21 Thread Rémy Maucherat
2014/1/21 Mark Thomas ma...@apache.org On the down side: - there is much more potential to mess things up Yes, I can help with that if you want :) - cleaning up is potentially more complex - the disruption of the move - particularly if we want to move to a single git repo - could be

Re: Git

2014-01-21 Thread Rémy Maucherat
2014/1/21 Mark Thomas ma...@apache.org Since we're considering big changes, what about Maven too ? I'll spare you the pros and cons. I still see more cons than pros for moving to Maven. It (mostly) works now and allows behaving better with bigger projects. IMO it is unavoidable now.

Re: Git

2014-01-21 Thread Rémy Maucherat
2014/1/21 Yoav Shapira yo...@apache.org Also +1 to separating the git vs svn discussion from the build system discussion (Maven, Ant, whatever.) (Side note: been using gradle recently, fun.) +1 Never used that Gradle yet though. Rémy

Re: Context switch integration

2014-01-22 Thread Rémy Maucherat
2014/1/22 Mark Thomas ma...@apache.org I've been looking at this some more with an eye to reducing code duplication. I think the thread binding listener could be merged with the ContainerListener. I can't see a good reason to keep them apart at this point. With this in mind, the changes I'm

Re: Context switch integration

2014-01-22 Thread Rémy Maucherat
2014/1/22 Konstantin Kolinko knst.koli...@gmail.com Thus I think that the calls to ContextBindings.bindThread(...) / unbindThread(...) as performed by those StandardContext methods are needed only during some initial set up. Using them as general methods would be a waste. Those methods are

Re: Context switch integration

2014-01-22 Thread Rémy Maucherat
2014/1/22 Mark Thomas ma...@apache.org I thought about that. There is some coupling between the entry and exit methods (the class loader) that the caller would need to retain and some standard try/finally plumbing. There is also an optimisation not to try to change the class loader if there

Re: Context switch integration

2014-01-23 Thread Rémy Maucherat
2014/1/23 Mark Thomas ma...@apache.org http://people.apache.org/~markt/dev/2014-01-23-tccl-tc8-v2.patch It was easier to write, removes more code and the result is easier to read. Unless there are objections I plan to commit this along with some additional work to migrate other code that is

Re: svn commit: r1560702 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsRemoteEndpointImplBase.java WsSession.java pojo/PojoEndpointBase.java

2014-01-23 Thread Rémy Maucherat
2014/1/23 Mark Thomas ma...@apache.org - Call onClose before actually closing anything (sending a close message closes the endpoint). -1 (veto) for a specification violation Section 2.1.5 requires that: the implementation must attempt to send the websocket close frame prior to calling

Re: svn commit: r1560702 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsRemoteEndpointImplBase.java WsSession.java pojo/PojoEndpointBase.java

2014-01-23 Thread Rémy Maucherat
2014/1/23 Mark Thomas ma...@apache.org I'd need to go back and check the archives but the I think the expectation from the EG was that onClose() would be used to clean up resources rather than anything else. It is always possible that I have misunderstood the intention of the spec here but

Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Rémy Maucherat
2014-01-28 Mark Thomas ma...@apache.org The proposed Apache Tomcat 8.0.0 release is now available for voting. This is the first non-RC release so I am leaving all the stability options open to get an idea of where folks think we currently stand. The main changes since RC10 are: - Fix

Re: [VOTE] Release Apache Tomcat 8.0.1

2014-01-30 Thread Rémy Maucherat
2014-01-30 Mark Thomas ma...@apache.org: The proposed 8.0.1 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.0.1 (alpha) [X] Beta - go ahead and release as 8.0.1 (beta) [ ] Stable - go ahead and release as 8.0.1 (stable) Rémy

Re: [VOTE][RESULT] Release Apache Tomcat 6.0.39

2014-01-31 Thread Rémy Maucherat
2014-01-31 Mark Thomas ma...@apache.org: stable (binding) : markt, rjung, kfujino, kkolinko stable (non-binding) : Ognjen Blagojevic This release vote therefore passes. Thanks to everyone who voted. I'll move the bits to dist/release now and announce this once the mirrors catch up.

Re: [VOTE][RESULT] Release Apache Tomcat 6.0.39

2014-01-31 Thread Rémy Maucherat
2014-01-31 Mark Thomas ma...@apache.org: Check the subject Remy. This is for 6.0.39, not 8.0.1. Hum. Ok :D Rémy

Re: [VOTE] Release Apache Tomcat 8.0.3

2014-02-10 Thread Rémy Maucherat
2014-02-07 19:16 GMT+01:00 Mark Thomas ma...@apache.org: The proposed 8.0.3 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.0.3 (alpha) [X] Beta - go ahead and release as 8.0.3 (beta) [ ] Stable - go ahead and release as 8.0.3 (stable) Rémy

NIO 2 connector

2014-03-04 Thread Rémy Maucherat
Hi, I've been working on porting a NIO2 connector that was originally developed for JBoss AS by Nabil Benothman (an intern at Red Hat). Due to the very different connector structure in Tomcat and my preference for basing it on the existing NIO1 connector, it is mostly new code, though. So I

Re: NIO 2 connector

2014-03-04 Thread Rémy Maucherat
2014-03-04 19:26 GMT+01:00 Mark Thomas ma...@apache.org: On 04/03/2014 16:16, Rémy Maucherat wrote: Hi, I've been working on porting a NIO2 connector that was originally developed for JBoss AS by Nabil Benothman (an intern at Red Hat). Due to the very different connector structure

Re: NIO 2 connector

2014-03-04 Thread Rémy Maucherat
2014-03-04 21:51 GMT+01:00 Mark Thomas ma...@apache.org: Can you wait until we split 8.0.x from trunk or did you want to get this into 8.0.x? Depends, if you want to branch soon or not. It would have to be experimental for a while anyway, but it will likely bring something useful.

Re: svn commit: r1574167 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2014-03-05 Thread Rémy Maucherat
2014-03-05 11:07 GMT+01:00 Konstantin Kolinko knst.koli...@gmail.com: In my opinion, this is wrong. One should not skip access logging. If context==null, it can be logged via CoyoteAdapter.log(...) that logs into (ROOT app or Host or Engine). Ok, I'll try to improve it. I see the call at the

Re: NIO 2 connector

2014-03-07 Thread Rémy Maucherat
2014-03-04 17:16 GMT+01:00 Rémy Maucherat r...@apache.org: The code is there (rebased to the current trunk): https://github.com/rmaucher/tomcat Updated commit here: https://github.com/rmaucher/tomcat/commit/614d8c43d8d1f3eeb4d5e4c2493ead589a72bf2c I have removed the two main hacks

Re: NIO 2 connector

2014-03-07 Thread Rémy Maucherat
2014-03-07 23:16 GMT+01:00 Konstantin Kolinko knst.koli...@gmail.com: 1. It is a month since release 8.0.3 and thus I think 8.0.4 is expected in a week or so.. I am -1 to destabilize 8.0.x now. As a new component, it is not supposed to destabilize the other components that are in 8.0. To

Re: Tomcat 8: Firing listeners from within a synchronized(writeLock) in onWritePossible()

2014-03-08 Thread Rémy Maucherat
2014-03-08 21:16 GMT+01:00 Konstantin Kolinko knst.koli...@gmail.com: My question is that these events are fired while holding a synchronized (writeLock) { lock. Is holding the writeLock lock is needed here. The on write possible event is processed by webapp's code. I think that in theory

Re: Tomcat 8: Firing listeners from within a synchronized(writeLock) in onWritePossible()

2014-03-10 Thread Rémy Maucherat
2014-03-10 10:36 GMT+01:00 Mark Thomas ma...@apache.org: I'm not convinced these write locks are needed, there should be no write concurrency in the first place. The explanation for why the lock is required is in the comments in the writeInternal() method. The lock is definitely required.

Re: NIO 2 connector

2014-03-10 Thread Rémy Maucherat
2014-03-10 14:03 GMT+01:00 Konstantin Kolinko knst.koli...@gmail.com: There are 52 warning shown by Eclipse IDE. Most of them are boxing/unboxing ones. To remind, the setting are documented here: res\ide-support\eclipse\java-compiler-errors-warnings.txt Ahah, ok, NIO2 does a lof of

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2014-03-11 Thread Rémy Maucherat
2014-03-10 22:16 GMT+01:00 build...@apache.org: The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5571 Buildbot URL: http://ci.apache.org/ Buildslave for this

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2014-03-11 Thread Rémy Maucherat
2014-03-11 13:14 GMT+01:00 Konstantin Kolinko knst.koli...@gmail.com: The only test that fails is org.apache.tomcat.util.net.TestSsl. Its failure repeats consistently (all 6 of 6 runs), with NIO2. BIO,NIO,APR connectors do not fail. [[[ Testsuite: org.apache.tomcat.util.net.TestSsl Tests

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2014-03-11 Thread Rémy Maucherat
2014-03-11 14:30 GMT+01:00 Konstantin Kolinko knst.koli...@gmail.com: That test never failed for me actually. It is a bit suspect that I've had almost no SSL problems overall with the new code, although reusing the NIO secure channel structure probably helped. Can you post the server

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2014-03-11 Thread Rémy Maucherat
2014-03-11 15:21 GMT+01:00 Konstantin Kolinko knst.koli...@gmail.com: Looking at org.apache.tomcat.util.net.TestSsl.testRenegotiateWorks(TestSsl.java:206) more closely, it is a broken test. +1 on the test being broken as it is now, for me it works because I don't get an IOE, but it is null

Re: [GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2014-03-12 Thread Rémy Maucherat
2014-03-12 15:44 GMT+01:00 Bill Barker billbar...@apache.org: Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/index.html So, after debugging it, I can confirm there's an issue with the test

Re: [VOTE] Release Apache Tomcat 8.0.4

2014-03-20 Thread Rémy Maucherat
2014-03-19 22:14 GMT+01:00 Mark Thomas ma...@apache.org: [X] Beta - go ahead and release as 8.0.4 (beta) [ ] Stable - go ahead and release as 8.0.4 (stable) This looks good enough to me to be Stable, but with this many fixes included it is likely there will be a couple hotfixes needed. I

Re: [VOTE] Release Apache Tomcat 8.0.4

2014-03-20 Thread Rémy Maucherat
2014-03-20 14:58 GMT+01:00 Mark Thomas ma...@apache.org: Unit tests hang for NIO2 on Windows (not an issue since NIO2 is still experimental) I got curious so I installed Java on my Windows. This didn't hang for me, and there were no failures on the big IO tests. Platform: Java 8 + Win 8.1-64

Re: [VOTE] Release Apache Tomcat 8.0.4

2014-03-21 Thread Rémy Maucherat
2014-03-21 10:42 GMT+01:00 Konstantin Kolinko knst.koli...@gmail.com: I am not voting yet. The test suite did pass successfully for BIO,NIO,APR,NIO2 with JDK 7u51 (32-bit) on Windows 7, except for the following test with NIO2:

Re: [VOTE] Release Apache Tomcat 8.0.4

2014-03-21 Thread Rémy Maucherat
2014-03-21 19:02 GMT+01:00 Christopher Schultz ch...@christopherschultz.net : It appears that the test has completely-stalled in NIO2 on Linux 2.6.32 x86_64 under Oracle's 1.7.0_45 JVM. I haven't run into trouble with that particular test yet. Some tests could use some timeout and clean fail,

Re: [VOTE] Release Apache Tomcat 8.0.4

2014-03-21 Thread Rémy Maucherat
2014-03-21 20:26 GMT+01:00 Christopher Schultz ch...@christopherschultz.net : I'll give it a try. It looks like I have another hang, the first time I (re)tried. Here is the tail of the console log: [junit] 21-Mar-2014 15:21:41.229 INFO [main] org.apache.coyote.AbstractProtocol.init

Re: svn commit: r1580821 - in /tomcat/trunk/webapps/docs: changelog.xml web-socket-howto.xml

2014-03-24 Thread Rémy Maucherat
2014-03-24 13:18 GMT+01:00 ma...@apache.org: Author: markt Date: Mon Mar 24 12:18:57 2014 New Revision: 1580821 URL: http://svn.apache.org/r1580821 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56304 WebSocket + BIO HTTP + Production = bad idea Shouldn't the BIO connector

Re: Connectors, blocking, and keepalive

2014-03-24 Thread Rémy Maucherat
2014-03-24 18:08 GMT+01:00 Mark Thomas ma...@apache.org: Given that this feature offers little/no benefit at the price of having to run through a whole pile of code only to end up back where you started, I'm tempted to hard-code the return value of breakKeepAliveLoop() to false for BIO HTTP.

Re: [VOTE] Release Apache Tomcat 8.0.5

2014-03-25 Thread Rémy Maucherat
2014-03-24 19:47 GMT+01:00 Mark Thomas ma...@apache.org: The proposed 8.0.5 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.0.5 (alpha) [X] Beta - go ahead and release as 8.0.5 (beta) [ ] Stable - go ahead and release as 8.0.5 (stable) I expect it will need

Re: Connectors, blocking, and keepalive

2014-03-25 Thread Rémy Maucherat
2014-03-25 15:57 GMT+01:00 Christopher Schultz ch...@christopherschultz.net : What about when an Executor is used, where the number of threads can fluctuate (up to a maximum) but are (or can be) also shared with other connectors? This is not really related, the connector stops using a thread

Re: [VOTE] Release Apache Tomcat 8.0.5

2014-03-25 Thread Rémy Maucherat
2014-03-24 19:47 GMT+01:00 Mark Thomas ma...@apache.org: - Various NIO2 fixes Along with some other fixes, I cleaned up some shutdown issues. It now looks ok in Linux, but there's one known issue on Windows: https://bugs.openjdk.java.net/browse/JDK-7056546 When testing on Windows traces like

Re: [ANN] ApacheCon NA 2013 Tomcat presentation videos available

2014-03-26 Thread Rémy Maucherat
2014-03-26 12:18 GMT+01:00 Mark Thomas ma...@apache.org: All, Most (all?) of the presentations from ApacheCon NA 2013 are now available on YouTube. To help you to navigate to the Tomcat presentations we have created this page: http://tomcat.apache.org/presentations.html Nice, I just went

Re: [ANN] ApacheCon NA 2013 Tomcat presentation videos available

2014-03-26 Thread Rémy Maucherat
2014-03-26 14:52 GMT+01:00 Mark Thomas ma...@apache.org: Yes, it is a solvable problem as long as you drop the self-imposed requirement to run on top of the Servlet API. Now the difficulties are understood, I'm beginning to think about dropping that requirement and using some of the Tomcat

Java 8 support

2014-03-26 Thread Rémy Maucherat
Hi, As I was looking at 55988, the testsuite seems to have two issues with Java 8 at the moment: - test.name=org/apache/tomcat/util/buf/TestUtf8.java UTF-8 experts wanted ! - test.name=org/apache/jasper/tagplugins/jstl/core/TestForEach.java This would look like a JDT configuration issue or bug,

Re: Java 8 support

2014-03-26 Thread Rémy Maucherat
2014-03-26 17:10 GMT+01:00 Konstantin Kolinko knst.koli...@gmail.com: 1. Can you cite what the errors are? An error occurred at line: [22] in the generated java file: [C:\Work\apache-tomcat-8.0.5-src\output\test-tmp\work\Tomcat\localhost\test\org\apache\jsp\bug5\bug54242_jsp.java] The

Re: [VOTE] Release Apache Tomcat Native 1.1.30

2014-04-10 Thread Rémy Maucherat
2014-04-10 13:50 GMT+02:00 Mladen Turk mt...@apache.org: The Apache Tomcat Native 1.1.30 is [X] Stable, go ahead and release [ ] Broken because of ... Rémy

NIO2 connector status

2014-04-10 Thread Rémy Maucherat
Hi, With some fixes in, I think the status is now better than what the welcome message says, which is: The NIO2 connector is currently EXPERIMENTAL and should not be used in production In preparation for the next build, I would like to update it to: The NIO2 connector is currently BETA and

CI

2014-04-17 Thread Rémy Maucherat
Hi, I'm a bit confused about the infra for CI. - ci.apache.org seems down - http://vmgump.apache.org/gump/public/tomcat-trunk/ does mostly the same, isn't down but apparently doesn't have a build status history; also it has a

Re: CI

2014-04-18 Thread Rémy Maucherat
2014-04-17 14:40 GMT+02:00 Martin Grigorov mgrigo...@apache.org: Hi, There are failed disks with BuildBot's master server (hostname: aegis). pctony (infra guy) said that they have ordered new ones and they will replace them today (US time ?!). Thanks for the info, but it looks like it is

NIO buffering

2014-04-18 Thread Rémy Maucherat
Hi, I am not convinced by the NIO buffering that is used on output. Due to concurrent access issues I couldn't use it in NIO 2, but then I cannot see either what it does to justify using a more complex structure over a simpler array list. If the idea was to reuse buffers (which it doesn't),

Re: NIO buffering

2014-04-23 Thread Rémy Maucherat
On Fri, Apr 18, 2014 at 1:30 PM, Rémy Maucherat r...@apache.org wrote: Hi, I am not convinced by the NIO buffering that is used on output. Due to concurrent access issues I couldn't use it in NIO 2, but then I cannot see either what it does to justify using a more complex structure over

Re: NIO buffering

2014-04-23 Thread Rémy Maucherat
2014-04-23 18:30 GMT+02:00 Mark Thomas ma...@apache.org: I'd agree with that assessment. I do remember having to be very careful with some of that code to get things working correctly. If there is a cleaner solution then I'd be all for it as long as performance is no worse. Mark [1]

Re: svn commit: r1589672 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ webapps/docs/

2014-04-24 Thread Rémy Maucherat
2014-04-24 15:04 GMT+02:00 Konstantin Kolinko knst.koli...@gmail.com: 2. AbstractEndpoint,unlockAccept() s.setSoLinger(getSocketProperties().getSoLingerOn(),getSocketProperties().getSoLingerTime()); I expect the above call to be broken because of NPE. I don't see the NPE, but that would

Re: Time for 8.0.6

2014-04-26 Thread Rémy Maucherat
2014-04-26 21:38 GMT+02:00 Mark Thomas ma...@apache.org: The remaining open 8.0.x bugs are related to cookie parsing and I don't plan on addressing them until at least after the next release. The remaining open 7.0.x issue doesn't affect 8.0.x The remaining open 6.0.x issues don't affect

Re: Time for 8.0.6

2014-04-27 Thread Rémy Maucherat
2014-04-27 0:41 GMT+02:00 Mark Thomas ma...@apache.org: Agreed, but that it out of our control. However, I'm seeing some fairly consistent failures with NIO2 and TestCoyoteAdapter.testBug54928 that I'd like to get to the bottom of. It doesn't (usually) fail if I run the test on its own but

Re: Time for 8.0.6

2014-04-28 Thread Rémy Maucherat
2014-04-28 11:12 GMT+02:00 Mark Thomas ma...@apache.org: This test never fails for me. However, the behavior is not identical to NIO (you need more output before getting an IOE, for some reason) so I added more wait. Oddly, it only fails for me on a VM. I'm still trying to get to the

Re: Time for 8.0.6

2014-04-29 Thread Rémy Maucherat
2014-04-27 1:03 GMT+02:00 Konstantin Kolinko knst.koli...@gmail.com: If someone is able to edit Buildbot configuration, maybe it is possible to skip that RAT report publishing step? The build is now going further, but it seems a folder is missing.

Re: Proposed patch for JDTCompiler

2014-05-10 Thread Rémy Maucherat
2014-05-06 19:25 GMT+02:00 Christopher Schultz ch...@christopherschultz.net : Since this is not really a bug per se, I decided not to create a BZ issue. If it would be easier for everyone if I attached the patch to a BZ issue I'm happy to do that as well. Ok, but this is not a review then

Re: svn commit: r1593303 - /tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

2014-05-11 Thread Rémy Maucherat
2014-05-08 16:55 GMT+02:00 ma...@apache.org: Author: markt Date: Thu May 8 14:55:08 2014 New Revision: 1593303 URL: http://svn.apache.org/r1593303 Log: Fix test failure with NIO2 where additional, unexpected access log entry was being created during connector shutdown. I didn't run

Re: Plans for 8.0.6

2014-05-12 Thread Rémy Maucherat
2014-05-12 14:33 GMT+02:00 Mark Thomas ma...@apache.org: Over the weekend I ran the unit tests for BIO, NIO and APR on OSX, Win64 and Linux64 and they all passed. My plans for 8.0.6 are therefore: - work through the backlog of messages that built up during the mail server outage; - fix any

Re: svn commit: r1593303 - /tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

2014-05-12 Thread Rémy Maucherat
2014-05-12 16:25 GMT+02:00 Mark Thomas ma...@apache.org: In terms of whether there is a better place, I didn't look lower down the stack. We probably only want to swallow this if we haven't read any part of the request line. Ok, I'll add back the two try/catch I removed, I should have

Re: Plans for 8.0.6

2014-05-12 Thread Rémy Maucherat
2014-05-12 16:39 GMT+02:00 Mark Thomas ma...@apache.org: I just got to that. I've answered your immediate question but I want to do a little more digging of my own. I'll respond in more detail on that thread. That said, I'm not expecting NIO2 to be declared stable in this release so I don't

Re: Plans for 8.0.6

2014-05-13 Thread Rémy Maucherat
2014-05-13 9:37 GMT+02:00 Mark Thomas ma...@apache.org: I'm running the unit tests now. I want to look at BZ 56516 some more and I don't want to hold up a 8.0.x release any longer. There's nothing to look at IMO, the guy is using scriptlets and expects things to work with the tag variable.

Re: svn commit: r1594436 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ webapps/docs/

2014-05-14 Thread Rémy Maucherat
2014-05-14 2:44 GMT+02:00 kkoli...@apache.org: Author: kkolinko Date: Wed May 14 00:44:33 2014 New Revision: 1594436 URL: http://svn.apache.org/r1594436 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56399 When recycling a Coyote request, ensure that Catalina request have

Re: [VOTE] Release Apache Tomcat 8.0.6

2014-05-14 Thread Rémy Maucherat
2014-05-14 13:39 GMT+02:00 Mark Thomas ma...@apache.org: - Further NIO2 fixes which is now considered BETA Thanks for the testing and fixes. The proposed 8.0.6 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.0.6 (alpha) [X] Beta - go ahead and release as

Re: [VOTE] Release Apache Tomcat 8.0.6

2014-05-16 Thread Rémy Maucherat
2014-05-16 14:42 GMT+02:00 Jeanfrancois Arcand jfarcand@gmail.com: Seems https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.6/ is private as I do get a Not Found https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.7/ But I would have waited a bit for some more testing.

Re: svn commit: r1594436 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ webapps/docs/

2014-05-17 Thread Rémy Maucherat
2014-05-15 14:57 GMT+02:00 Mark Thomas ma...@apache.org: Konstantin, (bcc'd directly as list mail still seems to be delayed by 8-12 hours) It looks like I am going to need to tag a new 8.0.x release as DBCP is currently broken. Please can you revert this commit as per Remy's veto ASAP so I

Re: [VOTE] Release Apache Tomcat 6.0.40

2014-05-18 Thread Rémy Maucherat
2014-05-15 16:14 GMT+02:00 Mark Thomas ma...@apache.org: The proposed 6.0.40 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 6.0.40 Stable Great job on clearing up all the issues. Rémy

Re: [VOTE] Release Apache Tomcat 8.0.8

2014-05-18 Thread Rémy Maucherat
2014-05-16 22:55 GMT+02:00 Mark Thomas ma...@apache.org: The proposed 8.0.8 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.0.8 (alpha) [X] Beta - go ahead and release as 8.0.8 (beta) [ ] Stable - go ahead and release as 8.0.8 (stable) Looking good. Rémy

Re: [VOTE] Release Apache Tomcat 8.0.8

2014-05-19 Thread Rémy Maucherat
2014-05-19 14:51 GMT+02:00 Mark Thomas ma...@apache.org: Unit tests all pass for BIO, NIO and APR/native on Linux, OSX and Windows with 64-bit Java. NIO2 included ? I've come the conclusion the the cookie work - if done carefully - can be done without destabilising 8.0.x therefore I am

Re: [VOTE] Release Apache Tomcat 6.0.41

2014-05-21 Thread Rémy Maucherat
2014-05-19 14:58 GMT+02:00 Mark Thomas ma...@apache.org: The proposed 6.0.41 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 6.0.41 Stable Rémy

Re: [VOTE] Release Apache Tomcat 7.0.54

2014-05-21 Thread Rémy Maucherat
2014-05-20 12:04 GMT+02:00 Violeta Georgieva violet...@apache.org: The proposed 7.0.54 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 7.0.54 Stable Rémy

Re: Error handling

2014-05-29 Thread Rémy Maucherat
2014-05-29 14:31 GMT+02:00 Mark Thomas ma...@apache.org: There are four variations: 1. Content length set, some content written, response not committed. 2. Content length set, some content written, response committed. 3. Content length not set, some content written, response not committed.

Re: svn commit: r1598483 - in /tomcat/trunk/webapps: docs/changelog.xml examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java examples/WEB-INF/classes/websocket/echo/EchoStreamAnnotation.ja

2014-06-01 Thread Rémy Maucherat
2014-05-31 0:47 GMT+02:00 Konstantin Kolinko knst.koli...@gmail.com: I fixed svn:eol-style and other issues in r1598763 Sorry for that problem. What I do not like here is that it is not clear how to use these classes. They are not referenced in public examples html pages, not used in unit

Re: svn commit: r1600950 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java webapps/docs/changelog.xml

2014-06-06 Thread Rémy Maucherat
2014-06-06 18:14 GMT+02:00 r...@apache.org: Author: remm Date: Fri Jun 6 16:14:44 2014 New Revision: 1600950 URL: http://svn.apache.org/r1600950 Log: Try removing the beta tag from the NIO2 connector to get more feedback, after the latest round of fixes. In practice since it is not used

Re: svn commit: r1600950 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java webapps/docs/changelog.xml

2014-06-06 Thread Rémy Maucherat
2014-06-06 18:39 GMT+02:00 Konstantin Kolinko knst.koli...@gmail.com: 1. Doesn't it feel too early? Maybe, but tests pass and no reports. 2. You only removed a startup warning. I think the documentation still labels it as beta. This could be a good middle ground. Rémy

Re: svn commit: r1602159 - in /tomcat/trunk/java/org/apache/catalina/loader: LocalStrings.properties LocalStrings_es.properties WebappClassLoader.java

2014-06-12 Thread Rémy Maucherat
2014-06-12 15:54 GMT+02:00 Mark Thomas ma...@apache.org: -1. These log messages indicate problems that users need to do something to fix. While I've no problem with reducing error - warning, logging them at info is not acceptable. Ok. This indicates a potential leak, about which the user

Re: svn commit: r1603274 - /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java

2014-06-17 Thread Rémy Maucherat
2014-06-17 22:36 GMT+02:00 Mark Thomas ma...@apache.org: There are some large messages in the Autobahn tests (multi-MB). On reflection I think it will be easier to just disable it again. Good job on fixing the example, I couldn't see anything wrong with it ! Besides that IMO it should remain

Re: [VOTE] Release Apache Tomcat 8.0.9

2014-06-19 Thread Rémy Maucherat
2014-06-19 16:00 GMT+02:00 Mark Thomas ma...@apache.org: The proposed 8.0.9 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.0.9 (alpha) [ ] Beta - go ahead and release as 8.0.9 (beta) [X] Stable - go ahead and release as 8.0.9 (stable) Tests are ok,

Re: [PROPOSAL] Drop comet support in Tomcat 9 onwards

2014-06-19 Thread Rémy Maucherat
2014-06-18 23:40 GMT+02:00 Mark Thomas ma...@apache.org: I have been thinking about connector refactoring for Tomcat 9. Currently BIO is planned to be dropped due to the number of features in the servlet spec that rely on non-blocking IO. I would like to propose dropping support for Comet in

Re: Possible TomEE release news?

2014-06-25 Thread Rémy Maucherat
2014-06-24 20:02 GMT+02:00 David Blevins david.blev...@gmail.com: Wonder what people's thoughts are about possibly including TomEE releases in the Tomcat news feed on occasion? Having some mention of TomEE on tomcat.apache.org would be nice -- most users still do not know it exists.

Re: svn commit: r1605723 - /tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java

2014-06-26 Thread Rémy Maucherat
2014-06-26 13:32 GMT+02:00 Konstantin Kolinko knst.koli...@gmail.com: What are the circumstances when this NPE happens? StandardRoot.initInternal() throws an IllegalStateException if the context is null. How can it be without a context? Avoid NPE with storeconfig: storeconfig creates

  1   2   3   4   5   6   7   8   9   10   >