[Bug 60927] JMX domain name for embed tomcat is inconsistent with standard tomcat

2017-03-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60927

Huxing Zhang  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60927] JMX domain name for embed tomcat is inconsistent with standard tomcat

2017-03-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60927

--- Comment #3 from Huxing Zhang  ---
(In reply to Mark Thomas from comment #2)
> It has been this way since the class was first introduced some 8+ years ago.

I don't know that exists for so long time until you mentioned.

> Users have always been able to change the names if they wish to do so.

Yes, with only following 2 lines of code:

Tomcat tomcat = new Tomcat();
tomcat.getEngine().setName("Catalina");

Note that the following code won't work:

Tomcat tomcat = new Tomcat();
tomcat.getService().setName("Catalina");

What I thought is sth. likes this:

Tomcat tomcat = new Tomcat("Catalina");

But there is no much difference.

> 
> Experience has shown that changing the default JMX name of a component in a
> point release breaks JMX monitoring for existing users. That limits any
> change to 9.0.x only and it will still break things for existing 9.0.x users.

It looks reasonable to me.

> Given that this is only a default, it doesn't look to me as if the benefit
> outweighs the risk.

Agreed.

I will withdraw this proposal, our monitoring tools has been updated using the
above workaround.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60927] JMX domain name for embed tomcat is inconsistent with standard tomcat

2017-03-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60927

--- Comment #2 from Mark Thomas  ---
It has been this way since the class was first introduced some 8+ years ago.
Users have always been able to change the names if they wish to do so.

Experience has shown that changing the default JMX name of a component in a
point release breaks JMX monitoring for existing users. That limits any change
to 9.0.x only and it will still break things for existing 9.0.x users.

Given that this is only a default, it doesn't look to me as if the benefit
outweighs the risk.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60927] JMX domain name for embed tomcat is inconsistent with standard tomcat

2017-03-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60927

--- Comment #1 from Huxing Zhang  ---
One of the workaround might be: 
1) call javax.management.MBeanServer#queryNames('*:type=Server', null) to get a
set of possible object names.
2) iterate through all the possible object names and get the info you want.

But I feel that providing the ability to config domain name in embeded tomcat
is still useful, at least it allows the user the simplify the way getting
information via JMX.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org