markt-asf commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1953742188
You're welcome. I didn't do much here. I just tweaked the original PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Hakky54 commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1953299389
Hi @markt-asf I just wanted to thank you. I noticed the latest version
10.1.19 is available since today. I tried it out and it works, amazing work!
--
This is an automated message from
Hakky54 commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1932206483
Thank you mate, I really appreciate this! Big kudos! 拾
I am looking forward to the new release!
--
This is an automated message from the Apache Git Service.
To respond to the message,
markt-asf commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1932089608
OK, it is in main. I'll back-port as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
markt-asf commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1931990842
I have some ideas on how to address this. I might have a fix for this soon
that takes account of the lifecycle issues.
--
This is an automated message from the Apache Git Service.
To
Hakky54 commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1931967568
Ah that is pity, I was looking forward to it. You have a better overview of
the issues which it can cause to other functionalities. I was not aware of the
lifecycle management and only
markt-asf commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1931686883
I was tempted to merge this but having reviewed the Tomcat code I think this
is going to create problems - the main one being that Tomcat clears the
SSLContext on Connector.stop() when
markt-asf closed pull request #673: Added option to use custom SSLContext
URL: https://github.com/apache/tomcat/pull/673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Hakky54 commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1929460593
Hi team, is there any progress on this topic. Is there something what I can
do on my side? Like backporting to other branches or anything else maybe?
--
This is an automated message from
KoteswararaoGundapaneni commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1816164863
Requesting to panel the change request to be considering and request has
been taken care by the process that's done above
--
This is an automated message from the Apache
Hakky54 commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1777163986
I am not sure whether you would consider to have this option at all. Would
you prefer me to close the issue?
--
This is an automated message from the Apache Git Service.
To respond to
Hakky54 commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1772265010
I see indeed clearly that it was not the intention of the
developers/maintainers to expose a setter method to set a custom sslcontext
which is later on ignored. As it is clearly not a bug
rmaucher commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1772201584
It doesn't work like that because it was not supposed to. The item that
is/was supposed to be configured is the SSLImplementation, which then provides
the SSLUtil which will create the
13 matches
Mail list logo
