Re: [VOTE] Release Apache Tomcat 8.5.13

2017-03-30 Thread Rainer Jung

Am 27.03.2017 um 17:13 schrieb Mark Thomas:

The proposed Apache Tomcat 8.5.13 release is now available for voting.

The major changes compared to the 8.5.12 release are:

- Various HTTP/2 improvements

- Fixes for sendfile related issues that could cause subsequent requests
  to experience IllegalStateExceptions

- Servlet 4.0 updates


It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.13/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1126/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_13/

The proposed 8.5.13 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 8.5.13


I know the vote is over but for the sake of completeness:

+1 to release.

Details
===

- SHA1 and MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src consistent with svn tag
  - except bin shell scripts are not executable in src tarball
(not critical)
- builds fine
  - warning about unchecked calls or conversions in:
- org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
- org/apache/tomcat/jdbc/pool/PoolProperties.java
  Not a regression
- build result looks consistent with binaries
- no checkstyle complaints
- no Javadoc warnings

- Unit tests: No failures

  - WARN messages:
- less Tribes warnings (72 versus 62)
- less 
"org.apache.catalina.loader.WebappClassLoaderBase.clearReferencesThreads 
The web application [ROOT] is still processing a request that has yet to 
finish. This is very likely to create a memory leak. You can control the 
time allowed for requests to finish by using the unloadDelay attribute 
of the standard Context implementation. Stack trace of request 
processing thread:" (4 versus 2)
- no more "org.apache.tomcat.util.net.Nio2Endpoint.shutdownExecutor 
The executor associated with thread pool [http-nio2-127.0.0.1-auto-I] 
has not fully shutdown. Some application threads may still be running." 
(2 versus 0)


  - SEVERE message
- less "org.apache.coyote.http11.Http11Processor.service Error 
processing request" (nio2 3 versus 2)
- slight change in 
"org.apache.coyote.http11.Http11Processor.endRequest Error finishing 
response" (nio 1 versus 2, nio2 1 versus 0)
- more 
"org.apache.coyote.AbstractProtocol$ConnectionHandler.process Error 
reading request, ignored" (apr 4 versus 5)
- slight change in 
"org.apache.catalina.connector.CoyoteAdapter.asyncDispatch Exception 
while processing an asynchronous" (apr 1 versus 0, io 0 versus 1)
- more "org.apache.tomcat.util.net.AprEndpoint$Poller.run Poller 
failed with error [9] : [Bad file number]" (apr 1 versus 2)

- minor changes for Tribes

  - Exceptions
- fewer java.io.IOException in apr (5 versus 4)
- more "java.io.IOException: Broken pipe" (11 versus 12)
- "org.apache.catalina.connector.CoyoteAdapter.asyncDispatch 
Exception while processing an asynchronous request" (1 moved from apr to 
nio)

- more "java.net.ConnectException" in tribes (2 versus 3)
- more "java.nio.channels.ClosedChannelException" (5 versus 6)
- fewer "java.lang.NullPointerException" (9 versus 7)
- fewer "org.apache.catalina.tribes.ChannelException: Sender not 
connected.; No faulty members identified." (8 versus 7)
- new "java.lang.IllegalStateException: Calling [asyncComplete()] 
is not valid for a request with Async state [MUST_COMPLETE]" (once)
- new 
"org.apache.catalina.tribes.transport.nio.NioReplicationTask.run 
IOException in replication worker, unable to drain channel. Probable 
cause: Keep alive socket closed[null]." (once)


- JMX MBean Comparison with 8.5.12:
  - ProtocolHandler MBean new attribute "sendReasonPhrase: false"
- attribute compressableMimeTypes additional list elements
  "application/json" and "application/xml" as expected
- attribute compressibleMimeType String
  ",application/json,application/xml" appended to value
  as expected
- for http additional attributes "truststoreType: JKS",
  "trustMaxCertLength: 10", "truststoreAlgorithm: PKIX",
  "algorithm: SunX509", "sSLDisableSessionTickets: false",
  "sessionCacheSize: 0", "keystoreType: JKS",
  "sslProtocol: TLS", "sSLVerifyDepth: 10",
  "clientAuth: NONE", "sSLVerifyClient: NONE",
  "ciphers: HIGH:!aNULL:!eNULL:!EXPORT:!DES:!RC4:!MD5:!kRSA",
  "sSLCipherSuite: HIGH:!aNULL:!eNULL:!EXPORT:!DES:!RC4:!MD5:!kRSA",
  "sSLDisableCompression: true", "keystoreFile: /home/.../.keystore",
  "sessionTimeout: 86400",
  "compressibleMimeType: text/html,text/xml,text/plain,text/css,text",
  "compressibleMimeTypes" (same as compressibleMimeType but as a 
String Array)
  - Connector MBean new attribute "ciphers: 
HIGH:!aNULL:!eNULL:!EXPORT:!DES:!RC4:!MD5:!kRSA:!DHE"

  - Logging MBean: three new loggers,
"org.apache.tomcat.util.net",
"org.apache.tomcat.util.net.SSLHostConfig",

Re: [VOTE] Release Apache Tomcat 8.5.13

2017-03-29 Thread Mark Thomas
On 27/03/17 16:13, Mark Thomas wrote:
> The proposed 8.5.13 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.13


Unit tests pass for NIO, NIO2 and APR/native (1.2.12) on Windows, Linux
and OSX.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.13

2017-03-29 Thread Coty Sutherland
On Mon, Mar 27, 2017 at 11:13 AM, Mark Thomas  wrote:
> The proposed Apache Tomcat 8.5.13 release is now available for voting.
>
> The major changes compared to the 8.5.12 release are:
>
> - Various HTTP/2 improvements
>
> - Fixes for sendfile related issues that could cause subsequent requests
>   to experience IllegalStateExceptions
>
> - Servlet 4.0 updates
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.13/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1126/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_13/
>
> The proposed 8.5.13 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.5.13

+1

> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.13

2017-03-29 Thread Keiichi Fujino
2017-03-28 0:13 GMT+09:00 Mark Thomas :

> The proposed Apache Tomcat 8.5.13 release is now available for voting.
>
> The major changes compared to the 8.5.12 release are:
>
> - Various HTTP/2 improvements
>
> - Fixes for sendfile related issues that could cause subsequent requests
>   to experience IllegalStateExceptions
>
> - Servlet 4.0 updates
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.13/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1126/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_13/
>
> The proposed 8.5.13 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.13
>
>
+1
Tested on some test applications (use jdbc-pool).

-
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
> --
> Keiichi.Fujino
> 




Re: [VOTE] Release Apache Tomcat 8.5.13

2017-03-29 Thread Felix Schumacher


Am 27. März 2017 17:13:51 MESZ schrieb Mark Thomas :
>The proposed Apache Tomcat 8.5.13 release is now available for voting.
>
>The major changes compared to the 8.5.12 release are:
>
>- Various HTTP/2 improvements
>
>- Fixes for sendfile related issues that could cause subsequent
>requests
>  to experience IllegalStateExceptions
>
>- Servlet 4.0 updates
>
>
>It can be obtained from:
>https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.13/
>The Maven staging repo is:
>https://repository.apache.org/content/repositories/orgapachetomcat-1126/
>The svn tag is:
>http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_13/
>
>The proposed 8.5.13 release is:
>[ ] Broken - do not release
>[x] Stable - go ahead and release as 8.5.13

Felix

>
>-
>To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>For additional commands, e-mail: dev-h...@tomcat.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.13

2017-03-29 Thread Rémy Maucherat
2017-03-27 17:13 GMT+02:00 Mark Thomas :

> The proposed Apache Tomcat 8.5.13 release is now available for voting.
>
> The major changes compared to the 8.5.12 release are:
>
> - Various HTTP/2 improvements
>
> - Fixes for sendfile related issues that could cause subsequent requests
>   to experience IllegalStateExceptions
>
> - Servlet 4.0 updates
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.13/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1126/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_13/
>
> The proposed 8.5.13 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.13
>
> Rémy


Re: [VOTE] Release Apache Tomcat 8.5.13

2017-03-29 Thread Martin Grigorov
On Mon, Mar 27, 2017 at 5:13 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.13 release is now available for voting.
>
> The major changes compared to the 8.5.12 release are:
>
> - Various HTTP/2 improvements
>
> - Fixes for sendfile related issues that could cause subsequent requests
>   to experience IllegalStateExceptions
>
> - Servlet 4.0 updates
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.13/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1126/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_13/
>
> The proposed 8.5.13 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.5.13
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.13

2017-03-28 Thread Violeta Georgieva
Hi,

2017-03-27 18:13 GMT+03:00 Mark Thomas :
>
> The proposed Apache Tomcat 8.5.13 release is now available for voting.
>
> The major changes compared to the 8.5.12 release are:
>
> - Various HTTP/2 improvements
>
> - Fixes for sendfile related issues that could cause subsequent requests
>   to experience IllegalStateExceptions
>
> - Servlet 4.0 updates
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.13/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1126/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_13/
>
> The proposed 8.5.13 release is:
> [ ] Broken - do not release

[X] Stable - go ahead and release as 8.5.13

My tests passed.

Regards,
Violeta

>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>