Re: [VOTE] Release Apache Tomcat 9.0.0.M22

2017-06-26 Thread Mark Thomas 
On 23/06/17 07:24, Huxing Zhang wrote:
> Hi,
> 
> The proposed 9.0.0.M22 release is:
> [ ] Broken - do not release
> [ X ] Alpha - go ahead and release as 9.0.0.M22
> 
> Unit test passed.
> Our test web application works fine.
> 
> 1. There is a typo in trailers.ResponseTrailers, I will fix that later.
> 2. Actually I have a concern of the trailer field implementation. Should we 
> add an extra whitespace between the trailer field name and trailer field, 
> just to keep align with the head field format?

We should be consistent so no objections to the space being added.

Mark


> 
> In rfc7230 section 4.1.2 says the white space is optional.
> header-field   = field-name ":" OWS field-value OWS
> 
> But right now the format is inconsistent between header and trailer field.
> 
> Examples: 
> 
> Escape character is '^]'.
> GET /examples/servlets/trailers/response HTTP/1.1
> Host: hsf.taobao.net:8180
> User-Agent: curl/7.47.0
> Accept: */*
> 
> HTTP/1.1 200
> Content-Type: text/plain;charset=UTF-8
> Transfer-Encoding: chunked
> Date: Fri, 23 Jun 2017 05:49:14 GMT
> 
> 2b
> This reponse should include trailer fields.
> 0
> x-trailer-2:Trailer value two
> x-trailer-1:Trailer value one
> 
> BTW, Jetty[1] has an white space between trailer field name and value. 
> https://webtide.com/http-trailers-in-jetty/
> 
> --
> From:Mark Thomas 
> Time:2017 Jun 21 (Wed) 22:18
> To:Tomcat Developers List 
> Subject:[VOTE] Release Apache Tomcat 9.0.0.M22
> 
> 
> The proposed Apache Tomcat 9.0.0.M22 release is now available for voting.
> 
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
> 
> The major changes compared to the 9.0.0.M21 release are:
> 
> - Add a new JULI FileHandler configuration for specifying the maximum
>   number of days to keep the log files. By default the log files will be
>   kept 90 days.
> 
> - Update the Servlet 4.0 implementation to add support for setting
>   trailer fields for HTTP responses.
> 
> - When pre-compiling with JspC, report all compilation errors rather
>   than stopping after the first error.
> 
> Along with lots of other bug fixes and improvements
> 
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M22/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1137/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M22/
> 
> The proposed 9.0.0.M22 release is:
> [ ] Broken - do not release
> [ ] Alpha - go ahead and release as 9.0.0.M22
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M22

2017-06-26 Thread Mark Thomas 
On 21/06/17 15:18, Mark Thomas wrote:
> The proposed Apache Tomcat 9.0.0.M22 release is now available for voting.
> 
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
> 
> The major changes compared to the 9.0.0.M21 release are:
> 
> - Add a new JULI FileHandler configuration for specifying the maximum
>   number of days to keep the log files. By default the log files will be
>   kept 90 days.
> 
> - Update the Servlet 4.0 implementation to add support for setting
>   trailer fields for HTTP responses.
> 
> - When pre-compiling with JspC, report all compilation errors rather
>   than stopping after the first error.
> 
> Along with lots of other bug fixes and improvements
> 
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M22/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1137/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M22/
> 
> The proposed 9.0.0.M22 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 9.0.0.M22

Tests passed for NIO, NIO2 and APR/native on Windows, Linux and OSX.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M22

2017-06-24 Thread Felix Schumacher 


Am 21. Juni 2017 16:18:39 MESZ schrieb Mark Thomas :
>The proposed Apache Tomcat 9.0.0.M22 release is now available for
>voting.
>
>This is a milestone release for the 9.0.x branch. It should be
>noted that, as a milestone release:
>- Servlet 4.0 is not finalised
>- The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
>The major changes compared to the 9.0.0.M21 release are:
>
>- Add a new JULI FileHandler configuration for specifying the maximum
> number of days to keep the log files. By default the log files will be
>  kept 90 days.
>
>- Update the Servlet 4.0 implementation to add support for setting
>  trailer fields for HTTP responses.
>
>- When pre-compiling with JspC, report all compilation errors rather
>  than stopping after the first error.
>
>Along with lots of other bug fixes and improvements
>
>For full details, see the changelog:
>http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
>It can be obtained from:
>https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M22/
>The Maven staging repo is:
>https://repository.apache.org/content/repositories/orgapachetomcat-1137/
>The svn tag is:
>http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M22/
>
>The proposed 9.0.0.M22 release is:
>[ ] Broken - do not release
>[x] Alpha - go ahead and release as 9.0.0.M22

Felix

>
>-
>To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>For additional commands, e-mail: dev-h...@tomcat.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M22

2017-06-24 Thread Rainer Jung 

Am 21.06.2017 um 16:18 schrieb Mark Thomas:

The proposed 9.0.0.M22 release is:
[ ] Broken - do not release
[X] Alpha - go ahead and release as 9.0.0.M22


+1 to release as alpha.

Details
===

- SHA1 and MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src consistent with svn tag
  - except bin shell scripts are not executable in src tarball
(not critical)
- builds fine
- build result looks consistent with binaries
- no checkstyle complaints
- no Javadoc warnings

- JMX MBean Comparison with 9.0.0.M21 (same as M20):

  - Filter MBeans for SetCharacterEncodingFilter are gone
  (webapps manager, host-manager and examples)
This is due to r1798121 and r1798125

  - New Servlet MBean "responsetrailer" in examples webapp
This is due to r1796186

  - Manager MBean attribute sessionAttributeValueClassNameFilter added
for webapp manager and host-manager with value
java\.lang\.(?:Boolean|Integer|Long|Number|String)|org\.apache\.catalina\.filters\.CsrfPreventionFilter\$LruCache(?:\$1)?|java\.util\.(?:Linked)?HashMap
This is due to BZ61150, r1798384

  - one more thread is started

  - MBean java.util.logging:type=Logging has three items removed
from the LoggerNames array: org.apache.catalina.session,
org.apache.catalina.session.ManagerBase and
org.apache.catalina.session.StandardManager

- Unit tests: No failures, below comparisons are against M20 and M21. 
Numbers are given for M20 / M21 / M22.


  - Exceptions:

- new java.lang.IllegalStateExceptions:

  - M21 (both once):
java.lang.IllegalStateException: Calling [asyncComplete()] is 
not valid for a request with Async state [MUST_COMPLETE]

java.lang.IllegalStateException: Unexpected read state [CLOSING]
  - M22 (twice):
Exception in thread "testBug54928" 
java.lang.IllegalStateException: Calling [asyncComplete()] is not valid 
for a request with Async state [MUST_ERROR]


- changed in M22 (was 2 / 1):
org.apache.catalina.core.StandardHostValve.invoke Exception Processing 
/simple

  instead now once
org.apache.catalina.core.StandardWrapperValve.invoke Servlet.service() 
for servlet [simple] in context with path [] threw exception

  and the exception is
[junit]  java.io.IOException: Stream reset
[junit] at 
org.apache.coyote.http2.Stream$StreamInputBuffer.doRead(Stream.java:866)

[junit] at org.apache.coyote.Request.doRead(Request.java:526)
...

- 20 / 26 / 22 java.lang.NullPointerException

- java.io.IOException

  - new in M22 (once)
java.security.cert.CertificateException: Could not parse certificate: 
java.io.IOException: Incomplete data

Caused by: java.io.IOException: Incomplete data

  - 4 / 3 / 3
java.io.IOException: The socket [NUMBER] associated with this connection 
has been closed.


  - 6 / 5 / 6
java.io.IOException: java.io.IOException: Unexpected error [NUMBER] 
writing data to the APR/native socket [NUMBER] with wrapper 
[org.apache.tomcat.util.net.AprEndpoint$AprSocketWrapper@HEX:NUM].


  - 12 / 12 / 11
java.io.IOException: java.io.IOException: Broken pipe

  - 2 / 2 / 3
Caused by: java.io.IOException: Connection reset by peer

- 2 / 1 / 2 java.io.EOFException

- only in M21 (once) 
java.util.concurrent.RejectedExecutionException: Executor not running, 
can't force a command into the queue


- only in M21 (once)
java.lang.Exception.(Exception.java:LINE)
java.lang.InterruptedException.(InterruptedException.java:LINE)

- only in M21 (once apr) and M22 (once nio)
org.apache.catalina.connector.CoyoteAdapter.asyncDispatch Exception 
while processing an asynchronous request


- 2 / 1 / 3
org.apache.catalina.tribes.transport.nio.NioReplicationTask.run 
IOException in replication worker, unable to drain channel. Probable 
cause: Keep alive socket closed[null].


- 5 / 4 / 5
java.nio.channels.ClosedChannelException

- 7 / 5 / 4
org.apache.catalina.tribes.ChannelException: Sender not connected.; No 
faulty members identified.


- 3 / 3 / 2
org.apache.catalina.tribes.ChannelException: Operation has timed 
out([NUMBER] ms.).; Faulty members:tcp://{IP}:PORT;

  but instead in M22 one new
org.apache.catalina.tribes.ChannelException: Send failed, and sender is 
disconnected. Not retrying.; Faulty members:tcp://{IP}:PORT;



  - SEVERE messages

- new in M22
org.apache.catalina.valves.SSLValve.invoke The SSL provider specified on 
the connector associated with this request of [wontBeFound] is invalid. 
The certificate data could not be processed.

  together with
java.security.NoSuchProviderException: no such provider: wontBeFound

- 1 / 0 / 1 for apr
org.apache.tomcat.websocket.pojo.PojoEndpointBase.onError No error 
handling configured for 
[org.apache.tomcat.websocket.TesterEchoServer$Async] and the following 
error occurred


- 1 / 0 / 0 for nio
org.apache.tomcat.websocket.pojo.PojoEndpointBase.onError No error 
handling configured for

Re: [VOTE] Release Apache Tomcat 9.0.0.M22

2017-06-23 Thread Huxing Zhang 
Hi,

The proposed 9.0.0.M22 release is:
[ ] Broken - do not release
[ X ] Alpha - go ahead and release as 9.0.0.M22

Unit test passed.
Our test web application works fine.

1. There is a typo in trailers.ResponseTrailers, I will fix that later.
2. Actually I have a concern of the trailer field implementation. Should we add 
an extra whitespace between the trailer field name and trailer field, just to 
keep align with the head field format?

In rfc7230 section 4.1.2 says the white space is optional.
header-field   = field-name ":" OWS field-value OWS

But right now the format is inconsistent between header and trailer field.

Examples: 

Escape character is '^]'.
GET /examples/servlets/trailers/response HTTP/1.1
Host: hsf.taobao.net:8180
User-Agent: curl/7.47.0
Accept: */*

HTTP/1.1 200
Content-Type: text/plain;charset=UTF-8
Transfer-Encoding: chunked
Date: Fri, 23 Jun 2017 05:49:14 GMT

2b
This reponse should include trailer fields.
0
x-trailer-2:Trailer value two
x-trailer-1:Trailer value one

BTW, Jetty[1] has an white space between trailer field name and value. 
https://webtide.com/http-trailers-in-jetty/

--
From:Mark Thomas 
Time:2017 Jun 21 (Wed) 22:18
To:Tomcat Developers List 
Subject:[VOTE] Release Apache Tomcat 9.0.0.M22


The proposed Apache Tomcat 9.0.0.M22 release is now available for voting.

This is a milestone release for the 9.0.x branch. It should be
noted that, as a milestone release:
- Servlet 4.0 is not finalised
- The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0

The major changes compared to the 9.0.0.M21 release are:

- Add a new JULI FileHandler configuration for specifying the maximum
  number of days to keep the log files. By default the log files will be
  kept 90 days.

- Update the Servlet 4.0 implementation to add support for setting
  trailer fields for HTTP responses.

- When pre-compiling with JspC, report all compilation errors rather
  than stopping after the first error.

Along with lots of other bug fixes and improvements

For full details, see the changelog:
http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M22/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1137/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M22/

The proposed 9.0.0.M22 release is:
[ ] Broken - do not release
[ ] Alpha - go ahead and release as 9.0.0.M22

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M22

2017-06-22 Thread Coty Sutherland 
On Wed, Jun 21, 2017 at 10:18 AM, Mark Thomas  wrote:
> The proposed Apache Tomcat 9.0.0.M22 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M21 release are:
>
> - Add a new JULI FileHandler configuration for specifying the maximum
>   number of days to keep the log files. By default the log files will be
>   kept 90 days.
>
> - Update the Servlet 4.0 implementation to add support for setting
>   trailer fields for HTTP responses.
>
> - When pre-compiling with JspC, report all compilation errors rather
>   than stopping after the first error.
>
> Along with lots of other bug fixes and improvements
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M22/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1137/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M22/
>
> The proposed 9.0.0.M22 release is:
> [ ] Broken - do not release
> [x] Alpha - go ahead and release as 9.0.0.M22

+1

>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M22

2017-06-22 Thread Violeta Georgieva 
Hi,

2017-06-21 17:18 GMT+03:00 Mark Thomas :
>
> The proposed Apache Tomcat 9.0.0.M22 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M21 release are:
>
> - Add a new JULI FileHandler configuration for specifying the maximum
>   number of days to keep the log files. By default the log files will be
>   kept 90 days.
>
> - Update the Servlet 4.0 implementation to add support for setting
>   trailer fields for HTTP responses.
>
> - When pre-compiling with JspC, report all compilation errors rather
>   than stopping after the first error.
>
> Along with lots of other bug fixes and improvements
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M22/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1137/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M22/
>
> The proposed 9.0.0.M22 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 9.0.0.M22

+1

Regards,
Violeta

>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>