RE: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
-Original Message- From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] Sent: Wednesday, April 04, 2012 2:34 PM To: Tomcat Developers List Subject: Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc- pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacad e.java 2012/4/4 Filip Hanik Mailing Lists devli...@hanik.com: I know of two places where long lines cause problems: 1. Commit e-mails. Long lines are wrapped and it impacts readability. 2. Side-by-side comparison in viewvc when you do colored comparison here I see a challenge, since so many of our commits, are not code commits, but like a line wrap commit like this, this pollutes our diffs and why I'm not a big fan of changing it for changing it. I do not remember many line-wrap commits. [Filip Hanik] You're looking at the reply of one. There are ending whitespace commits, because sometimes people forget to run checkstyle and we would be nagged if someone does not fix the code. Therefore I would like to stick to the current convention of 80 chars. It is not a hard convention (we do not enforce it through checkstyle), but something to follow. The convention is something fairly new. For most of the time of Tomcat's life time, it was the committers preference, but fairly recently is when we started modifying style for style's sake. So the archives you refer to, can't go that far back. The only convention we've had through the history of Tomcat, is spaces, not tabs, not line length etc. a. I might be not very careful in selecting English words. Please excuse me. b. I do not see much difference between convention and preference. [Filip Hanik] Convention = mutually agreed upon standard Preference = Individual standard, like I like 120, markt likes 80 If it is a preference of many then it has to be respected as a convention. Isn't it? [Filip Hanik] Not really, only if it is mutually agreed upon Previous discussion (December 2010): http://markmail.org/thread/alo77qd4yiduvqvz [Filip Hanik] Opinions in this thread as I read it is - 80 is a bit outdated - 80 is not enforced We also have this description of our coding style: http://tomcat.apache.org/getinvolved.html#Coding_Conventions [Filip Hanik] Again, I'm only bringing this up for the following reasons - I think we can modernize our preferences/conventions/standards - If we are gonna enforce something like that, let's automate it a bit more Now, since only three people have chimed in, you, me and Mark, and both you and Mark believe that 80 is good for now, then we should aim for it, but as the thread points out, not enforced. I'll bring it up in another year or so, when monitors are even better :) Filip Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
- Original Message -
From: ma...@apache.org
To: dev@tomcat.apache.org
Sent: Thursday, March 29, 2012 2:19:18 PM
Subject: svn commit: r1307093 -
/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
Author: markt
Date: Thu Mar 29 20:19:18 2012
New Revision: 1307093
@Override
-public Object invoke(Object proxy, Method method, Object[] args)
throws Throwable {
+public Object invoke(Object proxy, Method method, Object[] args)
+throws Throwable {
Can we change the line length to something more modern than our 1980s monitors
that were limited to 80 characters.
In today's environment, 80 characters is like your chat window, surely we can
go 120 or 150 and get way more readable code
Filip
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
On 04/04/2012 17:12, Filip Hanik Mailing Lists wrote:
- Original Message -
From: ma...@apache.org To: dev@tomcat.apache.org Sent: Thursday,
March 29, 2012 2:19:18 PM Subject: svn commit: r1307093 -
/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
Author: markt
Date: Thu Mar 29 20:19:18 2012 New Revision: 1307093
@Override -public Object invoke(Object proxy, Method method,
Object[] args) throws Throwable { +public Object invoke(Object
proxy, Method method, Object[] args) +throws Throwable
{
Can we change the line length to something more modern than our 1980s
monitors that were limited to 80 characters. In today's environment,
80 characters is like your chat window, surely we can go 120 or 150
and get way more readable code
If I was going to dedicate my whole screen to the code pane then yes,
but there are other useful panes I want to see as well. 80 chars is
about right for the code window (and the line length we generally stick
to throughout the Tomcat code base).
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
- Original Message -
From: Mark Thomas ma...@apache.org
To: Tomcat Developers List dev@tomcat.apache.org
Sent: Wednesday, April 4, 2012 11:18:42 AM
Subject: Re: svn commit: r1307093 -
/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
On 04/04/2012 17:12, Filip Hanik Mailing Lists wrote:
- Original Message -
From: ma...@apache.org To: dev@tomcat.apache.org Sent: Thursday,
March 29, 2012 2:19:18 PM Subject: svn commit: r1307093 -
/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
Author: markt
Date: Thu Mar 29 20:19:18 2012 New Revision: 1307093
@Override -public Object invoke(Object proxy, Method method,
Object[] args) throws Throwable { +public Object invoke(Object
proxy, Method method, Object[] args) +throws Throwable
{
Can we change the line length to something more modern than our
1980s
monitors that were limited to 80 characters. In today's
environment,
80 characters is like your chat window, surely we can go 120 or 150
and get way more readable code
If I was going to dedicate my whole screen to the code pane then yes,
whole screen can probably fit 300+ characters, so were not talking whole screen.
80 is so tiny that it takes up a quarter of my screen or less.
I would therefor suggest to increase this, as it will dramatically shrink the
number of lines of code, and readability
but there are other useful panes I want to see as well. 80 chars is
about right for the code window (and the line length we generally
stick
to throughout the Tomcat code base).
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
2012/4/4 Filip Hanik Mailing Lists devli...@hanik.com:
- Original Message -
From: Mark Thomas ma...@apache.org
To: Tomcat Developers List dev@tomcat.apache.org
Sent: Wednesday, April 4, 2012 11:18:42 AM
Subject: Re: svn commit: r1307093 -
/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
On 04/04/2012 17:12, Filip Hanik Mailing Lists wrote:
- Original Message -
From: ma...@apache.org To: dev@tomcat.apache.org Sent: Thursday,
March 29, 2012 2:19:18 PM Subject: svn commit: r1307093 -
/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
Author: markt
Date: Thu Mar 29 20:19:18 2012 New Revision: 1307093
@Override - public Object invoke(Object proxy, Method method,
Object[] args) throws Throwable { + public Object invoke(Object
proxy, Method method, Object[] args) + throws Throwable
{
Can we change the line length to something more modern than our
1980s
monitors that were limited to 80 characters. In today's
environment,
80 characters is like your chat window, surely we can go 120 or 150
and get way more readable code
If I was going to dedicate my whole screen to the code pane then yes,
whole screen can probably fit 300+ characters, so were not talking whole
screen.
80 is so tiny that it takes up a quarter of my screen or less.
I would therefor suggest to increase this, as it will dramatically shrink the
number of lines of code, and readability
I know of two places where long lines cause problems:
1. Commit e-mails.
Long lines are wrapped and it impacts readability.
2. Side-by-side comparison in viewvc when you do colored comparison
Therefore I would like to stick to the current convention of 80 chars.
It is not a hard convention (we do not enforce it through checkstyle),
but something to follow.
There should be several previous discussions on this topic in the archives...
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
- Original Message -
From: Konstantin Kolinko knst.koli...@gmail.com
To: Tomcat Developers List dev@tomcat.apache.org
Sent: Wednesday, April 4, 2012 11:52:01 AM
Subject: Re: svn commit: r1307093 -
/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
2012/4/4 Filip Hanik Mailing Lists devli...@hanik.com:
- Original Message -
From: Mark Thomas ma...@apache.org
To: Tomcat Developers List dev@tomcat.apache.org
Sent: Wednesday, April 4, 2012 11:18:42 AM
Subject: Re: svn commit: r1307093 -
/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
On 04/04/2012 17:12, Filip Hanik Mailing Lists wrote:
- Original Message -
From: ma...@apache.org To: dev@tomcat.apache.org Sent:
Thursday,
March 29, 2012 2:19:18 PM Subject: svn commit: r1307093 -
/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
Author: markt
Date: Thu Mar 29 20:19:18 2012 New Revision: 1307093
@Override - public Object invoke(Object proxy, Method
method,
Object[] args) throws Throwable { + public Object
invoke(Object
proxy, Method method, Object[] args) + throws
Throwable
{
Can we change the line length to something more modern than our
1980s
monitors that were limited to 80 characters. In today's
environment,
80 characters is like your chat window, surely we can go 120 or
150
and get way more readable code
If I was going to dedicate my whole screen to the code pane then
yes,
whole screen can probably fit 300+ characters, so were not talking
whole screen.
80 is so tiny that it takes up a quarter of my screen or less.
I would therefor suggest to increase this, as it will dramatically
shrink the number of lines of code, and readability
I know of two places where long lines cause problems:
1. Commit e-mails.
Long lines are wrapped and it impacts readability.
2. Side-by-side comparison in viewvc when you do colored comparison
here I see a challenge, since so many of our commits, are not code commits, but
like a line wrap commit like this,
this pollutes our diffs and why I'm not a big fan of changing it for changing
it.
Therefore I would like to stick to the current convention of 80
chars.
It is not a hard convention (we do not enforce it through
checkstyle),
but something to follow.
The convention is something fairly new. For most of the time of Tomcat's life
time, it was the committers preference, but fairly recently is when we started
modifying style for style's sake. So the archives you refer to, can't go that
far back. The only convention we've had through the history of Tomcat, is
spaces, not tabs, not line length etc.
There should be several previous discussions on this topic in the
archives...
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
2012/4/4 Filip Hanik Mailing Lists devli...@hanik.com: I know of two places where long lines cause problems: 1. Commit e-mails. Long lines are wrapped and it impacts readability. 2. Side-by-side comparison in viewvc when you do colored comparison here I see a challenge, since so many of our commits, are not code commits, but like a line wrap commit like this, this pollutes our diffs and why I'm not a big fan of changing it for changing it. I do not remember many line-wrap commits. There are ending whitespace commits, because sometimes people forget to run checkstyle and we would be nagged if someone does not fix the code. Therefore I would like to stick to the current convention of 80 chars. It is not a hard convention (we do not enforce it through checkstyle), but something to follow. The convention is something fairly new. For most of the time of Tomcat's life time, it was the committers preference, but fairly recently is when we started modifying style for style's sake. So the archives you refer to, can't go that far back. The only convention we've had through the history of Tomcat, is spaces, not tabs, not line length etc. a. I might be not very careful in selecting English words. Please excuse me. b. I do not see much difference between convention and preference. If it is a preference of many then it has to be respected as a convention. Isn't it? Previous discussion (December 2010): http://markmail.org/thread/alo77qd4yiduvqvz We also have this description of our coding style: http://tomcat.apache.org/getinvolved.html#Coding_Conventions Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
