Re: Logging configuration

2016-11-15 Thread Claude Brisson
So, I reviewed tools logging as proposed. Here's the default behavior: - structural classes log with 'org.apache.velocity.tools' - tools log with they key name, for instance 'org.apache.velocity.tools.date' for the date tool. And here's how it is configurable: - if runtime.log.instance

Re: Logging configuration

2016-11-11 Thread Nathan Bubna
+1 for logical names and a configurable base. On Fri, Nov 11, 2016 at 6:24 AM, Claude Brisson wrote: > In fact, the logger name (well, *base* logger name) is configurable. So we > can both be happy: we can have the default base logger name be > "org.apache.velocity", as like

Re: Logging configuration

2016-11-11 Thread Claude Brisson
In fact, the logger name (well, *base* logger name) is configurable. So we can both be happy: we can have the default base logger name be "org.apache.velocity", as like you say it is more intuitive, and people like me willing to shorten it can still tune their config file. But as I said, I'd

Re: Logging configuration

2016-11-11 Thread Greg Huber
Doing only casual debugging, as long as its intuitive to set the debugging name="foobar" name without having to dip into the code sounds great. The package name is however the easiest to remember as its from the class you are trying to debug (using attached source jar). Thanks On 11 November

Re: Logging configuration

2016-11-11 Thread Claude Brisson
And also velocity.rendering for every rendering error (including introspector/uberspector). So here's the new list: - velocity for the app/runtime/singleton - velocity.event for the event cartridge - velocity.directive, and velocity.directive.[directivename] - velocity.parser -

Re: Logging configuration

2016-11-11 Thread Claude Brisson
Why not, but it should be done right now to take advantage of the major version change. I checked quickly, and it seems like all logging backends build the loggers hierarchy using namespaces separated with dots, which can be class names by convention but it is not at all necessary. I'd

Re: Logging configuration

2016-11-10 Thread Mike Kienenberger
+1 to using several appropriate functional names if we are picking loggers by String rather than by Class. On Thu, Nov 10, 2016 at 11:11 AM, Claude Brisson wrote: > On 10/11/2016 15:56, Greg Huber wrote: > >> Yes it does when I use name="Velocity" >> >> But as you are using

Re: Logging configuration

2016-11-10 Thread Greg Huber
Yes it does when I use name="Velocity" But as you are using the runtime instance logger its either on or off for the whole package. Using a per class I think enables more filtering as you can name="org.apache.velocity.app" level="DEBUG" purely for this package and name="org.apache.velocity"

Re: Logging configuration

2016-11-10 Thread Claude Brisson
Any module anywhere can get a logger using one of the two static methods: Logger org.slf4j.LoggerFactory.getLogger(String loggerName) Logger org.slf4j.LoggerFactory.getLogger(Class targetClass) Calling one or the other is a matter of taste. It does not *have* to be the same logger anywhere in