Re: [EXTERNAL] Re: [edk2-devel] BaseCryptLib in ARM incorrectly marked as a DXE_DRIVER

2021-07-16 Thread Arti Gupta via groups.io
Thank you Andrew, you are right. I missed the fact that there are 2 INFs in there. From: Andrew Fish Sent: Wednesday, July 14, 2021 9:14 PM To: edk2-devel-groups-io ; Arti Gupta Subject: [EXTERNAL] Re: [edk2-devel] BaseCryptLib in ARM incorrectly marked as a DXE_DRIVER Arti, Can you be a

[edk2-devel] [PATCH] SecurityPkg: TPM must go to Idle state on CRB command completion.

2021-07-16 Thread Rodrigo Gonzalez del Cueto
To follow the TCG CRB protocol specification, on every CRB TPM command completion the TPM should return to Idle state, regardless of the CRB Idle Bypass capability reported by the TPM device. See: TCG PC Client Device Driver Design Principles for TPM 2.0, Version 1.0, Rev 0.27 Signed-off-by:

Re: [edk2-devel] [edk2-platforms PATCH v3 0/2] Add BootDiscoveryPolicyUiLib

2021-07-16 Thread Samer El-Haj-Mahmoud
Yes this depends on https://edk2.groups.io/g/devel/message/77787 Which is still under review From: Ard Biesheuvel Sent: Friday, July 16, 2021 1:31:04 PM To: Samer El-Haj-Mahmoud Cc: Grzegorz Bernacki ; devel@edk2.groups.io ; l...@nuviainc.com ;

Re: [edk2-devel] [edk2-platforms PATCH 0/4] ACPI MDIO support for Marvell SoCs

2021-07-16 Thread Ard Biesheuvel
On Mon, 12 Jul 2021 at 13:17, Jon Nettleton wrote: > > On Mon, Jul 12, 2021 at 12:52 PM Marcin Wojtas wrote: > > > > Hi, > > > > wt., 29 cze 2021 o 16:17 Marcin Wojtas napisał(a): > > > > > > Hi Leif, > > > > > > pon., 14 cze 2021 o 23:55 Leif Lindholm napisał(a): > > > > > > > > Hi Marcin, >

Re: [edk2-devel] [edk2-platforms PATCH v3 0/2] Add BootDiscoveryPolicyUiLib

2021-07-16 Thread Ard Biesheuvel
On Fri, 16 Jul 2021 at 13:50, Samer El-Haj-Mahmoud wrote: > > Series Reviewed-By: Samer El-Haj-Mahmoud > Does this series depend on core EDK2 changes, and if so, have they been merged already? > > -Original Message- > > From: Grzegorz Bernacki > > Sent: Wednesday, July 14, 2021 9:21

Re: [edk2-devel] [PATCH v6 00/11] Secure Boot default keys

2021-07-16 Thread Ard Biesheuvel
On Fri, 16 Jul 2021 at 14:00, Samer El-Haj-Mahmoud wrote: > > The v6 of this series seems to have all the necessary Reviewed-By (and some > Tested-By) of all parts, except the following platform specific parts. Could > we get help from maintainers to review these please? > > Much appreciated! >

Re: [edk2-devel] [PATCH v4 0/3] Enable Cloud Hypervisor support in edk2

2021-07-16 Thread Ard Biesheuvel
On Fri, 16 Jul 2021 at 19:25, Ard Biesheuvel wrote: > > On Mon, 5 Jul 2021 at 12:06, Jianyong Wu wrote: > > > > Cloud Hypervisor is an open source Virtual Machine Monitor (VMM) that > > runs on top of KVM. Cloud Hypervisor is implemented in Rust and is based > > on the rust-vmm crates. See [1]

Re: [edk2-devel] [PATCH v4 0/3] Enable Cloud Hypervisor support in edk2

2021-07-16 Thread Ard Biesheuvel
On Mon, 5 Jul 2021 at 12:06, Jianyong Wu wrote: > > Cloud Hypervisor is an open source Virtual Machine Monitor (VMM) that > runs on top of KVM. Cloud Hypervisor is implemented in Rust and is based > on the rust-vmm crates. See [1] to find more. > > To support UEFI, Cloud Hypervisor is introduced

Re: [edk2-devel] [PATCH v2 00/11] Measured SEV boot with kernel/initrd/cmdline

2021-07-16 Thread Ard Biesheuvel
On Tue, 6 Jul 2021 at 10:55, Dov Murik wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3457 > > Booting with SEV prevented the loading of kernel, initrd, and kernel > command-line via QEMU fw_cfg interface because they arrive from the VMM > which is untrusted in SEV. > > However, in

Re: [edk2-devel] [PATCH 1/1] ArmVirtPkg: Remove meaningless comment

2021-07-16 Thread Ard Biesheuvel
On Wed, 7 Jul 2021 at 19:14, Philippe Mathieu-Daudé wrote: > > On 7/6/21 5:57 PM, Laszlo Ersek wrote: > > On 07/06/21 11:49, Philippe Mathieu-Daudé wrote: > >> From: Philippe Mathieu-Daude > >> > >> The "Shell Embedded Boot Loader" description (added in > >> commit 6f5872b1f401) does not add any

Re: [edk2-devel] [PATCH 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

2021-07-16 Thread Ard Biesheuvel
On Fri, 16 Jul 2021 at 17:00, Kinney, Michael D wrote: > > Hi Ard, > > I see you were involved in the OS side changes. > > Can you explain what is required for the FW <-> OS interface with respect to > Load File Protocol and this media device path node. > > What happens if this media device path

Re: [edk2-devel] [PATCH 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

2021-07-16 Thread Michael D Kinney
Hi Ard, I see you were involved in the OS side changes. Can you explain what is required for the FW <-> OS interface with respect to Load File Protocol and this media device path node. What happens if this media device path node is not present? What breaks? Trying to figure out if this is a

Re: [edk2-devel] [PATCH v5 3/4] OvmfPkg/PlatformPei: Mark SEC GHCB page as unencrypted via hypercall

2021-07-16 Thread Lendacky, Thomas via groups.io
On 7/8/21 9:08 AM, Ashish Kalra wrote: > From: Ashish Kalra > > Mark the SEC GHCB page (that is mapped as unencrypted in > ResetVector code) in the hypervisor page status tracking. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Ashish Kalra > --- >

Re: [edk2-devel] [PATCH v5 2/4] OvmfPkg/VmgExitLib: Add support for hypercalls with SEV-ES.

2021-07-16 Thread Lendacky, Thomas via groups.io
On 7/8/21 9:08 AM, Ashish Kalra wrote: > From: Ashish Kalra > The subject isn't correct since the #VC handler already supports hypercalls. It should say something like "Make the #VC handler aware of the encryption state change hypercall" or "Update the #VC handler to support the encryption

Re: [edk2-devel] [PATCH v5 1/4] OvmfPkg/BaseMemEncryptLib: Support to issue unencrypted hypercall

2021-07-16 Thread Lendacky, Thomas via groups.io
On 7/8/21 9:07 AM, Ashish Kalra wrote: > From: Ashish Kalra > The patch subject is a bit confusing. Something more like "Add API to issue hypercall on page encryption state change" or similar, since this is issued for changes to shared and private, not just shared. > By default all the SEV

Re: [edk2-devel] [PATCH v5 1/4] OvmfPkg/BaseMemEncryptLib: Support to issue unencrypted hypercall

2021-07-16 Thread Ashish Kalra via groups.io
Hello Dov, On Thu, Jul 15, 2021 at 11:58:17PM +0300, Dov Murik wrote: > Hi Ashish, > > On 08/07/2021 17:07, Ashish Kalra wrote: > > From: Ashish Kalra > > > > By default all the SEV guest memory regions are considered encrypted, > > if a guest changes the encryption attribute of the page (e.g

Re: [edk2-devel] [PATCH 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

2021-07-16 Thread Ard Biesheuvel
On Fri, 16 Jul 2021 at 01:20, Jeff Brasen wrote: > > The GUID is used by the linux kernel but not sure if part of any formal spec > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/include/linux/efi.h?h=v5.14-rc1=ec93fc371f014a6fb483e3556061ecad4b40735c > > If we feel

Re: [edk2-devel] [PATCH v6 00/11] Secure Boot default keys

2021-07-16 Thread Samer El-Haj-Mahmoud
The v6 of this series seems to have all the necessary Reviewed-By (and some Tested-By) of all parts, except the following platform specific parts. Could we get help from maintainers to review these please? Much appreciated! - ArmVirtPkg : https://edk2.groups.io/g/devel/message/2 -

Re: [edk2-devel] [edk2-platforms PATCH v3 0/2] Add BootDiscoveryPolicyUiLib

2021-07-16 Thread Samer El-Haj-Mahmoud
Series Reviewed-By: Samer El-Haj-Mahmoud > -Original Message- > From: Grzegorz Bernacki > Sent: Wednesday, July 14, 2021 9:21 AM > To: devel@edk2.groups.io > Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud > ; Sunny Wang ; > m...@semihalf.com;

Re: [edk2-devel] [PATCH] Fix variables may be used uninitialize

2021-07-16 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Hsu, WesleyX Sent: Thursday, July 15, 2021 11:38 PM To: devel@edk2.groups.io Cc: Hsu, WesleyX ; Ni, Ray ; Chaganty, Rangasai V Subject: [PATCH] Fix variables may be used uninitialize