[edk2-devel] [PATCH] RedfishPkg/RefishCrtLib: Public RefishCrtLib

Move RefishCrtLib from PrivateInclude to Include. Signed-off-by: Abner Chang Cc: Nickle Wang --- RedfishPkg/{PrivateInclude => Include}/Library/RedfishCrtLib.h | 2 +- .../RedfishLib/edk2libredfish/include/redfishPayload.h | 2 +-

[edk2-devel] [PATCH] RedfishPkg/JsonLib: Add more JsonLib functions

Signed-off-by: Abner Chang Cc: Nickle Wang --- RedfishPkg/Include/Library/JsonLib.h | 127 -- RedfishPkg/Library/JsonLib/JsonLib.c | 156 --- 2 files changed, 261 insertions(+), 22 deletions(-) diff --git a/RedfishPkg/Include/Library/JsonLib.h

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

On July 27, 2021 8:46 PM, Yao, Jiewen wrote: > HI Min > I agree with Brijesh. > > The basic rule is: SEV file shall never refer to TDX data structure. TDX file > shall never refer to SEV data structure. > These code should be isolated clearly. > > Do we still need that logic if we follow the new

[edk2-devel] [PATCH 1/1] OvmfPkg PlatformBootManagerLib: Move TryRunningQemuKernel()

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3504 This change ensures that PlatformBdsConnectSequence() is run before TryRunningQemuKernel(). It reverses commit a34a886962561f6d8550b2a1bb193798ca456431 which aimed to improve UEFI boot time. Unfortunately that commit now results in boot

[edk2-devel] [PATCH 0/1] OvmfPkg PlatformBootManagerLib: Move TryRunningQemuKernel()

Use of Qemu's -kernel option (thus also -initrd & -append) is currently not working correctly under UEFI boot. The nominated kernel is loaded and the initrd is opened successfully but there is no access to the VM filesystem. Booting without the -kernel option i.e. using the VM's internal kernel &

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 07/27/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

On July 27, 2021 8:31 PM, Brijesh Singh wrote: > On 7/27/21 6:51 AM, Xu, Min M wrote: > > On July 27, 2021 6:57 PM, Brijesh Singh wrote: > >> Hi Min, > >> > >> This refactoring is already done by the SNP patch series. > >> > >> >

Re: [EXTERNAL] [edk2-devel] Missing TPM 2 related call to Tpm2HierarchyChangeAuth

On 7/27/21 12:25 PM, Yao, Jiewen wrote: Oops. Sorry for late response. The code is NOT in EDKII, but EDKII-platform as example. https://github.com/tianocore/edk2-platforms/tree/master/Platform/Intel/MinPlatformPkg/Tcg We allow a platform having its own implementation. That is why

[edk2-devel] [PATCH v5 06/11] ArmVirtPkg: add BlobVerifierLibNull to DSC

This prepares the ground for calling VerifyBlob() in QemuKernelLoaderFsDxe. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Jordan Justen Cc: Ashish Kalra Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Min Xu Cc: Tom Lendacky Ref:

[edk2-devel] [PATCH v5 08/11] OvmfPkg/AmdSev/SecretPei: build hob for full page

Round up the size of the SEV launch secret area to a whole page, as required by BuildMemoryAllocationHob. This will allow the secret area defined in the MEMFD to take less than a whole 4KB page. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Ashish Kalra Cc: Brijesh Singh Cc: Erdem Aktas Cc:

[edk2-devel] [PATCH v5 09/11] OvmfPkg/AmdSev: reserve MEMFD space for for firmware config hashes

From: James Bottomley Split the existing 4KB page reserved for SEV launch secrets into two parts: first 3KB for SEV launch secrets and last 1KB for firmware config hashes. The area of the firmware config hashes will be attested (measured) by the PSP and thus the untrusted VMM can't pass in

[edk2-devel] [PATCH v5 04/11] OvmfPkg: add library class BlobVerifierLib with null implementation

BlobVerifierLib will be used to verify blobs fetching them from QEMU's firmware config (fw_cfg) in platforms that enable such verification. The null implementation BlobVerifierLibNull treats all blobs as valid. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Ashish Kalra Cc: Brijesh Singh Cc: Erdem

[edk2-devel] [PATCH v5 01/11] OvmfPkg/AmdSev/SecretDxe: fix header comment to generic naming

From: James Bottomley Commit 96201ae7bf97 ("OvmfPkg/AmdSev/SecretDxe: make secret location naming generic", 2020-12-15) replaced references to SEV with the generic term Confidential Computing, but missed the file header comment. Fix the naming in that header. Cc: Ard Biesheuvel Cc: Jordan

[edk2-devel] [PATCH v5 11/11] OvmfPkg/AmdSev: Enforce hash verification of kernel blobs

In the AmdSevX64 build, use BlobVerifierLibSevHashes to enforce verification of hashes of the kernel/initrd/cmdline blobs fetched from firmware config. This allows for secure (measured) boot of SEV guests with QEMU's -kernel/-initrd/-append switches (with the corresponding QEMU support for

[edk2-devel] [PATCH v5 00/11] Measured SEV boot with kernel/initrd/cmdline

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3457 Booting with SEV prevented the loading of kernel, initrd, and kernel command-line via QEMU fw_cfg interface because they arrive from the VMM which is untrusted in SEV. However, in some cases the kernel, initrd, and cmdline are not secret

[edk2-devel] [PATCH v5 02/11] OvmfPkg/AmdSev: use GenericQemuLoadImageLib in AmdSev builds

Newer kernels support efistub and therefore don't need all the legacy stuff in X86QemuLoadImageLib, which are harder to secure. Specifically the verification of kernel/initrd/cmdline blobs will be added only to the GenericQemuLoadImageLib implementation, so use that for SEV builds. Cc: Ard

[edk2-devel] [PATCH v5 10/11] OvmfPkg/AmdSev: add BlobVerifierLibSevHashes

Add an implementation for BlobVerifierLib that locates the SEV hashes table and verifies that the calculated hashes of the kernel, initrd, and cmdline blobs indeed match the expected hashes stated in the hashes table. If there's a missing hash or a hash mismatch then EFI_ACCESS_DENIED is returned

[edk2-devel] [PATCH v5 07/11] OvmfPkg/QemuKernelLoaderFsDxe: call VerifyBlob after fetch from fw_cfg

In QemuKernelLoaderFsDxeEntrypoint we use FetchBlob to read the content of the kernel/initrd/cmdline from the QEMU fw_cfg interface. Insert a call to VerifyBlob after fetching to allow BlobVerifierLib implementations to add a verification step for these blobs. This will allow confidential

[edk2-devel] [PATCH v5 03/11] OvmfPkg: PlatformBootManagerLibGrub: Allow executing kernel via fw_cfg

From: James Bottomley Support QEMU's -kernel option. Create a QemuKernel.c for PlatformBootManagerLibGrub which is an exact copy of the file PlatformBootManagerLib/QemuKernel.c . Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Ashish Kalra Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley

[edk2-devel] [PATCH v2 3/3] OvmfPkg/ResetVector: add the macro to request guest termination

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The upcoming SEV-SNP support will need to make a few additional guest termination requests depending on the failure type. Let's move the logic to request the guest termination into a macro to keep the code readable. Cc: James Bottomley Cc:

[edk2-devel] [PATCH v2 2/3] OvmfPkg/ResetVector: add the macro to invoke MSR protocol based VMGEXIT

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The upcoming SEV-SNP support will need to make a few additional MSR protocol based VMGEXIT's. Add a macro that wraps the common setup and response validation logic in one place to keep the code readable. While at it, define SEV_STATUS_MSR

[edk2-devel] [PATCH v2 1/3] OvmfPkg/ResetVector: move SEV specific code in a separate file

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The PageTables64.asm was created to provide routines to set the CR3 register for 64-bit paging. During the SEV support, it grew to include a lot of the SEV stuff. Before adding more SEV features, let's move all the SEV-specific routines into

[edk2-devel] [PATCH v2 0/3] Move the SEV specific changes in ResetVector in separate file

The PageTable64.asm was created to build the initial page table, but over the time it grew to include bunch of the SEV specific code which does not directly manipulates the pagetable. Before adding more to it, let's move all the SEV-specific routines into a separate file. The series is taken from

[edk2-devel] [PATCH edk2-platforms v2 6/6] Platform/ARM: Juno: Add JunoPkg.ci.yaml for CI support

From: Pierre Gondois Add a JunoPkg.ci.yaml file to enable the CI for the JunoPkg. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Cc: Sami Mujawar Signed-off-by: Pierre Gondois --- Platform/ARM/JunoPkg/JunoPkg.ci.yaml | 104 +++ 1 file

[edk2-devel] [PATCH edk2-platforms v2 5/6] .mergify: Add Mergify YML pull request rules configuration file

From: Pierre Gondois These files are copies of the files from the tianocore/edk2 repository. Any modification to the tianocore/edk2 files must be reflected on the tianocore/edk2-platforms copies. Initial commid-id in the edk2 repository: ab060128768b Initial message: Add directory for the

[edk2-devel] [PATCH edk2-platforms v2 4/6] .azurepipelines: Add Azure Pipelines YML configuration files

From: Pierre Gondois To enable CI support of the tianocore/edk2-platforms repository, add YML configuration files used to run Continuous Integration (CI) checks on Azure Pipelines agents. These files are copies of the files from the tianocore/edk2 repository. Any modification to the

[edk2-devel] [PATCH edk2-platforms v2 3/6] .pytool/Plugin: Add CI plugins

From: Pierre Gondois To enable CI support of the tianocore/edk2-platforms repository, add a .pytool directory containing the following files: - .pytool/CISettings.py - .pytool/Readme.md These files are largely inspired from the same files available in the edk2 repository. The .pytool/Plugin/*

[edk2-devel] [PATCH edk2-platforms v2 2/6] pip-requirements.txt: Add python pip requirements file

From: Pierre Gondois To enable CI support of the tianocore/edk2-platforms repository, add pip requirements file to install the python modules required to perform EDK II Continuous Integration (CI) builds. This file is a copy of the file from the tianocore/edk2 repository. Any modification to

[edk2-devel] [PATCH edk2-platforms v2 1/6] edk2-platforms: add edk2 repository as a submodule

From: Pierre Gondois Add the edk2 repository as a submodule: https://github.com/tianocore/edk2 Platforms in edk2-platforms often relies on modules available in the edk2 repository. In order to enable an upstream CI for edk2-platforms, adding edk2 as a submodule is a convenient way to advertise

[edk2-devel] [PATCH edk2-platforms v2 0/6] Enable edk2-platforms CI for JunoPkg

From: Pierre Gondois v2: - Use tianocore repository instead of personal repository for edk2 submodule [Pierre] - Bugzilla associated to the topic: https://bugzilla.tianocore.org/show_bug.cgi?id=3509 This patch-set is dependent on the following patch-set: edk2-platforms: [PATCH v1 0/2]

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

On Tue, 27 Jul 2021 at 18:45, Jeff Brasen wrote: > > Add LINUX_EFI_INITRD_MEDIA_GUID to our collection of GUID definitions, > it can be used in a media device path to specify a Linux style initrd > that can be loaded by the OS using the LoadFile2 protocol. > > Move these defines to MdePkg from

[edk2-devel] [PATCH v2 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

Add LINUX_EFI_INITRD_MEDIA_GUID to our collection of GUID definitions, it can be used in a media device path to specify a Linux style initrd that can be loaded by the OS using the LoadFile2 protocol. Move these defines to MdePkg from OvmfPkg as these are relevant to non-OVMF targets as well.

Re: [EXTERNAL] [edk2-devel] Missing TPM 2 related call to Tpm2HierarchyChangeAuth

Oops. Sorry for late response. The code is NOT in EDKII, but EDKII-platform as example. https://github.com/tianocore/edk2-platforms/tree/master/Platform/Intel/MinPlatformPkg/Tcg We allow a platform having its own implementation. That is why it is NOT in EDKII. Thank you Yao Jiewen From:

Re: [EXTERNAL] [edk2-devel] Missing TPM 2 related call to Tpm2HierarchyChangeAuth

Adding @Jeremiah… Jeremiah, weren’t you or @Michael shopping this change to MinPlatform? - Bret From: Stefan Berger via groups.io Sent: Monday, July 26, 2021 7:48 AM To: Yao,

[edk2-devel] [staging/edk2-redfish-client RedfishFeatureCore PATCH 2/3] RedfishClientPkg/RedfishFeatureCoreDxe: Redfish Feature Core DXE driver

EDKII Redfish Feature Core DXE driver provides the protocol interface to the auto-generated Redfish feature driver to register itself for the Redfish resource URI it manages. Refer to the Readme.md for the details. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Liming Gao ---

[edk2-devel] [staging/edk2-redfish-client RedfishFeatureCore PATCH 3/3] RedfishClientPkg/Document: Update diagrams

Update architectural diagrams. You can skip reviewing this patch. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Liming Gao --- .../Media/RedfishClientDriverStack.svg| 197 -- 1 file changed, 135 insertions(+), 62 deletions(-) diff --git

[edk2-devel] [staging/edk2-redfish-client RedfishFeatureCore PATCH 1/3] RedfishClientPkg: Initial commit of meta files

Initial commit of RedfishclientPkg meta files Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Liming Gao --- RedfishClientPkg/RedfishClientPkg.dec | 24 ++ RedfishClientPkg/RedfishClient.dsc.inc| 21 + .../RedfishClientComponents.dsc.inc | 16 +++

[edk2-devel] [staging/edk2-redfish-client RedfishFeatureCore PATCH 0/3] RedfishFeatureCoreDxe

Patch of EDKII Redfish Feature Core DXE driver. EDKII Redfish Feature Core DXE driver provides the protocol interface to the auto-generated Redfish feature driver to register itself for the Redfish resource URI it manages. You can skip 0003 patch which is the diagrams. Signed-off-by: Abner

[edk2-devel] "StdLibPkg" branch on edk2-staging

Hi, I have submitted a new edk2-staging branch named "StdLibPkg". https://github.com/tianocore/edk2-staging/tree/StdLibPkg Branch contains initial implementation of C standard library and intrinsic library for UEFI to smoothen open-source submodule integration (instead of implementing those

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/ResetVector: move SEV specific code in a separate file

On 7/27/21 6:16 AM, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The PageTables64.asm was created to provide routines to set the CR3 > register for 64-bit paging. During the SEV support, it grew to include a > lot of the SEV stuff. Before adding more SEV

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

HI Min I agree with Brijesh. The basic rule is: SEV file shall never refer to TDX data structure. TDX file shall never refer to SEV data structure. These code should be isolated clearly. Do we still need that logic if we follow the new pattern? Thank you Yao Jiewen > -Original

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

On 7/27/21 6:51 AM, Xu, Min M wrote: > On July 27, 2021 6:57 PM, Brijesh Singh wrote: >> Hi Min, >> >> This refactoring is already done by the SNP patch series. >> >>

Re: [edk2-devel] [PATCH 0/3] Move the SEV specific changes in ResetVector in separate file

On Tue, 27 Jul 2021 at 13:54, Yao, Jiewen wrote: > > Thank you very much to confirm that. > > I will follow 24 hour rule for this patch set. > Thanks for taking care of this. For the series, Acked-by: Ard Biesheuvel > > > > -Original Message- > > From: devel@edk2.groups.io On Behalf

Re: [edk2-devel] [PATCH 0/3] Move the SEV specific changes in ResetVector in separate file

Thank you very much to confirm that. I will follow 24 hour rule for this patch set. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Brijesh > Singh via groups.io > Sent: Tuesday, July 27, 2021 7:47 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc:

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

On July 27, 2021 6:57 PM, Brijesh Singh wrote: > Hi Min, > > This refactoring is already done by the SNP patch series. > > https://edk2.groups.io/g/devel/message/77336?p=,,,20,0,0,0::Created,,post > erid%3A5969970,20,2,20,83891510 > > It appears that you are also pulling in some of TDX logic

Re: [edk2-devel] [PATCH 0/3] Move the SEV specific changes in ResetVector in separate file

On 7/27/21 6:30 AM, Yao, Jiewen wrote: > Thank you Brijesh. That is exactly what I want. > > Reviewed-by: Jiewen Yao > > Sorry, I obviously overlooked the SNP series. > > If you don't mind, I would like to merge this at first as soon as possible, > then we can build up more stuff on top it. I

Re: [edk2-devel] [PATCH V3 00/10] Add Intel TDX support in OvmfPkg/ResetVector

Thank Brijesh. Yes, I just notice that. I am reviewing SNP patch series. It may take me some time to review all 28 patches. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Brijesh > Singh via groups.io > Sent: Tuesday, July 27, 2021 7:24 PM > To:

Re: [edk2-devel] [PATCH 0/3] Move the SEV specific changes in ResetVector in separate file

Thank you Brijesh. That is exactly what I want. Reviewed-by: Jiewen Yao Sorry, I obviously overlooked the SNP series. If you don't mind, I would like to merge this at first as soon as possible, then we can build up more stuff on top it. Thank you Yao Jiewen > -Original Message-

Re: [edk2-devel] [PATCH V3 00/10] Add Intel TDX support in OvmfPkg/ResetVector

Hi, On 7/27/21 2:16 AM, Yao, Jiewen wrote: > Thanks Min. > Many thanks for splitting SEV stuff to a standalone file. That is very good > start. I am not sure if you noticed but the SEV refactoring was already included in the SNP series, I extracted those patches from SNP series and posted now

Re: [edk2-devel] [PATCH v2 0/4] ArmPlatformPkg: Add support to generate HEST ACPI table

Thanks Sami. Regards, Omkar > Hi Omkar, > > I will pick this up for review this week. > > Regards, > > Sami Mujawar > > On 26/07/2021, 15:52, "Omkar Kulkarni" wrote: > > Gentle reminder to review this patch series. > > Regards, > Omkar > > > Changes since v1: > > -

[edk2-devel] [PATCH 2/3] OvmfPkg/ResetVector: add the macro to invoke MSR protocol based VMGEXIT

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The upcoming SEV-SNP support will need to make a few additional MSR protocol based VMGEXIT's. Add a macro that wraps the common setup and response validation logic in one place to keep the code readable. While at it, define SEV_STATUS_MSR

[edk2-devel] [PATCH 3/3] OvmfPkg/ResetVector: add the macro to request guest termination

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The upcoming SEV-SNP support will need to make a few additional guest termination requests depending on the failure type. Let's move the logic to request the guest termination into a macro to keep the code readable. Cc: James Bottomley Cc:

[edk2-devel] [PATCH 0/3] Move the SEV specific changes in ResetVector in separate file

The PageTable64.asm was created to build the initial page table, but over the time it grew to include bunch of the SEV specific code which does not directly manipulates the pagetable. Before adding more to it, let's move all the SEV-specific routines into a separate file. The series is taken from

[edk2-devel] [PATCH 1/3] OvmfPkg/ResetVector: move SEV specific code in a separate file

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The PageTables64.asm was created to provide routines to set the CR3 register for 64-bit paging. During the SEV support, it grew to include a lot of the SEV stuff. Before adding more SEV features, let's move all the SEV-specific routines into

Re: [edk2-devel] [RFC PATCH] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

On Wed, Jul 21, 2021 at 02:56:46PM +0800, Gary Lin wrote: > BTW, it seems to me that QEMU fwcfg is only used for Xen Direct Kernel > Boot. However, per xl.cfg manpage, it's possible to turn on or off S3 > support by setting "acpi_s3" in xl.cfg, but PcdAcpiS3Enable wasn't set > in the current

Re: [edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

Hi Min, This refactoring is already done by the SNP patch series. https://edk2.groups.io/g/devel/message/77336?p=,,,20,0,0,0::Created,,posterid%3A5969970,20,2,20,83891510 It appears that you are also pulling in some of TDX logic inside the AMDSev.asm such as ; +PostJump64BitAndLandHereSev: + +

[edk2-devel] [PATCH v1] UefiCpuPkg/CpuCacheInfoLib: Sort CpuCacheInfo array

From: Jason REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3508 Sort the CpuCacheInfo array by the core type values from largest to smallest. Signed-off-by: Jason Lou Cc: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar --- UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Platform/Sgi: Add platform support for firmware first error handling

Hi Omkar, I will pick this up for review this week. Regards, Sami Mujawar On 26/07/2021, 15:52, "Omkar Kulkarni" wrote: Gentle reminder to review this patch series. Regards, Omkar > Changes since v1: > - Added Platform Error Handler DXE driver. > - Move the ACPI

Re: [edk2-devel] [PATCH v2 0/4] ArmPlatformPkg: Add support to generate HEST ACPI table

Hi Omkar, I will pick this up for review this week. Regards, Sami Mujawar On 26/07/2021, 15:52, "Omkar Kulkarni" wrote: Gentle reminder to review this patch series. Regards, Omkar > Changes since v1: > - Helper added for HEST ACPI table generation. > - Rebased to

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78204): https://edk2.groups.io/g/devel/message/78204 Mute This Topic: https://groups.io/mt/83439673/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH V3 00/10] Add Intel TDX support in OvmfPkg/ResetVector

On July 27, 2021 3:17 PM, Yao, Jiewen wrote: > Thanks Min. > Many thanks for splitting SEV stuff to a standalone file. That is very good > start. > > Some other comments for your consideration: > > 1) There is no need to create a standalone Init32.asm and ReloadFlat32.asm. > They are only

Re: [edk2-devel] [PATCH V3 00/10] Add Intel TDX support in OvmfPkg/ResetVector

Thanks Min. Many thanks for splitting SEV stuff to a standalone file. That is very good start. Some other comments for your consideration: 1) There is no need to create a standalone Init32.asm and ReloadFlat32.asm. They are only needed in TDX so far. Please keep it in TDX. 2) I do not see the

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78201): https://edk2.groups.io/g/devel/message/78201 Mute This Topic: https://groups.io/mt/84303611/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: