Re: [edk2-devel] [PATCH] SecurityPkg: Debug code to audit BIOS TPM extend operations.

I am OK to add API to the library. I am OK to add one function call to dump PCR[0] in TcgPei to show if there is any measurement before BIOS. That is good use case for BootGuard. But I don't think we need dump the PCR every time in PCR_Extend - assuming TPM hardware is good, then it should

Re: [edk2-devel] [PATCH] Reallocate TPM Active PCRs based on platform support.

OK, Would you please to share the PCD configuration works before and PCD configuration fails now? As well as your DSC file on how to configure the library. I would like to understand the problem statement from real use case, because the issue description cannot provide useful information to

Re: [edk2-devel] [PATCH V2] RedfishPkg/RefishCrtLib: Public RefishCrtLib

Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Wednesday, August 11, 2021 11:01 AM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) Subject: [PATCH V2] RedfishPkg/RefishCrtLib: Public RefishCrtLib Public the header

Re: [edk2-devel] [PATCH] RedfishPkg/RefishCrtLib: Public RefishCrtLib

Hi Nickle, I sent the V2 patch to add the change on RedfishPkg.yaml file. Please review it again. Thanks Abner > -Original Message- > From: Wang, Nickle (HPS SW) > Sent: Sunday, August 8, 2021 9:00 PM > To: Chang, Abner (HPS SW/FW Technologist) ; > devel@edk2.groups.io > Subject: RE:

[edk2-devel] [PATCH V2] RedfishPkg/RefishCrtLib: Public RefishCrtLib

Public the header file, move RefishCrtLib.h from PrivateInclude/ to Include/. RefishCrtLib.lib will be public later. (Moved out from PrivateLibrary/) Signed-off-by: Abner Chang Cc: Nickle Wang Reviewed-by: Nickle Wang --- RedfishPkg/{PrivateInclude => Include}/Library/RedfishCrtLib.h | 2 +-

Re: [edk2-devel] [edk2-platforms] [PATCH V2] KabylakeOpenBoardPkg: Add MMIO Base/Length to SA GNVS

Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, August 11, 2021 11:46 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Michael Kubacki > ; Benjamin Doron > > Subject: [edk2-platforms] [PATCH V2] KabylakeOpenBoardPkg: Add MMIO >

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Add MMIO Base/Length to SA GNVS

Thank you for letting me know Chasel, please see PATCH V2 for the fix. Thanks, Nate -Original Message- From: Chiu, Chasel Sent: Tuesday, August 10, 2021 8:25 PM To: devel@edk2.groups.io; Chiu, Chasel ; Desimone, Nathaniel L Cc: Michael Kubacki ; Benjamin Doron Subject: RE:

[edk2-devel] [edk2-platforms] [PATCH V2] KabylakeOpenBoardPkg: Add MMIO Base/Length to SA GNVS

The SA GNVS Area contains fields for the MMIO region base address and length. This implements code to populate those fields. The MMIO Base/Length are used by ASL at runtime and must be populated for normal system operation. Cc: Chasel Chiu Cc: Michael Kubacki Cc: Benjamin Doron Signed-off-by:

Re: [edk2-devel] [staging/edk2-redfish-client RedfishFeatureCore PATCH 2/3] RedfishClientPkg/RedfishFeatureCoreDxe: Redfish Feature Core DXE driver

Thanks All issues were addressed before merged to edk2-staging edk2-redfish-clinet branch. Abner > -Original Message- > From: Wang, Nickle (HPS SW) > Sent: Sunday, August 8, 2021 8:55 PM > To: Chang, Abner (HPS SW/FW Technologist) ; > devel@edk2.groups.io > Cc: Liming Gao > Subject: RE:

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Add MMIO Base/Length to SA GNVS

Hi Nate, Internal test case failed, please see below inline for comments. Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, > Chasel > Sent: Wednesday, August 11, 2021 9:56 AM > To: Desimone, Nathaniel L ; > devel@edk2.groups.io > Cc: Michael

Re: [edk2-devel] [PATCH EDK2 v2 1/1] MdeModulePkg/UefiSortLib:Add UefiSortLib unit test

Hi Wu Hao， Thank you for your help. I will have a try and send a V3 patch later. Best Regards, Wenyi On 2021/8/11 9:50, Wu, Hao A wrote: > Seems no help is received so far. > The approach I can think of is to add this to the ECC exception list defined > in file MdeModulePkg.ci.yaml. > > Hello

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Add MMIO Base/Length to SA GNVS

Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, August 11, 2021 6:53 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Michael Kubacki > ; Benjamin Doron > > Subject: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Add MMIO >

Re: [edk2-devel] [edk2-platforms] [PATCH V1] MinPlatformPkg: Cleanup PeiFspWrapperHobProcessLib dependencies

Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, August 10, 2021 12:37 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Michael Kubacki > ; Benjamin Doron > > Subject: [edk2-platforms] [PATCH V1] MinPlatformPkg: Cleanup >

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeSiliconPkg: Update SA_MISC_PEI_PREMEM_CONFIG

Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, August 10, 2021 12:37 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Michael Kubacki > ; Benjamin Doron > > Subject: [edk2-platforms] [PATCH V1] KabylakeSiliconPkg: Update >

[edk2-devel] 回复: [PATCH v5 2/5] ArmPkg: prepare 32bit ARM build of StandaloneMmPkg

Etienne: Thanks for your update. This version should pass CI. Sami: Can you help review the updated patch? So, it can still catch this stable tag. Thanks Liming > -邮件原件- > 发件人: Etienne Carriere > 发送时间: 2021年8月9日 23:20 > 收件人: devel@edk2.groups.io > 抄送: Achin Gupta ; Ard Biesheuvel >

Re: [edk2-devel] [PATCH EDK2 v2 1/1] MdeModulePkg/UefiSortLib:Add UefiSortLib unit test

Seems no help is received so far. The approach I can think of is to add this to the ECC exception list defined in file MdeModulePkg.ci.yaml. Hello Wenyi, Could you help to check if the code changes in https://github.com/tianocore/edk2/pull/1883 works for you? If so, could you update a V3

回复: [edk2-devel] [PATCH v2 00/13] Add ACPI 6.4 header file

Create PR https://github.com/tianocore/edk2/pull/1887 for this patch set. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Sami > Mujawar > 发送时间: 2021年8月6日 16:19 > 收件人: Christopher Jones ; > devel@edk2.groups.io > 抄送: Akanksha Jain ; Ben Adderson > ; Michael Kinney ; >

[edk2-devel] [PATCH 1/1] BaseTools/GenFds: Change FV Header to FileSystemGuid3.

Following PI spec: when there has Ffs with EFI_FFS_FILE_HEADER2, the Parent Fv of the Ffs need set to FileSystemGuid3; when all the Ffs with EFI_FFS_FILE_HEADER, the Parent Fv of the Ffs need set to FileSystemGuid2. Currently, when changing the Ffs in Fv from EFI_FFS_FILE_HEADER to

Re: [edk2-devel] [PATCH 1/1] OvmfPkg PlatformBootManagerLib: Move TryRunningQemuKernel()

On 11/8/21 9:24 am, James Bottomley wrote: > On Wed, 2021-08-11 at 09:04 +1000, Christoph Willing wrote: >> On 11/8/21 12:26 am, James Bottomley wrote: >> [...] >>> In the working kernel dmesg Gerd requested, what does it mount as >>> root? sda? In which case what does the kernel say about where

Re: [edk2-devel] [PATCH 1/1] OvmfPkg PlatformBootManagerLib: Move TryRunningQemuKernel()

On Wed, 2021-08-11 at 09:04 +1000, Christoph Willing wrote: > On 11/8/21 12:26 am, James Bottomley wrote: > [...] > > In the working kernel dmesg Gerd requested, what does it mount as > > root? sda? In which case what does the kernel say about where it > > got sda from? > > > Yes it mounts

Re: [edk2-devel] [PATCH 1/1] OvmfPkg PlatformBootManagerLib: Move TryRunningQemuKernel()

On 11/8/21 12:26 am, James Bottomley wrote: > On Tue, 2021-08-10 at 10:10 +1000, Christoph Willing wrote: >> On 10/8/21 12:52 am, James Bottomley wrote: >>> On Mon, 2021-08-09 at 22:53 +1000, Christoph Willing wrote: With soft feature freeze started, I wonder if this patch could be

[edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Add MMIO Base/Length to SA GNVS

The SA GNVS Area contains fields for the MMIO region base address and length. This implements code to populate those fields. The MMIO Base/Length are used by ASL at runtime and must be populated for normal system operation. Cc: Chasel Chiu Cc: Michael Kubacki Cc: Benjamin Doron Signed-off-by:

Re: [edk2-devel] [edk2-platforms PATCH 2/7] Marvell: Armada7k8k/OcteonTx: Add missing _STA methods in ACPI tables

Hi, wt., 10 sie 2021 o 16:41 Ard Biesheuvel napisał(a): > > On Tue, 10 Aug 2021 at 16:36, Samer El-Haj-Mahmoud > wrote: > > > > Apologies for the tardiness in replying to this. Please see my comments > > below. > > > > > -Original Message- > > > From: Marcin Wojtas > > > Sent:

[edk2-devel] [edk2-platforms PATCH v2] Marvell: Armada7k8k/OcteonTx: Add missing _STA methods in ACPI tables

BBR 1.0 spec says that _STA is required for each device in DSDT or SSDT. Fix that for all platforms with the Marvell SoC's. Signed-off-by: Marcin Wojtas --- Changelog: v1->v2: * Rebase on top of tree Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl| 56 +++

Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

> On Aug 10, 2021, at 2:30 PM, Marvin Häuser wrote: > > On 10/08/2021 21:35, Andrew Fish via groups.io wrote: >> >> >>> On Aug 10, 2021, at 1:27 AM, Marvin Häuser >> > wrote: >>> >>> On 10/08/2021 06:19, Andrew Fish via groups.io wrote:

Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

> On Aug 10, 2021, at 2:24 PM, Marvin Häuser wrote: > > On 10/08/2021 21:49, Andrew Fish wrote: >> I forgot I have an Ubuntu VM so we can take a look at an ELF to PE/COFF >> toolchain example …. >> >> So it looks like nasm[1] “does the right thing”(tm) and places a .rodata >> section in

Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

On 10/08/2021 21:35, Andrew Fish via groups.io wrote: On Aug 10, 2021, at 1:27 AM, Marvin Häuser > wrote: On 10/08/2021 06:19, Andrew Fish via groups.io wrote: On Aug 9, 2021, at 2:51 AM, Marvin Häuser

Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

On 10/08/2021 21:49, Andrew Fish wrote: I forgot I have an Ubuntu VM so we can take a look at an ELF to PE/COFF  toolchain example …. So it looks like nasm[1] “does the right thing”(tm) and places a .rodata section in the object file…. But it looks like GenFw[2] smashed the .rodata section

Re: [edk2-devel] [PATCH v2 1/2] MdePkg/BaseLib: Fix unaligned API prototypes

On 10/08/2021 19:36, Andrew Fish via groups.io wrote: On Aug 10, 2021, at 1:53 AM, Marvin Häuser > wrote: On 09/08/2021 23:32, Andrew Fish viagroups.io wrote: On Aug 9, 2021, at 9:15 AM, Michael D Kinney

Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

> On Aug 10, 2021, at 1:27 AM, Marvin Häuser wrote: > > On 10/08/2021 06:19, Andrew Fish via groups.io wrote: >> >> >>> On Aug 9, 2021, at 2:51 AM, Marvin Häuser >> > wrote: >>> >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3318 >>>

[edk2-devel] edk2-test Release Notice

Hello All, This mail is to notify that the edk2-test repository shall be released by end of August 2021 with the tag edk2-test-stable202108. The base-line commit shall be: 814b2af535d977b3967d65de77e42ab18a4f4db4 Please feel free to contact me or Barton for any clarifications. With Warm

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption

Thanks to capture and fix this issue. Reviewed-by: Guo Dong -Original Message- From: Marvin Häuser Sent: Sunday, August 8, 2021 12:40 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin ; Vitaly Cheptsov Subject: [PATCH]

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix the non-ascii character in UniversalPayloadEntry.c

Reviewed-by: Guo Dong -Original Message- From: Tan, Dun Sent: Sunday, August 8, 2021 11:08 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin ; Tan, Dun Subject: [PATCH] UefiPayloadPkg: Fix the non-ascii character in UniversalPayloadEntry.c Fix the

Re: [edk2-devel] [PATCH v2 1/2] MdePkg/BaseLib: Fix unaligned API prototypes

> On Aug 10, 2021, at 1:53 AM, Marvin Häuser wrote: > > On 09/08/2021 23:32, Andrew Fish via groups.io wrote: >> >> >>> On Aug 9, 2021, at 9:15 AM, Michael D Kinney >> >>

[edk2-devel] [PATCH v3 6/6] ArmVirtPkg: Disable the TPM2 platform hierarchy

Use the newly added function to disable the TPM2 platform hierarchy. Signed-off-by: Stefan Berger --- ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 6 ++ .../PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + 2 files changed, 7 insertions(+) diff --git

[edk2-devel] [PATCH v3 2/6] OvmfPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib

Add a NULL implementation of the library class TpmPlatformHierarchyLib Signed-off-by: Stefan Berger --- .../PeiDxeTpmPlatformHierarchyLib.c | 19 .../PeiDxeTpmPlatformHierarchyLib.inf | 31 +++ 2 files changed, 50 insertions(+) create mode 100644

[edk2-devel] [PATCH v3 1/6] OvmfPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms

Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms. Modify it so that ConfigureTpmPlatformHierarchy() is the only public function provided by this file. Signed-off-by: Stefan Berger --- .../Include/Library/TpmPlatformHierarchyLib.h | 27 +++ .../PeiDxeTpmPlatformHierarchyLib.c

[edk2-devel] [PATCH v3 4/6] OvmfPkg: Disable the TPM2 platform hierarchy

Use the newly added function to disable the TPM2 platform hierarchy. Signed-off-by: Stefan Berger --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 6 ++ OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c | 6 ++

[edk2-devel] [PATCH v3 5/6] ArmVirtPkg: Reference new TPM classes in the build system for compilation

Signed-off-by: Stefan Berger --- ArmVirtPkg/ArmVirtCloudHv.dsc| 1 + ArmVirtPkg/ArmVirtQemu.dsc | 3 +++ ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + ArmVirtPkg/ArmVirtXen.dsc| 1 + 4 files changed, 6 insertions(+) diff --git a/ArmVirtPkg/ArmVirtCloudHv.dsc

[edk2-devel] [PATCH v3 3/6] OvmfPkg: Reference new TPM classes in the build system for compilation

Compile the added TPM related code now. Signed-off-by: Stefan Berger --- OvmfPkg/AmdSev/AmdSevX64.dsc | 3 +++ OvmfPkg/Bhyve/BhyveX64.dsc | 1 + .../Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 +

Re: [edk2-devel] [edk2-platforms] [PATCH V1] MinPlatformPkg: Cleanup PeiFspWrapperHobProcessLib dependencies

Acked-by: Michael Kubacki On 8/10/2021 12:37 AM, Nate DeSimone wrote: PeiFspWrapperHobProcessLib is currently set to depens on FspWrapperPlatformLib, but it does not use any of the functions implemented by that LibraryClass. This change removes that unneeded dependency. Cc: Chasel Chiu Cc:

[edk2-devel] [PATCH v3 6/6] Platform/StandaloneMm: build StandaloneMmRpmb for 32bit architectures

Build PlatformStandaloneMmRpmb for ARM architecture (32bit arm machine). The generated image targets an execution environment similar to AArch64 StMM secure partition in OP-TEE but in 32bit mode. GCC flag -fno-stack-protector added. The stack protection code bring GOT dependencies we prefer avoid

[edk2-devel] [PATCH v3 5/6] Drivers/OpTee: address cast build warning issue in 32b mode

Use (UINTN) cast to cast physical or virtual address values to the pointer size before casting from/to a pointer value. Cc: Ard Biesheuvel Cc: Ilias Apalodimas Cc: Leif Lindholm Cc: Sami Mujawar Signed-off-by: Etienne Carriere --- No change since v2 No change since v1 ---

[edk2-devel] [PATCH v3 4/6] Drivers/OpTee: Add Aarch32 SVC IDs for 32bit Arm targets

Add SMCCC function IDs for RPMB read/write service on 32bit architectures. Define generic SP_SVC_RPMB_READ/SP_SVC_RPMB_WRITE IDs for native target architecture (32b or 64b). Changes OpTeeRpmbFvb.c to use architecture agnostic macro ARM_SVC_ID_FFA_MSG_SEND_DIRECT_REQ for 32b and 64b support. Cc:

[edk2-devel] [PATCH v3 2/6] Platform/Socionext/DeveloperBox: sync with edk2 StandaloneMmCpu path change

Synchronize with edk2 package where StandaloneMmCpu component has moved from StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf to StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf Cc: Ard Biesheuvel Cc: Ilias Apalodimas Cc: Leif Lindholm Cc: Sami Mujawar Cc:

[edk2-devel] [PATCH v3 3/6] Platform/StandaloneMm: sync with edk2 StandaloneMmCpu path change

Synchronize with edk2 package where StandaloneMmCpu component has moved from StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf to StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf Cc: Ard Biesheuvel Cc: Ilias Apalodimas Cc: Leif Lindholm Cc: Sami Mujawar Cc:

[edk2-devel] [PATCH v3 1/6] Platform/ARM/SgiPkg: sync with edk2 StandaloneMmCpu path change

Synchronize with edk2 package where StandaloneMmCpu component has moved from StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf to StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf Cc: Ard Biesheuvel Cc: Ilias Apalodimas Cc: Leif Lindholm Cc: Sami Mujawar Cc:

[edk2-devel] [PATCH v3 0/6] Arm 32bit support in PlatformStandaloneMmRpmb

This series brings support for building PlatformStandaloneMmRpmb for 32bit Arm architectures. This series is based on series tracked through [1] in edk2 that allows to build StandaloneMm package for 32bit Arm. This series starts by syncing with paths changes from [1] series, then comes changes for

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

Installation is a platform decision. The buried dependency on boot mode in this particular function is just a roadblock platforms have to work around. The role of this API is to install the PPI. Thanks, Michael On 8/9/2021 9:47 PM, Ni, Ray wrote: Michael, Allowing the gPeiSmmAccessPpiGuid

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg: Add BaseSmmAccessLibNull

There is not a SmmAccess PEIM in IntelSiliconPkg. There is a SmmAccessDxe driver: https://github.com/tianocore/edk2-platforms/blob/master/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/SmmAccessDxe/SmmAccess.inf And there is a PeiSmmAccessLib:

Re: [edk2-devel] [PATCH] ArmPkg: Enable boot discovery policy for ARM package.

Hi Ard, Yeah, this is a good point. Greg and I offline discussed this as well. If we don't miss anything, only applying this patch without platform changes should be fine. There should be no behavior change. I added some details below for your reference. - if the platform doesn’t add

Re: [edk2-devel] [edk2-platforms PATCH 2/7] Marvell: Armada7k8k/OcteonTx: Add missing _STA methods in ACPI tables

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel via groups.io > Sent: Tuesday, August 10, 2021 10:41 AM > To: edk2-devel-groups-io ; Samer El-Haj-Mahmoud > > Cc: Marcin Wojtas ; Leif Lindholm ; > Ard Biesheuvel ; Grzegorz Jaszczyk > ; Grzegorz Bernacki ;

Re: [edk2-devel] [edk2-platforms PATCH 2/7] Marvell: Armada7k8k/OcteonTx: Add missing _STA methods in ACPI tables

On Tue, 10 Aug 2021 at 16:36, Samer El-Haj-Mahmoud wrote: > > Apologies for the tardiness in replying to this. Please see my comments below. > > > -Original Message- > > From: Marcin Wojtas > > Sent: Friday, July 30, 2021 5:57 AM > > To: Ard Biesheuvel > > Cc: Samer El-Haj-Mahmoud ;

Re: [edk2-devel] [PATCH 1/1] OvmfPkg PlatformBootManagerLib: Move TryRunningQemuKernel()

On Tue, 2021-08-10 at 10:10 +1000, Christoph Willing wrote: > On 10/8/21 12:52 am, James Bottomley wrote: > > On Mon, 2021-08-09 at 22:53 +1000, Christoph Willing wrote: > > > With soft feature freeze started, I wonder if this patch could be > > > reviewed and pushed for edk2-stable202108 tag? I

Re: [edk2-devel] [PATCH v6 6/6] OvmfPkg/AmdSevDxe: Add support for SEV live migration.

On 8/10/21 6:13 AM, Ashish Kalra wrote: > Hello Tom, > > On Mon, Aug 09, 2021 at 09:29:29AM -0500, Tom Lendacky wrote: >> On 8/2/21 7:33 AM, Ashish Kalra wrote: >> >> Should there be an "ASSERT_EFI_ERROR (Status)" after the DEBUG call? >> > > I don't think we should do an assert here and abort

Re: [edk2-devel] [PATCH v6 1/6] OvmfPkg/BaseMemEncryptLib: Detect SEV live migration feature.

On 8/10/21 1:05 AM, Gerd Hoffmann wrote: > Hi, > >>> I still really don't understand the need for the CPUID loop. KVM only ever >>> programs CPUID function 0x4000, right? > > Nope. When you enable hyper-v emulation features you'll go find the kvm > cpuid @ 0x4000 and the hyper-v cpuid

Re: [edk2-devel] [PATCH 1/1] OvmfPkg PlatformBootManagerLib: Move TryRunningQemuKernel()

On 10/8/21 4:01 pm, Gerd Hoffmann wrote: > Hi, > >> insmod /lib/modules/5.13.8/kernel/fs/jbd2/jbd2.ko >> insmod /lib/modules/5.13.8/kernel/fs/mbcache.ko >> insmod /lib/modules/5.13.8/kernel/fs/ext4/ext4.ko >> mount: mounting /dev/sda2 on /mnt failed: No such file or directory >> ERROR: No

Re: [edk2-devel] [PATCH v6 6/6] OvmfPkg/AmdSevDxe: Add support for SEV live migration.

Hello Tom, On Mon, Aug 09, 2021 at 09:29:29AM -0500, Tom Lendacky wrote: > On 8/2/21 7:33 AM, Ashish Kalra wrote: > > From: Ashish Kalra > > > > Check for SEV live migration feature support, if detected > > setup a new UEFI enviroment variable to indicate OVMF > > support for SEV live

Re: [edk2-devel] [PATCH v2 1/2] MdePkg/BaseLib: Fix unaligned API prototypes

On 09/08/2021 23:32, Andrew Fish via groups.io wrote: On Aug 9, 2021, at 9:15 AM, Michael D Kinney mailto:michael.d.kin...@intel.com>> wrote: Hi Marvin, Can you provide an example of which C compiler is flagging this as an error and what error message is generated. Please enter a BZ with

Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/BaseUefiCpuLib: Use toolchain-specific rodata section name

On 10/08/2021 06:40, Andrew Fish via groups.io wrote: On Aug 9, 2021, at 7:43 PM, Ni, Ray > wrote: Acked-by: Ray Ni mailto:ray...@intel.com>> I will depend on tool owner to review the tool configuration change making sure that the correct section name is chosen for

Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

On 10/08/2021 06:19, Andrew Fish via groups.io wrote: On Aug 9, 2021, at 2:51 AM, Marvin Häuser > wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3318 Different toolchains of the EDK II build

Re: [edk2-devel] [PATCH 0/3] BaseTools: fix some python DeprecationWarnings

Hi Robinson, When we doing the internal test, the issue is found that py27 is blocked by this patch. You can reproduce the error with below steps: For Linux: [Error Reproduce steps] $ export PYTHON3_ENABLE=FALSE $ export PYTHON_COMMAND=/usr/bin/python2.7 $ build -p OvmfPkg/OvmfPkgIa32X64.dsc

[edk2-devel] [edk2-platforms:PATCH V6] Platform/Intel: Correct CPU APIC IDs

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365 BIOS cannot find correct AcpiProcId in mApicIdMap because of there is no suitable map, that causes ACPI_BIOS_ERROR. Remove mApicIdMap for determing AcpiProcId, uses normal countings instead. Signed-off-by: JackX Lin Cc: Chasel Chiu Cc:

Re: [edk2-devel] [PATCH] SecurityPkg: Debug code to audit BIOS TPM extend operations.

Hi Jiewen, The intention of such API would be to ease debugging and auditing PCR attestation along the boot; it has been a common task while debugging several issues and TPM configurations. a) Configurations in which BIOS is not the S-CRTM and we need to attest what has been measured to the

Re: [edk2-devel] [PATCH] Reallocate TPM Active PCRs based on platform support.

Hi Jiewen, Indeed, this bug has existed for a long time in this code. What recently changed are the TPM configurations we are testing and exposed the issue; this can be reproduced when the BIOS supported algorithms are a strict subset of the PCRs currently active in the TPM. Now that we are

Re: [edk2-devel] [PATCH v6 1/6] OvmfPkg/BaseMemEncryptLib: Detect SEV live migration feature.

Hi, > > I still really don't understand the need for the CPUID loop. KVM only ever > > programs CPUID function 0x4000, right? Nope. When you enable hyper-v emulation features you'll go find the kvm cpuid @ 0x4000 and the hyper-v cpuid @ 0x4100 (or the other way around, not sure).

Re: [edk2-devel] [PATCH 1/1] OvmfPkg PlatformBootManagerLib: Move TryRunningQemuKernel()

Hi, > insmod /lib/modules/5.13.8/kernel/fs/jbd2/jbd2.ko > insmod /lib/modules/5.13.8/kernel/fs/mbcache.ko > insmod /lib/modules/5.13.8/kernel/fs/ext4/ext4.ko > mount: mounting /dev/sda2 on /mnt failed: No such file or directory > ERROR: No /sbin/init found on rootdev (or not mounted). Trouble