Hi
> > The base VmgExitLib library provides a default limited interface to
> > handle #VE exception. To provide full support, the OVMF version of
> > VmgExitLib is extended to provide full support of #VE handler.
> >
> > PcdIgnoreVeHalt is created in OvmfPkg.dec to ignore the VE halt.
>
> Why
Hi Wenyi,
Could you please create PR for this change? So we can have core CI on this
patch and I can also merge this patch later when the core CI is finished
successfully.
Just send me the link to PR once you create it.
Thanks
Abner
From: xiewenyi (A)
Sent:
Create PR https://github.com/tianocore/edk2/pull/2427 for it.
Thanks
Liming
> -邮件原件-
> 发件人: Michael Kubacki
> 发送时间: 2022年1月20日 3:46
> 收件人: devel@edk2.groups.io; guomin.ji...@intel.com
> 抄送: Gao, Liming ; Kinney, Michael D
> ; Xu, Wei6
> 主题: Re: [edk2-devel] [PATCH v1 1/1]
This enables Whitley as a test vehicle for features.
These are not expected to be fully functional at this time.
Specifically UserAuthentication causes a boot failure and the others
have only been verified to be built and dispatched, not ported to
the Whitley reference platform hardware.
Cc: Nate
This produces three FV and no FD.
FvAdvancedPreMemory.fv contains PEIM for pre-memory use.
FvAdvancedUncompressed.fv contains post memory PEIM and drivers for DXE
and SMM.
FvAdvanced.fv contains the compressed FvAdvancedUncompressed.fv in an
FV file format as is common practice.
These FV are not
The AdvancedFeaturePkg is supposed to include all features.
Add Beep Debug feature to include DSC and FDF.
Order features based on their domains.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 66
Use the MinPlatformPkg common core build files to build libraries
needed by this feature.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMemory.fdf|
2 +-
Use the MinPlatformPkg common core build files to build libraries
needed by this feature.
Cc: Dandan Bi
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 69
Remove build of common libraries. Boards will already have those.
Modified Usb3DebugFeature.dsc to treat libraries like libraries.
Usb3DebugFeaturePkg.dsc uses the component trick for standalone build
testing of the libraries.
Added a PCD to allow board to select between NULL, regular, and IO
Packages should be at the root of a PACKAGES_PATH entry.
At some point, paths were relative to edk2-platforms/Features/Intel
which was functional, but interferes with the proper functioning
of packaging tools.
Cc: Liming Gao
Cc: Dandan Bi
Signed-off-by: Isaac Oram
---
Use the MinPlatformPkg common core build files to build libraries
needed by this feature.
Cc: Dandan Bi
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/UserInterface/UserAuthFeaturePkg/Include/PostMemory.fdf |
6 +-
Use the MinPlatformPkg common core build files to build libraries
needed by this feature.
Cc: Eric Dong
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dsc | 21
++
Add feature enable PCD.
Use MinPlatformPkg build include files.
Fix PEI_COR typo in PEI handler lib.
Build StatusCodeHandler components with unique filename GUID.
Add PreMemory.fdf and PostMemory.fdf include files.
Improve Readme formatting and feature enabling checklist.
Cc: Eric Dong
Cc:
Use the MinPlatformPkg common core build files to build libraries
needed by this feature.
Cc: Dandan Bi
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/VirtualKeyboardFeature.dsc
| 62 +++-
Packages should be at the root of a PACKAGES_PATH entry.
At some point, paths were relative to edk2-platforms/Features/Intel
which was functional, but interferes with the proper functioning
of packaging tools.
Cc: Liming Gao
Cc: Dandan Bi
Signed-off-by: Isaac Oram
---
The BeepDebugFeaturePkg was malformed and did not build anything
and thus wasn't testable in standalone build.
Added gBeepDebugFeaturePkgTokenSpaceGuid.PcdBeepDebugFeatureEnable
to properly control the advanced feature inclusion.
Use the standard MinPlatform includes for core libraries. This
This series addresses inconsistencies in feature implementation and use. Some
inconsistencies are just
conventions of the feature design/template/convention. Some are inconsistency
with feature design intent
that negatively affect the usability of the features and the amount of work
required
VirtualKeyboard missing feature enable PCD.
Cc: Liming Gao
Cc: Dandan Bi
Signed-off-by: Isaac Oram
---
Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/PostMemory.fdf
| 2 +-
Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardFeaturePkg.dec
| 7
Hi Guo ,
yes, I know it is merged, and I have some update based on that change.
I get comments from Ray, and he suggests using BaseCpuTimerLib for Universal
Payload by default.
The reason is that we only want to enable UPL on latest CPUs and they should
all support the BaseCpuTimerLib. (qemu is
Reviewed-by: Isaac Oram
-Original Message-
From: Chaganty, Rangasai V
Sent: Wednesday, January 19, 2022 4:04 PM
To: Desimone, Nathaniel L ; devel@edk2.groups.io
Cc: Oram, Isaac W ; Gao, Liming
; Kinney, Michael D
Subject: RE: [PATCH v1] Add maintainers for advanced features
Reviewed-by: Sai Chaganty
-Original Message-
From: Desimone, Nathaniel L
Sent: Wednesday, January 19, 2022 3:59 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Oram, Isaac W
; Gao, Liming ; Kinney,
Michael D
Subject: [PATCH v1] Add maintainers for advanced features
Add
Add maintainers to Features/Intel to enable expedient approval
of new advanced features.
Cc: Sai Chaganty
Cc: Isaac Oram
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Nate DeSimone
---
Maintainers.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Maintainers.txt
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Oram, Isaac W
Sent: Tuesday, January 11, 2022 6:20 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Chaganty, Rangasai V
; Gao, Liming ; Dong,
Eric ; Tan, Ming
Subject:
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Oram, Isaac W
Sent: Tuesday, January 11, 2022 6:20 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Dong, Eric ;
Gao, Liming
Subject: [edk2-devel][edk2-platforms][PATCH V1 18/27] AcpiDebugFeaturePkg:
Hi Isaac,
Thank you for digging into the PEI_ARCH/DXE_ARCH issue. It is unfortunate that
issue is not totally solved in BaseTools yet. With that new knowledge, Patch 1
and 18 are now approved. Please fix patch 19 and resend it. I think that should
complete the series.
Thanks,
Nate
Improve the MemEncryptSev{Es,Snp}IsEnabled() to use the SEV_STATUS MSR
value saved in the workarea. Since workarea is valid until the PEI phase,
so, for the Dxe phase use the PcdConfidentialComputingGuestAttr to
determine which SEV technology is enabled.
Cc: Min Xu
Cc: Jiewen Yao
Cc: Tom
In order to probe the SEV feature the BaseMemEncryptLib and Reset vector
reads the SEV_STATUS MSR. Cache the value on the first read in the
workarea. In the next patches the value saved in the workarea will
be used by the BaseMemEncryptLib. This not only eliminates the extra
MSR reads it also
This is the first of cleanup for SEV MemEncryptLib. The library uses
the CPUID followed by the MSR read to determine whether SEV is enabled.
Now that we have a workarea concept, the logic can be simplified to
store the msr status in workarea and use that to build PCDs and then
later simply use
Oh, thanks! It turns out there was one remaining use in MdeModulePkg, by
UefiBootManagerLib.
I've sent the following patch to fix it: [PATCH 1/1]
MdeModulePkg/UefiBootManagerLib: Convert BmLoadOption to Variable Policy .
--
Rebecca Cran
On 1/18/22 23:30, gaoliming wrote:
Rebecca:
It
Since the Variable Lock protocol is deprecated, convert locking of
PlatformRecovery in EfiBootManagerLoadOptionToVariable to use the
Variable Policy protocol.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhichao Gao
Cc: Ray Ni
Signed-off-by: Rebecca Cran
---
Hi Guomin,
It has been a couple of weeks since your review and I have not seen the
patch merged yet.
Do you know when it will be merged?
Thanks,
Michael
On 1/6/2022 10:45 PM, Guomin Jiang wrote:
Reviewed-by: Guomin Jiang
Guomin
-Original Message-
From:
Pushed as 6e4384833e..b2503a71a3
-Original Message-
From: Desimone, Nathaniel L
Sent: Wednesday, January 12, 2022 6:51 PM
To: Oram, Isaac W ; devel@edk2.groups.io
Cc: Chiu, Chasel
Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 25/27]
WhitleyOpenBoardPkg/Build: Use common SPI FV
Pushed as dd5139c6a6..6e4384833e
-Original Message-
From: Chaganty, Rangasai V
Sent: Thursday, January 13, 2022 10:02 PM
To: Oram, Isaac W ; devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Gao, Liming
; Dong, Eric
Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 24/27]
Pushed as 92228e9e4b..dd5139c6a6
-Original Message-
From: Chaganty, Rangasai V
Sent: Thursday, January 13, 2022 9:39 PM
To: Oram, Isaac W ; devel@edk2.groups.io
Cc: Gao, Liming
Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 22/27] AdvancedFeaturePkg:
Fix all relative package paths
Pushed as 2082072cc8..92228e9e4b
-Original Message-
From: Chaganty, Rangasai V
Sent: Thursday, January 13, 2022 10:06 PM
To: Oram, Isaac W ; devel@edk2.groups.io
Cc: Gao, Liming
Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 21/27] TemplateFeaturePkg:
Use MinPlatform build include
Pushed as d0919cab63..2082072cc8
-Original Message-
From: Chaganty, Rangasai V
Sent: Thursday, January 13, 2022 10:10 PM
To: Oram, Isaac W ; devel@edk2.groups.io
Cc: Gao, Liming
Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 20/27] SpcrFeaturePkg: Use
MinPlatform build include
On 1/13/22 10:30 AM, Peter Gonda wrote:
The SEV-ES bit of Fn800-001F[EAX] - Bit 3 is used for a host to
determine support for running SEV-ES guests. It should not be checked by
a guest to determine if it is running under SEV-ES. The guest should use
the SEV_STATUS MSR Bit 1 to determine if
Hi Abdul,
Please also create a bugzilla ticket and add a reference to it in the
commit message.
Regards,
Sami Mujawar
On 19/01/2022 04:44 PM, Sami Mujawar wrote:
Hi Abdul,
Thank you for providing a patch to add this feature to Acpiview.
I have some minor feedback marked inline as
Hi Abdul,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 19/12/2021 02:44 PM, Abdul Lateef Attar wrote:
Adds PrintFormatter function to the FADT flags field.
Prints indivisual flag name along with flag value.
Cc: Ray Ni
Cc:
Hi Abdul,
Thank you for providing a patch to add this feature to Acpiview.
I have some minor feedback marked inline as [SAMI].
Regards,
Sami Mujawar
On 19/12/2021 02:44 PM, Abdul Lateef Attar wrote:
Adds ParseAcpiBitFields() which is based on
ParseAcpi() and capable of parsing the bit
Hi Steven,
I don't have opinions with enabling GNU parallel job, that is fine if it does
break the build.
However I am not the maintainer of BaseTools, thus I can't give the review tag
to this change.
Regards,
Abner
> -Original Message-
> From: Shi, Steven
> Sent: Wednesday, January
Hi Khasim,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 22/12/2021 01:14 AM, Khasim Mohammed via groups.io wrote:
The patch removes PciExpressLib implementation for N1Sdp as:
a) The PciSegmentLib implementation for N1Sdp
Hi Khasim,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 22/12/2021 01:14 AM, Khasim Mohammed via groups.io wrote:
This patch enables CCIX root complex support by updating
the root complex node info in PciHostBridge library.
Hi Khasim,
Thank you for this patch.
I have a minor suggestion marked inline as [SAMI]. Otherwise this patch
looks good to me.
With that changed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 22/12/2021 01:14 AM, Khasim Mohammed via groups.io wrote:
PCD entries are updated to
Hi Khasim,
Thank you for this patch.
Please find my feedback marked inline as [SAMI].
Regards,
Sami Mujawar
On 22/12/2021 01:14 AM, Khasim Mohammed via groups.io wrote:
The BasePCISegment Library in MdePkg doesn't allow configuring
multiple segments required for PCIe and CCIX root port
Reviewed-by: Robert Kowalewski
-Original Message-
From: Sheng, W
Sent: Tuesday, January 18, 2022 9:15 AM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Chaganty, Rangasai V
; Huang, Jenny ;
Kowalewski, Robert
Subject: [PATCH v5 1/4] IntelSiliconPkg/VTd: Fix typos
It is DRHD(DMA Remapping
Hello Ard, Leif, Abner, Daniel,
Are you ok to enable the GNU make "--jobs" option in GCC5 toolchain by default?
Thanks
Steven Shi
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Steven
> Shi
> Sent: Monday, January 17, 2022 10:54 PM
> To: a...@kernel.org;
Hi Leif,
Apologies, I had forgotten to send a patch to add myself as the reviewer for
ArmPkg.
I have now sent a patch to update the maintainer.txt at
https://edk2.groups.io/g/devel/message/85812
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Signed-off-by: Sami Mujawar
---
Notes:
v1:
- Add Sami as the reviewer for ArmPkg[SAMI]
Ref: https://edk2.groups.io/g/devel/message/82219
Maintainers.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Maintainers.txt
Any idea?
From: devel@edk2.groups.io on behalf of Boeuf, Sebastien
Sent: Tuesday, January 11, 2022 4:23 PM
To: Kinney, Michael D ; bret.barke...@microsoft.com
; sean.bro...@microsoft.com
; devel@edk2.groups.io
Subject: [edk2-devel] Does CI support nested
Hi Kun,
Thank you for this patch series.
These changes look good to me. For this series
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 21/12/2021 01:33 AM, Kun Qin via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3709
REF:
Current, a macro CPU_TIMER_LIB_ENABLE is added to determine which timerlib
is used. BaseCpuTimerLib.inf is a better way and only fit for recent CPU.
Meanwhile, Universal Payload are only aimed to work with recent CPU.
Therefore, for Universal Payload, use the BaseCpuTimerLib by default
Cc: Guo
Hi Kun,
I will review this patch series shortly.
Regards,
Sami Mujawar
On 18/01/2022, 22:07, "devel@edk2.groups.io on behalf of Kun Qin via
groups.io"
wrote:
I thought the reply on website will retain the original CC list. But I
was wrong about that.
Thanks for the reminder,
53 matches
Mail list logo
