Call GopQueryMode() in GopSetMode(), use the ModeInfo returned when
setting the mode. This is needed to properly handle modes which are
not on the static mGopResolutions list.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/VirtioGpuDxe/Gop.c | 60 --
1 file
Try query native display resolution from the host. When successfull
setup PcdVideoHorizontalResolution and PcdVideoVerticalResolution
accordingly and add the video mode to the GOP mode list if needed.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/VirtioGpuDxe/VirtioGpu.inf | 6 ++
Add new function to initialize the GOP, move over setup code. Handle
initialization first, specifically before calling GopQueryMode(), so
GopQueryMode is never called before GopInitialize() did complete.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/VirtioGpuDxe/Gop.c | 47
Extend VirtioGpuSendCommand() to support commands which return data,
rename the function to VirtioGpuSendCommandWithReply() to indicate that.
Add a new VirtioGpuSendCommand() function which is just a thin wrapper
around VirtioGpuSendCommandWithReply() so existing code continues to
work without
Gerd Hoffmann (6):
OvmfPkg/VirtioGpuDxe: add VirtioGpuSendCommandWithReply
OvmfPkg/VirtioGpuDxe: add GetDisplayInfo to virtio-gpu spec header.
OvmfPkg/VirtioGpuDxe: add VirtioGpuGetDisplayInfo
OvmfPkg/VirtioGpuDxe: use GopQueryMode in GopSetMode
OvmfPkg/VirtioGpuDxe: move code to
Add GetDisplayInfo command, reply and data struct to the
virtio-gpu specification header file.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Include/IndustryStandard/VirtioGpu.h | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git
Add support for sending a GetDisplayInfo command.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/VirtioGpuDxe/VirtioGpu.h | 6 ++
OvmfPkg/VirtioGpuDxe/Commands.c | 20
2 files changed, 26 insertions(+)
diff --git a/OvmfPkg/VirtioGpuDxe/VirtioGpu.h
Solution is upstreamed through commit:
https://github.com/tianocore/edk2-test/commit/d919c4a5d9fe2681de4d11a0bbfb07373fe6f9c7
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86356): https://edk2.groups.io/g/devel/message/86356
Mute This
The solution is upstreamed through commit-id:
https://github.com/tianocore/edk2-test/commit/733a11dceaa043e9e5f95e9e224442f134d0975f
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86355): https://edk2.groups.io/g/devel/message/86355
Mike Kinney mentioned at the TianoCore Stewards Meeting that it might be a good
idea to add a panic API to the edk2. I agree.
Some background…. While ASSERT is a powerful tool I think we have a tendency to
misuse it at times in our TianoCore code:
1) Sometime we do ASSERT when we should be
Mike,
That sounds like the right fox to me. Disable the warning.
> On Feb 2, 2022, at 1:18 PM, Michael D Kinney
> wrote:
>
>
> Hi Rebecca,
>
> GCC added -Wno-unused-but-set-variable back in 2016 for RELEASE builds to
> address this same issue
>
>
From: Ken Lautner
Update to the newest pytools and resolves the API change for
GetAbsolutePathOnThisSytemFromEdk2RelativePath
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Kenneth Lautner
---
.azurepipelines/Ubuntu-PatchCheck.yml
On 2/2/22 14:16, Lendacky, Thomas via groups.io wrote:
This looks like the same error that XCODE5 was complaining about. The
patch was submitted by Brijesh, but some CI failure occurred. I'm not
sure how that is possible from a one line patch like that, maybe it
has something to do with the
Pushed as 8f41641a6f..c05cbfd80a
-Original Message-
From: Desimone, Nathaniel L
Sent: Friday, January 21, 2022 5:37 PM
To: Oram, Isaac W ; devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Gao, Liming
; Dong, Eric ; Tan, Ming
; Chiu, Chasel ; Bi, Dandan
; Shindo, Miki ; Abbas, Mohamed
I mean missing gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut |$
(PLATFORM_BOOT_TIMEOUT)
-Original Message-
From: devel@edk2.groups.io On Behalf Of Guo Dong
Sent: Wednesday, February 2, 2022 4:07 PM
To: devel@edk2.groups.io; Rhodes, Sean
Subject: Re: [edk2-devel] [PATCH]
+ DEFINE PLATFORM_BOOT_TIMEOUT= 3
It looks you missed the change to gEfiMdePkgTokenSpaceGuid using
PLATFORM_BOOT_TIMEOUT.
Thanks,
Guo
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sean Rhodes
Sent: Wednesday, February 2, 2022 12:16 AM
To: devel@edk2.groups.io
Cc:
Hi Rebecca,
GCC added -Wno-unused-but-set-variable back in 2016 for RELEASE builds to
address this same issue
https://github.com/tianocore/edk2/commit/20d00edf21d2f2144921622891d8b59a1553cd83
Then later added -Wno-unused-const-variable
On 2/2/22 14:54, Rebecca Cran wrote:
VmgExitLib fails to build with the CLANG38 toolset (clang 13.0.0):
edk2/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1875:9: error: variable
'Compacted' is used uninitialized whenever 'if' condition is false [-Werror,-W
sometimes-uninitialized]
if
VmgExitLib fails to build with the CLANG38 toolset (clang 13.0.0):
edk2/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1875:9: error:
variable 'Compacted' is used uninitialized whenever 'if' condition is
false [-Werror,-W
sometimes-uninitialized]
if (EcxIn == 1) {
^~
With the CLANG38 toolset (clang version 13.0.0) MdePkg fails to build in
RELEASE mode because Status is only used by an assert.
edk2/MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c:141:15:
error: variable 'Status' set but not used
[-Werror,-Wunused-but-set-variable]
EFI_STATUS
For this series,
Reviewed-by: Sami Mujawar
Merged as 017564d637e9..33189f052783
Regards,
Sami Mujawar
On 13/01/2022 04:40 PM, Rebecca Cran wrote:
Add functions to generate code for the Memory32Fixed ASL macro and a
method returning an Integer.
Remove a redundant cast from
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Leif Lindholm
> Sent: Monday, January 31, 2022 3:43 AM
> To: Leif Lindholm
> Cc: devel@edk2.groups.io; Andrew Fish ; Kinney, Michael D
>
> Subject: Re: [PATCH 2/2] Maintainers.txt: update email for Leif Lindholm
>
> On Mon,
Jake,
Sorry for the delay.
Pushed as 8f41641a6f29e2ae3ffe2ed44a026db7993ed94f.
On Tue, Jan 25, 2022 at 2:13 PM Jake Garver wrote:
> This change modularizes the Ext4 DSC/FDF files following the model used
> in edk2/NetworkPkg.
>
> A platform DSC can include Ext4 using "!include
On 2/2/22 07:53, Sami Mujawar wrote:
+ Status = AmlCodeGenInteger (Integer, );
+ ASSERT_EFI_ERROR (Status);
[SAMI] In release builds, ASSERT_EFI_ERROR() would vanish and we could
end up accessing an invalid pointer.
If you agree, I will change this to check the status and return the
error
On 2/2/22 07:52, Sami Mujawar wrote:
+AmlCodeGenRdMemory32Fixed (
+ BOOLEAN IsReadWrite,
+ UINT32 Address,
+ UINT32 RangeLength,
+ AML_OBJECT_NODE_HANDLE NameOpNode,
+ AML_DATA_NODE_HANDLE*NewMemNode
+ )
+{
+ EFI_STATUS
Hi Rebecca,
Thank you for this patch.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 13/01/2022 04:40 PM, Rebecca Cran wrote:
Add AmlCodeGenMethodRetInteger function to generate AML code for
a Method returning an Integer.
Signed-off-by: Rebecca Cran
Reviewed-by:
Hi Rebecca,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 13/01/2022 04:40 PM, Rebecca Cran wrote:
In AmlCodeGenReturn, the cast to AML_NODE_HEADER* in the call to
AmlSetFixedArgument is redundant because ReturnNode is already
Hi Rebecca,
Thank you for this patch.
I have a minor suggestion marked inline as [SAMI].
Otherwise this patch looks good to me.
Regards,
Sami Mujawar
On 13/01/2022 04:40 PM, Rebecca Cran wrote:
Add a Memory32Fixed function to generate code for the corresponding
Memory32Fixed macro in AML.
On 02/02/2022 09:02, Sean Rhodes wrote:
Not quite sure how to implement that, are there any existing use cases
that I can look at?
From the way that your patch uses SMBIOS data, I'm assuming that your
use case involves a pre-existing SMBIOS table structure that is
constructed by something
On Tue, Feb 01, 2022 at 14:23:06 +0100, Ard Biesheuvel wrote:
> Enable resizable BAR support so that BARs for, e.g., GPU cards that are
> sized conservatively by default, but can be resized to cover all of the
> GPU's VRAM, are resized by the firmware before handing over to the OS.
> This is a
Hi Ard,
Thank you for this patch.
The timeout value 5 appears to be standard across platforms, so it looks good
to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 02/02/2022, 09:42, "devel@edk2.groups.io on behalf of PierreGondois via
groups.io"
wrote:
Hi,
The value
Hi,
The value also gets updated from 3 to 5, is it possible to note it in the
commit message or to let it to 3 ?
Otherwise the patch looks good to me,
Reviewed-by: Pierre Gondois
On 2/1/22 7:03 PM, Ard Biesheuvel wrote:
Use the correct PCD type for PcdPlatformBootTimeOut so it gets wired up
Hi Michael
Not quite sure how to implement that, are there any existing use cases that I
can look at?
Thanks!
Sean
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86330): https://edk2.groups.io/g/devel/message/86330
Mute This Topic:
33 matches
Mail list logo
