[edk2-devel] [edk2-platforms: PATCH v4] MinPlatformPkg/SaveMemoryConfig: Variable may not be locked.

2022-02-16 Thread Chiu, Chasel
From: "Chiu, Chasel" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3829 Fixed the bug that existing variable will not be locked when it is identical with hob data by creating LockLargeVariable function, also switched to VariablePolicyProtocol for locking variables. Failing to lock

Re: [edk2-devel] [PATCH v1] CryptoPkg: Add new hash algorithm ParallelHash256HashAll in BaseCryptLib.

2022-02-16 Thread Li, Zhihao
We try to make proper attribution for the code in openssl_sha3 and in xkcp. We separated their implementation into CryptSha3.c and CryptXkcp.c, Separated their declaration into sha3.h and xkcp.h. With the comment, we plan to delete these header files and put the declaration and Structure

回复: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: reserve snp pages

2022-02-16 Thread gaoliming
Gerd and Brijesh: I see six FDF files include AmdSevDxe. But, only CloudHvX64 and OvmfPkgX64 adds reserve snp pages. So, I want to confirm whether others require reserve snp pages. AmdSev\AmdSevX64.fdf Bhyve\BhyveX64.fdf CloudHv\CloudHvX64.fdf OvmfPkgIa32X64.fdf OvmfPkgX64.fdf OvmfXen.fdf

Re: [edk2-devel] [edk2-platform][PATCH] UefiPayloadPkg: Fix PciHostBridgeLib

2022-02-16 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: Patrick Rudolph > Sent: Monday, February 7, 2022 2:01 > To: devel@edk2.groups.io > Cc: Ni, Ray ; Ma, Maurice ; You, > Benjamin ; Dong, Guo > Subject: [edk2-platform][PATCH] UefiPayloadPkg: Fix PciHostBridgeLib > > On modern

Re: [edk2-devel] PcdDebugPropertyMask in DSC: How to I set different values for PEI and DXE?

2022-02-16 Thread Andrew Fish via groups.io
> On Feb 16, 2022, at 2:10 PM, Kinney, Michael D > wrote: > > Hi Andrew, > > Current DSC syntax for platform scoped [PcdsXXX] sections only supports > CPU Arch and SKUID. > > So there is no mechanism today to specify different PCD values based on > module type. > > You can manage this in

Re: [edk2-devel] [PATCH v3 0/2] EDK2 Code First: PI Specification: Expand PI Status Codes

2022-02-16 Thread Kun Qin
Hi community maintainers, It has been a few weeks since the patches being sent out. Could anyone please provide any feedback on this code-first series so that we can keep the wheels rolling as the first step of N? Thanks in advance. Regards, Kun On 02/03/2022 11:03, Kun Qin via groups.io

Re: [edk2-devel] [edk2-platforms: PATCH v3] MinPlatformPkg/SaveMemoryConfig: Variable may not be locked.

2022-02-16 Thread Nate DeSimone
Hi Chasel, Please see feedback inline. Thanks, Nate > -Original Message- > From: Chiu, Chasel > Sent: Friday, February 11, 2022 1:02 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > ; Dong, Eric > Subject: [edk2-platforms: PATCH v3]

Re: [edk2-devel] [PATCH 14/18] UefiPayloadPkg: Add RNG support

2022-02-16 Thread Guo Dong
should we put BaseRngLib into SecurityPkg so that it could be used by other platforms? Thanks, Guo -Original Message- From: Sean Rhodes Sent: Thursday, February 10, 2022 2:28 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Patrick Rudolph Subject: [PATCH 14/18] UefiPayloadPkg: Add RNG

Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection

2022-02-16 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: Sean Rhodes Sent: Thursday, February 10, 2022 2:28 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Patrick Rudolph Subject: [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection From: Patrick Rudolph

Re: [edk2-devel][PATCH] UefiPayloadPkg: Fix PciHostBridgeLib

2022-02-16 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: Patrick Rudolph Sent: Wednesday, February 16, 2022 7:54 AM To: devel@edk2.groups.io Cc: Ni, Ray ; You, Benjamin ; Ma, Maurice ; Dong, Guo Subject: [edk2-devel][PATCH] UefiPayloadPkg: Fix PciHostBridgeLib On modern platforms with TBT

Re: [edk2-devel] PcdDebugPropertyMask in DSC: How to I set different values for PEI and DXE?

2022-02-16 Thread Michael D Kinney
Hi Andrew, Current DSC syntax for platform scoped [PcdsXXX] sections only supports CPU Arch and SKUID. So there is no mechanism today to specify different PCD values based on module type. You can manage this in the DSC file, but it does require the module scoped section for each module INF

[edk2-devel] PcdDebugPropertyMask in DSC: How to I set different values for PEI and DXE?

2022-02-16 Thread Andrew Fish via groups.io
I’m trying to have a different platform policy for PcdDebugPropertyMask in PEI and DXE. I can’t figure out how to do without overriding every PEIM that I build? My PEI and DXE has the same arch so I can’t use the CPU Arch to tell them apart. Is there something I’m missing? Thanks, Andrew

Re: [edk2-devel] Another regression with SEV resulting in VM reset loop

2022-02-16 Thread Lendacky, Thomas via groups.io
On 2/16/22 12:06, Aaron Young via groups.io wrote: We have encountered another regression related to SEV support resulting in a reset loop with Intel/Win2012R2 guests. NOTE that I reported this several months ago here (which contains more details):

[edk2-devel] Another regression with SEV resulting in VM reset loop

2022-02-16 Thread Aaron Young
We have encountered another regression related to SEV support resulting in a reset loop with Intel/Win2012R2 guests. NOTE that I reported this several months ago here (which contains more details): https://bugzilla.tianocore.org/show_bug.cgi?id=3582 I have reconfirmed that this issue still

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: reserve snp pages

2022-02-16 Thread Brijesh Singh via groups.io
On 2/16/22 01:00, Gerd Hoffmann wrote: The SNP patch series updated the OvmfPkgX64 build but forgot the AmdSev variant, resulting in a broken OvmfSevMetadata table. Fixes: cca9cd3dd6bf ("OvmfPkg: reserve CPUID page") Fixes: 707c71a01b9d ("OvmfPkg: reserve SNP secrets page") Signed-off-by:

[edk2-devel] [edk2-non-osi][PATCH 1/1] Drivers/Realtek: Including Realtek driver to enable network support

2022-02-16 Thread Himanshu Sharma
This patch adds the generic Realtek PCIe UNDI Driver version 2.057 driver binary to edk2-non-osi that can be made available to use for the platforms that use Realtek's network controller This is a Aarch64 binary, available at:

[edk2-devel][PATCH] UefiPayloadPkg: Fix PciHostBridgeLib

2022-02-16 Thread Patrick Rudolph
On modern platforms with TBT devices the coreboot resource allocator opens large PCI bridge MMIO windows above 4GiB to place hotplugable PCI BARs there as they won't fit below 4GiB. In addition modern GPGPU devices have very big PCI bars that doesn't fit below 4GiB. The PciHostBridgeLib made lots

[edk2-devel] [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser

2022-02-16 Thread Abdul Lateef Attar via groups.io
Hi, Sorry for the delayed reply. I had updated the patch according to the review comments. Please review the updated patch. REF: https://github.com/abdattar/edk2/tree/FadtFlagsParserV5 Cc: Ray Ni Cc: Zhichao Gao Cc: Sami Mujawar Abdul Lateef Attar (2): ShellPkg/AcpiView: Adds

[edk2-devel] [PATCH v5 2/2] ShellPkg/AcpiView: PrintFormatter for FADT Flags field

2022-02-16 Thread Abdul Lateef Attar via groups.io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3839 Adds PrintFormatter function to the FADT flags field. Prints indivisual flag name along with flag value. Cc: Ray Ni Cc: Zhichao Gao Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar ---

[edk2-devel] [PATCH v5 1/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser

2022-02-16 Thread Abdul Lateef Attar via groups.io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3839 Adds ParseAcpiBitFields() which is based on ParseAcpi() and capable of parsing the bit fields. Supports parsing of UINT8, UINT16, UINT32 and UINT64 byte data. Cc: Ray Ni Cc: Zhichao Gao Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar

[edk2-devel] Recall: [PATCH v1] CryptoPkg: Add new hash algorithm ParallelHash256HashAll in BaseCryptLib.

2022-02-16 Thread Li, Zhihao
Li, Zhihao would like to recall the message, "[PATCH v1] CryptoPkg: Add new hash algorithm ParallelHash256HashAll in BaseCryptLib.". -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86703): https://edk2.groups.io/g/devel/message/86703 Mute

Re: [edk2-devel] [PATCH v1] CryptoPkg: Add new hash algorithm ParallelHash256HashAll in BaseCryptLib.

2022-02-16 Thread Li, Zhihao
In CT 46 review result, it require that the code in openssl_sha3 and in xkcp need to be made proper attribution. We separated their implementation into CryptSha3.c and CryptXkcp.c, separated their header files into sha3.h and xkcp.h. Now we plan to delete these header files and put the