Hi Marvin,
> -Original Message-
> From: Marvin Häuser
> Sent: Friday, April 15, 2022 9:44 AM
> To: disc...@edk2.groups.io; Johnson, Brian ;
> Desimone, Nathaniel L ; Andrew Fish
> ; devel@edk2.groups.io
> Cc: Pedro Falcato ; adachristin...@gmail.com;
> Shi, Steven
> Subject: Re:
The series has been pushed as ~630df8c..91a03f7
Thanks,
Nate
-Original Message-
From: devel@edk2.groups.io On Behalf Of Kuo, Ted
Sent: Friday, April 15, 2022 1:38 AM
To: devel@edk2.groups.io
Subject: [edk2-devel][PATCH v5 0/8] Support PEI 64bit in IntelFsp2Pkg and
IntelFsp2WrapperPkg
On April 16, 2022 4:52 AM, Lendacky, Thomas wrote:
>
> Unfortunately, this driver also breaks SEV-ES. I bypassed the TDX code in the
> SEC library, but then hit an issue because this driver is loaded before the
> AmdSevDxe driver. The AmdSevDxe driver performs a
>
On April 16, 2022 4:05 AM, Tom Lendacky wrote:
> > #define SEC_IDT_ENTRY_COUNT 34
> > @@ -738,6 +737,20 @@ SecCoreStartupWithStack (
> > UINT32Index;
> > volatile UINT8*Table;
> >
> > + #if defined (TDX_GUEST_SUPPORTED)
> > + if (TdIsEnabled ()) {
>
> I wish I
The current ACPI Reclaim memory size is set as 0x10(64k). The
ACPI table size will be increased if the memory slots' number of
the guest gets increased. In the guest with more memory slots,
the ACPI Reclaim memory size may not be sufficient for hibernation.
This may cause resume failure of the
Oops! This patch title misses the module name, I'll post a V2 version to
include it.
Thanks
Annie
On 4/15/2022 1:11 PM, annie li wrote:
The current ACPI Reclaim memory size is set as 0x10(64k). The
ACPI table size will be increased if the memory slots' number of
the guest gets increased. In
On 3/29/22 18:46, Min Xu wrote:
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
TdxDxe driver is dispatched early in DXE, due to being list in APRIORI.
This module is responsible for below features:
- Sets max logical cpus based on TDINFO
- Sets PCI PCDs based on resource hobs
-
On 3/29/22 18:46, Min Xu wrote:
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
There are below major changes in this commit.
1. SecEntry.nasm
In TDX BSP and APs goes to the same entry point in SecEntry.nasm.
BSP initialize the temporary stack and then jumps to SecMain, just as
Great work thanks Ted!
Reviewed-by: Nate DeSimone
From: devel@edk2.groups.io on behalf of Kuo, Ted
Date: Friday, April 15, 2022 at 1:38 AM
To: devel@edk2.groups.io
Subject: [edk2-devel][PATCH v5 0/8] Support PEI 64bit in IntelFsp2Pkg and
IntelFsp2WrapperPkg
Hey Isaac,
Thanks for your input! :)
On 15.04.22 20:47, Oram, Isaac W wrote:
In practice, it feels like we have evolved far beyond original PEI scope for
natural and good reasons. Initially, it was very resource constrained. 8KB
CAR for data only. That is no longer a real constraint for
In practice, it feels like we have evolved far beyond original PEI scope for
natural and good reasons. Initially, it was very resource constrained. 8KB
CAR for data only. That is no longer a real constraint for most HW. And thus
we get things like MP services early, writable variables
The current ACPI Reclaim memory size is set as 0x10(64k). The
ACPI table size will be increased if the memory slots' number of
the guest gets increased. In the guest with more memory slots,
the ACPI Reclaim memory size may not be sufficient for hibernation.
This may cause resume failure of the
On 4/12/22 16:00, James Bottomley via groups.io wrote:
I've identified a serious performance regression in recent edk2, so
I've been trying to identify it by bisection, but it seems that the TDX
patches have broken bisection in edk2. You can see this by trying to
checkout b6b2de884864 and build
Hey Brian,
On 15.04.22 18:22, Brian J. Johnson wrote:
Nate, Andrew, Marvin, Pedro, Ada, et al,
This is a great discussion. I've been debating where to weigh in...
Personally, I don't think this topic can get enough attention. Thanks! :)
I agree that some sort of library sharing to reduce
Nate, Andrew, Marvin, Pedro, Ada, et al,
This is a great discussion. I've been debating where to weigh in...
I agree that some sort of library sharing to reduce image size would be
very helpful. Although some parts of the BIOS are built separately,
large parts of it are compiled at the same
On 15.04.22 17:02, Yao, Jiewen wrote:
Exactly. Lacking of doc from different compilers is very painful.
The Asan or UBsan support is just a hack -
https://github.com/jyao1/SecurityEx/blob/master/StackCheckPkg/Library/StackCheckLib/ASanStub.c
Exactly. Lacking of doc from different compilers is very painful.
The Asan or UBsan support is just a hack -
https://github.com/jyao1/SecurityEx/blob/master/StackCheckPkg/Library/StackCheckLib/ASanStub.c
Historically the challenge we had w/ upstreaming some features was if the
compiler intrinsic for which a particular feature was dependent didn't have
public documentation or wasn't supported by all of the compilers that EDKII
supported. For the former, this lack of info would lead to the
Hey Vincent,
In fact I haven't, thanks a lot! Are there any known blockers for these
outside development resources? Except for C++, they are things we'd want
asap downstream. I guess rather than OverflowDetectionPkg, ASan has
higher priority here.
Best regards,
Marvin
On 15.04.22 15:31,
Fyi
There is a running list of some edk2 defense-in-depth work at
https://github.com/jyao1/SecurityEx/blob/master/Summary.md, too, including
ASLR, if you haven't already seen that material
-Original Message-
From: disc...@edk2.groups.io On Behalf Of Marvin Häuser
Sent: Friday, April
CC Mike (proposal review as per announcement mail)
Hey Ada,
I can neither decide on nor even view your proposal (I think that's up
to Nate and Mike?), but I had a brief conversation with Vitaly about the
Amaranth downstream. There are other potentially technologically related
topics Vitaly's
Hi Everybody
I've read all the discussion here and condensed my plan into a short
project proposal. It's a little short and light on detail at the moment
because I'm pressed for time for other matters today, but I wanted to get
something in before EOD today as requested. Anybody else's input or a
I see the configuration in MdeModulePkg\MdeModulePkg.ci.yaml. I add
SmmCpuRendezvousLib.h in
MdeModulePkg/Include/Library folder so that it doesn't need add UefiCpuPkg.dec
in [Packages] and bypass the check.
For the second point, due to the patch pass the CI test, it also pass the
Thanks for fixing issues Ted!
For this patch series: Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kuo,
> Ted
> Sent: Friday, April 15, 2022 4:38 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel][PATCH v5 0/8] Support PEI 64bit in
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893
1.Added SecFspWrapperPlatformSecLibSample support for X64.
2.Adopted FSPT_ARCH2_UPD in SecFspWrapperPlatformSecLibSample.
3.Moved Fsp.h up one level to be shared across IA32 and X64.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Cc:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893
Add Execute64BitCode to execute 64bit code from long mode directly
in PEI 64bit.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Ashraf Ali S
Signed-off-by: Ted Kuo
---
.../BaseFspWrapperApiLib/FspWrapperApiLib.c| 44
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893
Adopt FSPM_UPD_COMMON_FSP24 in FspmWrapperPeim to support X64.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Ashraf Ali S
Signed-off-by: Ted Kuo
---
.../FspmWrapperPeim/FspmWrapperPeim.c | 27 ++
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893
1.Added SecFspSecPlatformLibNull support for X64.
2.Added X64 support to IntelFsp2Pkg.dsc.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Ashraf Ali S
Signed-off-by: Ted Kuo
---
IntelFsp2Pkg/IntelFsp2Pkg.dsc |
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893
Updated FSP_GLOBAL_DATA and FSP_PLAT_DATA structures to support
both IA32 and X64.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Ashraf Ali S
Signed-off-by: Ted Kuo
---
IntelFsp2Pkg/FspSecCore/SecFsp.c | 2 +-
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893
1.Added FspSecCore support for X64.
2.Bumped FSP header revision to 7 to indicate FSP 64bit is supported.
3.Corrected few typos.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Ashraf Ali S
Signed-off-by: Ted Kuo
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893
1.Added FSPx_ARCH2_UPD structures which support both IA32 and X64.
2.Added FSPx_UPD_COMMON_FSP24 structures.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Ashraf Ali S
Signed-off-by: Ted Kuo
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893
Currently PEI drivers/libraries only support 32bit in IntelFsp2Pkg and
IntelFsp2WrapperPkg. The patches below are needed to support these
drivers/libraries in 64bit.
V2 changes:
1.Change FSPM_UPD_COMMON2 to FSPM_UPD_COMMON_FSP24 in
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893
1.Added EFIAPI to FspNotifyPhasePeimEntryPoint, SwapStack and
PEI_CORE_ENTRY.
2.Treat both MAX_ADDRESS and MAX_UINT32 as invalid address for
FSP global data in FspApiCallingCheck().
3.Changed AsmReadEsp to AsmReadStackPointer.
4.Changed
Add Kinney, Michael D and Gao, Liming
Best Regards.
-Original Message-
From: Gao, Zhichao
Sent: Thursday, April 14, 2022 10:25 AM
To: Ke, Bo-ChangX ; devel@edk2.groups.io
Cc: Liu, Zhiguang ; Bi, Dandan ;
Zeng, Star
Subject: RE: [PATCH v2] MdePkg: Update smbiosview type 9 with SMBIOS
Hi Andrew,
On 4/14/22, 7:43 PM, "Andrew Fish" wrote:
>
>
>> On Apr 14, 2022, at 6:06 PM, Nate DeSimone
>> wrote:
>>
>> Hi Marvin,
>>
>>> -Original Message-
>>> From: devel@edk2.groups.io On Behalf Of Marvin
>>> Häuser
>>> Sent: Thursday, April 14, 2022 12:56 AM
>>> To:
> On 15. Apr 2022, at 04:42, Andrew Fish wrote:
>
>
>> On Apr 14, 2022, at 6:06 PM, Nate DeSimone
>> wrote:
>>
>> Hi Marvin,
>>
>>> -Original Message-
>>> From: devel@edk2.groups.io On Behalf Of Marvin
>>> Häuser
>>> Sent: Thursday, April 14, 2022 12:56 AM
>>> To:
36 matches
Mail list logo
