Re: [edk2-devel] [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Introduce Redfish version library

2022-05-17 Thread Abner Chang
> -Original Message- > From: Wang, Nickle (Server BIOS) > Sent: Tuesday, May 17, 2022 11:59 AM > To: devel@edk2.groups.io > Cc: Wang, Nickle (Server BIOS) ; Chang, Abner (HPS > SW/FW Technologist) > Subject: [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Introduce > Redfish

Re: [edk2-devel] [PATCH V2 1/1] [edk2-stable202205]OvmfPkg/OvmfPkgX64: Use different CcProbeLib when SMM is on or off

2022-05-17 Thread Yao, Jiewen
Hi Steward Team I request this be in stable202205. It is a regression issue since stable202202. Reviewed-by: Jiewen Yao Thank you Yao Jiewen > -Original Message- > From: Xu, Min M > Sent: Wednesday, May 18, 2022 11:37 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Andrew Fish ; Leif

[edk2-devel] [PATCH V2 1/1] [edk2-stable202205]OvmfPkg/OvmfPkgX64: Use different CcProbeLib when SMM is on or off

2022-05-17 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3930 CcProbeLib is designed to check the vm guest type. The OvmfPkg/CcProbeLib reads the OvmfWorkArea (0x80B000) to get the vm guest type which is written by each guest (SEV or TDX guest). But in SMM drivers the access to OvmfWorkArea is illegal.

Re: [edk2-devel] [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Introduce Redfish event library

2022-05-17 Thread Abner Chang
Few minor issues. > -Original Message- > From: Wang, Nickle (Server BIOS) > Sent: Tuesday, May 17, 2022 10:40 AM > To: devel@edk2.groups.io > Cc: Wang, Nickle (Server BIOS) ; Chang, Abner (HPS > SW/FW Technologist) > Subject: [edk2-staging][PATCH] edk2-staging/RedfishClientPkg:

Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

2022-05-17 Thread Jeff Brasen via groups.io
Any comments on this patch? Thanks, Jeff -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89876): https://edk2.groups.io/g/devel/message/89876 Mute This Topic: https://groups.io/mt/89143704/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] [PATCH] .gitignore: Ignore build tools build logs

2022-05-17 Thread Jeff Brasen via groups.io
Any comments on this patch? Thanks, Jeff -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89875): https://edk2.groups.io/g/devel/message/89875 Mute This Topic: https://groups.io/mt/90610467/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] [PATCH v5 2/2] IntelFsp2WrapperPkg: FSP_TEMP_RAM_INIT call must follow X64 Calling Convention

2022-05-17 Thread Kuo, Ted
Looks good to me except one typo. Please see my inline comment. Thanks, Ted -Original Message- From: devel@edk2.groups.io On Behalf Of Chiu, Chasel Sent: Wednesday, May 18, 2022 9:41 AM To: Duggapu, Chinni B ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Zeng, Star ; S, Ashraf Ali

Re: 回复: [edk2-devel] [PATCH v1 0/8] Fix new typos reported

2022-05-17 Thread Michael Kubacki
Hi Liming, That should be true but these are intended to be non-functional changes (low risk) that should help ease the decision to move to a new version in the future and help support consumers of the stable tag that might need spelling fixes. For example, Project Mu integrates the stable

Re: [edk2-devel] [PATCH V1 1/1] MinPlatformPkg: Add PCDs to update FADT entries from board package

2022-05-17 Thread Ni, Ray
Ankit, I see. So, the goal is to build an infrastructure that makes sure mandatory ACPI tables are always populated. I am fine with that. Thanks for the explanation. > -Original Message- > From: Sinha, Ankit > Sent: Wednesday, May 18, 2022 3:02 AM > To: Ni, Ray ; devel@edk2.groups.io;

Re: [edk2-devel] [PATCH v5 2/2] IntelFsp2WrapperPkg: FSP_TEMP_RAM_INIT call must follow X64 Calling Convention

2022-05-17 Thread Chiu, Chasel
Thanks Chinni! Reviewed-by: Chasel Chiu > -Original Message- > From: Duggapu, Chinni B > Sent: Tuesday, May 17, 2022 4:44 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; S, > Ashraf Ali > Subject: [PATCH v5 2/2] IntelFsp2WrapperPkg:

Re: [edk2-devel] [PATCH v5 1/2] IntelFsp2Pkg: FSP_TEMP_RAM_INIT call must follow X64 Calling Convention

2022-05-17 Thread Chiu, Chasel
Thanks for fixing a small coding issue! Reviewed-by: Chasel Chiu > -Original Message- > From: Duggapu, Chinni B > Sent: Tuesday, May 17, 2022 4:44 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; S, > Ashraf Ali > Subject: [PATCH v5 1/2]

回复: [edk2-devel] [PATCH v1 0/8] Fix new typos reported

2022-05-17 Thread gaoliming
Michael: Thanks for your quick work to resolve the CI issue. For this issue, if we use the old stable version cspell version, those new issues will not be reported, right? If yes, can we update CI only to unblock PR first for this stable tag? The change in Packages can be made in future.

Re: [edk2-devel] [PATCH v1 5/8] FatPkg: Fix new typos reported

2022-05-17 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 18, 2022 12:01 AM > To: devel@edk2.groups.io > Cc: Ni, Ray > Subject: [PATCH v1 5/8] FatPkg: Fix new typos reported > > From: Michael Kubacki > > The SpellCheck plugin began

[edk2-devel] [PATCH v2 11/11] .pytool/plugin/SpellCheck: Add more common words

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki Appends the word list to reduce the number of errors encountered by individual packages. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Michael Kubacki --- .pytool/Plugin/SpellCheck/cspell.base.yaml | 113 +++- 1

[edk2-devel] [PATCH v2 10/11] .pytool/plugin/SpellCheck: Allow compound words

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki Sets "allowCompoundWords" to "true" to reduce the number of compound word issues encountered in the future. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Michael Kubacki --- .pytool/Plugin/SpellCheck/cspell.base.yaml | 2 +- 1

[edk2-devel] [PATCH v2 09/11] .azurepipelines: Fix cspell version to v5.20.0

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki The v5.21.0 update introduced a number of new issues that might impact stable tag integration so this fixes the version to the previous release. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Michael Kubacki This value can be

[edk2-devel] [PATCH v2 08/11] ArmVirtPkg: Add new ignored spelling errors

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously missed. This change adds the new words reported to the extended words list in ArmVirtPkg.ci.yaml. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Michael Kubacki

[edk2-devel] [PATCH v2 07/11] ArmPkg: Ignore new typos reported

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3929 The SpellCheck plugin began reporting new typos that were previously missed. Due to the number of spelling errors in this package, no errors are fixed in this change. They are ignored to unblock overall edk2 CI. The

[edk2-devel] [PATCH v2 06/11] FmpDevicePkg: Fix new typos reported

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously missed. This change fixes those typos. Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin Jiang Cc: Wei6 Xu Signed-off-by: Michael Kubacki --- FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c |

[edk2-devel] [PATCH v2 05/11] FatPkg: Fix new typos reported

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously missed. This change fixes those typos. Cc: Ray Ni Signed-off-by: Michael Kubacki --- FatPkg/EnhancedFatDxe/FileSpace.c | 2 +- FatPkg/EnhancedFatDxe/ReadWrite.c | 2 +- FatPkg/EnhancedFatDxe/Fat.h

[edk2-devel] [PATCH v2 04/11] UnitTestFrameworkPkg: Fix new typos reported

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously missed. This change fixes those typos. Cc: Michael D Kinney Cc: Michael Kubacki Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Michael Kubacki ---

[edk2-devel] [PATCH v2 03/11] DynamicTablesPkg: Fix new typos reported

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously missed. This change fixes those typos. Cc: Sami Mujawar Cc: Alexei Fedorov Signed-off-by: Michael Kubacki Reviewed-by: Sami Mujawar ---

[edk2-devel] [PATCH v2 02/11] StandaloneMmPkg: Fix new typos reported

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously missed. This change fixes those typos. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Signed-off-by: Michael Kubacki Reviewed-by: Sami Mujawar ---

[edk2-devel] [PATCH v2 01/11] PrmPkg: Fix new typos reported

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously missed. This change fixes those typos. Cc: Michael Kubacki Cc: Nate DeSimone Cc: Ankit Sinha Signed-off-by: Michael Kubacki --- PrmPkg/Application/PrmInfo/PrmInfo.c

[edk2-devel] [PATCH v2 00/11] Fix new typos reported

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3929 The SpellCheck plugin began reporting new typos that were previously missed. This is impacting edk2 pull requests from being completed. A change in the cspell plugin or some other upstream component may have caused

Re: [edk2-devel] [PATCH v1 0/8] Fix new typos reported

2022-05-17 Thread Michael Kubacki
Hi Ard, I understand it is frustrating for things that were working to suddenly stop and errors to have been missed by the plugin in the past. I'm also surprised that some of these issues were previously not caught. To clarify, adding the words to the ignore list was not really that much

Re: [edk2-devel] [PATCH v1 0/8] Fix new typos reported

2022-05-17 Thread Ard Biesheuvel
On Tue, 17 May 2022 at 21:32, Michael Kubacki wrote: > > As noted in the patch, this BZ was filed to follow up and review those: > https://bugzilla.tianocore.org/show_bug.cgi?id=3929 > > I don't like doing this either but the spelling errors do exist. I am > trying not to make CI policy changes

Re: [edk2-devel] [PATCH v1 0/8] Fix new typos reported

2022-05-17 Thread Michael Kubacki
As noted in the patch, this BZ was filed to follow up and review those: https://bugzilla.tianocore.org/show_bug.cgi?id=3929 I don't like doing this either but the spelling errors do exist. I am trying not to make CI policy changes as those can be controversial even among maintainers in the

Re: [edk2-devel] [PATCH V1 1/1] MinPlatformPkg: Add PCDs to update FADT entries from board package

2022-05-17 Thread Sinha, Ankit
Hi Ray, That is a good feedback. However, since FADT is a mandatory table to boot an ACPI compliant OS, we have placed it in the implementation of MinPlatformPkg. If we move this to be a board responsibility then we will need to implement a check in the boot process to make sure FADT is

Re: [edk2-devel] [PATCH v1 0/8] Fix new typos reported

2022-05-17 Thread Ard Biesheuvel
On Tue, 17 May 2022 at 18:25, Michael Kubacki wrote: > > Hi Ard, > > I think that's a reasonable approach. > > We could also consider locking onto a specific cspell version to > decrease the likelihood of this sporadically appearing in the future. > > In this case, I would prefer not to make the

Re: [edk2-devel] [PATCH v1 2/8] StandaloneMmPkg: Fix new typos reported

2022-05-17 Thread Michael Kubacki
Sure I can add that to a v2. I'm going to leave v1 up for a bit longer to collect more feedback before sending that. Regards, Michael On 5/17/2022 12:19 PM, Sami Mujawar wrote: Hi Michael, Thank you for fixing these issues. I have a minor suggestion marked inline as [SAMI]. Otherwise, this

Re: [edk2-devel] [PATCH] OvmfPkg: Make an Ia32/X64 hybrid build work with SEV

2022-05-17 Thread Ard Biesheuvel
On Tue, 17 May 2022 at 18:26, Tom Lendacky wrote: > > On 5/16/22 15:24, Lendacky, Thomas via groups.io wrote: > > The BaseMemEncryptSevLib functionality was updated to rely on the use of > > the OVMF/SEV workarea to check for SEV guests. However, this area is only > > updated when running the X64

Re: [edk2-devel] [PATCH v1 3/8] DynamicTablesPkg: Fix new typos reported

2022-05-17 Thread Sami Mujawar
Hi Michael, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 17/05/2022, 17:01, "mikub...@linux.microsoft.com" wrote: From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously

Re: [edk2-devel] [PATCH] OvmfPkg: Make an Ia32/X64 hybrid build work with SEV

2022-05-17 Thread Lendacky, Thomas via groups.io
On 5/16/22 15:24, Lendacky, Thomas via groups.io wrote: The BaseMemEncryptSevLib functionality was updated to rely on the use of the OVMF/SEV workarea to check for SEV guests. However, this area is only updated when running the X64 OVMF build, not the hybrid Ia32/X64 build. Base SEV support is

Re: [edk2-devel] [PATCH v1 0/8] Fix new typos reported

2022-05-17 Thread Michael Kubacki
Hi Ard, I think that's a reasonable approach. We could also consider locking onto a specific cspell version to decrease the likelihood of this sporadically appearing in the future. In this case, I would prefer not to make the decision to disable spell check entirely on behalf of various

Re: [edk2-devel] [PATCH v1 2/8] StandaloneMmPkg: Fix new typos reported

2022-05-17 Thread Sami Mujawar
Hi Michael, Thank you for fixing these issues. I have a minor suggestion marked inline as [SAMI]. Otherwise, this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 17/05/2022, 17:01, "mikub...@linux.microsoft.com" wrote: From: Michael Kubacki The

Re: [edk2-devel] [PATCH v1 0/8] Fix new typos reported

2022-05-17 Thread Ard Biesheuvel
Hello Michael, Thanks for taking care of this. However, I strongly feel that automation is increasing my workload here rather than the other way around, for dubious benefits, so as a package maintainer, I am inclined to disable the spell checks altogether for all the packages I am in charge of.

Re: 回复: 回复: 回复: [edk2-devel] [PATCH v5 0/8] Add Variable Flash Info HOB

2022-05-17 Thread Michael Kubacki
A lot of new spelling errors began appearing in various packages in that PR (unrelated to this change). As a community service to unblock edk2 PRs, I have sent the following series to address these newly reported errors: https://edk2.groups.io/g/devel/message/89833 The PR with the CI

Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Configurable New Boot Options

2022-05-17 Thread Ashish Singhal via groups.io
Ray, Won't that mean changing UEFI UI and boot maintenance manager applications as well to make this call? If we do not do that, the applications would not reflect the sorted boot order automatically. Considering this, the change I have is pretty small and takes care of all scenarios. Please

[edk2-devel] [PATCH v1 8/8] ArmVirtPkg: Add new ignored spelling errors

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously missed. This change adds the new words reported to the extended words list in ArmVirtPkg.ci.yaml. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Michael Kubacki

[edk2-devel] [PATCH v1 7/8] ArmPkg: Ignore new typos reported

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously missed. Due to the number of spelling errors in this package, no errors are fixed in this change. They are ignored to unblock overall edk2 CI. The maintainers should visit the list of extended words for

[edk2-devel] [PATCH v1 6/8] FmpDevicePkg: Fix new typos reported

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously missed. This change fixes those typos. Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin Jiang Cc: Wei6 Xu Signed-off-by: Michael Kubacki --- FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c |

[edk2-devel] [PATCH v1 5/8] FatPkg: Fix new typos reported

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously missed. This change fixes those typos. Cc: Ray Ni Signed-off-by: Michael Kubacki --- FatPkg/EnhancedFatDxe/FileSpace.c | 2 +- FatPkg/EnhancedFatDxe/ReadWrite.c | 2 +- FatPkg/EnhancedFatDxe/Fat.h

[edk2-devel] [PATCH v1 4/8] UnitTestFrameworkPkg: Fix new typos reported

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously missed. This change fixes those typos. Cc: Michael D Kinney Cc: Michael Kubacki Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Michael Kubacki ---

[edk2-devel] [PATCH v1 3/8] DynamicTablesPkg: Fix new typos reported

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously missed. This change fixes those typos. Cc: Sami Mujawar Cc: Alexei Fedorov Signed-off-by: Michael Kubacki --- DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 2 +-

[edk2-devel] [PATCH v1 2/8] StandaloneMmPkg: Fix new typos reported

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously missed. This change fixes those typos. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Signed-off-by: Michael Kubacki --- StandaloneMmPkg/Core/Dependency.c | 2 +-

[edk2-devel] [PATCH v1 1/8] PrmPkg: Fix new typos reported

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously missed. This change fixes those typos. Cc: Michael Kubacki Cc: Nate DeSimone Cc: Ankit Sinha Signed-off-by: Michael Kubacki --- PrmPkg/Application/PrmInfo/PrmInfo.c

[edk2-devel] [PATCH v1 0/8] Fix new typos reported

2022-05-17 Thread Michael Kubacki
From: Michael Kubacki The SpellCheck plugin began reporting new typos that were previously missed. This is impacting edk2 pull requests from being completed. A change in the cspell plugin or some other upstream component may have caused them to appear now. This patch series mitigates the issue

Re: [edk2-devel] vTPM support in cloud-Hypervisor in aarch64

2022-05-17 Thread Praveen K Paladugu
Closing the loop on this thread. With some support from folks at ARM, I was able to narrow down the issue to Page Tables not correctly configured in EDKII to handle TPM device. After marking the pages in vTPM address range (start:0xFED4, len:0x5000) as device Pages

Re: [edk2-devel] [PATCH] OvmfPkg/OvmfPkgX64: Use different CcProbeLib when SMM is on or off

2022-05-17 Thread Yao, Jiewen
Thanks. Acked-by: Jiewen Yao Hi Min Please follow hard free process to proceed. Reviewed-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of dann frazier > Sent: Tuesday, May 17, 2022 11:22 PM > To: Yao, Jiewen > Cc: Xu, Min M ; devel@edk2.groups.io;

Re: [edk2-devel] [PATCH] OvmfPkg/OvmfPkgX64: Use different CcProbeLib when SMM is on or off

2022-05-17 Thread dann frazier
On Tue, May 17, 2022 at 12:47:21PM +, Yao, Jiewen wrote: > Question: Does this patch need catch release 202205 release? It does fix a regression since 202202, so I'd hope so :) -dann > > > > -Original Message- > > From: Xu, Min M > > Sent: Tuesday, May 17, 2022 8:43 PM > > To:

Re: [edk2-devel] [PATCH] OvmfPkg/OvmfPkgX64: Use different CcProbeLib when SMM is on or off

2022-05-17 Thread dann frazier
On Tue, May 17, 2022 at 08:43:14PM +0800, Min Xu wrote: > CcProbeLib is designed to check the vm guest type. The OvmfPkg/CcProbeLib > reads the OvmfWorkArea (0x80B000) to get the vm guest type which is > written by each guest (SEV or TDX guest). But in SMM drivers the access > to OvmfWorkArea is

Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe: Don't check for address alignment

2022-05-17 Thread Sean Rhodes
Hi Star I think the point is shown in a comment from coreboot: "As mentioned above, only the offsets need to be aligned, not the absolute bases. Please, have a look for instance at `MdeModulePkg/Universal/FaultTolerantWriteDxe/FtwMisc.c:`: (FtwDevice->WorkSpaceAddress >= (FvbBaseAddress +

Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe: Don't check for address alignment

2022-05-17 Thread Zeng, Star
When length is larger than block size and block size aligned, if the address is not block size aligned, that means the range will mix with other range, but erase operation will be done per block, that will be risky and may break the fault tolerant mechanism. I could not remember all the

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: Store SEV-SNP AP jump table in the secrets page

2022-05-17 Thread Ni, Ray
can you please split the patches so one patch for one package? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael Roth > via groups.io > Sent: Monday, May 16, 2022 8:02 PM > To: devel@edk2.groups.io > Cc: Tom Lendacky > Subject: [edk2-devel] [PATCH v2] UefiCpuPkg:

Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Configurable New Boot Options

2022-05-17 Thread Ni, Ray
Please use the EfiBootManagerSortLoadOptionVariable() to sort the boot options from PlatformBootManagerLib. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ashish Singhal > via groups.io > Sent: Tuesday, May 17, 2022 7:02 AM > To: devel@edk2.groups.io; Wang, Jian J ;

Re: [edk2-devel] [PATCH V1 1/1] MinPlatformPkg: Add PCDs to update FADT entries from board package

2022-05-17 Thread Ni, Ray
I am thinking if most of FADT fields are configurable through PCD from BoardPkg. Then why not remove the FADT from this open-source driver but let some code in BoardPkg produces the FADT? It helps to remove the PCD layer and simplifies the data flow from PCD->FADT to FADT. Thanks, Ray >

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/UefiBootManagerLib: Add Pcd to prioritize internal devices

2022-05-17 Thread Ni, Ray
Sean, Can you use EfiBootManagerSortLoadOptionVariable() to sort the boot options from PlatformBootManagerLib? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sean Rhodes > Sent: Monday, March 21, 2022 6:04 PM > To: devel@edk2.groups.io > Cc: Matt DeVillier ; Wang, Jian J

Re: [edk2-devel] 回复: [edk2-devel] [PATCH 43/43] MdeModulePkg/BmBoot: skip secondary eMMC entries

2022-05-17 Thread Ni, Ray
Sean, Below function is called to make sure the description for each boot option doesn’t equal. Can you investigate why it doesn’t work for eMMC? BmMakeBootOptionDescriptionUnique (BootOptions, *BootOptionCount); From: devel@edk2.groups.io On Behalf Of Sheng Lean Tan Sent: Tuesday, May 17,

Re: 回复: 回复: 回复: [edk2-devel] [PATCH v5 0/8] Add Variable Flash Info HOB

2022-05-17 Thread Michael Kubacki
It is here: https://github.com/tianocore/edk2/pull/2828 I just rebased and pushed the branch. Thanks, Michael On 5/17/2022 1:22 AM, gaoliming wrote: Michael: Yes. I can. Where is the change for Edk2? Thanks Liming -邮件原件- 发件人: Michael Kubacki 发送时间: 2022年5月17日 12:14 收件人:

Re: [edk2-devel] [PATCH 1/2] SecurityPkg: Add RNG support

2022-05-17 Thread Yao, Jiewen
Some comment: 1) Please note that global variable is not allowed in BaseLib. +STATIC BOOLEAN mHasRdRand; 2) We already have https://github.com/tianocore/edk2/tree/master/MdePkg/Library/BaseRngLib Why we need another BaseRngLib ? > -Original Message- > From: devel@edk2.groups.io On

Re: [edk2-devel] [PATCH] OvmfPkg/OvmfPkgX64: Use different CcProbeLib when SMM is on or off

2022-05-17 Thread Yao, Jiewen
Question: Does this patch need catch release 202205 release? > -Original Message- > From: Xu, Min M > Sent: Tuesday, May 17, 2022 8:43 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; dann frazier > ; Aktas, Erdem ; > James Bottomley ; Yao, Jiewen ; > Tom Lendacky > Subject: [PATCH]

[edk2-devel] [PATCH] OvmfPkg/OvmfPkgX64: Use different CcProbeLib when SMM is on or off

2022-05-17 Thread Min Xu
CcProbeLib is designed to check the vm guest type. The OvmfPkg/CcProbeLib reads the OvmfWorkArea (0x80B000) to get the vm guest type which is written by each guest (SEV or TDX guest). But in SMM drivers the access to OvmfWorkArea is illegal. PiSmmCpuDxeSmm.inf is an example. It uses IoLib which in

Re: [edk2-devel] [PATCH 1/2] SecurityPkg: Add RNG support

2022-05-17 Thread Sheng Lean Tan
Hi Jiewen/ Jian J, This patch has been hanging around for months, could you help? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89817): https://edk2.groups.io/g/devel/message/89817 Mute This Topic: https://groups.io/mt/89353220/21656

Re: [edk2-devel] [PATCH 2/2] UefiPayloadPkg: Hook up RNG support

2022-05-17 Thread Sheng Lean Tan
Hi Ray/Dong Guo, Could you help to get this merge? Thanks, Sheng -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89816): https://edk2.groups.io/g/devel/message/89816 Mute This Topic: https://groups.io/mt/89353219/21656 Group Owner:

Re: [edk2-devel] 回复: [edk2-devel] [PATCH 43/43] MdeModulePkg/BmBoot: skip secondary eMMC entries

2022-05-17 Thread Sheng Lean Tan
Hi Liming, Mind to help on this? This patch has been hanging on for a long time :( Thank you. Best Regards, *Lean Sheng Tan* 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: sheng@9elements.com Phone: *+49 234 68 94 188 <+492346894188>* Mobile: *+49 176 76 113842

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add support for logging to CBMEM console

2022-05-17 Thread Sheng Lean Tan
Hi Ray, Could you help to review this? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89814): https://edk2.groups.io/g/devel/message/89814 Mute This Topic: https://groups.io/mt/88756033/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal

2022-05-17 Thread Sheng Lean Tan
Hi Ray, Could you help to review this? Thanks, Sheng -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89813): https://edk2.groups.io/g/devel/message/89813 Mute This Topic: https://groups.io/mt/89066601/21656 Group Owner:

Re: [edk2-devel] [PATCH 2/2] OvmfPkg: Fix PciHostBridgeLibScan

2022-05-17 Thread Sheng Lean Tan
Hi Ard, As per discribed in the commit message, this issue is seen on actual hardware and the fix is merged: https://github.com/tianocore/edk2/commit/bfefdc2c49ca9487b7aa0df196b2aca6c0c170a2 Since this function is the exact duplicate of the one in UefiPayloadPkg, he figured to port the fix

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/UefiBootManagerLib: Add Pcd to prioritize internal devices

2022-05-17 Thread Sheng Lean Tan
Hi Jian J/Liming, Any update on this? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89811): https://edk2.groups.io/g/devel/message/89811 Mute This Topic: https://groups.io/mt/89924426/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe: Don't check for address alignment

2022-05-17 Thread Sheng Lean Tan
Hi Star & Liming, Any update on this? Much appreciated. Best Regards, *Lean Sheng Tan* 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: sheng@9elements.com Phone: *+49 234 68 94 188 <+492346894188>* Mobile: *+49 176 76 113842 <+4917676113842>* Registered office: Bochum

[edk2-devel] [PATCH v5 2/2] IntelFsp2WrapperPkg: FSP_TEMP_RAM_INIT call must follow X64 Calling Convention

2022-05-17 Thread cbduggap
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3926 Pass Input parameters using RCX. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Signed-off-by: cbduggap --- .../SecFspWrapperPlatformSecLibSample/X64/SecEntry.nasm | 4 +++- 1 file changed, 3 insertions(+), 1

[edk2-devel] [PATCH v5 1/2] IntelFsp2Pkg: FSP_TEMP_RAM_INIT call must follow X64 Calling Convention

2022-05-17 Thread cbduggap
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3926 This API accept one parameter using RCX and this is consumed in mutiple sub functions. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Signed-off-by: cbduggap --- IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm | 39

[edk2-devel] [PATCH v5 0/2] FSP_TEMP_RAM_INIT call must follow X64 Calling Convention

2022-05-17 Thread cbduggap
cbduggap (2): IntelFsp2Pkg: FSP_TEMP_RAM_INIT call must follow X64 Calling Convention IntelFsp2WrapperPkg: FSP_TEMP_RAM_INIT call must follow X64 Calling Convention IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm | 39 ++- .../Include/SaveRestoreSseAvxNasm.inc |

Re: [edk2-devel] [PATCH V2 5/6] MdePkg: Probe Cc guest in BaseIoLibIntrinsicSev

2022-05-17 Thread Min Xu
On May 17, 2022 9:15 AM, Xu Min wrote: > On May 17, 2022 6:22 AM, dann frazier wrote: > > I ran through our tests on stable-202205-rc1, and I'm finding that all > > of the tests using 2M FD_SIZE & SMM_REQUIRE=TRUE are failing with > QEMU > > hanging w/o output. Equivalent tests w/ 4M FD_SIZE are

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PlatformCI: add IntelTdxBuild.py

2022-05-17 Thread Gerd Hoffmann
On Sun, May 15, 2022 at 07:33:04PM +0800, Min Xu wrote: > Add build test for OvmfPkg/IntelTdx > > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Tom Lendacky > Cc: Gerd Hoffmann > Cc: Jiewen Yao > Cc: Ard Biesheuvel > Signed-off-by: Min Xu Acked-by: Gerd Hoffmann -=-=-=-=-=-=-=-=-=-=-=-