Re: [edk2-devel] [PATCH v5 2/2] UefiPayloadPkg: Allow DxeMain.inf to consume the new SerialPortLib

The usage is not clear from the MACRO name DEBUG_REAL_INSTANCE_SUPPORT Not sure if we could have a better name (e.g., MULTIPLE_DEBUG_PORT_SUPPORT?) Thanks, Guo -Original Message- From: Sravanthi, K KavyaX Sent: Monday, August 29, 2022 10:29 PM To: devel@edk2.groups.io Cc: Sravanthi, K

Re: [edk2-devel] [PATCH v5 1/2] UefiPayloadPkg: Implement a new SerialPortLib instance

Had better read the register first and write register to have a short line and make it more readable. +SerialPortWriteRegister (SerialRegisterBase, R_UART_LCR, (UINT8)(SerialPortReadRegister (SerialRegisterBase, R_UART_LCR, MmioEnable, RegisterStride) | B_UART_LCR_DLAB), MmioEnable,

[edk2-devel] [PATCH v3 1/1] NetworkPkg/HttpBootDxe: Add Support for HTTPS Proxy Server for HTTP Boot

Add CONNECT HTTP command to create a tunnel from Proxy to EndPoint Server. Add support to connect through proxy server using multi-URI DevicePath sent to the Boot Manager. Cc: Maciej Rabeda Cc: Wu Jiaxin Cc: Siyuan Fu Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Saloni Kasbekar ---

回复: [edk2-devel] [PATCH v1 1/1] ShellPkg: Adds Local APIC parser to AcpiView

Abdul: This patch is merged again into edk2 at 3c06953fd76ca2d1372ce5b0df14608de53cd148. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Gao, Zhichao > 发送时间: 2022年8月22日 17:19 > 收件人: Abdul Lateef Attar ; devel@edk2.groups.io > 抄送: Ni, Ray > 主题: Re: [edk2-devel] [PATCH v1 1/1]

回复: [edk2-devel] [PATCH 1/6] BaseTools/VolInfo: Fix EFI_SECTION_GUID_DEFINED parsing

Konstantin: The changes for VolInfo tool is good to me . Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Konstantin > Aladyshev > 发送时间: 2022年8月30日 18:15 > 收件人: devel@edk2.groups.io > 抄送: bob.c.f...@intel.com; gaolim...@byosoft.com.cn; >

回复: [edk2-devel] [PATCH v2] BaseTools: Support COMPAT16 section generation

Aladyshev: The change is good. Reviewed-by: Liming Gao Besides, how do you find this issue? Have you such test case or usage? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Konstantin > Aladyshev > 发送时间: 2022年8月30日 18:20 > 收件人: devel@edk2.groups.io > 抄送:

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 08/30/2022 #cal-reminder

*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* 08/30/2022 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH v2 4/4] IntelFsp2WrapperPkg: Implement FSP 2.4 MultiPhase wrapper handlers.

Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, August 9, 2022 5:48 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v2 4/4] IntelFsp2WrapperPkg: Implement FSP 2.4 > MultiPhase wrapper

Re: [edk2-devel] [PATCH v2 3/4] IntelFsp2Pkg: Adopt FSP 2.4 MultiPhase functions.

Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, August 9, 2022 5:48 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v2 3/4] IntelFsp2Pkg: Adopt FSP 2.4 MultiPhase functions. > > REF:

Re: [edk2-devel] [PATCH v2 2/4] IntelFsp2WrapperPkg: Add FSP 2.4 MultiPhase interface.

Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, August 9, 2022 5:48 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v2 2/4] IntelFsp2WrapperPkg: Add FSP 2.4 MultiPhase > interface. > > REF:

Re: [edk2-devel] [PATCH v2 1/4] IntelFsp2Pkg: Add FSP 2.4 MultiPhase interface.

Hi Chasel, Please see feedback inline. Specifically, some improvements are needed in the comments. The code itself looks good! For that reason, there is no need to send a V3 patch series. Please fix the comments then you are free to push the change. With those changes... Reviewed-by: Nate

Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.

Hi Chasel, I have some minor feedback on PATCH 1/4. Specifically, some improvements are needed in the comments. The code itself looks good! For that reason, there is no need to send a V3 patch series. Please fix the comments then you are free to push the change. With those changes...

Re: [edk2-devel][edk2-platforms][PATCH v1 2/5] Silicon/Intel: Port SmmControl protocol to PPI for S3

Yes. PcdAcpiBaseAddress declaration can be moved to IntelSiliconPkg.dec Regards, Sai From: Oram, Isaac W Sent: Tuesday, August 30, 2022 11:40 AM To: devel@edk2.groups.io; benjamin.doro...@gmail.com; Chaganty, Rangasai V Cc: Desimone, Nathaniel L ; Sinha, Ankit ; Ni, Ray Subject: RE:

[edk2-devel] Python368 socket support #includes

Hello Ive tried building python368 in edk2 environment and Ive came across some issues. I cant seem to be able to import urllib or socket in a uefi shell env. The error reads, import _socket fails because _socket does not exist. Can anyone please provide a full guide on how to build python368

Re: [edk2-devel][edk2-platforms][PATCH v1 2/5] Silicon/Intel: Port SmmControl protocol to PPI for S3

@Chaganty, Rangasai V Is it fair to say that the build time address for ACPI BAR is the cross silicon design? I think it is and therefore we should move the PCD to IntelSiliconPkg. I agree with Benjamin that we don’t really want features depending on

Re: [edk2-devel] [PATCH v4 6/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI config

Hi Sami, Now that the merge window opens, could you please help us to merge in these patch series (after dropping this specific patch) when you have a chance? Please let me know if you ran into issues when doing that. Thanks in advance! Regards, Kun On 8/17/2022 10:42 AM, Kun Qin wrote:

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Add new Application/MpServicesTest application

On 8/29/22 09:59, Rebecca Cran wrote: +/** + Print app usage. +**/ +STATIC +VOID +PrintUsage ( + VOID + ) +{ + Print (L"MpServicesTest: usage\n"); + Print (L" MpServicesTest -A [-O]\n"); + Print (L" MpServicesTest -T \n"); + Print (L" MpServicesTest -S \n"); + Print (L"

[edk2-devel] [PATCH 1/1] OvmfPkg: Add BUILD_SHELL flag for IA32, IA32X64, X64

Add BUILD_SHELL flag, similar to the one in OvmfPkg/AmdSev, to enable/disable building of the UefiShell as part of the firmware image. The UefiShell should not be included for secure production systems (e.g. SecureBoot) because it can be used to circumvent security features. The default value for

Re: [edk2-devel][PATCH] Maintainers.txt: Update Maintainers/reviewers for universal payload

Reviewed-by: Michael D Kinney > -Original Message- > From: Dong, Guo > Sent: Monday, August 22, 2022 5:06 PM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Kinney, > Michael D ; Rhodes, > Sean ; Lu, James ; Guo, Gua > ; Liu, Zhiguang > > Subject: [edk2-devel][PATCH]

Re: [edk2-devel] [PATCH V2 14/14] MdeModulePkg: Pool and page functions accept memory when OOM occurs

On 8/29/22 22:20, Xu, Min M wrote: On August 30, 2022 4:47 AM, Lendacky, Thomas wrote: On 8/27/22 01:21, Min Xu wrote: From: Jiaqi Gao RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 When CoreAllocatePages() / CoreAllocatePool() meets error of EFI_OUT_OF_RESOURCES, locate the

Re: [edk2-devel] [PATCH] UefiPayloadPkg: To replace the libraries for the capsule driver.

Reviewed-by: Gua Guo -Original Message- From: Liu, KasimX Sent: Thursday, August 25, 2022 11:22 AM To: devel@edk2.groups.io Cc: Liu, KasimX ; Dong, Guo ; Ni, Ray ; Lu, James ; Guo, Gua Subject: [PATCH] UefiPayloadPkg: To replace the libraries for the capsule driver. From: KasimX

[edk2-devel] [PATCH v2] BaseTools: Correct initialization data size check for array PCDs

Currently it is not possible to initialize all elements in the array PCD. For example, this PCD would result to a build failure: gTokenSpaceGuid.PcdArray|{0x11, 0x22}|UINT8[2]|0x4C4CB9A3 Correct logical operator in the initialization data size checks to fix the issue. Signed-off-by: Konstantin

[edk2-devel] [PATCH v2] BaseTools: Add missing spaces for PCD expression values in AutoGenC

Currently the PCD values calculated from the expressions have different formating from the simple byte arrays in AutoGenC. Example: The following definition in DEC: gTokenSpaceGuid.PcdArray|{0x44, 0x33, 0x22, 0x11}|VOID*|0x

[edk2-devel] [PATCH v2] BaseTools: Support COMPAT16 section generation

Currently COMPAT16 section type is not recognized and GenSec is called without the "-s [SectionType]" argument. Add COMPAT16 type to the SectionType dictionary to fix the issue. Now this syntax works correctly: ``` FILE FREEFORM = { SECTION COMPAT16 = } ``` Signed-off-by: Konstantin

[edk2-devel] [PATCH v2] BaseTools: Add support for SUBTYPE_GUID section generation

EFI_SECTION_FREEFORM_SUBTYPE_GUID is a leaf section type that contains a single EFI_GUID in the header to describe the raw data. Currently is is not possible to generate such section. This patch adds initial support for the generation of such sections. The added syntax for this type of section

[edk2-devel] [PATCH v2] BaseTools/GenFds: Correct file type set for the PIC section

Corrently the set of file types for the PIC section contains two duplicate values. Replace the duplicate value with the correct one to fix the issue. Signed-off-by: Konstantin Aladyshev --- BaseTools/Source/Python/GenFds/FdfParser.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[edk2-devel] [PATCH 6/6] BaseTools/VolInfo: Update copyright information

Add Konstantin Aladyshev to the copyright header. Signed-off-by: Konstantin Aladyshev --- BaseTools/Source/C/VolInfo/VolInfo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c b/BaseTools/Source/C/VolInfo/VolInfo.c index 28c6806cf0..428011ca04 100644 ---

[edk2-devel] [PATCH 5/6] BaseTools/VolInfo: Parse apriori files

Output file GUIDs from the DXE and PEI apriori files. Signed-off-by: Konstantin Aladyshev --- BaseTools/Source/C/VolInfo/VolInfo.c | 74 1 file changed, 74 insertions(+) diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c b/BaseTools/Source/C/VolInfo/VolInfo.c index

[edk2-devel] [PATCH 4/6] BaseTools/VolInfo: Update file and section type strings

Change SMM to MM in naming according to the recent PI specifications. Remove trailing whitespaces in some strings. Signed-off-by: Konstantin Aladyshev --- BaseTools/Source/C/VolInfo/VolInfo.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[edk2-devel] [PATCH 3/6] BaseTools/VolInfo: Increase GUID base name string

The current string lenght (=60) is not enough for cases where basename is a path to Build folder. Drop custom define and use MAX_LINE_LEN from the BaseTools codebase instead. Signed-off-by: Konstantin Aladyshev --- BaseTools/Source/C/VolInfo/VolInfo.c | 4 +--- 1 file changed, 1 insertion(+), 3

[edk2-devel] [PATCH 2/6] BaseTools/VolInfo: Correct buffer for GenCrc32 tool

If the guided section was encoded with GenCrc32 tool the resulting 'EFI_GUID_DEFINED_SECTION.DataOffset' field points to the start of the meaningfull data that follows the CRC32 value. But if we want to decode the section with GenCrc32 tool we need to provide a buffer that includes the CRC32 value

[edk2-devel] [PATCH 1/6] BaseTools/VolInfo: Fix EFI_SECTION_GUID_DEFINED parsing

Currently 'PutFileImage' function is called with arguments that are not advanced on each section parsing. This would lead to an error if EFI_SECTION_GUID_DEFINED is not the first in a file. The same mistake is present in the parsing of CRC32 guided section case. Use correct arguments to fix the

Re: [edk2-devel] [PATCH V2 14/14] MdeModulePkg: Pool and page functions accept memory when OOM occurs

> > Do you mean: > > Accepting 4G memory in ResetVector and accepting more memory in TD > DXE > > driver through MP protocol? > The unaccepted-memory-region is described in TdHob which is passed by > QEMU. It includes the start address and size of the unaccepted-memory- > region. Accepting

Re: [edk2-devel] [PATCH V2 14/14] MdeModulePkg: Pool and page functions accept memory when OOM occurs

On August 30, 2022 3:44 PM, Ni Ray wrote: > > On August 30, 2022 3:12 PM, Ni Ray wrote: > > > > > > I saw the justification of this is to support different size of > > > Linux kernel images. > > > But that's after TD DXE driver. > > > For code running before TD DXE driver, the memory needs is > >

Re: [edk2-devel] [PATCH V2 14/14] MdeModulePkg: Pool and page functions accept memory when OOM occurs

> > > > I am also nervous to change in the fundamental memory allocation service > > (MdeModulePkg/Core/Dxe/Mem). > > Another option is that in current stage we accept memories under 4G and > so > > that we can drop this patch (Pool and page functions accept memory when > > OOM occurs). > > > >

Re: [edk2-devel] [PATCH V2 14/14] MdeModulePkg: Pool and page functions accept memory when OOM occurs

> On August 30, 2022 3:12 PM, Ni Ray wrote: > > > > I saw the justification of this is to support different size of Linux kernel > > images. > > But that's after TD DXE driver. > > For code running before TD DXE driver, the memory needs is predicable, > > right? > That's right. The memory before

Re: [edk2-devel] [PATCH V2 14/14] MdeModulePkg: Pool and page functions accept memory when OOM occurs

On August 30, 2022 3:12 PM, Ni Ray wrote: > > I saw the justification of this is to support different size of Linux kernel > images. > But that's after TD DXE driver. > For code running before TD DXE driver, the memory needs is predicable, > right? That's right. The memory before loading linux

Re: [edk2-devel] [PATCH V2 14/14] MdeModulePkg: Pool and page functions accept memory when OOM occurs

I saw the justification of this is to support different size of Linux kernel images. But that's after TD DXE driver. For code running before TD DXE driver, the memory needs is predicable, right? > -Original Message- > From: Xu, Min M > Sent: Tuesday, August 30, 2022 2:35 PM > To: Ni,

Re: [edk2-devel] [PATCH V2 14/14] MdeModulePkg: Pool and page functions accept memory when OOM occurs

On August 30, 2022 2:15 PM, Ni Ray wrote: > Min, > My understanding is there is a TDX driver in DXE phase that accepts memory > using MP protocol. EdkiiMemoryAcceptProtocol is a protocol which accept memories. It is implemented/installed by the platform drivers, such as TdxDxe driver, or SEV

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/NvmExpressPei: Use PCI_DEVICE_PPI to manage Nvme device

Thanks. Reviewed-by: Hao A Wu Will wait a couple of days before merging to see if comments from other reviewers. Best Regards, Hao Wu > -Original Message- > From: Chen, Xiao X > Sent: Tuesday, August 30, 2022 1:47 PM > To: devel@edk2.groups.io > Cc: Chen, Xiao X ; Wu, Hao A > ; Ni,

Re: [edk2-devel] [PATCH V2 14/14] MdeModulePkg: Pool and page functions accept memory when OOM occurs

Min, My understanding is there is a TDX driver in DXE phase that accepts memory using MP protocol. We only need to make sure there is sufficient memory for code running before that point. Is my understanding correct? Thanks, Ray > -Original Message- > From: Xu, Min M > Sent: Tuesday,

Re: [edk2-devel] [PATCH V2 14/14] MdeModulePkg: Pool and page functions accept memory when OOM occurs

On August 30, 2022 8:29 AM, Ni, Ray wrote: > Can you please explain more about this patch? > I am a little nervous when seeing patches that change the fundamental > memory services. > With the introduction of lazy-page-accept, the OUT_OF_RESOURCE may occur in Memory Allocation logic