[edk2-devel] [PATCH 1/1] MdeModulePkg/XhciDxe: Add PCD for the delay of HCRST

https://bugzilla.tianocore.org/show_bug.cgi?id=4727 Recently some of XHCI host controllers require to have extra 1ms delay before accessing any MMIO register during reset. PHY transition from P3 to P0 can take around 1.3ms and the xHCI reset can take around 1.5ms. Add PCD to control the delay,

Re: [edk2-devel] [PATCH] ShellPkg: Update smbiosview type 4 with SMBIOS 3.6 fields

Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Lien, > HoraceX > Sent: Tuesday, March 26, 2024 5:11 PM > To: devel@edk2.groups.io > Cc: Lien, HoraceX ; Gao, Zhichao > > Subject: [edk2-devel] [PATCH] ShellPkg: Update smbiosview

Re: [edk2-devel] [PATCH V2 1/6] RedfishPkg/RedfishPlatformConfigDxe: Config language searching optimization

Hi Abner, Could we change "DescriptionStr" below to something like "XuefiString", so people don't think it is a regular English string of HII statement? > + EFI_STRING_ID Description; // String > token of this question. > + CHAR16

Re: [edk2-devel] [PATCH] Platform/Loongson: Remove minimium memory size limitation

hi  maobibo: > > > On 2024/3/25 下午5:25, xianglai wrote: >> From: Bibo Mao >> >> Temparory stack memory on PEI is hardcoded now, also minimium memory >> [..] >> + >> +  QemuFwCfgSelectItem (FwCfgItem); >> +  for (Processed = 0; Processed < FwCfgSize; Processed += sizeof >> MemoryMapEntry) {

[edk2-devel] Cancelled Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, March 26, 2024 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20231222T233358Z

Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix GetRedpathNodeByIndex()

Hi, I have updated patches with R-b and pushed it to PR https://github.com/tianocore/edk2-redfish-client/pull/85 Thank you for the review! Regards, Mike On Tue, Mar 26, 2024 at 4:41 PM Nickle Wang wrote: > > Thanks for your reminder, Abner. I verify this patch series on my system, and > I

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Align the SEC module within OvmfPkgX64

On Tue, 26 Mar 2024 at 22:01, Glenn Griffin wrote: > > Prior to this change the alignment of the SEC module would be 4 bytes. > This is inconsistent with the expectations of the compiler and can lead > to unexpected behavior. > > For example a modern version of clang with size optimizations

[edk2-devel] [PATCH 1/1] OvmfPkg: Align the SEC module within OvmfPkgX64

Prior to this change the alignment of the SEC module would be 4 bytes. This is inconsistent with the expectations of the compiler and can lead to unexpected behavior. For example a modern version of clang with size optimizations enabled (-Oz) can break the ALIGN_POINTER macro in the SEC module.

[edk2-devel] [PATCH 1/1] OvmfPkg: Align the SEC module within OvmfPkgX64

Prior to this change the alignment of the SEC module would be 4 bytes. This is inconsistent with the expectations of the compiler and can lead to unexpected behavior. For example a modern version of clang with size optimizations enabled (-Oz) can break the ALIGN_POINTER macro in the SEC module.

Re: [edk2-devel] [PATCH v3 00/24] Provide SEV-SNP support for running under an SVSM

Any issues with this version of the series? Still looking for Reviewed-by's for the MdePkg, UefiCpuPkg and UefiPayloadPkg related patches. Once I get those, I'll submit the edk2-platform patches to support the new library as a response to these patches for a quick review. Thanks, Tom On

[edk2-devel] [PATCH v1 1/1] ArmVirtPkg: Kvmtool: Fix ACPI/DT boot selection

The Kvmtool guest firmware uses the dynamic HII PCD PcdForceNoAcpi to determine if ACPI tables or the DT must be used for booting an OS. This PcdForceNoAcpi is a BOOLEAN value that can be configured using the variable "ForceNoAcpi" specifing the gOvmfVariableGuid GUID which is

Re: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details

Hi All , Remider , request to review and provide feedback , Thanks, P. Madhan -Original Message- From: Pethaiyan, Madhan Sent: Thursday, March 14, 2024 1:47 PM To: Kinney, Michael D ; devel@edk2.groups.io Cc: Liming Gao ; Liu, Zhiguang ; Li, Yi1 ; GuoX Xu Subject: RE: [edk2-devel]

Re: [edk2-devel] [RFC PATCH] OvmfPkg/SecurityPkg: Add build option for coexistance of vTPM and RTMR.

On Fri, Mar 22, 2024 at 07:56:53AM -0700, Dionna Amalie Glaze wrote: > On Fri, Mar 22, 2024 at 1:52 AM Gerd Hoffmann wrote: > > > > On Fri, Mar 22, 2024 at 02:39:20AM +, Yao, Jiewen wrote: > > > Please aware that this option will cause potential security risk. > > > > > > In case that any the

[edk2-devel] compile with Visual Studio 2022 Community edition

Hello Mr. Tianocore, I am registered under schwertas at github, but did not want to register in your bug tracker tool. I have a feature request: The Edk2 tool cannot be compiled by Vs2022 Community edition, because some compiler Warnings have turned to errors by Microsoft. This affects

[edk2-devel] [RFC PATCH] OvmfPkg/SecurityPkg: Add build option for coexistance of vTPM and RTMR.

From: Qinkun Bao The UEFI v2.10 spec defines the protocol EFI_CC_MEASUREMENT_PROTOCOL to enable (for example) RTMR-based boot measurement for TDX VMs. With the current UEFI spec’s “should not” wording and EDK2 implementation, TPM measurement in TDVF is disabled when RTMR measurement is enabled.

[edk2-devel] UART Driver for STM32MP25 with EDK2

I want to write a driver UART for my platform in EDK2-platform. I made a change at https://github.com/tianocore/edk2/blob/master/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c with the address of my platform and used

Re: [edk2-devel] [RFC PATCH] OvmfPkg/SecurityPkg: Add build option for coexistance of vTPM and RTMR.

On Fri, Mar 22, 2024 at 7:57 AM Dionna Amalie Glaze wrote: > > On Fri, Mar 22, 2024 at 1:52 AM Gerd Hoffmann wrote: > > > > On Fri, Mar 22, 2024 at 02:39:20AM +, Yao, Jiewen wrote: > > > Please aware that this option will cause potential security risk. > > > > > > In case that any the guest

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/QemuBootOrderLib: Measure the etc/boot-menu-wait

On Tue, Mar 26, 2024 at 09:08:59AM +, Sun, CepingX wrote: > On Friday, March 22, 2024 5:06 PM Gerd Hoffmann wrote: > > > > No, we only need to update QemuFwCfgSelectItem + QemuFwCfgReadBytes to > > support reading from the cache. > Do you mean the existing API (QemuFwCfgSelectItem +

[edk2-devel] [PATCH V2 5/6] EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs

From: Abner Chang Signed-off-by: Abner Chang Cc: Nickle Wang --- EmulatorPkg/EmulatorPkg.dsc | 21 + 1 file changed, 21 insertions(+) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc index 85134b07816..5fa1ed345a3 100644 ---

[edk2-devel] [PATCH V2 6/6] RedfishPkg/RedfishPlatformConfigDxe: support menu path report

From: Nickle Wang "MenuPath" is the attribute in BIOS attribute registry. To support reporting this attribute, we need to include the formset without x-uefi-redfish support in database. So driver can find menu path to target attribute in BIOS menu. Signed-off-by: Nickle Wang Cc: Abner Chang

[edk2-devel] [PATCH V2 4/6] RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted unexpectedly

From: Abner Chang Add the condition check when delete HII string. Only when the HiiStatement operand equal to "EFI_IFR_STRING_OP" and the statement value type = EFI_IFR_TYPE_STRING. Signed-off-by: Abner Chang Co-authored-by: Nickle Wang Cc: Igor Kulchytskyy ---

[edk2-devel] [PATCH V2 3/6] RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support

From: Abner Chang Add RedfishPlatformConfigDxe debug capability that aligns with edk2 Redfish debug mechanism. - PcdRedfishPlatformConfigDebugProperty, add PCD to control RedfishPlatformConfigDxe subordinate of Redfish debug capabilities. - PcdRedfishPlatformConfigFeatureProperty, add PCD

[edk2-devel] [PATCH V2 2/6] RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro

From: Abner Chang Introduce DEBUG_REDFISH macro for the debug message of edk2 Redfish components. DEBUG_REDFISH can be used in any edk2 Redfish component with Redfish DebugCatagory as the first parameter. Whether the debug message is output or not depends on the platform setting of

[edk2-devel] [PATCH V2 1/6] RedfishPkg/RedfishPlatformConfigDxe: Config language searching optimization

From: abnchang Build up the x-uefi-redfish string database for the Redfish confg language searching, instead of using HII String protocol. This can improve the time consumption lot on searching strings. Signed-off-by: Abner Chang Co-authored-by: Nickle Wang Cc: Igor Kulchytskyy ---

[edk2-devel] [PATCH V2 0/6] [PATCH V2 0/5] Config language searching algorithm enhancement and the bug fixes

From: Abner Chang PR # 5491 In V2, add patch 6/6 contibuted by Nvidia for updating BIOS menu path implementation based on the performance improvement. In this patch set, 1 We enhance the config language searching algorithm. As the performance of searching config language using HII GetString

Re: [edk2-devel] [PATCH v2 1/1] SbsaQemu: AcpiDxe: Create SRAT table at runtime

W dniu 20.02.2024 o 08:47, Xiong Yining pisze: Add support to create SRAT(System resource affinity table) for sbsa platform at runtime. Signed-off-by: Xiong Yining Signed-off-by: Chen Baozi Needs rebase on top of "get rid of DeviceTree from SbsaQemu" series. Rename SbsaQemuHardwareInfoLib to

Re: [edk2-devel] [PATCH v3 1/1] SbsaQemu: add memory space for the high memory nodes

W dniu 20.02.2024 o 08:33, Xiong Yining pisze: To support more memory nodes, we refer to the implement of "OvmfPkg/Fdt/HighMemDxe" to add memory space for the high memory nodes except the first one. Signed-off-by: Xiong Yining Signed-off-by: Chen Baozi Needs rebase on top of "get rid of

Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix GetRedpathNodeByIndex()

Thanks for your reminder, Abner. I verify this patch series on my system, and I don't see any issue. Hi @Mike Maslenkin, please add Abner and my reviewed-by to the commit messages. And we can merge the pull request. Thanks, Nickle > -Original

Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 3/3] RedfishClientPkg: fix the first node processing in GetRedpathNodeByIndex()

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Saturday, March 23, 2024 8:01 PM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Igor Kulchytskyy ; Nickle Wang > > Subject: [edk2-redfish-client][RFC PATCH 3/3]

Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Maintainers.txt: add myself as QemuSbsa maintainer

On Tue, Mar 26, 2024 at 13:10:58 +0100, Marcin Juszkiewicz wrote: > With all changes going around sbsa-ref/QemuSbsa platform Leif suggested > that I should become maintainer as well. > > My GitHub account name is "hrw". > > Signed-off-by: Marcin Juszkiewicz Reviewed-by: Leif Lindholm Tweaked

Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 2/3] RedfishClientPkg: fix the last field processing in GetRedpathNodeByIndex()

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Saturday, March 23, 2024 8:01 PM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Igor Kulchytskyy ; Nickle Wang > > Subject: [edk2-redfish-client][RFC PATCH 2/3]

Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 1/3] RedfishClientPkg: fix nodes count in GetRedpathNodeByIndex()

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Saturday, March 23, 2024 8:01 PM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Igor Kulchytskyy ; Nickle Wang > > Subject: [edk2-redfish-client][RFC PATCH 1/3]

Re: [edk2-devel] [edk2-redfish-client][PATCH V5 2/2] RedfishClientPkg/FeatureDriver: Use SetRedfishSettingsObjectsUri

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, March 22, 2024 10:41 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH V5 2/2] RedfishClientPkg/FeatureDriver: > Use

Re: [edk2-devel] [edk2-redfish-client][PATCH V5 1/2] RedfishClientPkg: Set SettingsObject URI as the config language

Thanks for working on this, Abner. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, March 22, 2024 10:41 PM > To: devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nickle Wang > Subject: [edk2-redfish-client][PATCH V5 1/2]

Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Maintainers.txt: add myself as QemuSbsa maintainer

On Tue, 26 Mar 2024 at 14:11, Marcin Juszkiewicz wrote: > > With all changes going around sbsa-ref/QemuSbsa platform Leif suggested > that I should become maintainer as well. > > My GitHub account name is "hrw". > > Signed-off-by: Marcin Juszkiewicz Welcome! Reviewed-by: Ard Biesheuvel > ---

[edk2-devel] [PATCH edk2-platforms v2 1/1] Maintainers.txt: add myself as QemuSbsa maintainer

With all changes going around sbsa-ref/QemuSbsa platform Leif suggested that I should become maintainer as well. My GitHub account name is "hrw". Signed-off-by: Marcin Juszkiewicz --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt

Re: [edk2-devel] [PATCH 0/5] [PATCH 0/5] Config language searching algorithm enhancement and the bug fixes

Thanks for working on Redfish performance improvements, Abner. Per offline discussion, I have updated this patch series to support menu path reporting for BIOS attribute registry. Please send version 2 patch series if you are ok with my modifications. Thanks, Nickle > -Original

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Maintainers.txt: add myself as QemuSbsa maintainer

On Tue, Mar 26, 2024 at 12:24:10 +0100, Marcin Juszkiewicz wrote: > With all changes going around sbsa-ref/QemuSbsa platform Leif suggested > that I should become maintainer as well. > > My GitHub account name is "hrw". > > Signed-off-by: Marcin Juszkiewicz > --- > Maintainers.txt | 2 +- > 1

[edk2-devel] [PATCH edk2-platforms 1/1] Maintainers.txt: add myself as QemuSbsa maintainer

With all changes going around sbsa-ref/QemuSbsa platform Leif suggested that I should become maintainer as well. My GitHub account name is "hrw". Signed-off-by: Marcin Juszkiewicz --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt

[edk2-devel] [PATCH] ShellPkg: Update smbiosview type 4 with SMBIOS 3.6 fields

From: HoraceX Lien REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4737 update smbiosview type 4 related fileds. Signed-off-by: HoraceX Lien Cc: Zhichao Gao --- .../Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/QemuBootOrderLib: Measure the etc/boot-menu-wait

On Friday, March 22, 2024 5:06 PM Gerd Hoffmann wrote: > > > > But then you have to find and update all callsites (or at least the > > > ones where we care about measurement). > > In your solution, if we cache all items that need to be measured, we > > would have to add a new API (example:

[edk2-devel] [PATCH v2 1/1] MdeModulePkg/AcpiTableDxe: PCD switch to avoid using ACPI reclaim memory

UEFI spec defined ACPI Tables at boot time can be contained in memory of type EfiACPIReclaimMemory or EfiAcpiMemoryNVS, although InstallAcpiTable with AcpiTableProtocol will only allocate memory with type EfiACPIReclaimMemory (Except FACS). This patch provides an optional method controlled by PCD