Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA

2022-08-25 Thread Gerd Hoffmann
Hi, > We can design 2 instances of CcProbe. One is to read the OvmfWorkArea. This > is for SEC/PEI phase. > The other is to save the guest type in Ovmf work area to a global variable in > its init function. This is for DXE phase. I mean this one. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA

2022-08-25 Thread Min Xu
On August 25, 2022 3:42 PM, Gerd Hoffmann wrote: > Hi, > > > > Runtime service call are restricted so that you don't have > > > concurrent threads executing (see section 8.1 of the specification). > > > Without that you would have problems with runtime services today. > > > > > One of the situat

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA

2022-08-25 Thread Gerd Hoffmann
Hi, > > Runtime service call are restricted so that you don't have concurrent > > threads > > executing (see section 8.1 of the specification). Without that you would > > have > > problems with runtime services today. > > > One of the situation of CcProbe used is in BaseIoLib. > https://github

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA

2022-08-24 Thread Min Xu
On August 23, 2022 9:07 PM, Lendacky,Thomas wrote: > On 8/23/22 03:40, Xu, Min M wrote: > > On August 23, 2022 3:38 PM, Gerd Hoffmann wrote: > >>Hi, > >> > >>> Ah, I forget to reserve the work-area as RT_Data in below code: > >>>BuildMemoryAllocationHob ( > >>> (EFI_PHYSICAL_AD

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA

2022-08-23 Thread Lendacky, Thomas via groups.io
On 8/23/22 03:40, Xu, Min M wrote: On August 23, 2022 3:38 PM, Gerd Hoffmann wrote: Hi, Ah, I forget to reserve the work-area as RT_Data in below code: BuildMemoryAllocationHob ( (EFI_PHYSICAL_ADDRESS)(UINTN)FixedPcdGet32 (PcdOvmfWorkAreaBase), (UINT64)(UINTN)Fixe

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA

2022-08-23 Thread Min Xu
On August 23, 2022 3:38 PM, Gerd Hoffmann wrote: > Hi, > > > Ah, I forget to reserve the work-area as RT_Data in below code: > > BuildMemoryAllocationHob ( > > (EFI_PHYSICAL_ADDRESS)(UINTN)FixedPcdGet32 > (PcdOvmfWorkAreaBase), > > (UINT64)(UINTN)FixedPcdGet32 (PcdOvmfWorkA

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA

2022-08-23 Thread Gerd Hoffmann
Hi, > Ah, I forget to reserve the work-area as RT_Data in below code: > BuildMemoryAllocationHob ( > (EFI_PHYSICAL_ADDRESS)(UINTN)FixedPcdGet32 (PcdOvmfWorkAreaBase), > (UINT64)(UINTN)FixedPcdGet32 (PcdOvmfWorkAreaSize), > PlatformInfoHob->S3Supported ? EfiACPIMemor

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA

2022-08-22 Thread Min Xu
On August 22, 2022 9:19 PM, Tom Lendacky wrote: > On 8/21/22 21:23, Min Xu wrote: > > From: Min M Xu > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3974 > > > > Ovmf work-area (PcdOvmfWorkArea) was designed to store the > > Confidential Computing guest information, including the CC gue

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA

2022-08-22 Thread Min Xu
On August 22, 2022 4:52 PM, Gerd Hoffmann wrote: > On Mon, Aug 22, 2022 at 10:23:01AM +0800, Min Xu wrote: > > From: Min M Xu > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3974 > > > > Ovmf work-area (PcdOvmfWorkArea) was designed to store the > > Confidential Computing guest informat

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA

2022-08-22 Thread Lendacky, Thomas via groups.io
On 8/21/22 21:23, Min Xu wrote: From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3974 Ovmf work-area (PcdOvmfWorkArea) was designed to store the Confidential Computing guest information, including the CC guest type. This information will be probed by CcProbeLib so that the CC

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA

2022-08-22 Thread Gerd Hoffmann
On Mon, Aug 22, 2022 at 10:23:01AM +0800, Min Xu wrote: > From: Min M Xu > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3974 > > Ovmf work-area (PcdOvmfWorkArea) was designed to store the Confidential > Computing guest information, including the CC guest type. This > information will be

[edk2-devel] [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA

2022-08-21 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3974 Ovmf work-area (PcdOvmfWorkArea) was designed to store the Confidential Computing guest information, including the CC guest type. This information will be probed by CcProbeLib so that the CC guest type can be determined in ru