Re: [edk2-devel] [PATCH RFC v3 04/22] OvmfPkg/MemEncryptSevLib: extend Es Workarea to include hv features

2021-06-09 Thread Laszlo Ersek
On 06/08/21 23:36, Tom Lendacky wrote: > On 6/8/21 3:49 AM, Laszlo Ersek wrote: >> On 06/07/21 15:37, Brijesh Singh wrote: >> >> > ... > >> ... But maybe I just need to accept that we have to repurpose >> SEC_SEV_ES_WORK_AREA, considering it a super-early "HOB list" of sorts. >> Same as the PEI

Re: [edk2-devel] [PATCH RFC v3 04/22] OvmfPkg/MemEncryptSevLib: extend Es Workarea to include hv features

2021-06-08 Thread Lendacky, Thomas via groups.io
On 6/8/21 3:49 AM, Laszlo Ersek wrote: > On 06/07/21 15:37, Brijesh Singh wrote: > > ... > ... But maybe I just need to accept that we have to repurpose > SEC_SEV_ES_WORK_AREA, considering it a super-early "HOB list" of sorts. > Same as the PEI phase is considered the "HOB producer phase",

Re: [edk2-devel] [PATCH RFC v3 04/22] OvmfPkg/MemEncryptSevLib: extend Es Workarea to include hv features

2021-06-08 Thread Brijesh Singh via groups.io
On 6/8/21 3:49 AM, Laszlo Ersek wrote: > On 06/07/21 15:37, Brijesh Singh wrote: > >> Also, I was trying to avoid the cases where the malicious hypervisor >> changing the feature value after the GHCB negotiation is completed.  >> e.g, during the reset vector they give us one feature value and

Re: [edk2-devel] [PATCH RFC v3 04/22] OvmfPkg/MemEncryptSevLib: extend Es Workarea to include hv features

2021-06-08 Thread Laszlo Ersek
On 06/07/21 15:37, Brijesh Singh wrote: > Also, I was trying to avoid the cases where the malicious hypervisor > changing the feature value after the GHCB negotiation is completed.  > e.g, during the reset vector they give us one feature value and change > them during SEC or PEI or DXE instances

Re: [edk2-devel] [PATCH RFC v3 04/22] OvmfPkg/MemEncryptSevLib: extend Es Workarea to include hv features

2021-06-07 Thread Brijesh Singh via groups.io
Hi Laszlo, On 6/7/21 6:54 AM, Laszlo Ersek wrote: > Hi Brijesh, > > On 05/27/21 01:11, Brijesh Singh wrote: >> BZ: >>

Re: [edk2-devel] [PATCH RFC v3 04/22] OvmfPkg/MemEncryptSevLib: extend Es Workarea to include hv features

2021-06-07 Thread Laszlo Ersek
Hi Brijesh, On 05/27/21 01:11, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The GHCB Version 2 introduces advertisement of features that are supported > by the hypervisor. The features value is saved in the SevEs workarea. Save > the value in the PCD for the

[edk2-devel] [PATCH RFC v3 04/22] OvmfPkg/MemEncryptSevLib: extend Es Workarea to include hv features

2021-05-26 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The GHCB Version 2 introduces advertisement of features that are supported by the hypervisor. The features value is saved in the SevEs workarea. Save the value in the PCD for the later use. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao