Re: [edk2-devel] [PATCH V3 14/29] UefiCpuPkg: Enable Tdx support in MpInitLib

2021-11-08 Thread Min Xu
On November 5, 2021 2:46 PM, Gerd Hoffmann wrote: > > > Can't you create something in MdePkg/Library/Baselib and then use it > > > everywhere it's needed? > > > > > Do you mean put the basic Tdx functions in MdePkg/Library/BaseLib? If that > > is > the case, then I would add below basic Tdx

Re: [edk2-devel] [PATCH V3 14/29] UefiCpuPkg: Enable Tdx support in MpInitLib

2021-11-05 Thread Min Xu
On November 5, 2021 2:46 PM, Gerd Hoffmann wrote: > > > Can't you create something in MdePkg/Library/Baselib and then use it > > > everywhere it's needed? > > > > > Do you mean put the basic Tdx functions in MdePkg/Library/BaseLib? If that > > is > the case, then I would add below basic Tdx

Re: [edk2-devel] [PATCH V3 14/29] UefiCpuPkg: Enable Tdx support in MpInitLib

2021-11-05 Thread Gerd Hoffmann
> > Can't you create something in MdePkg/Library/Baselib and then use it > > everywhere it's needed? > > > Do you mean put the basic Tdx functions in MdePkg/Library/BaseLib? If that is > the case, then I would add below basic Tdx functions in BaseLib: > - TdIsEnabled () > - TdCall () > -

Re: [edk2-devel] [PATCH V3 14/29] UefiCpuPkg: Enable Tdx support in MpInitLib

2021-11-04 Thread Min Xu
On November 4, 2021 11:21 PM, Tom Lendacky wrote: > On 11/4/21 3:10 AM, Gerd Hoffmann wrote: > > On Wed, Nov 03, 2021 at 12:57:37PM +, Xu, Min M wrote: > >> On November 3, 2021 2:09 PM, Gerd Hoffmann wrote: > +++ b/UefiCpuPkg/Library/MpInitLib/X64/IntelTdcall.nasm > @@ -0,0 +1,120 @@

Re: [edk2-devel] [PATCH V3 14/29] UefiCpuPkg: Enable Tdx support in MpInitLib

2021-11-04 Thread Lendacky, Thomas via groups.io
On 11/4/21 3:10 AM, Gerd Hoffmann wrote: On Wed, Nov 03, 2021 at 12:57:37PM +, Xu, Min M wrote: On November 3, 2021 2:09 PM, Gerd Hoffmann wrote: +++ b/UefiCpuPkg/Library/MpInitLib/X64/IntelTdcall.nasm @@ -0,0 +1,120 @@ +;

Re: [edk2-devel] [PATCH V3 14/29] UefiCpuPkg: Enable Tdx support in MpInitLib

2021-11-04 Thread Gerd Hoffmann
On Wed, Nov 03, 2021 at 12:57:37PM +, Xu, Min M wrote: > On November 3, 2021 2:09 PM, Gerd Hoffmann wrote: > > > +++ b/UefiCpuPkg/Library/MpInitLib/X64/IntelTdcall.nasm > > > @@ -0,0 +1,120 @@ > > > +; > > > +-- > > >

Re: [edk2-devel] [PATCH V3 14/29] UefiCpuPkg: Enable Tdx support in MpInitLib

2021-11-03 Thread Min Xu
On November 3, 2021 2:09 PM, Gerd Hoffmann wrote: > > +++ b/UefiCpuPkg/Library/MpInitLib/X64/IntelTdcall.nasm > > @@ -0,0 +1,120 @@ > > +; > > +-- > > +;* > > +;* Copyright (c) 2020 - 2021, Intel Corporation. All rights >

Re: [edk2-devel] [PATCH V3 14/29] UefiCpuPkg: Enable Tdx support in MpInitLib

2021-11-03 Thread Gerd Hoffmann
> +++ b/UefiCpuPkg/Library/MpInitLib/X64/IntelTdcall.nasm > @@ -0,0 +1,120 @@ > +;-- > +;* > +;* Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved. > +;* SPDX-License-Identifier: BSD-2-Clause-Patent > +;* >

[edk2-devel] [PATCH V3 14/29] UefiCpuPkg: Enable Tdx support in MpInitLib

2021-11-01 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 In TDVF BSP and APs are simplified. BSP is the vCPU-0, while the others are treated as APs. So MP intialization is rather simple. The processor info is retrieved by TDCALL, ApWorker is not supported, BSP is always the working processor,