Re: [edk2-devel] [PATCH v3 10/11] OvmfPkg: add BlobVerifierLibSevHashes

2021-07-21 Thread Dov Murik
Tom, Brijesh, Ard, I think I found a bug in this patch. I used libfuzzer to test the VerifyBlob implementation here, and it immediately found a few "read memory out of range" issues. See details below in VerifyBlob. If the Guest Owner properly validates the measurement (which includes the

Re: [edk2-devel] [PATCH v3 10/11] OvmfPkg: add BlobVerifierLibSevHashes

2021-07-20 Thread Brijesh Singh via groups.io
On 7/20/21 3:04 AM, Dov Murik wrote: Add an implementation for BlobVerifierLib that locates the SEV hashes table and verifies that the calculated hashes of the kernel, initrd, and cmdline blobs indeed match the expected hashes stated in the hashes table. If there's a missing hash or a hash

Re: [edk2-devel] [PATCH v3 10/11] OvmfPkg: add BlobVerifierLibSevHashes

2021-07-20 Thread Lendacky, Thomas via groups.io
On 7/20/21 3:04 AM, Dov Murik wrote: > Add an implementation for BlobVerifierLib that locates the SEV hashes > table and verifies that the calculated hashes of the kernel, initrd, and > cmdline blobs indeed match the expected hashes stated in the hashes > table. > > If there's a missing hash or a

[edk2-devel] [PATCH v3 10/11] OvmfPkg: add BlobVerifierLibSevHashes

2021-07-20 Thread Dov Murik
Add an implementation for BlobVerifierLib that locates the SEV hashes table and verifies that the calculated hashes of the kernel, initrd, and cmdline blobs indeed match the expected hashes stated in the hashes table. If there's a missing hash or a hash mismatch then EFI_ACCESS_DENIED is returned