Re: [edk2-devel] [PATCH v4 1/4] OvmfPkg/MemEncryptHypercallLib: add library to support SEV hypercalls.

2021-06-23 Thread Ashish Kalra via groups.io
Hello Tom, Brijesh, Thanks for your comments and feedback on this patch-set. With reference to those, i will remove the new library and add the hypercall function inside BaseMemEncryptSevLib library. Also i will let the hypercall handling for SEV-ES be done as part of #VC exception handling in

Re: [edk2-devel] [PATCH v4 1/4] OvmfPkg/MemEncryptHypercallLib: add library to support SEV hypercalls.

2021-06-22 Thread Ashish Kalra via groups.io
Hello Tom, On Tue, Jun 22, 2021 at 05:47:48PM -0500, Tom Lendacky wrote: > On 6/21/21 8:56 AM, Ashish Kalra wrote: > > From: Ashish Kalra > > > > Add SEV and SEV-ES hypercall abstraction library to support SEV Page > > encryption/deceryption status hypercalls for SEV and SEV-ES guests. > >

Re: [edk2-devel] [PATCH v4 1/4] OvmfPkg/MemEncryptHypercallLib: add library to support SEV hypercalls.

2021-06-22 Thread Brijesh Singh via groups.io
On 6/22/2021 6:20 PM, Ashish Kalra wrote: > Hello Tom, > > On Tue, Jun 22, 2021 at 05:47:48PM -0500, Tom Lendacky wrote: > ... >>> +VOID >>> +EFIAPI >>> +SetMemoryEncDecHypercall3 ( >>> + IN PHYSICAL_ADDRESS PhysicalAddress, >>> + IN UINTNPages, >>> + IN UINTNMode

Re: [edk2-devel] [PATCH v4 1/4] OvmfPkg/MemEncryptHypercallLib: add library to support SEV hypercalls.

2021-06-22 Thread Ashish Kalra via groups.io
Hello Tom, On Tue, Jun 22, 2021 at 05:47:48PM -0500, Tom Lendacky wrote: ... > > +VOID > > +EFIAPI > > +SetMemoryEncDecHypercall3 ( > > + IN PHYSICAL_ADDRESS PhysicalAddress, > > + IN UINTNPages, > > + IN UINTNMode > > + ) > > +{ > > + if (MemEncryptSevEsIsEnabled ())

Re: [edk2-devel] [PATCH v4 1/4] OvmfPkg/MemEncryptHypercallLib: add library to support SEV hypercalls.

2021-06-22 Thread Lendacky, Thomas via groups.io
On 6/21/21 8:56 AM, Ashish Kalra wrote: > From: Ashish Kalra > > Add SEV and SEV-ES hypercall abstraction library to support SEV Page > encryption/deceryption status hypercalls for SEV and SEV-ES guests. Does this have to be a new library? It's just a single function and so I would think it

Re: [edk2-devel] [PATCH v4 1/4] OvmfPkg/MemEncryptHypercallLib: add library to support SEV hypercalls.

2021-06-22 Thread Brijesh Singh via groups.io
On 6/22/2021 2:47 PM, Brijesh Singh wrote: > > > On 6/21/2021 8:56 AM, Ashish Kalra wrote: >> From: Ashish Kalra >> >> Add SEV and SEV-ES hypercall abstraction library to support SEV Page >> encryption/deceryption status hypercalls for SEV and SEV-ES guests. >> >> Cc: Jordan Justen >> Cc:

Re: [edk2-devel] [PATCH v4 1/4] OvmfPkg/MemEncryptHypercallLib: add library to support SEV hypercalls.

2021-06-22 Thread Brijesh Singh via groups.io
On 6/21/2021 8:56 AM, Ashish Kalra wrote: > From: Ashish Kalra > > Add SEV and SEV-ES hypercall abstraction library to support SEV Page > encryption/deceryption status hypercalls for SEV and SEV-ES guests. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Remove this

[edk2-devel] [PATCH v4 1/4] OvmfPkg/MemEncryptHypercallLib: add library to support SEV hypercalls.

2021-06-21 Thread Ashish Kalra via groups.io
From: Ashish Kalra Add SEV and SEV-ES hypercall abstraction library to support SEV Page encryption/deceryption status hypercalls for SEV and SEV-ES guests. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Ashish Kalra --- Maintainers.txt