Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 11/14] Silicon/ARM/NeoverseN1Soc: NOR flash library for N1Sdp

2024-05-21 Thread Sami Mujawar
Hi Sahil, Please see my response marked inline as [SAMI]. Regards, Sami Mujawar On 21/05/2024 10:24 am, sahil via groups.io wrote: Hi Sami, Thank you for reviewing the patches. Please find my comments inline below marked as [SAHIL]. On Thu, 16 May 2024 at 20:54, Sami Mujawar via groups.io

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 11/14] Silicon/ARM/NeoverseN1Soc: NOR flash library for N1Sdp

2024-05-21 Thread sahil
Hi Sami, Thank you for reviewing the patches. Please find my comments inline below marked as [SAHIL]. On Thu, 16 May 2024 at 20:54, Sami Mujawar via groups.io wrote: > > Hi Sahil, > > Thank you for this patch. > > I have some suggestions marked inline below, otherwise this patch looks good > to

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 11/14] Silicon/ARM/NeoverseN1Soc: NOR flash library for N1Sdp

2024-05-16 Thread Sami Mujawar
Hi Sahil, Thank you for this patch. I have some suggestions marked inline below, otherwise this patch looks good to me. With that fixed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/04/2024 06:56 am, Sahil Kaushal wrote: From: sahil Add NOR flash library, this library

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 11/14] Silicon/ARM/NeoverseN1Soc: NOR flash library for N1Sdp

2024-04-24 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Sahil Kaushal via groups.io Sent: 23 April 2024 06:56 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm ; Sami Mujawar; Sahil Kaushal Subject: [edk2-devel] [PATCH RESEND