: Friday, October 27, 2023 10:32 AM
To: devel@edk2.groups.io; Joey Vagedes
Cc: Sean Brogan ; Kinney, Michael D
; Liming Gao
Subject: Re: [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest
Series:
Reviewed-by: Michael Kubacki
On 10/27/2023 11:15 AM, Joey Vagedes via groups.io wrote
Resolves an invalid escape sequence in a regex string that occurs
because the string was not marked as a raw string, so backslash
characters create unexpected escape sequences.
This was brought to light due to Python 3.12 now detecting invalid
escape sequences and generates a warning. It is best
Thank you, Rebecca!
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110770): https://edk2.groups.io/g/devel/message/110770
Mute This Topic: https://groups.io/mt/100122559/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
ps.io On Behalf Of Joey
> Vagedes via groups.io
> Sent: Monday, November 6, 2023 12:09 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v1 0/1] Edk2ToolsBuild.py: Clarify make
> error
>
> When make or nmake fails to build the basetools, Edk2ToolsBuild.py
>
When make or nmake fails to build the basetools, Edk2ToolsBuild.py
currently prints a generic error message "Failed to build." and
raises an exception. This has two issues: The first is that it raises
an exception, which leads people to believe it is a python issue, and
not a build issue. The
Clarify to users that they should review the build log when make
(POSIX-like system) or nmake (Windows) fails to compile basetools.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Signed-off-by: Joey Vagedes
---
BaseTools/Source/C/Common/BinderFuncs.c | 2 +-
When make or nmake fails to build the basetools, Edk2ToolsBuild.py
currently prints a generic error message "Failed to build." and
raises an exception. This has two issues: The first is that it raises
an exception, which leads people to believe it is a python issue, and
not a build issue. The
Clarify to users that they should review the build log when make
(POSIX-like system) or nmake (Windows) fails to compile basetools.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Signed-off-by: Joey Vagedes
---
BaseTools/Edk2ToolsBuild.py | 8 ++--
1 file changed, 6
Thank you for catching this! I will correct it.
Thanks,
Joey
On Fri, Oct 6, 2023 at 8:07 PM Li, Yi1 wrote:
> Joey:
>
> I already give feedback for CryptoPkg part.
>
> Seems there are two Crypto patch 07/24 and 13/24, but actually 13 is
> StandaloneMmPkg changes. Please check.
> [PATCH v1
Hello All,
Due to a Subject Line mistake, this particular patch was labeled as a
CryptoPkg change. I'm resending this out to the package maintainers with
the correct package (StandaloneMmPkg).
Please review this change to your package's ci.yaml file ~ This change will
ensure your package is
**Update: Version 2 of this patch series contains only packages that have
reviewed this change. This patch series is ready to be merged. Maintainers of
other packages may add these changes in a follow up patch series.
Updates Edk2-pytools to the latest versions, which introduces a new Policy
for
From: Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.
When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in
From: Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.
When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in
From: Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.
When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in
From: Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.
When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in
From: Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.
When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in
From: Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.
When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in
From: Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.
When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in
From: Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.
When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in
From: Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.
When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in
Hi All,
Any concerns over this patch? It merely adds the ability to detect some
compiler errors when building BaseTools with Edk2ToolsBuild.py and report
them as logging level ERROR to get a quick glimpse at the error without
needing to review the entire log.
Thanks,
Joey
On Wed, Jun 21, 2023
Hi all,
Do you have any concerns over the changes I've made to GenFw.c as seen
above? Please let me know if you have any questions, concerns, or
improvements; I would be happy to help!
Thanks,
Joey
On Fri, Jun 23, 2023 at 8:44 AM Joey Vagedes wrote:
> Automatically set the nxcompat flag in
Thank you for the review Michael. @Rebecca Cran , @Liming
Gao have you had time to take a look at this? It
is a fairly simple change, following the same logic as xdrlib with a few
modifications to use some newer python functionality.
Thanks,
Joey
On Tue, Jun 27, 2023 at 10:21 AM Kinney, Michael
v3: Updates function to be Doxygen compliant
v3: Updates commit message
v2: Adds --nonxcompat flag to GenFw; updates man page
v2: Updates PeImage.h to reference spec 9.3 rather then 8.3
Utilize GenFw to automatically set the NXCOMPAT bit of the DLL Characteristics
field of the Optional Header if
Add the bit masks for DLL Characteristics, used within the optional
header of a PE, to the PeImage.h header file.
Update the Visual Studio, Microsoft Portable Executable and Common
Object File Format Specification, and the PE/COFF Specification to the
latest version.
Cc: Michael D Kinney
Cc:
Automatically set the nxcompat flag in the DLL Characteristics field of
the Optional Header of the PE32+ image. For this flag to be set
automatically, the section alignment must be evenly divisible
by 4K (EFI_PAGE_SIZE) and no section must be executable and writable.
Adds a command line flag to
Thanks Rebecca! Let me know if you need anything else from me before you
get it merged. I appreciate your time!
Joey
On Sun, Jul 9, 2023 at 4:18 PM Rebecca Cran wrote:
> Sorry for the delay.
>
>
> Reviewed-by: Rebecca Cran
>
>
> On 6/21/23 9:59 AM, Joey Vagedes wrote:
> > Adds
Automatically set the nxcompat flag in the DLL Characteristics field of
the Optional Header of the PE32+ image. For this flag to be set
automatically, it must, the section alignment must be evenly divisible
by 4K (EFI_PAGE_SIZE) and no section must be executable and writable.
Adds a command line
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4487
v2: Adds --nonxcompat flag to GenFw; updates man page
v2: Updates PeImage.h to reference spec 9.3 rather then 8.3
Utilize GenFw to automatically set the NXCOMPAT bit of the DLL Characteristics
field of the Optional Header if the following
Add the bit masks for DLL Characteristics, used within the optional
header of a PE, to the PeImage.h header file.
Update the Visual Studio, Microsoft Portable Executable and Common
Object File Format Specification, and the PE/COFF Specification to the
latest version.
Cc: Michael D Kinney
Cc:
When UncrustifyCheck attempts to update the permissions of a file
( Only happens when a different error occurs ), it incorrectly uses
os.stat.S_IWRITE, which does not exist. The correct value is
stat.S_IWRITE.
see os.chmod documentation: https://docs.python.org/3/library/os.html#os.chmod
Cc:
The UncrustifyCheck plugin passes os.stat.S_IWRITE to os.chmod, when
attempting to change file permissions. os.stat.S_IWRITE does not exist
as os.stat is a function. The correct value is stat.S_IWRITE.
Signed-off-by: Joey Vagedes
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Sean Brogan
---
Hello!
Raw strings (the r prefix for a string) has been around since python 2, so
this change will not break anything. It just ensures that the backwards
slash is never treated as an escape character, which is what is expected
for regex strings.
The only change that occurred is that python 3.12
Hello.
It depends on the actual path that you are trying to include. This is the
requirements for an include statement (coming directly from the FDF
specification):
>
>
>
> The tools look for relative to the directory the FDF file
> resides. If the file is not found, and the directory
I found two other files with similar issues. Here is my patch series to resolve
all.
[PATCH v1 1/1] BaseTools: Fix raw strings containing valid escape characters
(groups.io) ( https://edk2.groups.io/g/devel/message/112986 )
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages
Hello,
This is in regard to my recent patch (see commit here: BaseTools: Resolve regex
syntax warnings · tianocore/edk2@9f0061a (github.com) (
https://github.com/tianocore/edk2/commit/9f0061a03b61d282fbc0ba5be22155d06a5e64a1
) ) that was resolving the newly introduced syntax warnings (that
Commit 9f0061a03b61d282fbc0ba5be22155d06a5e64a1 was intended to fix regex
strings using invalid escape characters. The regex module suggested way to
fix this is to use the raw string modifiler (`r'`). However in doing this,
any strings that also contained valid escape characters that were being
Fixes raw regex strings that contain valid (and purposeful) escape
characters as they are being treated as individual characters rather
than the single escaped character they represent (i.e. '\t' is being
treated as a '\' and a 't' rather than a single tab character).
Signed-off-by: Joey Vagedes
From: "Joey Vagedes (from Dev Box)"
Updates edk2-pytool-extensions, edk2-pytool-library, and regex to their
latest respective releases.
Signed-off-by: Joey Vagedes
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
---
pip-requirements.txt | 6 +++---
1 file changed, 3 insertions(+), 3
Hello.
Reviewed-by: Joey Vagedes
This has been merged via PR 5257 ( https://github.com/tianocore/edk2/pull/5257
) , commit SHA 58355ec1926563efc954821a2851365182a4ebd4
Thanks,
Joey
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
Thanks Mike,
I've updated the PR / branch with the reviewed-by tag. It is ready to be merged
at your convenience.
pip-requirements.txt: Update to latest by Javagedes · Pull Request #5256 ·
tianocore/edk2 (github.com) ( https://github.com/tianocore/edk2/pull/5256 )
Thanks,
Joey
commit 9f0061a03b61d282fbc0ba5be22155d06a5e64a1
Author: Joey Vagedes via groups.io
Date: Wed Dec 6 12:27:02 2023 -0800
BaseTools: Resolve regex syntax warnings
Switches regex patterns to raw text to resolve python 3.12 syntax
warnings in regards to invalid escape sequences
Hi Liming,
It was introduced due to the fact that a few of the regex strings with
invalid escape sequences (due to regex using their own escape sequences)
also included valid escape sequences - for handling new lines. I did not
see the valid escape characters in the strings, and the virtual
Reviewed-by: Joey Vagedes
On Wed, Nov 29, 2023 at 9:01 AM wrote:
> From: Michael Kubacki
>
> Updates the workflow to also output files that can be loaded in emacs
> to show CodeQL issues (in addition to the existing SARIF output for
> standard SARIF viewers).
>
> The emacs files are in the
Switches regex patterns to raw text to resolve python 3.12 syntax
warnings in regards to invalid escape sequences, as is suggested by the
re (regex) module in python.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Signed-off-by: Joey Vagedes
---
Python 3.12 now produces syntax warnings when using an invalid escape
character (\ followed by an unexpected character). This happens
throughout BaseTools due the usage of regular expressions. the re module
in python suggests that when creating regex patterns, to use raw text.
This patch series
Thanks Mike,
I've prepared a Pull request with your Reviewed-By Tag. Feel free to add the
push tag at your convenience. I appreciate your time!
.pytool/Plugin: UncrustifyCheck: use stat instead of os.stat by Javagedes ·
Pull Request #5287 · tianocore/edk2 (github.com) (
Reviewed-by: joey.vage...@gmail.com
On Wed, Apr 24, 2024 at 10:37 AM wrote:
> From: Michael Kubacki
>
> Fixes current CI CodeQL failures due to old CodeQL CLI version.
>
> Updates CodeQL to work with the latest queries. Includes functional
> and security fixes within the CodeQL CLI binary.
>
>
Update retrieval of private guids, protocols, or ppis from a package's
declaration file to use the original path of the module's INF file
rather than the current path. When building the same module multiple
times in the same INF (by override the define's FILE_GUID), a temporary
instance of the
Reviewed-By: joey.vage...@gmail.com
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117377): https://edk2.groups.io/g/devel/message/117377
Mute This Topic: https://groups.io/mt/105281054/21656
Group Owner: devel+ow...@edk2.groups.io
Reviewed-by: joey.vage...@gmail.com
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117546): https://edk2.groups.io/g/devel/message/117546
Mute This Topic: https://groups.io/mt/105394121/21656
Group Owner: devel+ow...@edk2.groups.io
Hi Lazlo,
I just looked at the pipelines - Looks like everything is fine, there is just
currently a backup of runners of jobs in the runners. It is common for jobs
that end in CODE_COVERAGE to appear frozen in queued status, but this is
expected as this job not queued until all others have
Reviewed-by: Joey Vagedes
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119060): https://edk2.groups.io/g/devel/message/119060
Mute This Topic: https://groups.io/mt/106161774/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
53 matches
Mail list logo
